Bug 598482 part 17 - Don't unnecessarily invalidate everything when showing a list box popup. r=roc
authorMarkus Stange <mstange@themasta.com>
Fri, 23 Dec 2011 22:52:24 -0500
changeset 84545 2147078591dc518ff8a9b1f431d24fda20c30275
parent 84544 1116117b73ccc738c4062e6dd0a364b935b36d1a
child 84546 05a23c8d3acb575d8c13fcefdf17e8b8b3ee5a29
push id805
push userakeybl@mozilla.com
push dateWed, 01 Feb 2012 18:17:35 +0000
treeherdermozilla-aurora@6fb3bf232436 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersroc
bugs598482
milestone12.0a1
Bug 598482 part 17 - Don't unnecessarily invalidate everything when showing a list box popup. r=roc
layout/forms/nsComboboxControlFrame.cpp
--- a/layout/forms/nsComboboxControlFrame.cpp
+++ b/layout/forms/nsComboboxControlFrame.cpp
@@ -382,25 +382,16 @@ nsComboboxControlFrame::SetFocus(bool aO
   if (!weakFrame.IsAlive()) {
     return;
   }
 
   // This is needed on a temporary basis. It causes the focus
   // rect to be drawn. This is much faster than ReResolvingStyle
   // Bug 32920
   Invalidate(nsRect(0,0,mRect.width,mRect.height));
-
-  // Make sure the content area gets updated for where the dropdown was
-  // This is only needed for embedding, the focus may go to 
-  // the chrome that is not part of the Gecko system (Bug 83493)
-  // XXX this is rather inefficient
-  nsIViewManager* vm = PresContext()->GetPresShell()->GetViewManager();
-  if (vm) {
-    vm->UpdateAllViews();
-  }
 }
 
 void
 nsComboboxControlFrame::ShowPopup(bool aShowPopup)
 {
   nsIView* view = mDropdownFrame->GetView();
   nsIViewManager* viewManager = view->GetViewManager();