Bug 1340869, crash @ RefreshDriverVsyncObserver::RecordTelemetryProbes, r=stone
authorOlli Pettay <Olli.Pettay@helsinki.fi>
Mon, 20 Feb 2017 10:24:46 +0200
changeset 372874 1ce3e577832893559a1873ec568a82fb31ff2093
parent 372873 3f4226570a86d2ae7345245ecae8a722e56d3da0
child 372875 24931c1b6d9e5c0b1e496a2428f2012428715956
child 372909 0bf3a9544a5c337523ef0c4eb4d2c30c8ac2c7ec
push id10863
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 23:02:23 +0000
treeherdermozilla-aurora@0931190cd725 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersstone
bugs1340869
milestone54.0a1
Bug 1340869, crash @ RefreshDriverVsyncObserver::RecordTelemetryProbes, r=stone
layout/base/nsRefreshDriver.cpp
--- a/layout/base/nsRefreshDriver.cpp
+++ b/layout/base/nsRefreshDriver.cpp
@@ -605,17 +605,19 @@ private:
         Telemetry::Accumulate(Telemetry::FX_REFRESH_DRIVER_CONTENT_FRAME_DELAY_MS,
                               sample);
         Telemetry::Accumulate(Telemetry::FX_REFRESH_DRIVER_SYNC_SCROLL_FRAME_DELAY_MS,
                               sample);
         RecordJank(sample);
       } else {
         // Request the vsync rate from the parent process. Might be a few vsyncs
         // until the parent responds.
-        mVsyncRate = mVsyncRefreshDriverTimer->mVsyncChild->GetVsyncRate();
+        if (mVsyncRefreshDriverTimer) {
+          mVsyncRate = mVsyncRefreshDriverTimer->mVsyncChild->GetVsyncRate();
+        }
       }
     #endif
     }
 
     void RecordJank(uint32_t aJankMS)
     {
       uint32_t duration = 1 /* ms */;
       for (size_t i = 0;