Bug 1314903 has been fixed, use callParentFunctionNoReturn in ext-c-omnibox.js r=mattw
authorRob Wu <rob@robwu.nl>
Fri, 17 Feb 2017 20:05:51 +0100
changeset 372697 0e1e91d221373947551b268ad3dde6d90ff0465e
parent 372696 23391448faad86360d6eba8269146ba2a00ddee9
child 372698 91b0938bc9763af91e0244f80c8dcbb6738ffb09
push id10863
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 23:02:23 +0000
treeherdermozilla-aurora@0931190cd725 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattw
bugs1314903
milestone54.0a1
Bug 1314903 has been fixed, use callParentFunctionNoReturn in ext-c-omnibox.js r=mattw MozReview-Commit-ID: FL8JKWjkpO2
browser/components/extensions/ext-c-omnibox.js
--- a/browser/components/extensions/ext-c-omnibox.js
+++ b/browser/components/extensions/ext-c-omnibox.js
@@ -9,18 +9,17 @@ var {
 } = ExtensionUtils;
 
 extensions.registerSchemaAPI("omnibox", "addon_child", context => {
   return {
     omnibox: {
       onInputChanged: new SingletonEventManager(context, "omnibox.onInputChanged", fire => {
         let listener = (text, id) => {
           fire.asyncWithoutClone(text, suggestions => {
-            // TODO: Switch to using callParentFunctionNoReturn once bug 1314903 is fixed.
-            context.childManager.callParentAsyncFunction("omnibox_internal.addSuggestions", [
+            context.childManager.callParentFunctionNoReturn("omnibox_internal.addSuggestions", [
               id,
               suggestions,
             ]);
           });
         };
         context.childManager.getParentEvent("omnibox_internal.onInputChanged").addListener(listener);
         return () => {
           context.childManager.getParentEvent("omnibox_internal.onInputChanged").removeListener(listener);