Bug 1286615 - Wrong use of ModifyBusyCountFromWorker in WorkerProxyToMainThreadRunnable, r=khuey
authorAndrea Marchesini <amarchesini@mozilla.com>
Mon, 18 Jul 2016 09:17:21 +0200
changeset 330429 0bf67462f9dc7603c70e21c65d01485694c7a2c3
parent 330428 ff9608965b499165c061aeb042f382609959eda1
child 330430 3c35da4f57e67fb3571885b6ba5442009bf5f00d
push id9858
push userjlund@mozilla.com
push dateMon, 01 Aug 2016 14:37:10 +0000
treeherdermozilla-aurora@203106ef6cb6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskhuey
bugs1286615
milestone50.0a1
Bug 1286615 - Wrong use of ModifyBusyCountFromWorker in WorkerProxyToMainThreadRunnable, r=khuey
dom/workers/WorkerRunnable.cpp
--- a/dom/workers/WorkerRunnable.cpp
+++ b/dom/workers/WorkerRunnable.cpp
@@ -723,17 +723,18 @@ WorkerProxyToMainThreadRunnable::PostDis
     virtual bool
     WorkerRun(JSContext* aCx, workers::WorkerPrivate* aWorkerPrivate) override
     {
       MOZ_ASSERT(aWorkerPrivate);
       aWorkerPrivate->AssertIsOnWorkerThread();
 
       mRunnable->RunBackOnWorkerThread();
 
-      aWorkerPrivate->ModifyBusyCountFromWorker(true);
+      // Let's release the worker thread.
+      aWorkerPrivate->ModifyBusyCountFromWorker(false);
       return true;
     }
 
   private:
     ~ReleaseRunnable()
     {}
   };