Bug 1295138 - Change NS_ASSERTION(false, "Existing entry in StartupCache.") to a NS_WARNING, r=nfroyd
☠☠ backed out by 31e1eb67dd23 ☠ ☠
authorBob Clary <bclary@bclary.com>
Mon, 15 Aug 2016 08:08:49 -0700
changeset 335251 0ad827f382ecf1e75efaf4e33108e671c79aee2e
parent 335141 fe562e66e9b9235bc77ba5f982e0fa3206522e90
child 335252 2fb68854b93a5878ff32fb026d8c14d40c201790
push id10033
push userraliiev@mozilla.com
push dateMon, 19 Sep 2016 13:50:26 +0000
treeherdermozilla-aurora@5dddbefdf759 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnfroyd
bugs1295138
milestone51.0a1
Bug 1295138 - Change NS_ASSERTION(false, "Existing entry in StartupCache.") to a NS_WARNING, r=nfroyd
startupcache/StartupCache.cpp
--- a/startupcache/StartupCache.cpp
+++ b/startupcache/StartupCache.cpp
@@ -350,17 +350,17 @@ StartupCache::PutBuffer(const char* id, 
   auto data = MakeUnique<char[]>(len);
   memcpy(data.get(), inbuf, len);
 
   nsCString idStr(id);
   // Cache it for now, we'll write all together later.
   CacheEntry* entry; 
   
   if (mTable.Get(idStr)) {
-    NS_ASSERTION(false, "Existing entry in StartupCache.");
+    NS_WARNING("Existing entry in StartupCache.");
     // Double-caching is undesirable but not an error.
     return NS_OK;
   }
 
 #ifdef DEBUG
   if (mArchive) {
     nsZipItem* zipItem = mArchive->GetItem(id);
     NS_ASSERTION(zipItem == nullptr, "Existing entry in disk StartupCache.");