Bug 848861 - Send stack traces with FHR errors; r=rnewman, sr=mconnor, a=bajaj
authorGregory Szorc <gps@mozilla.com>
Mon, 18 Mar 2013 15:07:07 -0700
changeset 128718 06b482d67485319ac9cf4e6bda2bc770c761f0f9
parent 128717 aa391e2a250881bd0ec9cb9e4e480438f700fb57
child 128719 f3a6fc9019f9f60e18c80e9911c270fa956f01b6
push id3568
push usergszorc@mozilla.com
push dateThu, 28 Mar 2013 22:57:01 +0000
treeherdermozilla-aurora@a084be958224 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrnewman, mconnor, bajaj
bugs848861
milestone21.0a2
Bug 848861 - Send stack traces with FHR errors; r=rnewman, sr=mconnor, a=bajaj
services/healthreport/healthreporter.jsm
services/metrics/providermanager.jsm
--- a/services/healthreport/healthreporter.jsm
+++ b/services/healthreport/healthreporter.jsm
@@ -451,17 +451,17 @@ AbstractHealthReporter.prototype = Objec
    * @param ex
    *        (Error) The error that should be captured.
    */
   _recordError: function (message, ex) {
     let recordMessage = message;
     let logMessage = message;
 
     if (ex) {
-      recordMessage += ": " + ex.message;
+      recordMessage += ": " + CommonUtils.exceptionStr(ex);
       logMessage += ": " + CommonUtils.exceptionStr(ex);
     }
 
     // Scrub out potentially identifying information from strings that could
     // make the payload.
     let appData = Services.dirsvc.get("UAppData", Ci.nsIFile);
     let profile = Services.dirsvc.get("ProfD", Ci.nsIFile);
 
--- a/services/metrics/providermanager.jsm
+++ b/services/metrics/providermanager.jsm
@@ -407,17 +407,17 @@ this.ProviderManager.prototype = Object.
   },
 
   /**
    * Record an error that occurred operating on a provider.
    */
   _recordProviderError: function (name, msg, ex) {
     let msg = "Provider error: " + name + ": " + msg;
     if (ex) {
-      msg += ": " + ex.message;
+      msg += ": " + CommonUtils.exceptionStr(ex);
     }
     this._log.warn(msg);
 
     if (this.onProviderError) {
       try {
         this.onProviderError(msg);
       } catch (callError) {
         this._log.warn("Exception when calling onProviderError callback: " +