searching for reviewer(rnewman)
8e4b96e23d7d4eba314d7582f79563220f2e4ae2: Bug 1350442 - Remove redundant storeDone from the RepositorySession class. r=rnewman, a=gchang
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 31 Mar 2017 19:00:13 -0400 - rev 375784
Push 11027 by ryanvm@gmail.com at Thu, 06 Apr 2017 21:05:28 +0000
Bug 1350442 - Remove redundant storeDone from the RepositorySession class. r=rnewman, a=gchang Confusion between storeDone() and storeDone(long end) resulted in certain sessions (bookmarks and form history) not overriding the current method. As a result, their final "flush the queue" methods weren't being called by the buffering middleware. This patch removes the storeDone(long end) method, making such confusion a non-issue. Given that a lot of sessions tend to build up buffers which they need to then flush after a storeDone() call, passing in a timestamp into that method doesn't make sense. Instead, let's supply a default implementation in RepositorySession which calls onStoreCompleted(endTimestamp) with current time, and allow sessions to override this method and own the onStoreCompleted(endTimestamp) call. MozReview-Commit-ID: 84o7aAL8RPC
48d85433e58bc4a3cec998c39ca492e1f891ddd6: Bug 1350442 - Use the main storeWorkQueue for failures in the buffering middleware. r=rnewman, a=gchang
Grigory Kruglov <gkruglov@mozilla.com> - Tue, 04 Apr 2017 17:15:02 -0400 - rev 375783
Push 11027 by ryanvm@gmail.com at Thu, 06 Apr 2017 21:05:28 +0000
Bug 1350442 - Use the main storeWorkQueue for failures in the buffering middleware. r=rnewman, a=gchang MozReview-Commit-ID: ByZtR5zSKZB
437ac8a1ad2cdb94ba9b5573da06049855ea4a38: Bug 1350196 - Part 2: Perform PRNGFixes earlier. r=rnewman, r=nalexander, a=lizzard
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 27 Mar 2017 18:32:54 -0700 - rev 375580
Push 10975 by ryanvm@gmail.com at Wed, 29 Mar 2017 22:31:53 +0000
Bug 1350196 - Part 2: Perform PRNGFixes earlier. r=rnewman, r=nalexander, a=lizzard MozReview-Commit-ID: 18jnRRFhyPq
83289c6543562a83e7546d793e75332fa753ed6b: Bug 1350196 - Part 1: Generate IV ourselves. r=rnewman, r=nalexander, a=lizzard
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 27 Mar 2017 18:40:02 -0700 - rev 375579
Push 10975 by ryanvm@gmail.com at Wed, 29 Mar 2017 22:31:53 +0000
Bug 1350196 - Part 1: Generate IV ourselves. r=rnewman, r=nalexander, a=lizzard MozReview-Commit-ID: 5rR8BQRcJoR
0bd17b868a31ce1e53b87f7a619974ad8c796f84: Bug 1335877 - Remove resource://services-common/stringbundle.js. r=rnewman
Zibi Braniecki <gandalf@mozilla.com> - Thu, 02 Mar 2017 15:26:53 -0800 - rev 374890
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1335877 - Remove resource://services-common/stringbundle.js. r=rnewman MozReview-Commit-ID: M7V6JS5myy
6ca43c00d5093b9196acea71b52a33bbdf625107: Bug 1317223 (part 1) - a collection_repair module (without any repairers) and integration with the clients engine. r=rnewman
Mark Hammond <mhammond@skippinet.com.au> - Thu, 02 Mar 2017 16:14:51 +1100 - rev 374781
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1317223 (part 1) - a collection_repair module (without any repairers) and integration with the clients engine. r=rnewman This creates a collection_repair module, somewhat analogous to the existing collection_validator module. This defines the public interface to request a new repair and respond to a remote repair request, and also includes changes to clients.js to call this public interface. MozReview-Commit-ID: 9JPpRrLgFoR
091bb2d8a1d93dce909f0ab3ff085ad6df9993e2: Bug 1317223 (part 1) - a collection_repair module (without any repairers) and integration with the clients engine. r=rnewman
Mark Hammond <mhammond@skippinet.com.au> - Thu, 02 Mar 2017 16:14:51 +1100 - rev 374616
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1317223 (part 1) - a collection_repair module (without any repairers) and integration with the clients engine. r=rnewman This creates a collection_repair module, somewhat analogous to the existing collection_validator module. This defines the public interface to request a new repair and respond to a remote repair request, and also includes changes to clients.js to call this public interface. MozReview-Commit-ID: 9JPpRrLgFoR
f0960b4bd9c435b25c575448e74d8fa0b1b158a4: Bug 1342851 - record the last-modified time of a Sync client record. r=rnewman
Mark Hammond <mhammond@skippinet.com.au> - Mon, 27 Feb 2017 12:44:12 +1100 - rev 374505
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1342851 - record the last-modified time of a Sync client record. r=rnewman MozReview-Commit-ID: 2jtCsl3sy3X
b8fb83d1d8513246187f3392e1020c7f56e29951: Bug 1342851 - record the last-modified time of a Sync client record. r=rnewman
Mark Hammond <mhammond@skippinet.com.au> - Mon, 27 Feb 2017 12:44:12 +1100 - rev 374269
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1342851 - record the last-modified time of a Sync client record. r=rnewman MozReview-Commit-ID: 2jtCsl3sy3X
bd232d46a3967a174a399d4cf444b99391bd8014: Bug 1291821 - Post: remove unused files r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Tue, 29 Nov 2016 13:36:26 -0800 - rev 373905
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Post: remove unused files r=rnewman MozReview-Commit-ID: 4qM5vx4AQyQ
5e0b1684de40494b4464d963253149080b120fa8: Bug 1291821 - Allow BatchingDownloader to resume downloads using offset r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Thu, 19 Jan 2017 13:11:18 -0800 - rev 373904
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Allow BatchingDownloader to resume downloads using offset r=rnewman BatchingDownloader uses provided RepositoryStateProvider instance in order to track offset and high water mark as it performs batching. The state holder objects are initialized by individual ServerSyncStages, and prefixes are used to ensure keys won't clash. Two RepositoryStateProvider implementations are used: persistent and non-persistent. Non-persistent state provider does not allow for resuming after a sync restart, while persistent one does. Persistent state provider is used by the history stage. It is fetched oldest-first, and records are applied to live storage as they're downloaded. These conditions let use resume downloads. It's also possible to resume downloads for stages which use a persistent buffer, but currently we do not have any. Offset value and its context is reset if we hit a 412 error; it is maintained if we hit a sync deadline, allowing us to minimize number of records we'll redownload. BatchingDownloaderController owns resuming and context checking logic. High water mark (h.w.m.) is maintained across syncs and used instead of stage's "last-synced" timestamp if said stage is set to fetch oldest-first and explicitely allows use of a h.w.m. Server15RepositorySession provides correct timestamp to RecordsChannel, decoupling BatchingDownloader from this logic. MozReview-Commit-ID: IH28YrDU4vW
3c89bba23c2d344c514b2d59ca52c377d55c541f: Bug 1291821 - Track incomplete stages and re-sync them r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Fri, 24 Feb 2017 13:04:54 -0800 - rev 373903
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Track incomplete stages and re-sync them r=rnewman Stage re-sync is requested if: - We hit a 412 either during batching download or batching upload - We hit a sync deadline either during batching download or when merging records from the buffer SessionStoreDelegate interface was expanded with onStoreFailed, indicating that not just a particular record failed, but the whole operation did. onFetchFailed is used to inform delegates of 412/deadline failures during downloads. Three new exception types were added, to facilitated messaging between different layers. MozReview-Commit-ID: Ltdi5noEvdV
28164480660dba21fba8e217c74a32b53edf8246: Bug 1291821 - Move bulk insert logic for new history to BrowserProvider r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Tue, 29 Nov 2016 13:42:53 -0800 - rev 373902
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Move bulk insert logic for new history to BrowserProvider r=rnewman This commit does two things: 1) It simplifies history insertion logic, which wrongly assumed that history which was being inserted might be not new. As such, it was necessary to check for collisions of visit inserts, record number of visits actually inserted, and update remote visit counts correspondingly in a separate step, making history insert a three step operation (insert history record, insert its visits, update history record with a count). However, bulkInsert runs only for records which were determined to be entirely new, so it's possible to drop the third step. 2) Makes all of the insertions (history records and their visits) run in one transaction. Prepared statements for both history and visit inserts are used are used as a performance optimization measure. MozReview-Commit-ID: 48T4G5IsQNS
c1069ad96647a8d0117ec976d70c6bf3523c48aa: Bug 1291821 - Rename repositories/sessions r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Fri, 24 Feb 2017 13:04:15 -0800 - rev 373901
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Rename repositories/sessions r=rnewman We're at Sync 1.5 now, so might as well rename the files. Also, renamed the ConstrainedRepository... to a name that's more reflective of that session's role after the changes. MozReview-Commit-ID: 96XCzoBzD5D
09ae692fe42cb59e7c62276d681666f733c96846: Bug 1291821 - Get tests to work after sync changes r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Tue, 11 Oct 2016 20:02:02 -0700 - rev 373900
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Get tests to work after sync changes r=rnewman MozReview-Commit-ID: 3djnmEmzndU
c027b2bb07344e664ba8c9f77e11740a246bebe6: Bug 1291821 - Ensure sink repository is aware of new events coming from the source r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Tue, 11 Oct 2016 20:00:09 -0700 - rev 373899
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Ensure sink repository is aware of new events coming from the source r=rnewman MozReview-Commit-ID: DgqGzfoJxhj
7e35c924287af2aa4408252d7c83e2e1e431b12f: Bug 1291821 - Split history stage into recent and full history stages r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Wed, 16 Nov 2016 14:53:07 -0800 - rev 373898
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Split history stage into recent and full history stages r=rnewman Recent history stage will only run if full history stage did not complete yet. Bug 1316110 tracks follow up work to make this more efficient. MozReview-Commit-ID: 7dtbfEFUMGB
d61efb5192df344972d4c5c0f21d4d1c04459441: Bug 1291821 - Wrap local repositories in buffering middleware r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Thu, 20 Oct 2016 16:31:31 -0700 - rev 373897
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Wrap local repositories in buffering middleware r=rnewman History stage does not wrap history respository in a buffer, because we'd like to use a high-water-mark and offset resuming later on, and using a persistent buffer for this stage does not make sense. MozReview-Commit-ID: FS1swml2bIC
3a43ecf3c62573024cd9b9d45d2edfc9c9e8d319: Bug 1291821 - Use sync deadline to decide of batching downloader should proceed r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Tue, 01 Nov 2016 18:52:18 -0700 - rev 373896
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Use sync deadline to decide of batching downloader should proceed r=rnewman MozReview-Commit-ID: IDgIj9lBt61
50608e0550054650b192bc451c3aeab6e6a0d5e6: Bug 1291821 - Keep track of sync deadline r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Tue, 08 Nov 2016 12:38:00 -0800 - rev 373895
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Keep track of sync deadline r=rnewman MozReview-Commit-ID: Fvuc05K1arV
63957df45bace6be17728d614625e6b358c0cc08: Bug 1291821 - Remove total sync limits, refactor batching downloader r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Thu, 20 Oct 2016 13:34:06 -0700 - rev 373894
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Remove total sync limits, refactor batching downloader r=rnewman MozReview-Commit-ID: 2SYxemfTv9V
4ecaf3862bc7d0feb4281ae5ec24b8495446f0c7: Bug 1291821 - Decouple BatchingUploader from Server11Repository r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Tue, 01 Nov 2016 18:55:15 -0700 - rev 373893
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Decouple BatchingUploader from Server11Repository r=rnewman MozReview-Commit-ID: 7mPy1cmr3vq
75035bf6dd1e705a75b8360677b26419e2b5b245: Bug 1291821 - Simplify onFetchFailed, clean up some exception code r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Tue, 11 Oct 2016 19:29:46 -0700 - rev 373892
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Simplify onFetchFailed, clean up some exception code r=rnewman MozReview-Commit-ID: 11sIAPCfLWk
3d8a46a90f237c445a7ea1e6797c909fac112604: Bug 1291821 - Add onBatchComplete to a FetchRecordsDelegate r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Tue, 11 Oct 2016 19:29:02 -0700 - rev 373891
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Add onBatchComplete to a FetchRecordsDelegate r=rnewman Intended to signal that a group of records have been fetched, and more are to come after a pause. MozReview-Commit-ID: 8ozZTc6aNdA
07c5a4e937382e86f6baf393626f9c3dd060010a: Bug 1291821 - Rename RepositorySession's delegate to storeDelegate, for clarity r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Sat, 08 Oct 2016 17:03:38 -0700 - rev 373890
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Rename RepositorySession's delegate to storeDelegate, for clarity r=rnewman Otherwise we often end up with delegate meaning both fetch delegate and store delegate in extending classes, which gets a little confusing. MozReview-Commit-ID: L4Sd79jLr88
e41e4bbf72ab1283f7ab13d0d8e1b20b7dadcbe5: Bug 1291821 - Switch stage duration interval counting to use elapsedRealtime r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Sat, 08 Oct 2016 15:28:14 -0700 - rev 373889
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Switch stage duration interval counting to use elapsedRealtime r=rnewman It is a better fit for interval counting. MozReview-Commit-ID: LCF0U24MAwF
86bc523c8c6024f4f8737813498e994c53625a87: Bug 1291821 - Buffering repository middleware r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Thu, 19 Jan 2017 13:11:41 -0800 - rev 373888
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Buffering repository middleware r=rnewman MozReview-Commit-ID: GS3M7k670Po
ff7ff02d0edfcf053d1dd0b9a7a2c983aec311ef: Bug 1291821 - Add storeIncomplete to RepositorySession interface r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Wed, 02 Nov 2016 16:40:15 -0700 - rev 373887
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Add storeIncomplete to RepositorySession interface r=rnewman MozReview-Commit-ID: 68ty7KlP5NR
f3e6086e7297f451161e1e90954819574d7357ef: Bug 1291821 - Pre: remove unused SerialRecordConsumer r=rnewman
Grisha Kruglov <gkruglov@mozilla.com> - Sat, 08 Oct 2016 14:49:46 -0700 - rev 373886
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1291821 - Pre: remove unused SerialRecordConsumer r=rnewman MozReview-Commit-ID: 3fiHVErUA1g
85f2279e848f2d9145228614fb7e1dbb99cf71ac: Bug 1336001 - Refactor BatchingUploader's state-holder objects to fix threading problems r=rnewman
Grigory Kruglov <gkruglov@mozilla.com> - Wed, 22 Feb 2017 11:26:35 -0800 - rev 373350
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1336001 - Refactor BatchingUploader's state-holder objects to fix threading problems r=rnewman Previous state: - Two threads were racing to get to batchMeta - one to reset its state, and the other to read its internal state to construct a network request, and then to update its internal state. - This resulted in data corruption when payloads had to be split into multiple batches. A core problem was that there is a lot of state shared across thread boundaries. Specifically, BatchMeta is being written and read both by record consumer threads running off of a thread pool, and by the network worker thread(s). This patch refactors BatchMeta and scheduling of network runnables to ensure that cross-thread access is minimized, and "who owns/accesses what" is explicit. - PayloadDispatcher owns scheduling payload runnables and any data they need to share between each other. - UploaderMeta owns information that's necessary to process incoming records. MozReview-Commit-ID: 9hFs3fXGaGM
20feb033b19b569aa876dc980727c1505ef8a0a1: Bug 1330714 - Allow distributions to override firstrun wizard. r=rnewman
Michael Kaply <mozilla@kaply.com> - Fri, 17 Feb 2017 11:33:03 -0600 - rev 372796
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1330714 - Allow distributions to override firstrun wizard. r=rnewman MozReview-Commit-ID: 8vEqApRi9bC
8043e0ac7edf90442c770ac8f8d653d48e2ad6bc: Bug 1333810: Hash record IDs during encryption, r=kmag,rnewman
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Tue, 31 Jan 2017 13:09:38 -0500 - rev 371337
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1333810: Hash record IDs during encryption, r=kmag,rnewman This does a sha256 of record IDs, the same way we do for collection IDs, during encryption. The way we compute the new ID (using an overridden method) is a little bit of a hack, but we use the new ID as part of the HMAC. This also invalidates a previous assumption, which is that we kept record IDs the same during decryption. MozReview-Commit-ID: Gbzlo9OE1he
721e2e29c1c716221d439c8852f01dc3a04d1828: Bug 1333810: Redo hashing of collection ID, r=kmag,rnewman
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Mon, 30 Jan 2017 19:07:02 -0500 - rev 371336
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1333810: Redo hashing of collection ID, r=kmag,rnewman This ties the collection ID used for a given extension to the "salts" record. This blocks an attack where, given the user's ID, an attacker could just hash all the extension IDs on addons.mozilla.org to generate possible hashed collection IDs. MozReview-Commit-ID: OABsOOMn2F
b9711bce61d0b19ef54077cb73e8f123407fb8aa: Bug 1333810: Add salts to the keys record, r=kmag,rnewman
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Mon, 30 Jan 2017 16:03:59 -0500 - rev 371335
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1333810: Add salts to the keys record, r=kmag,rnewman Because these need to be encrypted with kB like the keyring does, and wiped at the same time as the keyring does, just smush them into the keyring. Rename `ensureKeysFor` to `ensureCanSync`, but don't update it to return the salts -- for now, we don't need that. MozReview-Commit-ID: DOJxdx5ugKl
df5261b5476bb1d49351a2c93a7baad01beb6359: Bug 1333810: Encrypt record deletes, r=kmag,rnewman
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Fri, 27 Jan 2017 19:27:10 -0500 - rev 371334
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1333810: Encrypt record deletes, r=kmag,rnewman Camouflage deletes as updates, according to the rules given by the new RemoteTransformer contract. MozReview-Commit-ID: CwVJSs2jOil
8d0c434a75426db2555c7e226a1fa38d93940622: Bug 1330714 - Allow distributions to override firstrun wizard. r=rnewman a=gchang
Michael Kaply <mozilla@kaply.com> - Fri, 17 Feb 2017 11:33:03 -0600 - rev 359374
Push 10783 by cbook@mozilla.com at Wed, 22 Feb 2017 14:58:56 +0000
Bug 1330714 - Allow distributions to override firstrun wizard. r=rnewman a=gchang MozReview-Commit-ID: 8vEqApRi9bC
d0ba912fe2c8098a284b39d08a03d09c4c799cbe: Bug 1333810: Hash record IDs during encryption, r=kmag,rnewman a=gchang
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Tue, 31 Jan 2017 13:09:38 -0500 - rev 359195
Push 10739 by cbook@mozilla.com at Wed, 15 Feb 2017 14:58:46 +0000
Bug 1333810: Hash record IDs during encryption, r=kmag,rnewman a=gchang This does a sha256 of record IDs, the same way we do for collection IDs, during encryption. The way we compute the new ID (using an overridden method) is a little bit of a hack, but we use the new ID as part of the HMAC. This also invalidates a previous assumption, which is that we kept record IDs the same during decryption. MozReview-Commit-ID: Gbzlo9OE1he
d344c6088604a30dac696682e4c7d04f6a0dc6e1: Bug 1333810: Redo hashing of collection ID, r=kmag,rnewman a=gchang
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Mon, 30 Jan 2017 19:07:02 -0500 - rev 359194
Push 10739 by cbook@mozilla.com at Wed, 15 Feb 2017 14:58:46 +0000
Bug 1333810: Redo hashing of collection ID, r=kmag,rnewman a=gchang This ties the collection ID used for a given extension to the "salts" record. This blocks an attack where, given the user's ID, an attacker could just hash all the extension IDs on addons.mozilla.org to generate possible hashed collection IDs. MozReview-Commit-ID: OABsOOMn2F
3c6f5168bada37088a92fa489ddc56bfda06abbd: Bug 1333810: Add salts to the keys record, r=kmag,rnewman a=gchang
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Mon, 30 Jan 2017 16:03:59 -0500 - rev 359193
Push 10739 by cbook@mozilla.com at Wed, 15 Feb 2017 14:58:46 +0000
Bug 1333810: Add salts to the keys record, r=kmag,rnewman a=gchang Because these need to be encrypted with kB like the keyring does, and wiped at the same time as the keyring does, just smush them into the keyring. Rename `ensureKeysFor` to `ensureCanSync`, but don't update it to return the salts -- for now, we don't need that. MozReview-Commit-ID: DOJxdx5ugKl
7c112d81c854136a5ad758155f2b63555b8ac776: Bug 1333810: Encrypt record deletes, r=kmag,rnewman a=gchang
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Fri, 27 Jan 2017 19:27:10 -0500 - rev 359192
Push 10739 by cbook@mozilla.com at Wed, 15 Feb 2017 14:58:46 +0000
Bug 1333810: Encrypt record deletes, r=kmag,rnewman a=gchang Camouflage deletes as updates, according to the rules given by the new RemoteTransformer contract. MozReview-Commit-ID: CwVJSs2jOil
11e5d90cbf4de0882a6759d7062fa62f73e61d99: Bug 1323759 - To ensure distribution is initialized r=rnewman
Julian_Chu <walkingice0204@gmail.com> - Mon, 19 Dec 2016 14:25:14 +0800 - rev 356842
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1323759 - To ensure distribution is initialized r=rnewman The referrer intent INSTALL_REFERRER comes after Fennec been installed. On Android 5+ we might receive the referrer intent and never actually launch the browser. Attempt to init here to handle that case. MozReview-Commit-ID: 6kDeqnNT2pS
cd64a0a38b30e32c1049121d5999c9408435b9c4: Bug 1329621 - test_crypto_random.js attempts to test different key algorithms, but WeaveCrypto no longer supports them. r=rnewman
Mark Banner <standard8@mozilla.com> - Mon, 09 Jan 2017 11:05:22 +0000 - rev 356601
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1329621 - test_crypto_random.js attempts to test different key algorithms, but WeaveCrypto no longer supports them. r=rnewman MozReview-Commit-ID: AsI0c9cVSug
3cb6640378eae57e141c06c721054b67b49b983d: Bug 1289536 (part 2) - Add a unique flowID GUID to each command sent via the clients collection. r=rnewman
Mark Hammond <mhammond@skippinet.com.au> - Fri, 04 Nov 2016 12:46:57 +1100 - rev 356497
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1289536 (part 2) - Add a unique flowID GUID to each command sent via the clients collection. r=rnewman MozReview-Commit-ID: 4eTFDq4Yr7S
cac405d88a1138daaae823287e077e8d70d93957: Bug 1318414 - Default to empty strings for titles and parent titles if not set. r=rnewman,tcsc
Kit Cambridge <kit@yakshaving.ninja> - Sat, 19 Nov 2016 08:29:26 -0800 - rev 351397
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1318414 - Default to empty strings for titles and parent titles if not set. r=rnewman,tcsc MozReview-Commit-ID: DppxJuVrbAM
75671ee1ac40b5648898a66e6d63a9afd1ac469b: Bug 1258127 - Add migration logic for old synced bookmarks. r=markh,rnewman
Kit Cambridge <kit@yakshaving.ninja> - Fri, 18 Nov 2016 14:00:56 -0800 - rev 351396
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1258127 - Add migration logic for old synced bookmarks. r=markh,rnewman MozReview-Commit-ID: Gye30bYZejy
b5b8c8be96a36e7c5c5c6298fe97340444ed6d6e: Bug 1258127 - Add `PlacesSyncUtils` methods for pulling bookmark changes from Places. r=mak,markh,rnewman
Kit Cambridge <kcambridge@mozilla.com> - Fri, 18 Nov 2016 14:15:59 -0800 - rev 351392
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1258127 - Add `PlacesSyncUtils` methods for pulling bookmark changes from Places. r=mak,markh,rnewman MozReview-Commit-ID: JsCRwnmgw09
a9930548da0c1698b109d318b63f025d81e76dcd: Bug 1258127 - Update `nsNavBookmarksService` (C++) to track sync changes. r=mak,rnewman
Kit Cambridge <kit@yakshaving.ninja> - Thu, 17 Nov 2016 14:50:24 -0800 - rev 351391
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1258127 - Update `nsNavBookmarksService` (C++) to track sync changes. r=mak,rnewman MozReview-Commit-ID: AV6Uyr2eMtA
e614e5545a0c191a89c8503cd3eeb0db2c301e71: Bug 1258127 - Update `Bookmarks.jsm` (JS) to track sync changes. r=mak,rnewman
Kit Cambridge <kit@yakshaving.ninja> - Sun, 20 Nov 2016 09:57:14 -0800 - rev 351390
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1258127 - Update `Bookmarks.jsm` (JS) to track sync changes. r=mak,rnewman MozReview-Commit-ID: ItXlDKIUyYs
e2ef58201bcc5f5a5d9260fdf330a8171f250ebe: Bug 1258127 - Update the Places schema to track bookmark sync changes. r=mak,rnewman
Kit Cambridge <kcambridge@mozilla.com> - Sun, 20 Nov 2016 08:22:02 -0800 - rev 351389
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1258127 - Update the Places schema to track bookmark sync changes. r=mak,rnewman MozReview-Commit-ID: K27JzgU4KnB
c644b01be6496b3903d47f2842ba018188b08777: Bug 1318414 - Default to empty strings for titles and parent titles if not set. r=rnewman,tcsc
Kit Cambridge <kit@yakshaving.ninja> - Thu, 17 Nov 2016 10:42:32 -0800 - rev 351359
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1318414 - Default to empty strings for titles and parent titles if not set. r=rnewman,tcsc MozReview-Commit-ID: DppxJuVrbAM