searching for reviewer(mstange)
9ac3ed4401b54cab7c503b838674f54c838a6baf: Bug 1349828 Smooth scroller of <scrollbox> should not try to scroll to outside of the range. r=mstange. a=gchang
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 10 Apr 2017 19:56:40 +0900 - rev 375956
Push 11066 by ihsiao@mozilla.com at Tue, 18 Apr 2017 08:21:05 +0000
Bug 1349828 Smooth scroller of <scrollbox> should not try to scroll to outside of the range. r=mstange. a=gchang The scroll destination of the smooth scroller of <scrollbox> can be outside of the actual scrollable range. Therefore, it doesn't make scroll slower even when the end appears. This patch makes the destination always in the scrollable range. MozReview-Commit-ID: CfEGzhG7Jh7
c7276ad300e89d501eaec13e86a57227c75ec330: Bug 1349741 - Part 2: Reftest. r=mstange, a=gchang
cku <cku@mozilla.com> - Thu, 23 Mar 2017 14:40:10 +0800 - rev 375929
Push 11058 by ryanvm@gmail.com at Fri, 14 Apr 2017 20:06:37 +0000
Bug 1349741 - Part 2: Reftest. r=mstange, a=gchang MozReview-Commit-ID: AOKD7BeAUNl
9f51f12863d75798d9d8d38173faa70a7a7d9ac9: Bug 1349741 - Part 1: Correct the transform matrix of a context that pass to nsFilterInstance::PaintFilteredFrame. r=mstange, a=gchang
cku <cku@mozilla.com> - Thu, 13 Apr 2017 11:10:58 +0800 - rev 375928
Push 11058 by ryanvm@gmail.com at Fri, 14 Apr 2017 20:06:37 +0000
Bug 1349741 - Part 1: Correct the transform matrix of a context that pass to nsFilterInstance::PaintFilteredFrame. r=mstange, a=gchang MozReview-Commit-ID: 9BISQehlSgG
b95fcbceb5b39ade0054b2fd114c19bc2ed91ef8: Bug 1348776 - Part 1: Fix a crash in the profiler when MOZ_PROFILING is undefined. r=mstange, a=gchang
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 27 Mar 2017 16:49:41 +1100 - rev 375753
Push 11020 by ryanvm@gmail.com at Wed, 05 Apr 2017 21:31:14 +0000
Bug 1348776 - Part 1: Fix a crash in the profiler when MOZ_PROFILING is undefined. r=mstange, a=gchang
4d6b735d8a4b7331a5c6ad723e1c13a3d5fa1c67: Bug 1350211 - Re-enable native stack walking on Android. r=mstange, a=gchang
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 29 Mar 2017 14:44:07 +1100 - rev 375561
Push 10971 by ryanvm@gmail.com at Wed, 29 Mar 2017 14:49:26 +0000
Bug 1350211 - Re-enable native stack walking on Android. r=mstange, a=gchang
e23fd0f551cb50c89b8bedabed3950e85c265f88: Bug 1350211 - Re-enable native stack walking on Android. r=mstange, a=gchang
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 24 Mar 2017 17:02:54 +1100 - rev 375542
Push 10967 by ryanvm@gmail.com at Tue, 28 Mar 2017 21:42:19 +0000
Bug 1350211 - Re-enable native stack walking on Android. r=mstange, a=gchang Bug 1339695 part 8 accidentally disabled native stack walking on Android by using GP_arm_android instead of GP_PLAT_arm_android in a #if. This patch fixes that. It also fixes a couple of compile errors that crept into the relevant code while it was disabled.
f5139212bb40316767d9b1d01def5edf75452ced: Bug 1342398 - incorporate the popup's scroll position into the computation of where the current menuitem is, preventing misplaced popups on Mac, r=mstange a=gchang
Neil Deakin <neil@mozilla.com> - Mon, 13 Mar 2017 09:44:02 -0400 - rev 375500
Push 10963 by cbook@mozilla.com at Tue, 28 Mar 2017 10:55:21 +0000
Bug 1342398 - incorporate the popup's scroll position into the computation of where the current menuitem is, preventing misplaced popups on Mac, r=mstange a=gchang
36f165ceceba72d12ea746313195ae35cf817778: Bug 1345853 - Rollback the change of nsSVGPatternFrame.cpp in bug 1258510. r=mstange, r=tnikkel, a=jcristau
cku <cku@mozilla.com> - Tue, 21 Mar 2017 14:08:50 +0800 - rev 375453
Push 10951 by ryanvm@gmail.com at Fri, 24 Mar 2017 20:00:14 +0000
Bug 1345853 - Rollback the change of nsSVGPatternFrame.cpp in bug 1258510. r=mstange, r=tnikkel, a=jcristau MozReview-Commit-ID: D2AaxaLcWNt
12a4f938b5aaad367488612fa205315929b2ee45: Bug 1345853 - Rollback the change of nsSVGPatternFrame.cpp in bug 1258510. r=mstange, r=tnikkel, a=jcristau
cku <cku@mozilla.com> - Tue, 21 Mar 2017 14:08:50 +0800 - rev 375446
Push 10950 by ryanvm@gmail.com at Fri, 24 Mar 2017 19:39:10 +0000
Bug 1345853 - Rollback the change of nsSVGPatternFrame.cpp in bug 1258510. r=mstange, r=tnikkel, a=jcristau MozReview-Commit-ID: D2AaxaLcWNt
d6b911d8d67722d0b5aed02f3afbf22343bd6295: Bug 1348430 - Part 4. Reftest. r=mstange a=gchang
cku <cku@mozilla.com> - Wed, 22 Mar 2017 14:12:32 +0800 - rev 375421
Push 10942 by cbook@mozilla.com at Fri, 24 Mar 2017 09:26:58 +0000
Bug 1348430 - Part 4. Reftest. r=mstange a=gchang filter-in-pattern-02.svg/filter-in-pattern-02-ref.svg The only difference between 02 and 02-ref is filter effects region setting. The effect region of 02 is (x=-1 y=-1 w=10 h=10), while the region of 02-ref is (x=0 y=0 w=9 h=9). Supposedly, the rendering result of 02 and 02-ref should not be the same. But since we clip effects region by viewporit in ComputeTargetBBoxInFilterSpace, 02 look almost the same with 02-ref whithout Part 3. MozReview-Commit-ID: cqMGqGuHL0
3a1d3f5cc5337803edd07fc3e84de476fc0a7c69: Bug 1348430 - Part 3. Correct mTargetBBoxInFilterSpace. r=mstange a=gchang
cku <cku@mozilla.com> - Wed, 22 Mar 2017 21:29:14 +0800 - rev 375420
Push 10942 by cbook@mozilla.com at Fri, 24 Mar 2017 09:26:58 +0000
Bug 1348430 - Part 3. Correct mTargetBBoxInFilterSpace. r=mstange a=gchang I introduced ComputeTargetBBoxInFilterSpace[1] function in bug 1287492. Two reasons that I think we should not clip filter boundary by viewport in that function: 1. The patch in bug 1336480 can also fix bug 1287492 and is more correct. 2. That restriction cause wrong rendering result In this bug, reporter apply filter onto a path object in pattern element. Before the clipping applied in [1], the boundary of filter effects region is (x=-1, y=-1, width=10, height=10) in CSS units After clipping by svg viewport, the boundary turns out to be (x=0, y=0, width=9, height=9) in CSS units which is smaller then we need for filter painting. So we should stop clip the boundary by svg viewport. (Please refer to filter-in-pattern-02.svg in the next patch). [1] https://hg.mozilla.org/mozilla-central/file/dbabc189256e/layout/svg/nsFilterInstance.cpp#l235 MozReview-Commit-ID: 2d14rnyWPJs
da3f77e480c7e990ab08e9842610d220b75deab6: Bug 1348430 - Part 2. Rename a local variable in nsSVGPatternFrame::PaintPattern. r=mstange a=gchang
cku <cku@mozilla.com> - Tue, 21 Mar 2017 23:40:36 +0800 - rev 375419
Push 10942 by cbook@mozilla.com at Fri, 24 Mar 2017 09:26:58 +0000
Bug 1348430 - Part 2. Rename a local variable in nsSVGPatternFrame::PaintPattern. r=mstange a=gchang MozReview-Commit-ID: FIWQOHsC5o5
cfd92edead41beaf527208dd34527c1ee96830a4: Bug 1348430 - Part 1. (Main) Correct value pass to nsFilterInstance::PaintFilteredFrame in nsSVGUtil. r=mstange a=gchang
cku <cku@mozilla.com> - Mon, 20 Mar 2017 01:30:32 +0800 - rev 375418
Push 10942 by cbook@mozilla.com at Fri, 24 Mar 2017 09:26:58 +0000
Bug 1348430 - Part 1. (Main) Correct value pass to nsFilterInstance::PaintFilteredFrame in nsSVGUtil. r=mstange a=gchang There are two places that use nsFilterInstance::PaintFilteredFrame. One is nsSVGIntegrationUtil::PaintFilter, we do take care of it in bug 1224207. Another path is at nsSVGUtils::PaintFrameWithEffects, apparently I missed that path while working on bug 1224207. MozReview-Commit-ID: K4MjKa4ZpCR
1a53aec4fb0dd7685c1ba03489d454a6510b2648: Bug 1343664 - Part 1. Correct transform matrix. r=mstange a=gchang
cku <cku@mozilla.com> - Mon, 06 Mar 2017 15:25:29 +0800 - rev 375342
Push 10922 by cbook@mozilla.com at Tue, 21 Mar 2017 10:10:27 +0000
Bug 1343664 - Part 1. Correct transform matrix. r=mstange a=gchang MozReview-Commit-ID: Eg6i4SoSPoe
70d9504d91c469a8b367f5f5182fdf4ec1c375a2: Bug 1346265 - Pass gfxContext to nsCSSRendering::PaintGradient. r=mstange a=gchang
cku <cku@mozilla.com> - Fri, 17 Mar 2017 16:45:34 +0800 - rev 375299
Push 10917 by cbook@mozilla.com at Mon, 20 Mar 2017 13:59:41 +0000
Bug 1346265 - Pass gfxContext to nsCSSRendering::PaintGradient. r=mstange a=gchang MozReview-Commit-ID: K6xpFEjC2BB
bd730342c51508fd903a657030ae281163bf2c90: Bug 1342306 (part 2) - Avoid profiler_time() calls deep in profiler streaming code. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 27 Feb 2017 13:52:58 +1100 - rev 375031
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1342306 (part 2) - Avoid profiler_time() calls deep in profiler streaming code. r=mstange. Because profiler_time() is going to need the global lock when I add it, and the lock will already be held when streaming is happening, so it'll cause the thread to deadlock itself. Unfortunately this requires adding an |aStartTime| parameter to a lot of functions, but this is the least worst way I can think of handling it. This also removes the need for one of the profiler_time() functions, which the patch removes.
7becdd5d601a803789f817c7ae7d41b6f2d2c0d2: Bug 1328378 (part 6) - Eliminate SyncProfile. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 27 Feb 2017 12:56:42 +1100 - rev 374570
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1328378 (part 6) - Eliminate SyncProfile. r=mstange. It's now a very thin wrapper around ThreadInfo, and so can be removed. The patch also has the bonus of setting mIsMainThread correctly for the ThreadInfos that used to be SyncProfiles (i.e. the ones created in profiler_get_backtrace()). As far as I can tell this has only one very minor effect, because that field is only used for those objects to determine how ThreadResponsiveness::Update() dispatches its runnables.
6de72f3b7f8abb27024a34faac7fbde24ee6ec8f: Bug 1328378 (part 5) - Simplify ProfileBuffer handling. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 27 Feb 2017 12:34:59 +1100 - rev 374569
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1328378 (part 5) - Simplify ProfileBuffer handling. r=mstange. Currently ThreadInfo objects all share gBuffer, while SyncProfile objects each get their own ProfileBuffer. This patch removes ThreadInfo::mBuffer to reduce this difference, taking us a step towards eliminating SyncProfile. To support this, the patch: - passes in a buffer as an additional argument in a bunch of places where the buffer used to be obtained from a ThreadInfo; - adds an mBuffer field to ProfilerBacktrace; - changes ThreadInfo::SetProfile() to SetHasProfile(); - removes ThreadInfo::{addTag,StoredMarker,bufferGeneration}(), all of which just redirected to ThreadInfo anyway; - changes ProfileBuffer so it's no longer refcounted, which is unnecessary now that gBuffer and ProfilerBacktrace::mBuffer don't have multiple references, which makes their lifetimes obvious. The patch also removes some ThreadInfo& args in functions in platform.cpp, in places where that ThreadInfo is available within the accompanying TickSampler* arg.
1a8bcf69e88fb38e2bb18ffa1094997c5092fce6: Bug 1342571 - fix MaxStrokeExtents to account for partial pixel coverage properly. r=mstange
Lee Salzman <lsalzman@mozilla.com> - Tue, 28 Feb 2017 15:48:04 -0500 - rev 374295
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1342571 - fix MaxStrokeExtents to account for partial pixel coverage properly. r=mstange MozReview-Commit-ID: DS25AJKoVYo
129546a71da906cc26d19656128e0e2f45750e8b: Bug 1342571 - shrink dashed DrawTargetSkia::StrokeRect where possible. r=mstange
Lee Salzman <lsalzman@mozilla.com> - Tue, 28 Feb 2017 15:47:46 -0500 - rev 374294
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1342571 - shrink dashed DrawTargetSkia::StrokeRect where possible. r=mstange MozReview-Commit-ID: 7vu9j8jCwQn
6c2a029b41ea26131a0abae7d6e304567ff2615a: Bug 1328378 (part 4) - Remove sample_obj. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 27 Feb 2017 12:32:55 +1100 - rev 374174
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1328378 (part 4) - Remove sample_obj. r=mstange. It's silly indirection.
6b7e1d039956e207ca24ebfc2629ebd3b6f3c3f0: Bug 1328378 (part 3) - Remove unnecessary locking in profiler_get_backtrace(). r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 27 Feb 2017 12:32:18 +1100 - rev 374173
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1328378 (part 3) - Remove unnecessary locking in profiler_get_backtrace(). r=mstange. There's no need to lock when calling Tick() on a local TickSample that uses a fresh SyncProfile with its own fresh ProfileBuffer -- none of that data can be touched by another thread.
16d6cb0afff570c36c5aea1e4b9f59a86abc75a5: Bug 1328378 (part 2) - Remove BeginUnwind() and EndUnwind(). r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 27 Feb 2017 12:31:44 +1100 - rev 374172
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1328378 (part 2) - Remove BeginUnwind() and EndUnwind(). r=mstange. Both of these functions are now trivial and identical in both ThreadInfo and SyncProfile. This patch inlines and removes them.
63fa61a6e3d12a7d562e5108706b8d0a75dc7e4b: Bug 1328378 (part 1) - Remove SyncProfile::mOwnerState. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 27 Feb 2017 12:30:25 +1100 - rev 374171
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1328378 (part 1) - Remove SyncProfile::mOwnerState. r=mstange. It appears to be a remnant of a time when SyncProfile lifetimes were more complex. Nowadays they are simple. - profiler_get_backtrace() constructs a SyncProfile called |profile|. |profile|'s mOwnerState is REFERENCED. - profiler_get_backtrace() then calls BeginUnwind() and EndUnwind() on |profile|. After the EndUnwind(), |profile->mOwnerState| is always OWNED. - |profile| then is put into the returned ProfilerBacktrace. That ProfilerBacktrace will destroy |profile| in its destructor because ShouldDestroy() always returns true because mOwnerState is always OWNED. The OWNER_DESTROYING and ORPHANED states are never used, and the whole OwnerState type isn't necessary. This patch removes it and ShouldDestroy().
6fd458fdbd07be39745f0194fa54cc7d2e6f1f4b: Bug 1321321 - Ensure that we always save files with the given extension / Work-around NSSavePanel limitations when saving files with multiple extensions. r=mstange.
stefanh@inbox.com - Sat, 25 Feb 2017 00:34:46 +0100 - rev 373937
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1321321 - Ensure that we always save files with the given extension / Work-around NSSavePanel limitations when saving files with multiple extensions. r=mstange.
87cfe603d44d3f82e5af3eefaf5944fd128e591a: Bug 1303094 - remove the StrokeRect path for drawing dotted borders. r=mstange
Lee Salzman <lsalzman@mozilla.com> - Fri, 24 Feb 2017 17:02:46 -0500 - rev 373926
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1303094 - remove the StrokeRect path for drawing dotted borders. r=mstange MozReview-Commit-ID: 7zooPqCocco
1b8511b2ca4c016124cb1f5e7415267eba93fc12: Bug 1342302 - Part 4. Fine tune nsCSSRendering::PaintStyleImageLayerWithSC. r=mstange
cku <cku@mozilla.com> - Fri, 24 Feb 2017 15:58:55 +0800 - rev 373909
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1342302 - Part 4. Fine tune nsCSSRendering::PaintStyleImageLayerWithSC. r=mstange MozReview-Commit-ID: JB5S86tLvl6
a1deec7b451aaf446d02bf454b296dc5fe959c13: Bug 1342302 - Part 3. Rename ImageLayerClipState::mDirtyRectGfx to mDirtyRectInDevPx. r=mstange
cku <cku@mozilla.com> - Fri, 24 Feb 2017 14:56:11 +0800 - rev 373908
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1342302 - Part 3. Rename ImageLayerClipState::mDirtyRectGfx to mDirtyRectInDevPx. r=mstange MozReview-Commit-ID: 7YyQStU0Seq
f4ac43e3f67db80ac8a10fe00eb247c028ce7d4b: Bug 1342302 - Part 2. Implement ImageLayerClipState::IsValid. r=mstange
cku <cku@mozilla.com> - Fri, 24 Feb 2017 18:52:53 +0800 - rev 373907
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1342302 - Part 2. Implement ImageLayerClipState::IsValid. r=mstange MozReview-Commit-ID: 2Axr7buX1c4
14fd552c865b6492e84a8a71ede89e534c529b10: Bug 1342302 - Part 1. Implement RectCornerRadii::IsEmpty. r=mstange
cku <cku@mozilla.com> - Fri, 24 Feb 2017 14:30:19 +0800 - rev 373906
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1342302 - Part 1. Implement RectCornerRadii::IsEmpty. r=mstange MozReview-Commit-ID: JHaRg4rBHu8
ea1dda72c26d426d8b474af394455a3b44ac6837: Bug 1341149 - Implement ImageLayerClipState::ctor. r=mstange
cku <cku@mozilla.com> - Fri, 24 Feb 2017 11:40:44 +0800 - rev 373837
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1341149 - Implement ImageLayerClipState::ctor. r=mstange MozReview-Commit-ID: 7MPrjtgz6c7
aab0b3a45dae09c44e035628463759dc9b6948a7: Bug 1342349 - Fix out-of-bounds access in GetInfoForSelf. r=mstange
Marco Castelluccio <mcastelluccio@mozilla.com> - Fri, 24 Feb 2017 17:42:43 +0000 - rev 373828
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1342349 - Fix out-of-bounds access in GetInfoForSelf. r=mstange
4d41302b84810f47240ebf30b9856a9408542302: Bug 1340928 (part 16) - Clean up profiler env var handling. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 23 Feb 2017 14:26:46 +1100 - rev 373691
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 16) - Clean up profiler env var handling. r=mstange. This patch does the following. - Uses "entries" consistently for the name of the value that is obtained from MOZ_PROFILER_ENTRIES and is the first argument to profiler_start(). (I.e. not "entry" or "entrySize".) - Removes variables (e.g. PROFILER_HELP) holding env var names and uses the names (e.g. "MOZ_PROFILER_HELP") directly. Some of the names are already used directly and I think the slight repetition isn't harmful. It's unlikely that we'd want to change these names the way we might need to change a numeric value, and they're perfectly descriptive. - Changes the "MOZ_PROFILING_FEATURES" string in the weird Android-only startup code to be "MOZ_PROFILER_FEATURES", for consistency. - Renames gUnwindInterval and gProfileEntries as gEnvVarInterval and gEnvVarEntries to make it clearer that they come from environment variables, but otherwise are parallel to gInterval and gEntries. - Puts entries before intervals in most places, to match the profiler_start() argument order. - Changes profiler_usage() so that (a) it always prints, no matter the verbosity, (b) it exits at its end, and (c) doesn't double-print "Profiler: " at the start of each line.
494906dbf2d99146cc25c27f8cb51f84c6fe4759: Bug 1340928 (part 15) - Inline and remove ToJSObject(). r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 22 Feb 2017 13:42:14 +1100 - rev 373487
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 15) - Inline and remove ToJSObject(). r=mstange. It has a single call site.
d0d5dcaa2c361b2b5bd66f9ff06292098305c726: Bug 1340928 (part 14) - Factor out code repeated in both ProfileGatherer::Start() methods. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 22 Feb 2017 11:46:28 +1100 - rev 373486
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 14) - Factor out code repeated in both ProfileGatherer::Start() methods. r=mstange.
e5f1cf49bed1d6466244b54d9d9b2483a1fc0627: Bug 1340928 (part 13) - Merge two ProfileGatherer::Start() variants. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 22 Feb 2017 11:35:43 +1100 - rev 373485
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 13) - Merge two ProfileGatherer::Start() variants. r=mstange. The |nsIFile*| one is only called by the |const nsACString&| one, so this patch combines them.
34b0a316c4130407a4b7bcaca4be8557945ddb9b: Bug 1340928 (part 12) - Remove profiler_get_gatherer(). r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 22 Feb 2017 10:19:53 +1100 - rev 373484
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 12) - Remove profiler_get_gatherer(). r=mstange. profiler_get_gatherer() exposes ProfileGatherer to the outside world in a way that makes future changes difficult. This patch: - Removes ProfileGatherer.h from the list of headers exported from the profiler. - Removes nsIProfiler.profileGatherer and nsProfiler::GetProfileGatherer(). - Replaces profiler_get_gatherer() with three new functions that provide minimal but sufficient access to ProfileGatherer: profiler_will_gather_OOP_profile(), profiler_gathered_OOP_profile(), and profiler_OOP_exit_profile(). These functions provide access to the ProfileGatherer in a similar fashion to the pre-existing functions profiler_get_profile_jsobject_async() and profiler_save_profile_to_file_async() This significantly reduces the size of the profiler's API surface.
aa7e56055a3ec7b7b4bec6a5a1bc9265e0cb4a4d: Bug 1340928 (part 10) - Remove nested calls to profiler_{init,shutdown}(). r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 15 Feb 2017 17:08:38 +1100 - rev 373482
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 10) - Remove nested calls to profiler_{init,shutdown}(). r=mstange. The profiler can currently handle nested calls to profiler_{init,shutdown}() -- only the first call to profiler_init() and the last call to profiler_shutdown() do anything. And sure enough, we have the following. - Outer init/shutdown pairs in XRE_main()/XRE_InitChildProcess() (via GeckoProfilerInitRAII). - Inner init/shutdown pairs in NS_InitXPCOM2()/NS_InitMinimalXPCOM() (both shut down in ShutdownXPCOM()). This is a bit silly, so the patch removes the inner pairs, and adds a now-needed pair in XRE_XPCShellMain. This will allow gInitCount -- which tracks the nesting depth -- to be removed in a future patch.
b6b681adb0173c3d41faec2e7ff1cea163b6fdb6: Bug 1340928 (part 9) - Remove MOZ_PROFILER_STACK_SCAN env var. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 21 Feb 2017 13:53:19 +1100 - rev 373481
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 9) - Remove MOZ_PROFILER_STACK_SCAN env var. r=mstange. It's used to set gUnwindStackScan, which is never used.
8ac2f3a144257a917ac118499f54c6e18862bd21: Bug 1340928 (part 8) - Pass gStartTime to DuplicateLastSample(). r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 21 Feb 2017 10:18:51 +1100 - rev 373480
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 8) - Pass gStartTime to DuplicateLastSample(). r=mstange. This removes the one use of gStartTime outside of platform*.cpp, which lets us restrict its visibility to just that compilation unit.
6e4aa11ecb4d6873c113abf48f0694c9da8150d1: Bug 1340928 (part 7) - Factor out gIsActive handling in platform-*.cpp. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 16 Feb 2017 15:08:07 +1100 - rev 373479
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 7) - Factor out gIsActive handling in platform-*.cpp. r=mstange. PlatformStart() and PlatformStop() are currently responsible for setting and clearing gIsActive, but it's better if we do it in profiler_{start,stop}(). The patch also does the following. - Adds some missing emacs/vim modelines. - Makes Platform{Start,Stop}() crash if they have failures. I'm not at all confident that ignoring the errors as is currently done will result in sensible behaviour, so brittleness is better.
8ac1a3617dc977f6d4f36e644f41a1dd5acad6ff: Bug 1340928 (part 6) - Clean up profiler code relating to env vars. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 16 Feb 2017 13:59:35 +1100 - rev 373445
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 6) - Clean up profiler code relating to env vars. r=mstange. This patch mostly does formatting fixes. It also removes some declarations from platform.h that are no longer necessary now that platform-linux-android.cpp is in the same compilation unit as platform.cpp (due to it being #include-d directly); this required reordering some things.
7e6850af9372989b7dd66318076deb6df02ddf55: Bug 1340928 (part 5) - Pass the interval to PlatformStart(). r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 15 Feb 2017 14:44:12 +1100 - rev 373444
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 5) - Pass the interval to PlatformStart(). r=mstange. This avoids the need for platform-linux-android.cpp to read gInterval off the main thread in an awkward spot. It also makes platform-linux-android.cpp more like platform-{win32,macos}.cpp.
c043ce740d1bed8c359290b5b7125cc27f238147: Bug 1340928 (part 4) - Remove redundant PlatformStop() call in profiler_stop(). r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 15 Feb 2017 14:44:12 +1100 - rev 373443
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 4) - Remove redundant PlatformStop() call in profiler_stop(). r=mstange. There is another PlatformStop() call earlier in the function, and gIsActive is always false by the time we reach the removed call, so it's dead code.
cbc8f0119f8ba08e5c2f9782107531c085e794d7: Bug 1340928 (part 3) - Remove Sampler from ProfileGatherer. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 15 Feb 2017 14:44:12 +1100 - rev 373442
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 3) - Remove Sampler from ProfileGatherer. r=mstange. It's only being used in a boolean fashion, so this patch replaces it with a boolean.
a3a18d2124d73caac76f56fc87410fcaec7336b4: Bug 1340928 (part 2) - Don't use ThreadInfo to pass Linux memory measurements. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 15 Feb 2017 14:44:09 +1100 - rev 373441
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 2) - Don't use ThreadInfo to pass Linux memory measurements. r=mstange. This change means that all the relevant code is now within platform-linux-android.cpp, which is nice.
5b86ca9a7e8e3364e64fbab7c777f89305e0592e: Bug 1340928 (part 1) - Two small platform-linux-android.cpp tweaks. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 15 Feb 2017 14:44:07 +1100 - rev 373440
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340928 (part 1) - Two small platform-linux-android.cpp tweaks. r=mstange. - Don't bother checking gSampler in ProfilerSignalHandler. It is equivalent to checking gIsActive and we do that at the top of the loop in SignalSender(). There is no point repeatedly checking the same condition in the middle of that loop; that just opens up the possibility of partially complete samples where some threads are missing. - Clear gCurrentThreadInfo in SignalSender() instead of in ProfilerSignalHandler(). The effect is much the same, but this change means gCurrentThreadInfo is both set and cleared in SignalSender(), i.e. on a single thread, removing any need for Atomic<>.
d26eb1db5b1c4b9cec29a75c3d2e893dbd3b3e78: Bug 1336480 - Part 2. Test case. r=mstange
cku <cku@mozilla.com> - Mon, 20 Feb 2017 18:04:44 +0800 - rev 373373
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1336480 - Part 2. Test case. r=mstange MozReview-Commit-ID: K4EZOOzd1ND
f413492608a60e5ea8b0c16fd2f847f3c0a387f0: Bug 1336480 - Part 1. Apply suface limitation in nsFilterInstance::ComputeNeededBoxes. r=mstange
cku <cku@mozilla.com> - Tue, 21 Feb 2017 00:08:38 +0800 - rev 373372
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1336480 - Part 1. Apply suface limitation in nsFilterInstance::ComputeNeededBoxes. r=mstange There is no need to limit output space bounds in nsFilterInstance::OutputFilterSpaceBounds(), it's just far too early. MozReview-Commit-ID: 9i9huKDGxq6
2d924269745a8e81a0e0788fa0dce1f22fe7d385: Bug 1328065 - Add a pref to always layerize the scrollbar track, for test purposes. r=mstange
Botond Ballo <botond@mozilla.com> - Fri, 17 Feb 2017 15:47:51 -0500 - rev 373358
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1328065 - Add a pref to always layerize the scrollbar track, for test purposes. r=mstange MozReview-Commit-ID: GZY4tsdsFb4