searching for reviewer(mgoodwin)
10479537baf6bdc5d7168c586a17067b757b1023: Bug 1342736 - Remove nsIX509CertDB.verifySignedManifestAsync(). r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Sun, 26 Feb 2017 20:25:36 +0800 - rev 374443
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1342736 - Remove nsIX509CertDB.verifySignedManifestAsync(). r=mgoodwin verifySignedManifestAsync() was added in Bug 1059216 to support Trusted Hosted Apps. However, Bug 1196988 removed THA and no add-ons use this method, so there's no point in keeping it around. MozReview-Commit-ID: 6xBRxvRZfjh
735f81d9fd96c9d19d3f2fdfda29a14c1a066d22: Bug 1224528 - Load initial JSON files for blocklist r=mgoodwin
Mathieu Leplatre <mathieu@mozilla.com> - Sun, 11 Dec 2016 14:37:22 -1000 - rev 373279
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1224528 - Load initial JSON files for blocklist r=mgoodwin MozReview-Commit-ID: D53xoTa0PZu
63d0ef447e81e1da6f368ebfacfd238b0a231c3b: Bug 1224528 - Load initial JSON files for blocklist r=mgoodwin
Mathieu Leplatre <mathieu@mozilla.com> - Sun, 11 Dec 2016 14:37:22 -1000 - rev 372032
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1224528 - Load initial JSON files for blocklist r=mgoodwin MozReview-Commit-ID: D53xoTa0PZu
b3b730daa2558046bb337effad2c92a5d4d7f20a: Bug 1336867 - Remove unsafeProcessHeader and isSecureHost in nsISiteSecurityService r=keeler,mgoodwin,past
Jonathan Hao <jhao@mozilla.com> - Wed, 08 Feb 2017 11:17:29 +0800 - rev 371653
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1336867 - Remove unsafeProcessHeader and isSecureHost in nsISiteSecurityService r=keeler,mgoodwin,past
0a4f283638cb37563a517fb34e7e0f3e43b80a7a: Bug 1336867 - Remove unsafeProcessHeader and isSecureHost in nsISiteSecurityService r=keeler,mgoodwin,past
Jonathan Hao <jhao@mozilla.com> - Wed, 08 Feb 2017 11:17:29 +0800 - rev 370768
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1336867 - Remove unsafeProcessHeader and isSecureHost in nsISiteSecurityService r=keeler,mgoodwin,past
507fcddedb1f1d4a24ca98dc65633dd655c8f17d: Bug 1336654 - update expired certs and signatures for content signature tests, r=mgoodwin
Franziskus Kiefer <franziskuskiefer@gmail.com> - Mon, 06 Feb 2017 10:07:49 +0100 - rev 370012
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1336654 - update expired certs and signatures for content signature tests, r=mgoodwin
dd195a6fabaf558c0089488af184265041ffc34b: Bug 1331629 - Reuse the same kinto client instance accross syncs (r=mgoodwin)
Mathieu Leplatre <mathieu@mozilla.com> - Mon, 06 Feb 2017 10:35:26 +0100 - rev 369944
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1331629 - Reuse the same kinto client instance accross syncs (r=mgoodwin) MozReview-Commit-ID: F8Fhy9TzPTG
8ba4f117d820b2bdcc4118c70b2134b4f3de23d5: Bug 1336654 - update expired certs and signatures for content signature tests, r=mgoodwin a=test-only
Franziskus Kiefer <franziskuskiefer@gmail.com> - Mon, 06 Feb 2017 10:07:49 +0100 - rev 359039
Push 10704 by cbook@mozilla.com at Thu, 09 Feb 2017 08:40:32 +0000
Bug 1336654 - update expired certs and signatures for content signature tests, r=mgoodwin a=test-only
3d9de93bd6ecd8a44eeedda5d8dc18936b3fb675: Bug 1329248 - Enable 26 more ESLint rules for PSM. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Sat, 14 Jan 2017 13:18:03 +0800 - rev 358034
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1329248 - Enable 26 more ESLint rules for PSM. r=mgoodwin The "no-mixed-spaces-and-tabs" rule is also disabled since there's no point having it enabled when the "no-tabs" rule is also enabled. MozReview-Commit-ID: 49addnnmmvf
84a59e9496ed33e1c4a78705fcadac4a7d73181c: Bug 1331604 - Minor style and idiom changes (r=mgoodwin)
Mathieu Leplatre <mathieu@mozilla.com> - Tue, 17 Jan 2017 15:04:43 +0100 - rev 357932
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1331604 - Minor style and idiom changes (r=mgoodwin) MozReview-Commit-ID: IdO8EP3hg0P
4a234901b459b858850a481b86d23da95d7dac90: Bug 1329234 - Remove last uses of Scoped.h from PSM. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Thu, 12 Jan 2017 00:56:38 +0800 - rev 357535
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1329234 - Remove last uses of Scoped.h from PSM. r=mgoodwin Existing code has already switched to the UniqueX NSS types. MozReview-Commit-ID: EXtFq7q1V2j
48b6436bbb3bc4f915e91a4b7529e664274b7091: Bug 1325107 - Stop using NS_NOTREACHED() in PSM. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Mon, 02 Jan 2017 14:11:51 +0800 - rev 356054
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1325107 - Stop using NS_NOTREACHED() in PSM. r=mgoodwin MOZ_ASSERT_UNREACHABLE() is basically equivalent to NS_NOTREACHED(). PSM already uses MOZ_ASSERT_UNREACHABLE() for new code, so there's no need to use NS_NOTREACHED() as well. MozReview-Commit-ID: 9k2z9a1oIqe
84f2c626acc1f311919ec60d30dbc0a4956cd3bd: Bug 1325107 - Stop using NS_ASSERTION() in PSM. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Mon, 02 Jan 2017 14:11:39 +0800 - rev 356053
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1325107 - Stop using NS_ASSERTION() in PSM. r=mgoodwin MOZ_ASSERT() is basically equivalent to NS_ASSERTION(). PSM already uses MOZ_ASSERT() for new code, so there's no need to use NS_ASSERTION() as well. MozReview-Commit-ID: JHDsbDkYvHf
9957c63c664df44054c7930a5632ba9e07af3f55: Bug 1325107 - Stop using PR_ASSERT() in PSM. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Mon, 02 Jan 2017 14:11:30 +0800 - rev 356052
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1325107 - Stop using PR_ASSERT() in PSM. r=mgoodwin PR_ASSERT() is an unnecessary dependency on NSPR. We can use MOZ_ASSERT() instead, which accomplishes the same task but doesn't depend on NSPR. MozReview-Commit-ID: 9gyWUkv3KxQ
f4001bdf070d219a9c59a14bdee1053de505070c: bug 1312827 - make the certificate blocklist only apply to TLS server certificates r=jcj,mgoodwin
David Keeler <dkeeler@mozilla.com> - Thu, 22 Dec 2016 16:57:20 -0800 - rev 355153
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
bug 1312827 - make the certificate blocklist only apply to TLS server certificates r=jcj,mgoodwin (Note that content signature verification does not use the unified certificate verifier and thus will still consult OneCRL.) MozReview-Commit-ID: 6KvHOngpabT
25d3398133713b557d392b00ebaedbafc3a297e0: bug 1312827 - make the certificate blocklist only apply to TLS server certificates r=jcj,mgoodwin
David Keeler <dkeeler@mozilla.com> - Thu, 22 Dec 2016 16:57:20 -0800 - rev 355145
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
bug 1312827 - make the certificate blocklist only apply to TLS server certificates r=jcj,mgoodwin MozReview-Commit-ID: 6KvHOngpabT
801e9e6efb1742fd3e086685cec6698c8d05a995: Bug 1322914 - Enable flake8 linting for security/manager. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Tue, 13 Dec 2016 00:25:45 +0800 - rev 353947
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1322914 - Enable flake8 linting for security/manager. r=mgoodwin Various non-conformant B2G related files are simply ignored, since it's not worth the time to update them to conform. MozReview-Commit-ID: 5QMbg5pHSbn
836efdd6c83eb5b486de973ee75083ac36fb6799: Bug 1319884 - Address FirefoxAdapter feedback from kinto.js#589, r=mgoodwin
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Wed, 23 Nov 2016 14:18:53 -0500 - rev 352924
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1319884 - Address FirefoxAdapter feedback from kinto.js#589, r=mgoodwin Change FirefoxAdapter definitively to require an externally-managed Sqlite connection in order to function. This connection must be produced by calling an openConnection() static method, which does the work of initializing the tables and schema. Passing any other connection is wrong, but won't be detected at runtime, and might even work depending on the previous state of the database. Future work might define a new KintoSqliteConnection type that can only be produced by this method, so that it's impossible to create an uninitialized Kinto database. This change, since it moves Sqlite connections out of the FirefoxAdapter, also means that the path option is no longer handled or provided with a default. This means that the previous default, "kinto.sqlite", is now preserved in a bunch of places all over the codebase. This is unfortunate, but a migration is outside the scope of this patch. MozReview-Commit-ID: BKJqPR3jOTq
5bd73b7a3d61c5b557f3bfe0b64511378e95939b: Bug 1318669 - Remove stripPrivateProps from blocklist-clients.js, r=mgoodwin
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Fri, 18 Nov 2016 10:07:39 -0500 - rev 351643
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1318669 - Remove stripPrivateProps from blocklist-clients.js, r=mgoodwin MozReview-Commit-ID: 84yvzpBr3Q6
41dfabec7e72f58119aac0054ac192de66bcde42: Bug 1312827 - make the certificate blocklist only apply to TLS server certificates r=jcj,mgoodwin a=jcristau
David Keeler <dkeeler@mozilla.com> - Thu, 22 Dec 2016 16:57:20 -0800 - rev 350000
Push 10519 by cbook@mozilla.com at Thu, 05 Jan 2017 07:55:18 +0000
Bug 1312827 - make the certificate blocklist only apply to TLS server certificates r=jcj,mgoodwin a=jcristau (Note that content signature verification does not use the unified certificate verifier and thus will still consult OneCRL.) MozReview-Commit-ID: 6KvHOngpabT
bd9fb386560691dd55d4905213f28fa9666d30b9: bug 1313491 - add basic tests that PSM sets the right security state during session resumption r=Cykesiopka,jcj,mgoodwin
David Keeler <dkeeler@mozilla.com> - Tue, 01 Nov 2016 13:47:51 -0700 - rev 348351
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
bug 1313491 - add basic tests that PSM sets the right security state during session resumption r=Cykesiopka,jcj,mgoodwin MozReview-Commit-ID: 3Q265OJyTIO
1c76db819ee6f879a126db6d2a91234a2547b3e2: bug 1313491 - include more context when determining EV status r=Cykesiopka,jcj,mgoodwin
David Keeler <dkeeler@mozilla.com> - Mon, 31 Oct 2016 17:02:57 -0700 - rev 348350
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
bug 1313491 - include more context when determining EV status r=Cykesiopka,jcj,mgoodwin When doing TLS session resumption, the AuthCertificate hook is bypassed, which means that the front-end doesn't know whether or not to show the EV indicator. To deal with this, the platform attempts an EV verification. Before this patch, this verification lacked much of the original context (e.g. stapled OCSP responses, SCTs, the hostname, and in particular the first-party origin key). Furthermore, it was unclear from a code architecture standpoint that a full verification was even occurring. This patch brings the necessary context to the verification and makes it much more clear that it is happening. It also takes the opportunity to remove some unnecessary EV-related fields and information in code and data structures that don't require it. MozReview-Commit-ID: LTmZU4Z1YXL
8c3384531cc0c11e25f3fd6f3860e00a2fc8e3c7: Bug 1310961 - Stop using nsIDialogParamBlock in deletecert.(js|xul). r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Wed, 19 Oct 2016 22:47:29 +0800 - rev 347164
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1310961 - Stop using nsIDialogParamBlock in deletecert.(js|xul). r=mgoodwin An nsIDialogParamBlock is unnecessary for how deletecert.(js|xul) is currently used. Moreover, nsIDialogParamBlock is arguably a poor API, so moving away from it is also advantageous. In addition, this patch also fixes this bug: 1. Select a cert to delete in one of the cert manager tabs. 2. Press the delete button to launch the confirmation dialog, but don't accept or cancel. 3. Switch to another tab in the cert manager. 4. Press the accept button in the confirmation dialog. ER: Cert selected in the original tab is deleted. AR: Cert at the same index of the new tab is deleted, even though it was never selected. MozReview-Commit-ID: 3N8klOhrVzi
30939b7409ab1c7d5d277b01bb551f9d1077b1c3: bug 1312919 - fix test_bug383369.html to not use SpecialPowers in chrome code r=mgoodwin
David Keeler <dkeeler@mozilla.com> - Wed, 26 Oct 2016 11:29:59 -0700 - rev 346989
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
bug 1312919 - fix test_bug383369.html to not use SpecialPowers in chrome code r=mgoodwin MozReview-Commit-ID: 5H0zjl9LIbo
6810346363585085e260d47a58cf5b7d58542d44: bug 1227638 - deterministically load EV information r=Cykesiopka,mgoodwin
David Keeler <dkeeler@mozilla.com> - Fri, 30 Sep 2016 18:08:08 -0700 - rev 345873
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
bug 1227638 - deterministically load EV information r=Cykesiopka,mgoodwin Previously PSM would load EV information on-demand (i.e. just before verifying a certificate). This simplifies this operation, removes a dubious optimization (loading the EV information on another thread while opening a network connection), and relocates the loading operation to when we are likely to have good disk locality (i.e. when we've just loaded the built-in roots module). This also removes the now-unused MOZ_NO_EV_CERTS build flag. MozReview-Commit-ID: 8Rnl4ozF95V
d8fe77542a28f55246ebe81bb296a7022b6ce98f: Bug 332442 - Stop abusing window name to pass cert ref to editcerts.js. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Tue, 18 Oct 2016 00:02:42 +0800 - rev 345045
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 332442 - Stop abusing window name to pass cert ref to editcerts.js. r=mgoodwin editcacert.xul/editcerts.js currently requires the |dbKey| attribute of an nsIX509Cert to be passed to it via the window name so it can get a handle to the nsIX509Cert. This has two problems: 1. This used to trigger warnings, and is unwise to do in any case. 2. It's unnecessary complexity - the nsIX509Cert can be passed directly. This patch: 1. Addresses the two problems. 2. Adds a test to ensure the functionality of editcerts.js actually works. 3. Rewrites editcerts.js to better fit modern PSM style. 4. Updates the name of editcerts.js so it's more consistent with the general convention under security/pki/resources/content MozReview-Commit-ID: ECxziXq5TmL
790e2a380a460f823a787cd36ebdac2e79260e1c: Bug 332442 - Keep track of and delete imported certs in head.js instead of in various test files. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Tue, 18 Oct 2016 00:02:41 +0800 - rev 345044
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 332442 - Keep track of and delete imported certs in head.js instead of in various test files. r=mgoodwin head.js is run/included for every test file in the same folder, so having it keep track of and clean up imported certs reduces the amount of duplication. MozReview-Commit-ID: 23482qadMiy
003ec40aa48433d748cacfcd7baf82d6347db407: bug 1227638 - deterministically load EV information r=Cykesiopka,mgoodwin
David Keeler <dkeeler@mozilla.com> - Fri, 30 Sep 2016 18:08:08 -0700 - rev 344952
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
bug 1227638 - deterministically load EV information r=Cykesiopka,mgoodwin Previously PSM would load EV information on-demand (i.e. just before verifying a certificate). This simplifies this operation, removes a dubious optimization (loading the EV information on another thread while opening a network connection), and relocates the loading operation to when we are likely to have good disk locality (i.e. when we've just loaded the built-in roots module). This also removes the now-unused MOZ_NO_EV_CERTS build flag. MozReview-Commit-ID: 8Rnl4ozF95V
c833c9f92554dc099d47e0fa90d42dd5de3afa07: Bug 332442 - Stop abusing window name to pass cert ref to editcerts.js. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Mon, 10 Oct 2016 16:08:36 +0800 - rev 344189
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 332442 - Stop abusing window name to pass cert ref to editcerts.js. r=mgoodwin editcacert.xul/editcerts.js currently requires the |dbKey| attribute of an nsIX509Cert to be passed to it via the window name so it can get a handle to the nsIX509Cert. This has two problems: 1. This used to trigger warnings, and is unwise to do in any case. 2. It's unnecessary complexity - the nsIX509Cert can be passed directly. This patch: 1. Addresses the two problems. 2. Adds a test to ensure the functionality of editcerts.js actually works. 3. Rewrites editcerts.js to better fit modern PSM style. 4. Updates the name of editcerts.js so it's more consistent with the general convention under security/pki/resources/content MozReview-Commit-ID: ECxziXq5TmL
4967ccb1d9ff9af6ac435c007d36b44b52e24354: Bug 332442 - Keep track of and delete imported certs in head.js instead of in various test files. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Mon, 10 Oct 2016 16:08:36 +0800 - rev 344188
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 332442 - Keep track of and delete imported certs in head.js instead of in various test files. r=mgoodwin head.js is run/included for every test file in the same folder, so having it keep track of and clean up imported certs reduces the amount of duplication. MozReview-Commit-ID: 23482qadMiy
fcfc065914e5d402f1f2af030a965f4afbf6ca66: Bug 1186286 - Consult more than just the CN when deleting a cert so it's always clear what's being deleted. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Fri, 07 Oct 2016 20:14:27 +0800 - rev 343689
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1186286 - Consult more than just the CN when deleting a cert so it's always clear what's being deleted. r=mgoodwin Deleting certs via the cert manager results in a confirmation dialog popping up. This dialog contains a list of certs that were selected for deletion. Currently, only the Common Name of each cert is used to represent it in the list. This is a problem for certs that don't have a CN. More jarringly, the cert manager itself falls back to various other attributes, so for example selecting a cert that is represented by its OU ends up popping up a dialog where an empty list is shown. MozReview-Commit-ID: 3z4BebW8Ucd
4c693c3241fa5f68169f2b232828da2e499a8db3: Bug 1186286 - Move some code around to facilitate code reuse for the subsequent patch. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Fri, 07 Oct 2016 20:11:35 +0800 - rev 343688
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1186286 - Move some code around to facilitate code reuse for the subsequent patch. r=mgoodwin The existing code in head.js is moved out because it doesn't need to be there now, and probably not in the near future. MozReview-Commit-ID: GWUW9wT3fzF
ffb38910dcae79a05680bdb917ef93e69d6d3a8a: bug 1225682 - (still) don't use nsAutoString as class member variable in security/manager/ r=mgoodwin
David Keeler <dkeeler@mozilla.com> - Fri, 18 Mar 2016 10:24:27 -0700 - rev 343523
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
bug 1225682 - (still) don't use nsAutoString as class member variable in security/manager/ r=mgoodwin MozReview-Commit-ID: LvFQdleIuEx
daf738c4a41117ef270fc56dd1ec10121b596802: Bug 1305422 - part 15 - don't call size_forward in nsPKCS12Blob; r=mgoodwin,nfroyd
David Keeler <dkeeler@mozilla.com> - Thu, 29 Sep 2016 19:33:57 -0700 - rev 342571
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1305422 - part 15 - don't call size_forward in nsPKCS12Blob; r=mgoodwin,nfroyd Before this patch, nsPKCS12Blob::digest_read used size_forward to perform a size check on a buffer. However, the entire set of {digest_open, digest_close, digest_read, digest_write} was unnecessary because NSS provides this functionality by default when using SEC_PKCS12DecoderStart. This patch simplifies things by removing the extraneous implementations.
d0f9173a4daf66f0a2188a6b34e7b3f99d2085d8: Bug 1252385 - Remove unused nsNSSCertTrust methods. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Sat, 03 Sep 2016 22:47:20 +0800 - rev 338449
Push 10033 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:50:26 +0000
Bug 1252385 - Remove unused nsNSSCertTrust methods. r=mgoodwin MozReview-Commit-ID: 4vcFlcv5FJo
fabfb2ff761eace61d0433e4d6e3d74e0cba193e: bug 1290613 - test_ev_certs.js cleanup r=Cykesiopka,mgoodwin
David Keeler <dkeeler@mozilla.com> - Mon, 01 Aug 2016 17:01:27 -0700 - rev 337808
Push 10033 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:50:26 +0000
bug 1290613 - test_ev_certs.js cleanup r=Cykesiopka,mgoodwin MozReview-Commit-ID: KcCV161J3qV
9aac837c6e4955057c53f0608431b099d45dfe41: Bug 1296316 - Convert nsNSSShutDownObject::CalledFromType to an enum class. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Sat, 20 Aug 2016 23:00:19 +0800 - rev 336542
Push 10033 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:50:26 +0000
Bug 1296316 - Convert nsNSSShutDownObject::CalledFromType to an enum class. r=mgoodwin enum classes are in general safer than plain enums, and as such should be preferred. MozReview-Commit-ID: 1FK89SNhdk4
e8b7e5dc300463a6bc5ecd5813329d6acce02982: bug 1119778 - make "Forget About This Site" clear HSTS and HPKP info r=MattN,mgoodwin
David Keeler <dkeeler@mozilla.com> - Wed, 27 Jul 2016 17:11:52 -0700 - rev 333295
Push 10033 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:50:26 +0000
bug 1119778 - make "Forget About This Site" clear HSTS and HPKP info r=MattN,mgoodwin MozReview-Commit-ID: IJVQBsryfHq
c8fddbc2ee1d30aa16e635795c520d659a0c8edf: Bug 1119778 - Make "Forget About This Site" clear HSTS and HPKP info. r=MattN, r=mgoodwin, a=ritu
David Keeler <dkeeler@mozilla.com> - Wed, 27 Jul 2016 17:11:52 -0700 - rev 332699
Push 9905 by ryanvm@gmail.com at Tue, 16 Aug 2016 14:09:19 +0000
Bug 1119778 - Make "Forget About This Site" clear HSTS and HPKP info. r=MattN, r=mgoodwin, a=ritu MozReview-Commit-ID: IJVQBsryfHq
c80456e5e3dd72a65de2f7acaf5be73f3df80144: bug 1119778 - make "Forget About This Site" clear HSTS and HPKP info r=MattN,mgoodwin
David Keeler <dkeeler@mozilla.com> - Wed, 27 Jul 2016 17:11:52 -0700 - rev 332499
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
bug 1119778 - make "Forget About This Site" clear HSTS and HPKP info r=MattN,mgoodwin MozReview-Commit-ID: IJVQBsryfHq
cfe979de162ecf6f235e92e70b4d9ccc3c473e8d: Bug 1263793 - update SAN, r=mgoodwin,ulfr
Franziskus Kiefer <franziskuskiefer@gmail.com> - Mon, 25 Jul 2016 09:44:19 +0200 - rev 331608
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1263793 - update SAN, r=mgoodwin,ulfr MozReview-Commit-ID: HtMKl2gP1xi
df769eb7552e3485297e670803b0b33553c131a4: Bug 1284438 - Enable more ESLint rules for PSM. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Wed, 06 Jul 2016 01:59:03 +0800 - rev 329914
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1284438 - Enable more ESLint rules for PSM. r=mgoodwin PSM JS code already pass these rules, so enabling these rules will just help catch future bugs. MozReview-Commit-ID: AXM2VoG8jBP
731d8d633db8559244e2192d82b5a7b0af0a0ce5: Bug 1282004 - Convert TestMD4 CPP unit test into a GTest. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Mon, 27 Jun 2016 09:06:51 -0700 - rev 328294
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1282004 - Convert TestMD4 CPP unit test into a GTest. r=mgoodwin Nothing in the file requires functionality provided by the CPP unit test harness, so making the file a GTest makes it more accessible. MozReview-Commit-ID: FaAtF0blCwV
80a6a5d462603630918b7ddf0ebb62aa93049ef2: Bug 1282004 - Make it easier to run all PSM GTests at once. r=mgoodwin
Cykesiopka <cykesiopka.bmo@gmail.com> - Mon, 27 Jun 2016 09:06:43 -0700 - rev 328293
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1282004 - Make it easier to run all PSM GTests at once. r=mgoodwin Currently, running all the PSM GTests involves providing a filter that catches all the various tests. This is annoying and error prone. The changes here make running all PSM GTests as easy as: mach gtest "psm*" MozReview-Commit-ID: EqaysNvwJaQ
d985d574aea68b484d057e7a80a2172750b5db45: bug 826783 - make certificate viewer more flexible about its minimum size r=mgoodwin
David Keeler <dkeeler@mozilla.com> - Fri, 24 Jun 2016 10:23:18 -0700 - rev 328172
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
bug 826783 - make certificate viewer more flexible about its minimum size r=mgoodwin This makes the certificate viewer able to shrink itself down a bit on small screen sizes. Without this patch, the "Close" button would be off the screen on small resolutions like 1024x768. On larger screen sizes, this patch should have no effect on the initial size of the certificate viewer window (although it now can be made smaller manually). MozReview-Commit-ID: IET9dxx23Xc
231f18c06694da3d6cda786e4055f262a04e6a3c: bug 1282871 - import the Family Safety root by default when applicable r=mgoodwin
David Keeler <dkeeler@mozilla.com> - Tue, 28 Jun 2016 14:18:26 -0700 - rev 328171
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
bug 1282871 - import the Family Safety root by default when applicable r=mgoodwin Enabling this feature should make https sites work in Firefox on Windows 8.1 for user accounts where Microsoft Family Safety features have been enabled (whereas previously Firefox would show a connection untrusted error page). MozReview-Commit-ID: JH5Gn9lCYDA
394465ca5a62ce1276147aec4a5e4f695759baf9: bug 1278041 - skip TLS Feature checks so HPKP can be set r=mgoodwin
David Keeler <dkeeler@mozilla.com> - Mon, 20 Jun 2016 16:36:36 -0700 - rev 327293
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
bug 1278041 - skip TLS Feature checks so HPKP can be set r=mgoodwin This is safe because TLS Feature checks have already been done when connecting to the site in the first place. MozReview-Commit-ID: HfbcrAv4bCJ
852f817ca2c4a23f0736c4407305341adbc99904: Bug 1278041 - skip TLS Feature checks so HPKP can be set. r=mgoodwin, a=sylvestre
David Keeler <dkeeler@mozilla.com> - Mon, 20 Jun 2016 16:36:36 -0700 - rev 325189
Push 9707 by cbook@mozilla.com at Mon, 27 Jun 2016 12:11:59 +0000
Bug 1278041 - skip TLS Feature checks so HPKP can be set. r=mgoodwin, a=sylvestre This is safe because TLS Feature checks have already been done when connecting to the site in the first place. MozReview-Commit-ID: HfbcrAv4bCJ
0dfa11a25c898eb9d7d9d7220cc3323e8211d1aa: Bug 1273696 - Move pref reset button for cert errors and hide retry when pref reset is possible. r=mgoodwin, r=past
Jonathan Kingston <jkingston@mozilla.com> - Wed, 18 May 2016 13:47:38 +0100 - rev 323562
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1273696 - Move pref reset button for cert errors and hide retry when pref reset is possible. r=mgoodwin, r=past MozReview-Commit-ID: 2znWHkmitnF
dc96a1440e3c4f29da67e6eb8b6b6004a021bc7f: Bug 1266235 - Rename KintoBlocklist to blocklist-clients. r=mgoodwin
Mathieu Leplatre <mathieu@mozilla.com> - Thu, 28 Apr 2016 13:24:21 +0200 - rev 323124
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1266235 - Rename KintoBlocklist to blocklist-clients. r=mgoodwin MozReview-Commit-ID: Eus7sHqN6GW