searching for reviewer(mcomella)
bde43f72a0058e748d861d49ed7546dff4b58c32: Bug 1317191 - Return when onPause is called before onResume and add Telemetry ping for future debugging. r=mcomella, a=lizzard
Nevin Chen <cnevinchen@gmail.com> - Wed, 29 Mar 2017 21:09:00 -0400 - rev 375718
Push 11015 by ryanvm@gmail.com at Tue, 04 Apr 2017 22:25:39 +0000
Bug 1317191 - Return when onPause is called before onResume and add Telemetry ping for future debugging. r=mcomella, a=lizzard MozReview-Commit-ID: HsLP061zOKb
ed793a550dd602631e25febe9fc39f3bab41e80a: Bug 1269734 - Include adjust campaign ID with core ping r=mcomella
Jonathan Almeida (:jonalmeida) <jonalmeida942@gmail.com> - Tue, 19 Jul 2016 13:58:28 -0700 - rev 336335
Push 10033 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:50:26 +0000
Bug 1269734 - Include adjust campaign ID with core ping r=mcomella MozReview-Commit-ID: KZJKYzBfRfK
19222e86fb30c034d5ec45f9c8f1e51fb7efe183: Bug 1291373 - [geckoview] part 2, Clean up ActionBarTextSelection to remove unsupported code r=snorp,mcomella
Randall Barker <rbarker@mozilla.com> - Fri, 05 Aug 2016 13:32:29 -0700 - rev 335503
Push 10033 by raliiev@mozilla.com at Mon, 19 Sep 2016 13:50:26 +0000
Bug 1291373 - [geckoview] part 2, Clean up ActionBarTextSelection to remove unsupported code r=snorp,mcomella
830a8be8be2a90e9730ad61039c06db980eef0cc: Bug 1031519 - Use immersive fullscreen when available. r=mcomella
Tom Klein <twointofive@gmail.com> - Mon, 18 Jul 2016 18:50:47 -0500 - rev 331173
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1031519 - Use immersive fullscreen when available. r=mcomella This is Deepthi Venkitaramanan's patch with feedback comments addressed. MozReview-Commit-ID: 7vs0ZgefOVy
77a5e8e87f91113dcf6cb15fdc83a184cc237e48: Bug 1280382 - Catch ClassCastException that may occur on return from generic method r=mcomella
Andrzej Hunt <ahunt@mozilla.com> - Tue, 05 Jul 2016 09:29:30 -0700 - rev 330560
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1280382 - Catch ClassCastException that may occur on return from generic method r=mcomella MozReview-Commit-ID: BfiAMAEY1jY
a35a15008f0c37488cfc5f907f6d553aab028eb8: Bug 1284544 - Remove redundant flag from PackageManager.queryIntentServices r=mcomella
Andrzej Hunt <ahunt@mozilla.com> - Tue, 05 Jul 2016 09:12:47 -0700 - rev 330559
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1284544 - Remove redundant flag from PackageManager.queryIntentServices r=mcomella GET_SERVICES is already implicit in this method name. Using lint running against sdk 24 we get a warning that GET_SERVICES isn't a permitted flag. (Previous sdks didn't yet contain a list of allowable flags.) MozReview-Commit-ID: LINassWOTfc
5585aaffb2b674068cad9a125a7528a57c0962c0: Bug 1284544 - lint: suppress useless override error caused by presence of 24 sdk r=mcomella
Andrzej Hunt <ahunt@mozilla.com> - Mon, 18 Jul 2016 18:21:41 -0700 - rev 330558
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1284544 - lint: suppress useless override error caused by presence of 24 sdk r=mcomella We're still building with the 23 sdk, but lint is now giving us errors based on the 24 sdk. We therefore need to explicitly suppress the error (even though in reality we don't want to suppress the error so that we don't miss adding the @Override annotation when we switch to 24). MozReview-Commit-ID: 3RqLMhiyAFh
0cb14ba581524b331fd3f0c850695a963c6cc3e4: Bug 1284544 - lint: don't error on "OldTargetSdk", we don't want to upgrade the sdk yet r=mcomella
Andrzej Hunt <ahunt@mozilla.com> - Tue, 05 Jul 2016 09:04:43 -0700 - rev 330557
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1284544 - lint: don't error on "OldTargetSdk", we don't want to upgrade the sdk yet r=mcomella MozReview-Commit-ID: 7PGejjpmNWh
717e8cdc7be7951d4396ea8c758d1a483cf9a065: Bug 1261980 - Added checks in GeckoProfileDirectories to prevent null dereferencing. r=mcomella
Nicholas Rosbrook <nrosbrook@mail.smcvt.edu> - Fri, 17 Jun 2016 18:22:26 -0700 - rev 330039
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1261980 - Added checks in GeckoProfileDirectories to prevent null dereferencing. r=mcomella
668bade89622e322b3d8c191b9ce1c9a8e34e54f: Bug 1283478 - Tapping the download notification does not open the downloaded file r=mcomella
Jonathan Almeida (:jonalmeida) <jonalmeida942@gmail.com> - Tue, 05 Jul 2016 15:44:17 -0700 - rev 329826
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1283478 - Tapping the download notification does not open the downloaded file r=mcomella We were incorrectly retrieving the cookie from the notification intent and passing that along which affected the invocation of the notification. MozReview-Commit-ID: FxL8sw6lByJ
5013e7bb1c9fb049cfeb8546caf5cd504a57114e: Bug 1250782 - Include fxaDeviceId in sync client records. r=mcomella, nalexander
Edouard Oger <eoger@fastmail.com> - Wed, 18 May 2016 13:43:10 -0700 - rev 329140
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1250782 - Include fxaDeviceId in sync client records. r=mcomella, nalexander MozReview-Commit-ID: BjTKTN5XX4w
2b40afc365695b8ee407c46dea9ea5c89ada8beb: Bug 1250782 - Update device registration on device name change. r=mcomella, nalexander
Edouard Oger <eoger@fastmail.com> - Wed, 18 May 2016 12:49:56 -0700 - rev 329139
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1250782 - Update device registration on device name change. r=mcomella, nalexander MozReview-Commit-ID: Cqhej5cfKvE
bbc96e84aec09352666082b63ba0c51452c1d77d: Bug 1250782 - Register device on married state. r=mcomella, nalexander
Edouard Oger <eoger@fastmail.com> - Wed, 18 May 2016 12:48:49 -0700 - rev 329138
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1250782 - Register device on married state. r=mcomella, nalexander MozReview-Commit-ID: CswoGEpoNl3
28cff660f4e61fda441711ad4c4980599e97a3fa: Bug 1250782 - Add FxAccountDeviceRegistrator. r=mcomella, nalexander
Edouard Oger <eoger@fastmail.com> - Wed, 18 May 2016 12:48:21 -0700 - rev 329137
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1250782 - Add FxAccountDeviceRegistrator. r=mcomella, nalexander MozReview-Commit-ID: LIHuHxnfW1V
c8020e8d970ed9a437750a8ac54ef444c0844833: Bug 1250782 - FxAccountClient: add deviceList method. r=mcomella
Edouard Oger <eoger@fastmail.com> - Wed, 18 May 2016 12:36:31 -0700 - rev 329136
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1250782 - FxAccountClient: add deviceList method. r=mcomella MozReview-Commit-ID: GJ0fDsKkNEl
17541521c2ece62312b1e907a7675c7c7ba0711c: Bug 1250782 - FxAccountClient: add registerOrUpdateDevice method. r=mcomella
Edouard Oger <eoger@fastmail.com> - Wed, 18 May 2016 12:35:50 -0700 - rev 329135
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1250782 - FxAccountClient: add registerOrUpdateDevice method. r=mcomella MozReview-Commit-ID: 6cGQTZq5G1W
985cadcc9ed5a98f520e6988f556dadbb26266a9: Bug 1250782 - FxAccountClient: add accountStatus method and rename status method to recoveryEmailStatus. r=mcomella
Edouard Oger <eoger@fastmail.com> - Wed, 18 May 2016 12:28:51 -0700 - rev 329134
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1250782 - FxAccountClient: add accountStatus method and rename status method to recoveryEmailStatus. r=mcomella MozReview-Commit-ID: 3fFQaFe14x2
346623206d14008a0877ee57f3a2a4e396386da6: Bug 1250782 - ResourceDelegate#handleSuccess now gives access to a JsonArray body. r=mcomella
Edouard Oger <eoger@fastmail.com> - Wed, 18 May 2016 12:32:55 -0700 - rev 329133
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1250782 - ResourceDelegate#handleSuccess now gives access to a JsonArray body. r=mcomella MozReview-Commit-ID: HbRgCaMPZY7
ec25edc09a602ae0abf6b957d603018598e3ef7b: Bug 1250782 - Allow MozResponse to return a Json array body. r=mcomella
Edouard Oger <eoger@fastmail.com> - Wed, 18 May 2016 12:22:49 -0700 - rev 329132
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1250782 - Allow MozResponse to return a Json array body. r=mcomella MozReview-Commit-ID: B40vvA0E7xJ
bc55f3804d80c29e66abf8352faa705c6dca1d41: Bug 1235599 - Add basic UrlMetadata tests r=mcomella
Andrzej Hunt <ahunt@mozilla.com> - Mon, 06 Jun 2016 13:08:55 -0700 - rev 327804
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1235599 - Add basic UrlMetadata tests r=mcomella MozReview-Commit-ID: J7zSI7E9jb7
98220ccf6c93d6530c73e44f5511c23420fbe95e: Bug 1235599 - Make UrlMetadataTable.CONTENT_URI public to allow using in tests r=mcomella
Andrzej Hunt <ahunt@mozilla.com> - Mon, 06 Jun 2016 13:06:43 -0700 - rev 327803
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1235599 - Make UrlMetadataTable.CONTENT_URI public to allow using in tests r=mcomella MozReview-Commit-ID: EFDX4uihBqz
0f0aee891a7a6ea512448554feb30b68d34c532e: Bug 1276696 - Put custom tabs support behind a build flag. r=mcomella
Sebastian Kaspari <s.kaspari@gmail.com> - Mon, 30 May 2016 16:48:45 +0200 - rev 326858
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1276696 - Put custom tabs support behind a build flag. r=mcomella MozReview-Commit-ID: 44wtCsZWZv2
aa393509b3ce2715c441dd36f0ce8cce0c419da7: Bug 1276696 - Add dummy service for custom tabs. r=mcomella
Sebastian Kaspari <s.kaspari@gmail.com> - Wed, 25 May 2016 19:31:10 +0200 - rev 326857
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1276696 - Add dummy service for custom tabs. r=mcomella Currently this service does not implement any of the callbacks. However it is necessary to be detected as an app supporting custom tabs. MozReview-Commit-ID: Hz99Gp9aQCX
a449393cc44f986efffb41742d9c324b00b2caae: Bug 1276696 - Add CustomTabsActivity based on GeckoApp. r=mcomella
Sebastian Kaspari <s.kaspari@gmail.com> - Wed, 25 May 2016 19:58:17 +0200 - rev 326856
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1276696 - Add CustomTabsActivity based on GeckoApp. r=mcomella This activity doesn't do much yet and just has a layout including a GeckoView. Some basic behavior from GeckoApp is working though: Context menus, floating text selection, snackbars. MozReview-Commit-ID: C6SJeYz609h
a08f7952eebaa20f82c83644ae228e4cc3e46d25: Bug 1276696 - Add custom tabs support library. r=mcomella
Sebastian Kaspari <s.kaspari@gmail.com> - Fri, 10 Jun 2016 11:01:11 +0200 - rev 326855
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1276696 - Add custom tabs support library. r=mcomella MozReview-Commit-ID: LXie1GiV4gV
ed07ec207c76e28aa63a7aa04c1c6c8a8d6a1577: Bug 1276696 - Introduce new LauncherActivity that will handle all incoming Intents. r=mcomella
Sebastian Kaspari <s.kaspari@gmail.com> - Sun, 15 May 2016 14:25:12 +0200 - rev 326854
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1276696 - Introduce new LauncherActivity that will handle all incoming Intents. r=mcomella We will need to dispatch Intent objects to different destinations (Browser, Custom Tab and eventually progressive web apps). The logic of TabQueueDispatcher is folded into this new activity. MozReview-Commit-ID: 3P4eIvtAKEW
b5d5515f30c820692e52707f4ddb6ee624b50c9e: Bug 1245952 - Corrected comment in localization note to reference the corresponding string. r=mcomella
Kevin Lam <kevin.lam.cs@gmail.com> - Wed, 08 Jun 2016 18:08:00 +0200 - rev 326538
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1245952 - Corrected comment in localization note to reference the corresponding string. r=mcomella
97074800423c429ca7ae01ca5db8c2e61b0fee17: Bug 1264489 - Avoid DB access in UI thread from onPrepareOptionsMenu r=mcomella
Andrzej Hunt <ahunt@mozilla.com> - Mon, 06 Jun 2016 10:42:12 -0700 - rev 326222
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1264489 - Avoid DB access in UI thread from onPrepareOptionsMenu r=mcomella DB access happens deep in the internals of setting a new Intent for our ActionProvider. Posting this to a background thread here seems to be the simplest option to ensure correct threading. MozReview-Commit-ID: 3iS8w5Cxf02
61442f7ad442445cf5492949fb8771176e12cc50: Bug 1264489 - Pre: assert DB access is on background thread in debug builds r=mcomella
Andrzej Hunt <ahunt@mozilla.com> - Tue, 07 Jun 2016 08:57:19 -0700 - rev 326221
Push 9858 by jlund@mozilla.com at Mon, 01 Aug 2016 14:37:10 +0000
Bug 1264489 - Pre: assert DB access is on background thread in debug builds r=mcomella It's possible there are more UI-thread DB accesses lurking. To avoid maintenance burden we should therefore enable this assert only in debug builds - releases will be unaffected, but we can still notice incorrect DB access during development. MozReview-Commit-ID: Kgzf1L3WjIE
099dc4e6838eb8fb920178fba801d125e04316e7: Bug 1280382 - Catch ClassCastException that may occur on return from generic method. r=mcomella, a=sylvestre
Andrzej Hunt <ahunt@mozilla.com> - Tue, 05 Jul 2016 09:29:30 -0700 - rev 325468
Push 9804 by cbook@mozilla.com at Wed, 20 Jul 2016 08:30:59 +0000
Bug 1280382 - Catch ClassCastException that may occur on return from generic method. r=mcomella, a=sylvestre MozReview-Commit-ID: BfiAMAEY1jY
c537b77d3d25d03493107c7a9c23587cd4d21abe: Bug 1274901 - NullPointerException thrown in Tabs.java should be checked r=mcomella
Jonathan Almeida (:jonalmeida) <jonalmeida942@gmail.com> - Tue, 24 May 2016 15:08:52 -0700 - rev 324850
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1274901 - NullPointerException thrown in Tabs.java should be checked r=mcomella MozReview-Commit-ID: 2hMZn75BpeT
199fac6509aa6aaa249a178d6bd39e87f3061a67: Bug 1246159 - Add histogram probe for disk space used by reader view cache r=mcomella
Andrzej Hunt <ahunt@mozilla.com> - Thu, 12 May 2016 13:37:58 -0700 - rev 323163
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1246159 - Add histogram probe for disk space used by reader view cache r=mcomella MozReview-Commit-ID: 4r1yvWZ4lid
6afaaa5cf43b2729a342bb7a7f51c5bbb7a4f41b: Bug 1246159 - Pre: implement SavedReaderViewHelper.getBytesUsed r=mcomella
Andrzej Hunt <ahunt@mozilla.com> - Tue, 24 May 2016 15:01:17 -0700 - rev 323162
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1246159 - Pre: implement SavedReaderViewHelper.getBytesUsed r=mcomella MozReview-Commit-ID: EJ81q6f515q
a341a931d016eccc1b9b1fc7594a6cdfeab287db: Bug 1272506 - Change GeckoApp.ONE_DAY_MS to be initialized with the TimeUnit class. r=mcomella
Cesar Valiente <cesar.valiente@gmail.com> - Sat, 14 May 2016 11:42:04 +0200 - rev 323136
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1272506 - Change GeckoApp.ONE_DAY_MS to be initialized with the TimeUnit class. r=mcomella
ac75f8f4c01d67d54cc0d2cef39f1204ebcfa20f: Bug 1274956 - Pre: Make it easier to test Adjust locally. r=mcomella
Nick Alexander <nalexander@mozilla.com> - Mon, 23 May 2016 13:42:09 +0200 - rev 322709
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1274956 - Pre: Make it easier to test Adjust locally. r=mcomella This does a few things. First, it makes non-official builds use the Adjust sandbox. Second, I observe that the fake sandbox key no longer sends anything, so it's no longer valuable; this patch instead requires an Adjust token if install tracking is enabled, since we can't provide a default any more. Third, it removes a spurious default in configure.in; without this default, builders can easily enable Adjust locally using the following in their mozconfig: ac_add_options --with-adjust-sdk-keyfile=/path/to/adjust-sdk.keyfile export MOZ_INSTALL_TRACKING=1 With the default, the "export" had no impact, because it was overwritten immediately. MozReview-Commit-ID: Cn62fmrgwJL
e155723908e3c2aa129f12e7000ae416d91f5c70: Bug 1267580 - Hide Reading List smartfolder if empty r=mcomella
Andrzej Hunt <ahunt@mozilla.com> - Wed, 18 May 2016 08:59:56 -0700 - rev 322689
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1267580 - Hide Reading List smartfolder if empty r=mcomella MozReview-Commit-ID: HIGkK9Z19aq
5b17c3dacc25f65c82dfdb09bff09de96f17079d: Bug 1272659 - Revert additional padding for the share icon r=mcomella
Andrzej Hunt <ahunt@mozilla.com> - Wed, 18 May 2016 10:13:32 -0700 - rev 322688
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1272659 - Revert additional padding for the share icon r=mcomella We were experimenting with this on phones, however we decided this was unnecessary. MozReview-Commit-ID: LSJILxFO3a
bf8d6578893967e467eb3b37617b8c12493b7272: Bug 1266199 - Rename BrowserApp.searchEngineManager to mSearchEngineManager. r=mcomella
bzrd_Sdn <bouzroudzeineb@gmail.com> - Thu, 19 May 2016 21:38:38 -0400 - rev 322670
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1266199 - Rename BrowserApp.searchEngineManager to mSearchEngineManager. r=mcomella
aa7ea6cc079202092ea3234ad9bd8fd72db3e3f2: Bug 1261210 - Rename omg.mozglue.ContextUtils -> omg.mozglue.SafeIntentUtils. r=mcomella
Michael Comella <michael.l.comella@gmail.com> - Wed, 18 May 2016 15:48:07 -0700 - rev 322422
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1261210 - Rename omg.mozglue.ContextUtils -> omg.mozglue.SafeIntentUtils. r=mcomella MozReview-Commit-ID: 99kZNBPmqes
a4491cec2aa404caba9eee49657b62acaf9335f4: Bug 1271318 - Don't keep context in GeckoNetworkManager, and get it from GeckoAppShell r=mcomella
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 16 May 2016 14:41:09 -0700 - rev 322410
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1271318 - Don't keep context in GeckoNetworkManager, and get it from GeckoAppShell r=mcomella MozReview-Commit-ID: DX4GOca5IoO
64ad4c149ac09500108a684e9799664257c3d799: Bug 1273173 - Fix reader button telemetry events. r=mcomella
Margaret Leibovic <margaret.leibovic@gmail.com> - Mon, 16 May 2016 21:03:15 -0700 - rev 322214
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1273173 - Fix reader button telemetry events. r=mcomella MozReview-Commit-ID: ED2MFgQnh0z
c32981aa0f19bcd2791a27d0dfa693a056126230: Bug 1269001 - Show number of items for reading list smartfolder r=mcomella
Andrzej Hunt <andrzej@ahunt.org> - Tue, 10 May 2016 13:38:36 -0700 - rev 321929
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1269001 - Show number of items for reading list smartfolder r=mcomella MozReview-Commit-ID: EEtOqum7ejn
95739305c4d0843f72f579cd5437e70281b4aec7: Bug 1269001 - Introduce BrowserDB.getBookmarkCountForFolder r=mcomella
Andrzej Hunt <andrzej@ahunt.org> - Thu, 05 May 2016 11:10:49 -0700 - rev 321928
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1269001 - Introduce BrowserDB.getBookmarkCountForFolder r=mcomella For now we only need to support the bookmarks smartfolder, however we might want to extend this to support "recent bookmarks" in future. MozReview-Commit-ID: CvDNyfycWRl
4f0d003a90d1e7bd3b4cdd5320ba80e7c03451de: Bug 1269001 - Pre: use two line layout for BookmarkFolderView r=mcomella
Andrzej Hunt <andrzej@ahunt.org> - Thu, 05 May 2016 11:06:46 -0700 - rev 321927
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1269001 - Pre: use two line layout for BookmarkFolderView r=mcomella We want to be able to show the numebr of items for certain folders (e.g. the reading list smartfolder). The previous state list drawable was also unnecessarily confusing, let's just reference the desired images directly. We can do this largely by copying the existing TwoLinePageRow, modulo the unneeded status / switch-to-tab icons. MozReview-Commit-ID: 3w0Hcj0kIfG
83823a99114c095f1771d9a6b9c7d735dfe25abe: Bug 1264480 - Moved Distribution.ReadyCallback @WorkerThread annotation to the individual methods. r=mcomella
Jorick Caberio <jorick.caberio@gmail.com> - Thu, 14 Apr 2016 18:13:52 +0800 - rev 321088
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1264480 - Moved Distribution.ReadyCallback @WorkerThread annotation to the individual methods. r=mcomella MozReview-Commit-ID: 9lG2SPyPyP9
bbda46c289f1c84303db1f8efc89094b4b78ccff: Bug 1236130 - Part 2: Only use cache for tabs when network state is "down" r=mcomella
Grigory Kruglov <gkruglov@mozilla.com> - Thu, 28 Apr 2016 15:27:35 -0700 - rev 320728
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1236130 - Part 2: Only use cache for tabs when network state is "down" r=mcomella MozReview-Commit-ID: IC3lmO8cUBa
3cac818d4803432669bbe3ed916af12172b56d2e: Bug 1236130 - Part 1: Use an explicit state machine to control GeckoNetworkManager r=mcomella
Grigory Kruglov <gkruglov@mozilla.com> - Thu, 05 May 2016 01:27:35 -0700 - rev 320727
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1236130 - Part 1: Use an explicit state machine to control GeckoNetworkManager r=mcomella - specifying states, events and transition side-effects explicitely makes this code easier to read/maintain - move bunch of network state helper methods into NetworkUtils - ensure to update both network state (up/down/unknown), as well as connection type/subtype every time we need to update network state -- this should fix the buggy behaviour when we'd miss certain network state transitions - tests for the FSM transition matrix, and everything in the NetworkUtils MozReview-Commit-ID: LvrfHyFdkpB
932e2fda5e33bd2d80ac53df43ee59880780ad7c: Bug 1269661 - Checkstyle violations in history panel code. r=mcomella
Chenxia Liu <liuche@mozilla.com> - Tue, 03 May 2016 12:55:38 -0700 - rev 320402
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1269661 - Checkstyle violations in history panel code. r=mcomella MozReview-Commit-ID: CHuVsqhDuUw
f956d7fa4626295324504a6bd091b1113788eb64: Bug 1265525 - Pre: move history expirations tests to junit4 r=mcomella
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 02 May 2016 18:43:57 -0700 - rev 320331
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1265525 - Pre: move history expirations tests to junit4 r=mcomella MozReview-Commit-ID: DtkjEFoYQMA
9015ebea629332d283c11fdb8c525d5c1d20c8d2: Bug 1261993 - [infer] Errors in DefaultDoorHanger. r=mcomella
Chenxia Liu <liuche@mozilla.com> - Thu, 21 Apr 2016 16:24:39 -0700 - rev 320204
Push 9671 by raliiev@mozilla.com at Mon, 06 Jun 2016 20:27:52 +0000
Bug 1261993 - [infer] Errors in DefaultDoorHanger. r=mcomella MozReview-Commit-ID: AemVFuiMNjo