searching for reviewer(mats)
e984689093ed389415affc819776a6eede5d44d2: Bug 1351359 - Make nsGridContainerFrame call ReflowInput::SetBResize(true) because of auto-block-size swapping between measuring reflows and regular reflows. r=mats, a=gchang
L. David Baron <dbaron@dbaron.org> - Thu, 30 Mar 2017 22:56:14 -0400 - rev 375942
Push 11063 by ryanvm@gmail.com at Mon, 17 Apr 2017 14:39:33 +0000
Bug 1351359 - Make nsGridContainerFrame call ReflowInput::SetBResize(true) because of auto-block-size swapping between measuring reflows and regular reflows. r=mats, a=gchang This fixes the failure of layout/reftests/css-grid/grid-min-max-content-sizing-002.html with the primary patch in bug 1308876 (which causes a child whose parent is dirty to pick up the dirty bit from the parent only the first reflow of the child if the parent reflows the child multiple times). A simplified testcase for that failure is https://bugzilla.mozilla.org/attachment.cgi?id=8849771 . The failure was caused by an error in height calculation of the first <x> in the test. The div that is the parent of that x has a definite height (presumably due to rules in grid), and the x has a specified height. The div gets three reflows: two measuring reflows (from MinContentContribution and then from MaxContentContribution) and then a final reflow from nsGridContainerFrame::ReflowInFlowChild. Prior to the primary patch in this bug, the div was marked dirty on all three reflows, but with it it is marked dirty only on the first. This means that, without the block-resize flag, the div optimizes away the reflow of its children, since ShouldReflowAllKids returns false because IsBResize() is false, even though NS_FRAME_CONTAINS_RELATIVE_BSIZE is correctly set. In order to fix this, we need to make sure the BResize flag on the reflow state in at least some cases (see the comments in the patch for when, and for how the cases could be optimized in the future). Note that: * when the dirty bit is set on the grid container, the new behavior (with the combination of the patches) is strictly more efficient than the old, since we will sometimes do non-dirty reflows on the grid items (with the b-resize flag) * when the dirty bit is *not* set on the grid container, the new behavior is less efficient than the old, since we will set the b-resize flag when we did not do so before. However, this slowdown fixes existing bugs such as the one in the reftest. Given that I was able to construct a reftest that triggers the failure without the changes from bug 1308876, I've moved this to a separate bug. Without the patch, grid-measuring-reflow-resize-dynamic-001.html fails, but grid-measuring-reflow-resize-static-001.html passes. With the patch both tests pass. (And without the patch, doing a text zoom on the dynamic test fixes the layout error.) MozReview-Commit-ID: JQOdVTQIkU0
e8ea4c9c0102212a4401aa1a1ffa46a63dac16d3: Bug 1345873 - Part 1: Make flex-item sorting code treat placeholders as having the default value of 'order' / 'box-ordinal-group'. r=mats, a=lizzard
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 06 Apr 2017 14:48:00 -0400 - rev 375792
Push 11028 by ryanvm@gmail.com at Thu, 06 Apr 2017 22:49:27 +0000
Bug 1345873 - Part 1: Make flex-item sorting code treat placeholders as having the default value of 'order' / 'box-ordinal-group'. r=mats, a=lizzard This should allow their flex-item siblings to reorder themselves as-needed for honoring their own 'order' values, without unnecessarily reordering the placeholders. MozReview-Commit-ID: aCBQER5r2G
858b0ab812dfd88fa701a3e4f307f56bb1246e80: Bug 1343552 - Part 2: Record attempted misuse of gfxSkipCharsIterator via a gfxCriticalError. r=mats, a=lizzard
Jonathan Kew <jkew@mozilla.com> - Mon, 06 Mar 2017 17:31:01 +0000 - rev 375162
Push 10884 by ryanvm@gmail.com at Fri, 10 Mar 2017 22:28:07 +0000
Bug 1343552 - Part 2: Record attempted misuse of gfxSkipCharsIterator via a gfxCriticalError. r=mats, a=lizzard MozReview-Commit-ID: CayLp1dGSnq
18f657821f932c5023ece1f2baa14336c7b811d5: Bug 1343665 part 2: Regenerate devtools' generated properties db, now that layout.css.object-fit-and-position.enabled is removed. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 02 Mar 2017 10:04:11 -0800 - rev 374752
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1343665 part 2: Regenerate devtools' generated properties db, now that layout.css.object-fit-and-position.enabled is removed. r=mats MozReview-Commit-ID: 19F7rkKzmIN
0c9b2a4ecc28b5777cce1ac5de10ca94b7ea0f7b: Bug 1343665 part 1: Remove all mentions of about:config pref "layout.css.object-fit-and-position.enabled" from source files. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 02 Mar 2017 10:04:00 -0800 - rev 374751
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1343665 part 1: Remove all mentions of about:config pref "layout.css.object-fit-and-position.enabled" from source files. r=mats MozReview-Commit-ID: 1mHzzU7YVoL
9ff75c152be3b18e5f8750b7bb241f11ba3d52e4: Bug 1340309 part 2: Adjust some abspos align-self/justify-self tests to better exercise "auto" value. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 24 Feb 2017 08:38:38 -0800 - rev 374067
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340309 part 2: Adjust some abspos align-self/justify-self tests to better exercise "auto" value. r=mats MozReview-Commit-ID: Glrv2aYmgbX
06623679bd90b5edadd91022bf83589eb55b2d9e: Bug 1340309 part 1: Resolve "align-self:auto"/"justify-self:auto" to flex/grid parent's *-items value, when resolving static pos of abspos children. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 24 Feb 2017 08:38:31 -0800 - rev 374066
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340309 part 1: Resolve "align-self:auto"/"justify-self:auto" to flex/grid parent's *-items value, when resolving static pos of abspos children. r=mats MozReview-Commit-ID: 6fSmo1WGqow
6af6e3b0247f89ab98d04f16f294c6b21b9730cc: Bug 1340451. Don't use weak frames for reflow callbacks in nsMenuFrame. r=mats
Timothy Nikkel <tnikkel@gmail.com> - Sat, 18 Feb 2017 02:13:40 -0600 - rev 372825
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340451. Don't use weak frames for reflow callbacks in nsMenuFrame. r=mats Weak frames are stored in a linked list, so are not fast. Hence they are not meant to be used when there can be a lot of them active at the same time. When constructing large selects with lots of options we create one for every option. There's no need to use a weak frame for a reflow callback as we can just cancel the reflow callback in the Destroy function.
32242abfde5d17bcc1c7c82df0d395c1cc64f955: Bug 1339891 part 1. Make the invariants around nsIPresShell::FlushPendingNotifications clearer. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 17 Feb 2017 13:38:44 -0500 - rev 372799
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1339891 part 1. Make the invariants around nsIPresShell::FlushPendingNotifications clearer. r=mats
eb2a37ed9b766b3bb5e22f6b09fa220025b2f799: Bug 1338678: Only disallow lazy frame construction for direct children of display: contents elements. r=mats,bz
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 11 Feb 2017 17:13:03 +0100 - rev 372098
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1338678: Only disallow lazy frame construction for direct children of display: contents elements. r=mats,bz MozReview-Commit-ID: 3lQ3LIVMZgt Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
4c483e15fb91e4aaa6fb99e548d48516de194a78: Bug 1339239 - "Intermittent http://10.0.2.2:8854/tests/layout/reftests/bugs/84400-1.html == http://10.0.2.2:8854/tests/layout/reftests/bugs/84400-1-ref.html | image comparison, max difference: 4, number of differing pixels: 1". r=mats
Olli Pettay <bugs> - Tue, 14 Feb 2017 10:28:00 +0800 - rev 372095
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1339239 - "Intermittent http://10.0.2.2:8854/tests/layout/reftests/bugs/84400-1.html == http://10.0.2.2:8854/tests/layout/reftests/bugs/84400-1-ref.html | image comparison, max difference: 4, number of differing pixels: 1". r=mats
ef9db85bfdd7268cdb82fa35b61710928e73ff3d: Bug 1337466: Adjust click position in test_bug549170.html to more reliably target editable area of textfield, rather than its border. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 09 Feb 2017 22:14:24 -0800 - rev 371255
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1337466: Adjust click position in test_bug549170.html to more reliably target editable area of textfield, rather than its border. r=mats MozReview-Commit-ID: 4lHdTcCToOU
b77a472a5ce62f11c5f102a3a28b4169c3921f0c: Bug 1335885: Adjust click position in test_bug1301290.html to more reliably target resizer. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 08 Feb 2017 11:41:13 -0800 - rev 370559
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1335885: Adjust click position in test_bug1301290.html to more reliably target resizer. r=mats The resizer in question is smaller in Ubuntu 16.04 than on other platforms (due to smaller scrollbars in the default OS theme), so we need to target our click closer to the corner of the element in order to hit the resizer. MozReview-Commit-ID: Cz4MIKsOaGS
05b672699c45a40782a80c5982ab65e7c6be08c3: Bug 1259348 part 2: Simplify logic in CSSParserImpl::LookupKeywordPrefixAware. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 03 Feb 2017 14:56:15 -0800 - rev 369827
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1259348 part 2: Simplify logic in CSSParserImpl::LookupKeywordPrefixAware. r=mats MozReview-Commit-ID: D9WoQ9vXTGJ
171262d16e8019691233df6a64b329471ae42764: Bug 1259348 part 1: Remove CSSUnprefixingService.js and associated code (since it's been supplanted by built-in webkit-prefixed-CSS support). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 03 Feb 2017 14:56:13 -0800 - rev 369826
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1259348 part 1: Remove CSSUnprefixingService.js and associated code (since it's been supplanted by built-in webkit-prefixed-CSS support). r=mats MozReview-Commit-ID: CXCJJWhHc8G
2ea70ba06fa9057a4938345e8bc0cce17ecf83d1: Bug 795418 - test. r=mats
Jorg K <jorgk@jorgk.com> - Fri, 27 Jan 2017 00:24:00 +0100 - rev 360368
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 795418 - test. r=mats
b30c5aed91fb9281d04b65a0ce55ecc0db1073fd: Bug 1328053 - Correct thumb position when shift-click scrolling r=mats
Kearwood Gilbert <kgilbert@mozilla.com> - Wed, 25 Jan 2017 14:45:23 -0800 - rev 360146
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1328053 - Correct thumb position when shift-click scrolling r=mats During the refactoring of nsSliderFrame::SetCurrentPositionInternal in Bug 957445, one of the two calls to nsSliderFrame::UpdateAttribute was missed. This resulted in the position, identified with nsGkAtoms::curpos, not being updated immediately after the call to nsSliderFrame::SetCurrentThumbPosition MozReview-Commit-ID: 6gedouG4OFX
1dacb9dc5ced570008d8abeb16a07e0a954162c7: Bug 1333366 Part 2 - Update legacy NS_SIDE usage and document. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Tue, 24 Jan 2017 18:41:56 +0800 - rev 360076
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1333366 Part 2 - Update legacy NS_SIDE usage and document. r=mats Delete the "or 0 for no movement in that direction" from the CanAdjustEdges document in nsMenuPopupFrame.h because the only caller in nsResizerFrame.cpp never passes 0 to it. MozReview-Commit-ID: 3A5A8O4MDn1
4925b25106ea1f6a52c6d3edcbd92a0e31d29817: Bug 1333366 Part 1 - Update document related to Corner and HalfCorner. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Tue, 24 Jan 2017 18:37:05 +0800 - rev 360075
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1333366 Part 1 - Update document related to Corner and HalfCorner. r=mats MozReview-Commit-ID: 4wnjQOvploH
deb6668fecd71e2f8e5d84e9b591586b6f1858f5: Bug 1340309 - Part 2: Adjust some abspos align-self/justify-self tests to better exercise "auto" value. r=mats, a=jcristau
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 24 Feb 2017 08:38:38 -0800 - rev 359508
Push 10821 by ryanvm@gmail.com at Tue, 28 Feb 2017 18:06:57 +0000
Bug 1340309 - Part 2: Adjust some abspos align-self/justify-self tests to better exercise "auto" value. r=mats, a=jcristau MozReview-Commit-ID: Glrv2aYmgbX
e4f35a45184ce760f88c9d6572fb9b9542c4bcfb: Bug 1340309 - Part 1: Resolve "align-self:auto"/"justify-self:auto" to flex/grid parent's *-items value, when resolving static pos of abspos children. r=mats, a=jcristau
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 24 Feb 2017 08:38:31 -0800 - rev 359507
Push 10821 by ryanvm@gmail.com at Tue, 28 Feb 2017 18:06:57 +0000
Bug 1340309 - Part 1: Resolve "align-self:auto"/"justify-self:auto" to flex/grid parent's *-items value, when resolving static pos of abspos children. r=mats, a=jcristau MozReview-Commit-ID: 6fSmo1WGqow
cfff8883bbedcc72a58c45321222ec95d49f2a88: Bug 795418 - Test. r=mats, a=ritu
Jorg K <jorgk@jorgk.com> - Fri, 27 Jan 2017 00:24:00 +0100 - rev 358840
Push 10663 by ryanvm@gmail.com at Wed, 01 Feb 2017 23:07:38 +0000
Bug 795418 - Test. r=mats, a=ritu
c76aa324c7c2b57ce42a8b26c48778782b41be76: Bug 1328053 - Correct thumb position when shift-click scrolling r=mats a=jcristau
Kearwood Gilbert <kgilbert@mozilla.com> - Wed, 25 Jan 2017 14:45:23 -0800 - rev 358807
Push 10659 by cbook@mozilla.com at Wed, 01 Feb 2017 14:58:22 +0000
Bug 1328053 - Correct thumb position when shift-click scrolling r=mats a=jcristau During the refactoring of nsSliderFrame::SetCurrentPositionInternal in Bug 957445, one of the two calls to nsSliderFrame::UpdateAttribute was missed. This resulted in the position, identified with nsGkAtoms::curpos, not being updated immediately after the call to nsSliderFrame::SetCurrentThumbPosition MozReview-Commit-ID: 6gedouG4OFX
8f927b0973bc2c90fdb65ea4574fff24525484db: Bug 1330225. Remove unused function nsViewManager::InsertChild. r=mats
Timothy Nikkel <tnikkel@gmail.com> - Thu, 12 Jan 2017 00:59:11 -0600 - rev 357156
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1330225. Remove unused function nsViewManager::InsertChild. r=mats
d6bf8872b3c312843ea73308bb646a34f1020de2: Bug 1320014 Part 15 - Replace RectCorner with Corner. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Thu, 05 Jan 2017 17:07:07 +0800 - rev 356278
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 15 - Replace RectCorner with Corner. r=mats Rewrite RectCornerRadii::operator==() and RectCornerRadii::AreRadiiSame() by explicitly expand all the comparisons, and rewrite other explicit for-loops with NS_FOR_CSS_FULL_CORNERS. MozReview-Commit-ID: BLBJHla8kyk
af9e85ac33daf4e1000f251d3755d9344ecd3a8b: Bug 1320014 Part 14 - Convert NS_SIDE_TO_HALF_CORNER to a constexpr function. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Thu, 05 Jan 2017 16:23:16 +0800 - rev 356277
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 14 - Convert NS_SIDE_TO_HALF_CORNER to a constexpr function. r=mats MozReview-Commit-ID: 4MQu8omCdcg
3e3ca0d6683a76cec79cbcff3e1b54d07dfe52aa: Bug 1320014 Part 13 - Convert NS_SIDE_TO_FULL_CORNER to a constexpr function. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Thu, 05 Jan 2017 16:13:34 +0800 - rev 356276
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 13 - Convert NS_SIDE_TO_FULL_CORNER to a constexpr function. r=mats MozReview-Commit-ID: 4r4jEN2LklH
1c3a30388a86e7684bce427722fd03819de30646: Bug 1320014 Part 12 - Convert NS_SIDE_IS_VERTICAL to a constexpr function. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Thu, 05 Jan 2017 16:07:02 +0800 - rev 356275
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 12 - Convert NS_SIDE_IS_VERTICAL to a constexpr function. r=mats MozReview-Commit-ID: GFdigJKppuR
919cd7ac0dc38dc9b43c38308eea6c70c137af1d: Bug 1320014 Part 11 - Convert NS_FULL_TO_HALF_CORNER to a constexpr function. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Thu, 05 Jan 2017 14:59:17 +0800 - rev 356274
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 11 - Convert NS_FULL_TO_HALF_CORNER to a constexpr function. r=mats Because the new function checks types, we need to change the fullCorner type in nsComputedDOMStyle::GetEllipseRadii() and StyleAnimationValue::ExtractComputedValue() from uint8_t to |Corner| to fix build error. MozReview-Commit-ID: 5NuFE3yA2QD
83333bd36d7645370995ab712bfce30f22f5260c: Bug 1320014 Part 10 - Convert NS_HALF_TO_FULL_CORNER to a constexpr function. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Thu, 05 Jan 2017 14:39:58 +0800 - rev 356273
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 10 - Convert NS_HALF_TO_FULL_CORNER to a constexpr function. r=mats MozReview-Commit-ID: 1PECc7hm249
4dc7949d79de882f79c2513f9b75cb6ac1cf7e4d: Bug 1320014 Part 9 - Convert NS_HALF_CORNER_IS_X to a constexpr function. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Thu, 05 Jan 2017 14:30:14 +0800 - rev 356272
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 9 - Convert NS_HALF_CORNER_IS_X to a constexpr function. r=mats MozReview-Commit-ID: 3d2opSIjAUc
7b303c2f6979a481bcfa6b714c10e8ab0c5c51b8: Bug 1320014 Part 8 - Move NS_FOR_CSS_HALF_CORNERS to Types.h and rewrite it. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Thu, 05 Jan 2017 12:03:23 +0800 - rev 356271
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 8 - Move NS_FOR_CSS_HALF_CORNERS to Types.h and rewrite it. r=mats MozReview-Commit-ID: 5UkZUSe5stP
cf81b45536f34912377bfa743d85b8346b91b079: Bug 1320014 Part 7 - Convert half corner indices #define to an enum. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Thu, 05 Jan 2017 11:31:38 +0800 - rev 356270
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 7 - Convert half corner indices #define to an enum. r=mats MozReview-Commit-ID: 8lNtjV14WTN
b1b0ea86903836d753e0ca5a57840deb9efbcab9: Bug 1320014 Part 6 - Remove #define NS_CORNER_[TOP_LEFT/TOP_RIGHT/BOTTOM_RIGHT/BOTTOM_LEFT] r=mats
Ting-Yu Lin <tlin@mozilla.com> - Wed, 04 Jan 2017 18:15:30 +0800 - rev 356269
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 6 - Remove #define NS_CORNER_[TOP_LEFT/TOP_RIGHT/BOTTOM_RIGHT/BOTTOM_LEFT] r=mats MozReview-Commit-ID: ERAwdxKZPf7
6b29fba60795b7b85c004f9e60a4f386910564db: Bug 1320014 Part 5 - Remove NS_FOR_CSS_CORNERS. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Wed, 04 Jan 2017 17:52:43 +0800 - rev 356268
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 5 - Remove NS_FOR_CSS_CORNERS. r=mats Remove NS_FOR_CSS_FULL_CORNERS implementation, and rename NS_FOR_CSS_CORNERS to NS_FOR_CSS_FULL_CORNERS. MozReview-Commit-ID: 2kmPUZDz3bj
2177bf76842a1cefc9220ed0b1022d1fcf08b855: Bug 1320014 Part 4 - Remove eNumCorners and rewrite NS_FOR_CSS_CORNERS. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Wed, 04 Jan 2017 17:41:49 +0800 - rev 356267
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 4 - Remove eNumCorners and rewrite NS_FOR_CSS_CORNERS. r=mats Also, change Corner's operator++ from postfix to prefix version. MozReview-Commit-ID: CpBXOZmQtJ9
9a201f9c23741efed91fb195a49f71a748e06e9e: Bug 1320014 Part 3 - Move Corner from namespace mozilla::css into mozilla. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Wed, 04 Jan 2017 17:18:49 +0800 - rev 356266
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 3 - Move Corner from namespace mozilla::css into mozilla. r=mats For those cpp files, it's sufficient to use Corner to refer to mozilla::Corner. MozReview-Commit-ID: JmDEJ3gGm8K
0682966014dddf6ada27a79c2c0382e406ac685a: Bug 1320014 Part 2 - Rename Corner to LogicalCorner, and move it to nsStyleCoord.h. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Wed, 04 Jan 2017 16:52:12 +0800 - rev 356265
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 2 - Rename Corner to LogicalCorner, and move it to nsStyleCoord.h. r=mats To avoid confusion with the mozilla::css::corner, rename ::Corner to mozilla::LogicalCorner, and move it to nsStyleCoord.h. Also, append LogicalCorner prefix to all the enum values to match the coding style. It also fixed the build error preemptively in a later patch that removing ::css namespace from mozilla::css::corner. MozReview-Commit-ID: BbRYFuT3v4W
2cb81f3fc29e7a0186a59d48d6de06867482d790: Bug 1320014 Part 1 - Move Corner's definition and NS_FOR_CSS_CORNERS to gfx/2d/Types.h. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Wed, 04 Jan 2017 16:19:20 +0800 - rev 356264
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320014 Part 1 - Move Corner's definition and NS_FOR_CSS_CORNERS to gfx/2d/Types.h. r=mats The only change is that NS_PRECONDITION is replaced by MOZ_ASSERT to prevent Types.h depends on nsDebug.h. MozReview-Commit-ID: FI6LGOedKQ9
b7289e864f436802dc8b44b41979727058341ad1: Bug 1320484 part 3: Add reftest for simple positioning of abspos child inside of a -webkit-box container. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 04 Jan 2017 20:43:04 -0800 - rev 356257
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320484 part 3: Add reftest for simple positioning of abspos child inside of a -webkit-box container. r=mats MozReview-Commit-ID: 4SIys1zdkvy
f42dc6b82a4dd21f2decadcec028e5b85e70eeec: Bug 1320484 part 2: Wrap abspos placeholders in anonymous flex items, in flex containers that are really emulating legacy -webkit-box containers. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 04 Jan 2017 20:31:17 -0800 - rev 356256
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320484 part 2: Wrap abspos placeholders in anonymous flex items, in flex containers that are really emulating legacy -webkit-box containers. r=mats This changeset is intended to revert the logic from "Bug 1269045 part 3" [1], *specifically* for legacy "-webkit-box"/"-webkit-inline-box" flex containers. [1] https://hg.mozilla.org/mozilla-central/rev/707b2ab5879d MozReview-Commit-ID: vc4TuAoLai
cfea3f3068f0096b717e9664eb9033d2b49b4e74: Bug 1320484 part 1: Improve documentation for debug-only function FrameWantsToBeInAnonymousItem(), & change its arg from nsIAtom* to nsIFrame*. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 04 Jan 2017 20:29:19 -0800 - rev 356255
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320484 part 1: Improve documentation for debug-only function FrameWantsToBeInAnonymousItem(), & change its arg from nsIAtom* to nsIFrame*. r=mats This patch doesn't affect behavior at all -- it just refactors the sanity-checking function "FrameWantsToBeInAnonymousItem()", so that the next patch in this series can give it a new special case that checks a state bit on the container frame. This patch renames "parent" to "container" in this function's variable-names, for clarity, because when this function returns true, the flex/grid container is actually NOT expected to be the parent of aFrame. Rather, it's expected to be the grandparent, and the anonymous flex/grid item would be the parent. So, "aContainerFrame"/"containerType" is a bit more accurate (representing the flex/grid container for aFrame). Also worth mentioning: this patch makes FrameWantsToBeInAnonymousItem() perform its own local GetType() call, instead of accepting an already-queried GetType() result from the caller (as it previously did). Technically this could cause a slight perf hit, but it doesn't really matter since this is in "#ifdef DEBUG" sanity-checking code anyway. We could keep the nsIAtom* as an additional arg to avoid this new call, but it seems better to fall on the side of simplicity & just look up GetType() independently, rather than complicating the function signature with an extra arg. MozReview-Commit-ID: 4oJFkQMuH9c
e96e021a5aca0abb44545e36e379977ee38518b8: Bug 1328202. Remove unused variable mGfxScrollFrame in nsCSSFrameConstructor. r=mats
Timothy Nikkel <tnikkel@gmail.com> - Mon, 02 Jan 2017 22:07:51 -0600 - rev 355806
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1328202. Remove unused variable mGfxScrollFrame in nsCSSFrameConstructor. r=mats
cf9d3767e4e8c0a2bd34af0f6f84c85c2df22d35: Bug 1323606. Implement the pref layout.show_previous_page for e10s. r=gw280 r=mats
Timothy Nikkel <tnikkel@gmail.com> - Mon, 19 Dec 2016 17:34:00 -0600 - rev 354566
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1323606. Implement the pref layout.show_previous_page for e10s. r=gw280 r=mats The existing implementation only works for non-remote subdocuments. This essentially makes the changes from bug 1157941 conditional on this pref.
07f8e09df41150dcfd7ae18b3ce45703a30b7531: Bug 1324072 - Additional reftest for mtable alignment with negative rownumber. r=mats
Jonathan Kew <jkew@mozilla.com> - Mon, 19 Dec 2016 12:46:23 +0000 - rev 354525
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1324072 - Additional reftest for mtable alignment with negative rownumber. r=mats
70a0740cbd8129b84aabb426a50c3cf3240f8266: Bug 1319318: When resolving a video/audio frame's shrinkwrapped BSize from controls, check whether controls are orthogonal when reading its size. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Dec 2016 09:20:25 -1000 - rev 353597
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1319318: When resolving a video/audio frame's shrinkwrapped BSize from controls, check whether controls are orthogonal when reading its size. r=mats MozReview-Commit-ID: 9kH7rLF66zd
9d41238dabf42896e32ab1df01cb477f25e207f8: Bug 1319318: When resolving a video/audio frame's shrinkwrapped BSize from controls, check whether controls are orthogonal when reading its size. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Dec 2016 09:20:25 -1000 - rev 353404
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1319318: When resolving a video/audio frame's shrinkwrapped BSize from controls, check whether controls are orthogonal when reading its size. r=mats MozReview-Commit-ID: 9kH7rLF66zd
5144592dd9180a21472159e4d813a7f61c90484e: Bug 1319668 - Check for null context before trying to draw canvas text. r=mats
Jonathan Kew <jkew@mozilla.com> - Sat, 03 Dec 2016 14:49:46 +0000 - rev 353201
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1319668 - Check for null context before trying to draw canvas text. r=mats
eeb34d6bc82cbc44e9dec0005faa6dedb3d1b318: Bug 1321698 part 3: Fold nsFlexContainerFrame's old IsLegacyBox() function into its only remaining caller, nsFlexContainerFrame::Init(). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 02 Dec 2016 10:44:07 -0800 - rev 353133
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1321698 part 3: Fold nsFlexContainerFrame's old IsLegacyBox() function into its only remaining caller, nsFlexContainerFrame::Init(). r=mats This patch is to prevent any new callers of this API, since we can now rely on the new frame state bit (NS_STATE_FLEX_IS_LEGACY_WEBKIT_BOX) to test for this. MozReview-Commit-ID: BONaqPC30Cn
e38ccf5210624c1a4906f893fc2f7932d4e76a5e: Bug 1321698 part 2: Use the new frame state bit to check for -webkit-box containers. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 02 Dec 2016 10:32:31 -0800 - rev 353132
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1321698 part 2: Use the new frame state bit to check for -webkit-box containers. r=mats Note that at the callsites in nsCSSFrameConstructor.cpp, we have to also check the frame type (since the frame state bit is in a range of bits whose meaning differs depending on frame type). The first change in this patch is the addition of a convenience fucntion that checks both the frame type as well as the frame state bit. MozReview-Commit-ID: DEOThTX5NAO