searching for reviewer(masayuki)
bb23eb792eba53ae4464ebff9dc79f3572208836: Bug 1350908 - Upgrade Hunspell to version 1.6.1. r=masayuki, a=gchang
Ryan VanderMeulen <ryanvm@gmail.com> - Thu, 30 Mar 2017 22:30:35 -0400 - rev 375720
Push 11015 by ryanvm@gmail.com at Tue, 04 Apr 2017 22:25:39 +0000
Bug 1350908 - Upgrade Hunspell to version 1.6.1. r=masayuki, a=gchang
a2362db99b02e1ceaca575770d62e4d08113aaf3: Bug 1348851 - Part 2: Add crash test. r=masayuki, a=test-only
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 21 Mar 2017 14:36:52 +0900 - rev 375615
Push 10981 by ryanvm@gmail.com at Thu, 30 Mar 2017 18:15:06 +0000
Bug 1348851 - Part 2: Add crash test. r=masayuki, a=test-only MozReview-Commit-ID: 9QPwtwYfNa7
c1bdfc489807fd17f4d13a1d40ca0d39b6a71112: Bug 1348851 - Part 1: Use new block when better selection isn't found. r=masayuki, a=lizzard
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 24 Mar 2017 10:30:21 +0900 - rev 375614
Push 10981 by ryanvm@gmail.com at Thu, 30 Mar 2017 18:15:06 +0000
Bug 1348851 - Part 1: Use new block when better selection isn't found. r=masayuki, a=lizzard This is a kind of regression of bug 1088054 part 6. If new block doesn't have child node, GetLastEditableChild will return null after landing bug 1088054. So, we should use new block when GetLastEditableChild returns null. MozReview-Commit-ID: Gzt1Xp3Sl47
83f643b4880a603ce22543a4994a1e6476b6286d: Bug 1350683 - Ensure the transaction processing. r=masayuki, a=abillings
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 29 Mar 2017 13:23:31 -0400 - rev 375576
Push 10975 by ryanvm@gmail.com at Wed, 29 Mar 2017 22:31:53 +0000
Bug 1350683 - Ensure the transaction processing. r=masayuki, a=abillings
35d42d438c86a85eb158caf08407817cfab4a30a: Bug 1350772 - Part 2: Add test. r=masayuki, a=gchang
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 27 Mar 2017 14:41:21 +0900 - rev 375566
Push 10971 by ryanvm@gmail.com at Wed, 29 Mar 2017 14:49:26 +0000
Bug 1350772 - Part 2: Add test. r=masayuki, a=gchang MozReview-Commit-ID: 9jQyvpXFl1E
8a10927531c52f98ced4e8ef67fe776e600c9bf7: Bug 1350772 - Part 1: Check whether node can be splited. r=masayuki, a=gchang
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 28 Mar 2017 14:56:03 +0900 - rev 375565
Push 10971 by ryanvm@gmail.com at Wed, 29 Mar 2017 14:49:26 +0000
Bug 1350772 - Part 1: Check whether node can be splited. r=masayuki, a=gchang At first, HTMLEditor::GetActiveEditingHost might return null in this situation, we should check whether nullptr is returned. At second, SplitNodeDeep returns error since curent is design mode and selection node has no parent. So we should check error. MozReview-Commit-ID: 2YlWXPNtf80
81d219527dbe7143c71cbce2fc3c1ecca41a0f5d: Bug 1344116 - Clean up HTMLEditRules::RemoveAlignment. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 03 Mar 2017 13:13:21 +0900 - rev 374735
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1344116 - Clean up HTMLEditRules::RemoveAlignment. r=masayuki Before I will fix some justify* command's bug, I would like to clean up HTMLEditRules::RemoveAlignment to get rid of nsIDOM* into this method. MozReview-Commit-ID: 4UATycS5iBl
e980c683af8cb856dbb7409373d2cef7972fb4ca: Bug 809020 - Use a shorter "conservative breaking" range at word edges when dealing with letters rather than punctuation etc., and adjust existing tests accordingly. r=masayuki
Jonathan Kew <jkew@mozilla.com> - Wed, 01 Mar 2017 22:47:56 +0000 - rev 374563
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 809020 - Use a shorter "conservative breaking" range at word edges when dealing with letters rather than punctuation etc., and adjust existing tests accordingly. r=masayuki
283f43e8790b268c6f5316b007fddb6658b6dfba: Bug 809020 - Reftest for breaking near word beginning/end (the "conservative" breaking range). r=masayuki
Jonathan Kew <jkew@mozilla.com> - Wed, 01 Mar 2017 22:47:56 +0000 - rev 374562
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 809020 - Reftest for breaking near word beginning/end (the "conservative" breaking range). r=masayuki
4048d3a531078eb13aed019c5cc5f68da49967c5: Bug 1137567 - Make nsWindow for Android use TextEventDispatcher; r=esawin r=rbarker r=masayuki r=snorp
Jim Chen <nchen@mozilla.com> - Wed, 01 Mar 2017 15:29:30 -0500 - rev 374548
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1137567 - Make nsWindow for Android use TextEventDispatcher; r=esawin r=rbarker r=masayuki r=snorp Bug 1137567 - 1. Allow dispatching key events during composition; r=esawin We potentially dispatch key events during composition to provide compatibility for pages that only listen to key events. Bug 1137567 - 2. Allow keyboard events in DispatchInputEvent when not on APZ thread; r=rbarker We use nsIWidget::DispatchInputEvent to dispatch our keyboard events on the Gecko thread, which on Android is not the APZ controller thread. We should allow these events to pass instead of crashing. Bug 1137567 - 3. Add GeckoEditableSupport class to support TextEventDispatcher; r=masayuki Add a separate GeckoEditableSupport class, which implements TextEventDispatcherListener and uses TextEventDispatcher for IME operations. The new class is entirely separate from nsWindow to allow it to be independently used in content processes as well. Most of the code is copied from nsWindow::GeckoViewSupport, and adapted to use TextEventDispatcher. Bug 1137567 - 4. Make nsWindow::WindowPtr available for outside classes; r=snorp Make nsWindow::WindowPtr available not just for classes inside nsWindow but for outside classes as well. Also, add support for RefPtr native objects to nsWindow::NativePtr. Bug 1137567 - 5. Use GeckoEditableSupport in nsWindow; r=esawin Use the new GeckoEditableSupport class in nsWindow to replace the previous code in nsWindow::GeckoViewSupport. GeckoEditable native methods now go to GeckoEditableSupport instead of GeckoViewSupport. Several native methods in GeckoEditable are changed from dispatchTo="proxy" to dispatchTo="gecko", because we no longer need the special nsWindow::WindowEvent wrapper for our native calls. Bug 1137567 - 6. Use pushPrefEnv in test_assign_event_data.html; r=masayuki setAndObserveCompositionPref in test_assign_event_data.html does not invoke the callback if the pref is already set. This patch changes it to use SpecialPowers.pushPrefEnv so the callback is always invoked.
13bd2c36c19425fb40e73db798db68c3a806771f: Bug 1137567 - Make nsWindow for Android use TextEventDispatcher; r=esawin r=rbarker r=masayuki r=snorp
Jim Chen <nchen@mozilla.com> - Fri, 24 Feb 2017 16:28:18 -0500 - rev 373922
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1137567 - Make nsWindow for Android use TextEventDispatcher; r=esawin r=rbarker r=masayuki r=snorp Bug 1137567 - 1. Allow dispatching key events during composition; r=esawin We potentially dispatch key events during composition to provide compatibility for pages that only listen to key events. Bug 1137567 - 2. Allow keyboard events in DispatchInputEvent when not on APZ thread; r=rbarker We use nsIWidget::DispatchInputEvent to dispatch our keyboard events on the Gecko thread, which on Android is not the APZ controller thread. We should allow these events to pass instead of crashing. Bug 1137567 - 3. Add GeckoEditableSupport class to support TextEventDispatcher; r=masayuki Add a separate GeckoEditableSupport class, which implements TextEventDispatcherListener and uses TextEventDispatcher for IME operations. The new class is entirely separate from nsWindow to allow it to be independently used in content processes as well. Most of the code is copied from nsWindow::GeckoViewSupport, and adapted to use TextEventDispatcher. Bug 1137567 - 4. Make nsWindow::WindowPtr available for outside classes; r=snorp Make nsWindow::WindowPtr available not just for classes inside nsWindow but for outside classes as well. Also, add support for RefPtr native objects to nsWindow::NativePtr. Bug 1137567 - 5. Use GeckoEditableSupport in nsWindow; r=esawin Use the new GeckoEditableSupport class in nsWindow to replace the previous code in nsWindow::GeckoViewSupport. GeckoEditable native methods now go to GeckoEditableSupport instead of GeckoViewSupport. Several native methods in GeckoEditable are changed from dispatchTo="proxy" to dispatchTo="gecko", because we no longer need the special nsWindow::WindowEvent wrapper for our native calls.
e05399182c38b45f45225123a79abd11e701c6bd: Bug 833889 - Part 2. Update test result of web platform tests. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 22 Feb 2017 14:52:25 +0900 - rev 373497
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 833889 - Part 2. Update test result of web platform tests. r=masayuki Update web platfrom tests's result since some tests contain this situation. MozReview-Commit-ID: vm33zObiOW
8b7597b2fffa3d67426dac03a67a4f67f767b66a: Bug 833889 - Part 1. Remove CSS properties even if it is default value. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 23 Feb 2017 17:10:27 +0900 - rev 373496
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 833889 - Part 1. Remove CSS properties even if it is default value. r=masayuki When selected nodes are <span style="font-weight: normal;">A</span>, toggle bold inserts new span element into parent node like <span style="font-weight: bold;"><span style="font-weight: normal;">A</span><span>. So bold isn't applied correctly. IsCSSEquivalentToHTMLInlineStyleSet might return false even if style is applied. Because it returns true that style isn't default value. Since "font-weight: normal" is default property, it isn't removed. So when style is already applied even if it is default value, we should remove it. MozReview-Commit-ID: LgImkHRp9Ff
05efc3638dd900fb7074c7d7f0deacbb9c76a77d: Bug 1331357 - Expand number of allowed assertions during a reftest, because in QR builds we sometimes get two. r=masayuki
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 15 Feb 2017 11:05:35 -0500 - rev 372313
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1331357 - Expand number of allowed assertions during a reftest, because in QR builds we sometimes get two. r=masayuki MozReview-Commit-ID: LvHxTtdLDjD
334642cf0c00e7d2af2193537e5bfd8830db3487: Bug 1270235 - Part 2. Add test. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 13 Feb 2017 15:46:15 +0900 - rev 371895
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1270235 - Part 2. Add test. r=masayuki MozReview-Commit-ID: BV7Dc6YiNM6
4d5fe833df04a59af8d97734c5ac99ad8f2846a9: Bug 1270235 - Part 1. Check parent node is null in RemoveEmptyNodes. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 13 Feb 2017 15:46:09 +0900 - rev 371894
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1270235 - Part 1. Check parent node is null in RemoveEmptyNodes. r=masayuki RemoveEmptyNodes doesn't check whether parent node is null. So we shouldn't add null to skip list. Also, although this crash depends on clang, if debug build, it will hit the assertion on all compiler. MozReview-Commit-ID: GgiczVExlIn
7c0b9537f2db4917120eda3d7c6c5d8cbb7daadb: Bug 1302648 part 1 - Add animationcancel event handler. r=masayuki
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 10 Feb 2017 12:32:43 +0900 - rev 371670
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1302648 part 1 - Add animationcancel event handler. r=masayuki The 'animationcancel' spec is as follow: https://drafts.csswg.org/css-animations-1/#eventdef-animationevent-animationcancel MozReview-Commit-ID: Z2BUwFtMwk
5b25ddd519bb3619f098667779aad5705fd80f03: Bug 1337698 - Part 3. TypeInState should use UniquePtr. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 08 Feb 2017 18:14:53 +0900 - rev 370646
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1337698 - Part 3. TypeInState should use UniquePtr. r=masayuki MozReview-Commit-ID: K9UY83Nx1v3
4748eeef46250b4c89e78d774a6d060ef2e1e144: Bug 1337698 - Part 2. HTMLEditor should use UniquePtr. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 08 Feb 2017 18:14:24 +0900 - rev 370645
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1337698 - Part 2. HTMLEditor should use UniquePtr. r=masayuki MozReview-Commit-ID: 2O9f0K1RSU4
a13c6b029abec18df1c145a17190fbb516749a79: Bug 1337698 - Part 1. PlaceholderTransaction should use UniquePtr. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 09 Feb 2017 14:26:10 +0900 - rev 370644
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1337698 - Part 1. PlaceholderTransaction should use UniquePtr. r=masayuki MozReview-Commit-ID: 8xqAKRcKCLb
c74aceef62c86f5e7916ba31283bd4433e697bc1: Bug 1337273 - Don't use mTextEditor from HTMLEditRules. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 08 Feb 2017 18:32:32 +0900 - rev 370570
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1337273 - Don't use mTextEditor from HTMLEditRules. r=masayuki HTMLEditRules can access both mTextEditor and mHTMLEditor, but we should use mHTMLEditor only on HTMLEditRules for readability. MozReview-Commit-ID: HfzwAD554XQ
448a2d9d62c2951f6da51cd9ff5aa96ac88c67e8: Bug 1336349 - Merge GetIsDocumentEditable implementation to EditorBase. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 03 Feb 2017 16:22:50 +0900 - rev 369901
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1336349 - Merge GetIsDocumentEditable implementation to EditorBase. r=masayuki GetIsDocumentEditable is implemnted in EditorBase, TextEditor, and HTMLEditor. This is virtual method, we won't use EditorBase::GetIsDocumentEditable. Also, TextEditor::GetIsDocumentEditable and HTMLEditor::GetIsDocumentEditable are same implementation. So we should merge this to EditorBase. MozReview-Commit-ID: 62euqUaYAuY
d02bf33a50fb56f2714fc84c8d52443670d14a96: Bug 1304308: Investigate failure of test_pointerevent_setpointercapture_inactive_button_mouse-manual.html. r=masayuki
Stone Shih <sshih@mozilla.com> - Tue, 24 Jan 2017 13:03:21 +0800 - rev 361351
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1304308: Investigate failure of test_pointerevent_setpointercapture_inactive_button_mouse-manual.html. r=masayuki This test case should be triggered by pointerover and pointerout. Add new test API to fire mouse event at the specified position and refine the synthesized events fired to the test case to trigger it correctly. MozReview-Commit-ID: DkLYrD6MwYc
d6fd02e91afb14f51ee238032533ddb7c3e468e9: Bug 1335997 - Part 2. Don't use virtual method for NotifyDocumentListeners and ScrollSelectionIntoView. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 02 Feb 2017 13:56:57 +0900 - rev 361209
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1335997 - Part 2. Don't use virtual method for NotifyDocumentListeners and ScrollSelectionIntoView. r=masayuki Both methods don't override by TextEditor and HTMLEditor. It is unnecessary to use as virtual method. MozReview-Commit-ID: 6FNO78RauML
abb60930736316e14cae5c46d5e61c96a21a2427: Bug 1335997 - Part 1. Don't use virtual method for GetAndInitDocEncoder and InsertTextFromTransferable. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 02 Feb 2017 13:55:09 +0900 - rev 361208
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1335997 - Part 1. Don't use virtual method for GetAndInitDocEncoder and InsertTextFromTransferable. r=masayuki Both methods don't override by HTMLEditor. It is unnecessary to use as virtual method. MozReview-Commit-ID: CKqb0bxKEOr
1c092a627a52416909908ec3c1937c46ce9f1b0d: Bug 1335672 - Missing virtual keyword into HTMLEditor. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 01 Feb 2017 17:09:54 +0900 - rev 361099
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1335672 - Missing virtual keyword into HTMLEditor. r=masayuki MozReview-Commit-ID: 9C9KMfs5GAF
c87bbf779edaa0d27f8975a80b2001ee99fd56be: Bug 1328023 - Part 2. Add test for undo. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 30 Jan 2017 17:27:26 +0900 - rev 360834
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1328023 - Part 2. Add test for undo. r=masayuki MozReview-Commit-ID: 6ZuluRWrYxb
1e2993a59de6969076587cb8ee753e2984b6f5e9: Bug 1328023 - Part 1. Don't use RangeUpdater except to composition transaction. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 30 Jan 2017 17:25:43 +0900 - rev 360833
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1328023 - Part 1. Don't use RangeUpdater except to composition transaction. r=masayuki Part 3 fix of bug 1310912 is incorrect for not composition transaction. PlaceholderTransation is for saving and restoring current selection for undo. So we shouldn't use range updater to normal transaction. Composition transaction can modify multiple nodes and it merges text node for ime into single text node. So if current selection is into IME text node, it might be failed to restore selection by UndoTransaction. So we need update selection by range updater to work UndoTransaction. Also, CompositionTransaction::UndoTransaction will set selection after committed text. So at finally, selection will set correct position that composition transaction wants. MozReview-Commit-ID: 1NcH32YoKPQ
6c16eca3cc95d8d3e2f03c4e0334c94fde5ebae7: Bug 1332876 - Bail out of HTMLEditRules::BeforeEdit if we have no Selection. r=masayuki
Mats Palmgren <mats@mozilla.com> - Mon, 30 Jan 2017 04:54:37 +0100 - rev 360660
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1332876 - Bail out of HTMLEditRules::BeforeEdit if we have no Selection. r=masayuki
8a3f100c6b30683a04999085ef97fa03c83b150a: Bug 1334361 - Use NS_DECL macro for nsIEditorStyleSheets and nsITableEditor. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 27 Jan 2017 11:11:09 +0900 - rev 360632
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1334361 - Use NS_DECL macro for nsIEditorStyleSheets and nsITableEditor. r=masayuki Except to nsIEditorStyleSheets and nsITableEditor, we use NS_DECL macro into HTMLEditor, so we should use macro for both. MozReview-Commit-ID: I6v9mRXNci6
bdaabccd427cfc8e98cda64e7e01d9865d230c9b: Bug 1334372 - Part 2. Don't use virtual method for CreateTxnForAddStyleSheet and CreateTxnForRemoveStyleSheet. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 27 Jan 2017 13:29:00 +0900 - rev 360442
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1334372 - Part 2. Don't use virtual method for CreateTxnForAddStyleSheet and CreateTxnForRemoveStyleSheet. r=masayuki We don't have no overload method for both methods. So we shouldn't use virtual. And, other transaction methods return transaction object directly, we should change to it. MozReview-Commit-ID: 7CXz4XeOobk
8756360731f196823b926e41d5b44dbf67f7317a: Bug 1334372 - Part 1. Use EditorBase directly in AddStyleSheetTransaction/RemoveStyleSheetTransaction. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 27 Jan 2017 13:15:20 +0900 - rev 360441
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1334372 - Part 1. Use EditorBase directly in AddStyleSheetTransaction/RemoveStyleSheetTransaction. r=masayuki Other transaction classes use EditorBase directly, but these transaction classes use nsIEditor. To remove nsIDOMDocument XPCOM interface usage, I would like to use EditorBase directly. MozReview-Commit-ID: 3alRd9Zj5aZ
045a0995bdec04c1577b4459c3b29812041bdb19: Bug 795418 - Ensure that the inserted wrapper element has a frame to make it IsEditable. r=masayuki
Mats Palmgren <mats@mozilla.com> - Fri, 27 Jan 2017 00:24:00 +0100 - rev 360367
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 795418 - Ensure that the inserted wrapper element has a frame to make it IsEditable. r=masayuki
42112710614b3a7d397728647a810b3c10b5f78f: Bug 1333901 - support document.createEvent(ErrorEvent), r=masayuki
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 26 Jan 2017 12:00:16 +0200 - rev 360270
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1333901 - support document.createEvent(ErrorEvent), r=masayuki
fe6d35a774ed725a607b592d30117da7f0fd16f7: Bug 1333901 - support document.createEvent(ErrorEvent), r=masayuki
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 26 Jan 2017 12:00:16 +0200 - rev 360255
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1333901 - support document.createEvent(ErrorEvent), r=masayuki
f9f4879c272783c17a3e50a50437fff1e68212ec: Bug 1332527 - [Pointer Event] Remove redundent codes in PointerEvent test cases. r=masayuki
Stone Shih <sshih@mozilla.com> - Fri, 20 Jan 2017 09:58:15 +0800 - rev 360209
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1332527 - [Pointer Event] Remove redundent codes in PointerEvent test cases. r=masayuki MozReview-Commit-ID: EiV7PvyFBTU
48f782128e5dc9fd4ac0ad5d51914cbbc4665cde: Bug 1306532 - Post process node array in ReplaceOrphanedStructure to remove all descendants of replacement node. r=masayuki
William Chen <wchen@mozilla.com> - Mon, 09 Jan 2017 10:11:04 -0800 - rev 360006
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1306532 - Post process node array in ReplaceOrphanedStructure to remove all descendants of replacement node. r=masayuki
ea7f4f1874571273f2df4e579cebaab34735cb05: Bug 1332977 - Move InsertBR into TextEditor to HTMLEditor. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 23 Jan 2017 12:39:47 +0900 - rev 359974
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1332977 - Move InsertBR into TextEditor to HTMLEditor. r=masayuki TextEditor::InsertBR is called from HTMLEditor::TypedText only. So we should move it to HTMLEditor. MozReview-Commit-ID: 4rPcayd9T5n
6d8d5b5d1aa699f149851cd9c3034c1ccc6b24b1: Bug 1332984 - Clean up usage of nsIDOMCharacterData into editor. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 23 Jan 2017 14:14:30 +0900 - rev 359961
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1332984 - Clean up usage of nsIDOMCharacterData into editor. r=masayuki Some uses nsIDOMCharacterData to get the attribute of text node. But, by using Text object, we don't need nsIDOMCharacter. So we should use Text object instead of nsIDOMCharacterData instead if possible. MozReview-Commit-ID: 1cwTUcecFj3
a0bd28150d4f8654aaf3a05f0c97eea1f8233af7: Bug 1319660 - Fix possible crash when editing contentEditable; r=esawin r=masayuki r=smaug
Jim Chen <nchen@mozilla.com> - Mon, 23 Jan 2017 14:35:04 -0500 - rev 359817
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1319660 - Fix possible crash when editing contentEditable; r=esawin r=masayuki r=smaug Bug 1319660 - 1. Don't take shortcut if old replacement ranges don't match; r=esawin The block at [1] is a shortcut we take when we reconcile Java text changes with Gecko text changes. However, we only checked that the new ranges are the same, i.e. that the new Gecko text is the same as the new Java text. We should also be checking that the old ranges are the same, i.e. that the replaced Gecko text is the same as the replaced Java text. [1] https://dxr.mozilla.org/mozilla-central/rev/bbbd2f7539f224a482cc6d2dd10e6a5f31c8baf3/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditable.java#1233 Bug 1319660 - 2. Use previous node instead of sibling when adjusting last node; r=masayuki r=smaug nsContentIterator in pre mode adjusts its last node if the node is a childless node like <br>. However, right now it's using GetPrevSibling, which can lead to error in some edge cases such as: <p></p><div><br></div> In this case, if the last node is <br> with offset 0, GetPrevSibling will return <p> because <p> is <br>'s parent's previous sibling, and the last node will be set to <p>. However, the correct last node in this case is <div>, because <br> with offset 0 refers to the position to the left of <br>, which is <div> with offset 0. In this case, PrevNode returns the correct <div> value, so we should set the last node to the result of PrevNode. For the first node, for a childless node in pre mode, GetNextSibling and NextNode are the same, so there is no bug in this case. Nevertheless, this patch changes the call to NextNode to be consistent with calling PrevNode for the last node. Bug 1319660 - 3. Add test for correctly adjusting last node in content iterator; r=masayuki Add a test for the previous patch that makes sure querying selected text in an edge case works correctly. Bug 1319660 - 4. Add test for start node regression; r=me Add a new test case for the NextNode() regression. r=me for trivial test-only patch. Bug 1319660 - 5. Restore GetNextSibling call for first node of pre-content-iterator; r=smaug The last patch changed the `GetNextSibling()` call to `NextNode()` because I assumed they're equivalent in this case. That turned out to not be the case because we can reach this line even if the node has children -- the index just has to be after the last child. So this patch restores the `GetNextSibling` call to restore the correct behavior. I also added some comment to clarify that we can reach this line due to one of two conditions: 1) the node has no children; 2) the node has children but the index is after the last child. This patch also replaces the `HasChildren()` check when setting `cChild`. If the index is after the last child (i.e. index == childCount), `GetChildAt()` fails and we erroneously log an assertion warning, even though the input was valid. The new check handles all cases whether start node has children or not.
4a02468e067257db5c8f6cefc330bb3c30d1d541: Bug 1270235 - Part 2: Add test. r=masayuki, a=gchang
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 13 Feb 2017 15:46:15 +0900 - rev 359308
Push 10760 by ryanvm@gmail.com at Fri, 17 Feb 2017 21:22:33 +0000
Bug 1270235 - Part 2: Add test. r=masayuki, a=gchang MozReview-Commit-ID: BV7Dc6YiNM6
9f46a26cc63fb71cff48d8c45a9f6ceb75e85888: Bug 1270235 - Part 1: Check parent node is null in RemoveEmptyNodes. r=masayuki, a=gchang
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 13 Feb 2017 15:46:09 +0900 - rev 359307
Push 10760 by ryanvm@gmail.com at Fri, 17 Feb 2017 21:22:33 +0000
Bug 1270235 - Part 1: Check parent node is null in RemoveEmptyNodes. r=masayuki, a=gchang RemoveEmptyNodes doesn't check whether parent node is null. So we shouldn't add null to skip list. Also, although this crash depends on clang, if debug build, it will hit the assertion on all compiler. MozReview-Commit-ID: GgiczVExlIn
385b4f5d1c495855e16e6b62ebfb246610e7dc9a: Bug 795418 - Ensure that the inserted wrapper element has a frame to make it IsEditable. r=masayuki, a=ritu
Mats Palmgren <mats@mozilla.com> - Fri, 27 Jan 2017 00:24:00 +0100 - rev 358839
Push 10663 by ryanvm@gmail.com at Wed, 01 Feb 2017 23:07:38 +0000
Bug 795418 - Ensure that the inserted wrapper element has a frame to make it IsEditable. r=masayuki, a=ritu
46497fa848f7b678b5d1bbfd28ed8d1828443b9b: Bug 1328023 - Part 2. Add test for undo. r=masayuki, a=jcristau
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 30 Jan 2017 17:27:26 +0900 - rev 358806
Push 10659 by cbook@mozilla.com at Wed, 01 Feb 2017 14:58:22 +0000
Bug 1328023 - Part 2. Add test for undo. r=masayuki, a=jcristau MozReview-Commit-ID: 6ZuluRWrYxb
e235e56f062a8bb2bfec3ea17fa098ecd422b476: Bug 1328023 - Part 1. Don't use RangeUpdater except to composition transaction. r=masayuki, a=jcristau
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 30 Jan 2017 17:25:43 +0900 - rev 358805
Push 10659 by cbook@mozilla.com at Wed, 01 Feb 2017 14:58:22 +0000
Bug 1328023 - Part 1. Don't use RangeUpdater except to composition transaction. r=masayuki, a=jcristau Part 3 fix of bug 1310912 is incorrect for not composition transaction. PlaceholderTransation is for saving and restoring current selection for undo. So we shouldn't use range updater to normal transaction. Composition transaction can modify multiple nodes and it merges text node for ime into single text node. So if current selection is into IME text node, it might be failed to restore selection by UndoTransaction. So we need update selection by range updater to work UndoTransaction. Also, CompositionTransaction::UndoTransaction will set selection after committed text. So at finally, selection will set correct position that composition transaction wants. MozReview-Commit-ID: 1NcH32YoKPQ
5ae7001fbd3f6441525f70a8c4c2db12c5ce5b00: Bug 1319660 - Fix possible crash when editing contentEditable; r=esawin r=masayuki r=smaug a=lizzard a=jcristau
Jim Chen <nchen@mozilla.com> - Mon, 23 Jan 2017 14:35:04 -0500 - rev 358802
Push 10659 by cbook@mozilla.com at Wed, 01 Feb 2017 14:58:22 +0000
Bug 1319660 - Fix possible crash when editing contentEditable; r=esawin r=masayuki r=smaug a=lizzard a=jcristau Bug 1319660 - 1. Don't take shortcut if old replacement ranges don't match; r=esawin The block at [1] is a shortcut we take when we reconcile Java text changes with Gecko text changes. However, we only checked that the new ranges are the same, i.e. that the new Gecko text is the same as the new Java text. We should also be checking that the old ranges are the same, i.e. that the replaced Gecko text is the same as the replaced Java text. [1] https://dxr.mozilla.org/mozilla-central/rev/bbbd2f7539f224a482cc6d2dd10e6a5f31c8baf3/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditable.java#1233 Bug 1319660 - 2. Use previous node instead of sibling when adjusting last node; r=masayuki r=smaug nsContentIterator in pre mode adjusts its last node if the node is a childless node like <br>. However, right now it's using GetPrevSibling, which can lead to error in some edge cases such as: <p></p><div><br></div> In this case, if the last node is <br> with offset 0, GetPrevSibling will return <p> because <p> is <br>'s parent's previous sibling, and the last node will be set to <p>. However, the correct last node in this case is <div>, because <br> with offset 0 refers to the position to the left of <br>, which is <div> with offset 0. In this case, PrevNode returns the correct <div> value, so we should set the last node to the result of PrevNode. For the first node, for a childless node in pre mode, GetNextSibling and NextNode are the same, so there is no bug in this case. Nevertheless, this patch changes the call to NextNode to be consistent with calling PrevNode for the last node. Bug 1319660 - 3. Add test for correctly adjusting last node in content iterator; r=masayuki Add a test for the previous patch that makes sure querying selected text in an edge case works correctly. Bug 1319660 - 4. Add test for start node regression; r=me Add a new test case for the NextNode() regression. r=me for trivial test-only patch. Bug 1319660 - 5. Restore GetNextSibling call for first node of pre-content-iterator; r=smaug The last patch changed the `GetNextSibling()` call to `NextNode()` because I assumed they're equivalent in this case. That turned out to not be the case because we can reach this line even if the node has children -- the index just has to be after the last child. So this patch restores the `GetNextSibling` call to restore the correct behavior. I also added some comment to clarify that we can reach this line due to one of two conditions: 1) the node has no children; 2) the node has children but the index is after the last child. This patch also replaces the `HasChildren()` check when setting `cChild`. If the index is after the last child (i.e. index == childCount), `GetChildAt()` fails and we erroneously log an assertion warning, even though the input was valid. The new check handles all cases whether start node has children or not.
d6e53354c0346bede591b876c97561f03b50ef9d: Bug 1332876 - Bail out of HTMLEditRules::BeforeEdit if we have no Selection. r=masayuki a=jcristau
Mats Palmgren <mats@mozilla.com> - Mon, 30 Jan 2017 04:54:37 +0100 - rev 358783
Push 10655 by cbook@mozilla.com at Tue, 31 Jan 2017 15:17:41 +0000
Bug 1332876 - Bail out of HTMLEditRules::BeforeEdit if we have no Selection. r=masayuki a=jcristau
c4acba4df2b205a75c1f858c9b431ecfde531673: Bug 1330796 - Follow-up: Add key code to KEY_Enter. r=masayuki
Jorg K <jorgk@jorgk.com> - Tue, 17 Jan 2017 10:40:00 -0500 - rev 357786
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1330796 - Follow-up: Add key code to KEY_Enter. r=masayuki
86dde0e3081968e2d654f848902502ed7e7f1d8c: Bug 1324505 - Part 3. Clean up HTMLEditRules::PopListItem. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 11 Jan 2017 19:07:33 +0900 - rev 357677
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1324505 - Part 3. Clean up HTMLEditRules::PopListItem. r=masayuki PopListItem still uses nsIDOM*. We should new binding API instead and it is unnecessary to use QI and refcounting if possible. MozReview-Commit-ID: DJL105hNt6z
4f22ce6afa753b6ace59f6bf74b47a8f6a53531c: Bug 1324505 - Part 2. Add crash test. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 11 Jan 2017 19:04:32 +0900 - rev 357676
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1324505 - Part 2. Add crash test. r=masayuki MozReview-Commit-ID: 7NJr1fGKBZA