searching for reviewer(maja_zf)
7e03d31839f7726f20769a60988462e0d659b382: Bug 1350887 - Ensure Marionette prefs file has sensible name. r=maja_zf, a=test-only
Andreas Tolfsen <ato@mozilla.com> - Thu, 30 Mar 2017 14:52:16 +0100 - rev 375736
Push 11019 by ryanvm@gmail.com at Wed, 05 Apr 2017 21:18:17 +0000
Bug 1350887 - Ensure Marionette prefs file has sensible name. r=maja_zf, a=test-only Files appended to JS_PREFERENCE_FILES are moved into the objdir/dist/bin/defaults/pref directory, shared with default global preferences from other parts of Gecko. To ensure Marionette's preference file ends up in this directory with a sensible name, we put it in testing/marionette/prefs/marionette.js so that it ends up in the objdir as dist/bin/defaults/pref/marionette.js. MozReview-Commit-ID: 9YJ7vysDjSJ
82f186fc316dc3193724132ab9ef9cec2db7a78f: Bug 1291320 - Skip test_focus_after_navigation for "Unable to locate element: :focus". r=maja_zf, a=test-only
Henrik Skupin <mail@hskupin.info> - Mon, 03 Apr 2017 22:10:38 +0200 - rev 375734
Push 11019 by ryanvm@gmail.com at Wed, 05 Apr 2017 21:18:17 +0000
Bug 1291320 - Skip test_focus_after_navigation for "Unable to locate element: :focus". r=maja_zf, a=test-only MozReview-Commit-ID: Kd2lrH9y5US
83f38ac8d51ab9967b4a31f26ee0a5f5ce2b361d: Bug 1351422 - Prevent redirect on Firefox upgrade in automation; r=maja_zf, a=test-only
Andreas Tolfsen <ato@mozilla.com> - Tue, 28 Mar 2017 19:50:33 +0100 - rev 375608
Push 10979 by ryanvm@gmail.com at Thu, 30 Mar 2017 17:57:37 +0000
Bug 1351422 - Prevent redirect on Firefox upgrade in automation; r=maja_zf, a=test-only This preference should have been part of the recommended automation preferences when the set was first installed. This recitfies the omission by not causing the browser to redirect the user to an upgrade website when a milestone upgrade of Firefox is detected. MozReview-Commit-ID: ACUeJ2vPhl9
7d66958d9a4c45f95cec90e9a92032ef834cf1f1: Bug 1351371 - Disable recommended automation prefs in CI; r=maja_zf, a=test-only
Andreas Tolfsen <ato@mozilla.com> - Tue, 28 Mar 2017 17:30:22 +0100 - rev 375607
Push 10979 by ryanvm@gmail.com at Thu, 30 Mar 2017 17:57:37 +0000
Bug 1351371 - Disable recommended automation prefs in CI; r=maja_zf, a=test-only This tells Marionette to not set the recommended automation preferences in testing/marionette/server.js when started. We only want to use this set of recommended prefs for public consumers of Marionette, and not when we are testing Gecko itself as they may interfere with expectations of tests. MozReview-Commit-ID: 4InVBRBnUTG
2a7bd5f693c2146bfda0b27faa5c1e0d87154df4: Bug 1337743 - Add assert.callable for checking callbacks; r=maja_zf, a=test-only
Andreas Tolfsen <ato@mozilla.com> - Fri, 10 Feb 2017 19:28:51 +0000 - rev 375600
Push 10979 by ryanvm@gmail.com at Thu, 30 Mar 2017 17:57:37 +0000
Bug 1337743 - Add assert.callable for checking callbacks; r=maja_zf, a=test-only MozReview-Commit-ID: 2bJbi4iEGlZ
df3bfa03df6da4403697aff2facfd77bd5dcfcea: Bug 1344748 - Skip recommended Marionette prefs for Firefox tests; r=maja_zf,whimboo, a=test-only
Andreas Tolfsen <ato@mozilla.com> - Mon, 06 Mar 2017 18:38:06 +0000 - rev 375592
Push 10979 by ryanvm@gmail.com at Thu, 30 Mar 2017 17:57:37 +0000
Bug 1344748 - Skip recommended Marionette prefs for Firefox tests; r=maja_zf,whimboo, a=test-only The recommended Marionette preferences for use in automation are not so useful when testing the browser itself. Many of the tests for Firefox have highly specific requirements, and setting the recommended Marionette preferences could for these mean a deterioration of test coverage. The majority of test harnesses utilising Marionette use it to install unsigned add-ons at runtime, and these preferences are not relevant in this context. The preferences they use are defined in prefs_general.js. To avoid an unfortunate and unintended regression in test coverage, we skip using the recommended Marionette preferences when we test the browser itself. MozReview-Commit-ID: 5h3cGPfbicV
4b03583a265bbb01ec70f4246d1d88795da42766: Bug 1344748 - Gate recommended prefs on a preference; r=maja_zf,whimboo, a=test-only
Andreas Tolfsen <ato@mozilla.com> - Tue, 07 Mar 2017 21:02:05 +0000 - rev 375591
Push 10979 by ryanvm@gmail.com at Thu, 30 Mar 2017 17:57:37 +0000
Bug 1344748 - Gate recommended prefs on a preference; r=maja_zf,whimboo, a=test-only MozReview-Commit-ID: FnqBDAXpg6v
5917cc5857187180d63ee7c38b2864f84b47390b: Bug 1344748 - Rename and register Marionette prefs; r=maja_zf, a=test-only
Andreas Tolfsen <ato@mozilla.com> - Thu, 09 Mar 2017 11:12:53 +0000 - rev 375590
Push 10979 by ryanvm@gmail.com at Thu, 30 Mar 2017 17:57:37 +0000
Bug 1344748 - Rename and register Marionette prefs; r=maja_zf, a=test-only This change renames the following Marionette preferences: marionette.defaultPrefs.enabled marionette.enabled marionette.defaultPrefs.port marionette.port marionette.force-local marionette.forcelocal marionette.logging marionette.log.level The old preference names are still usable, but are henceforth considered deprecated. They will be removed when Firefox 55 ships. It also registers these preferences in Firefox so that they are discoverable through about:config. This patch also refactors testing/marionette/components/marionette.js. MozReview-Commit-ID: 1dAMQS2e0og
f41b674de525db4f6962712ab5399285f04949ff: Bug 1344748 - Merge dispatcher into server.js; r=maja_zf, a=test-only
Andreas Tolfsen <ato@mozilla.com> - Mon, 06 Mar 2017 17:39:42 +0000 - rev 375589
Push 10979 by ryanvm@gmail.com at Thu, 30 Mar 2017 17:57:37 +0000
Bug 1344748 - Merge dispatcher into server.js; r=maja_zf, a=test-only Merges testing/marionette/dispatcher.js into testing/marionette/server.js and renames it server.TCPConnection. The rationale behind this change is that the current dispatcher is not a single entity to which incoming requests are dispatched. The old organisation might make sense if this was an HTTP server where all connections are transitive and it didn't hold any connection details, however the dispatcher is in effect a representation of a client socket connection. Since the module is not used elsewhere, it makes sense to pair it with the existing server.TCPListener class. MozReview-Commit-ID: 2HF35OiP6AY
d30b685a8811d6e495ea4b9195cfa153fc0c06e9: Bug 1344748 - Make testing/marionette/server.js a class; r=maja_zf,whimboo, a=test-only
Andreas Tolfsen <ato@mozilla.com> - Mon, 06 Mar 2017 17:09:07 +0000 - rev 375588
Push 10979 by ryanvm@gmail.com at Thu, 30 Mar 2017 17:57:37 +0000
Bug 1344748 - Make testing/marionette/server.js a class; r=maja_zf,whimboo, a=test-only No functional changes apart from class'ifying the file and harmonising the export symbol with the rest of the Marionette code base by renaming the MarionetteServer class to server.TCPListener. MozReview-Commit-ID: 8WJKoprGGvr
0b16ceaefbeb2b8d2661cae10616d4276185619a: Bug 1344748 - Set recommended prefs when Marionette starts; r=automatedtester,maja_zf,whimboo, a=test-only
Andreas Tolfsen <ato@mozilla.com> - Mon, 06 Mar 2017 16:47:38 +0000 - rev 375587
Push 10979 by ryanvm@gmail.com at Thu, 30 Mar 2017 17:57:37 +0000
Bug 1344748 - Set recommended prefs when Marionette starts; r=automatedtester,maja_zf,whimboo, a=test-only This makes the Marionette server itself set a long list of recommended automation preferences when it starts up, and reset those it changed when stopping. Preferences used in automation are currently written to the Firefox profile before Firefox starts, but after a closer examination of the preferences, it is thought that many of them can be set at runtime. There is a subset of preferences that are checked on startup and which must be set in the profile. These are clearly called out in the comments. We still set them at runtime, since we foresee a future where it will be possible to attach an existing Firefox session to geckodriver, and many of the prefs can also be checked at runtime during the course of that automation session. For example, if we would not set the "app.update.auto" preference in such a runtime, opening the About dialogue would cause a forced update of Firefox. This is not desirable when the browser is under Marionette control. When the Marionette server is stopped, the altered preferences are reset and the browser session's state is returned to its pre-existing condition. This change does not mean it is dangerous or wrong for consumers to write their own preferences to the profile. Any preferences written to the profile will take precedence over this set of recommended preferences. If the recommended Marionette preference has a user-defined value (i.e. it is written to the profile before starting up or has manually changed), that user-set value is preferred. The list of preferences in this file is the authorative reference of recommended preferences for using Marionette in automation. They have been gathered from geckoinstance.py and geckodriver. MozReview-Commit-ID: INHSQRg2XjF
eff9e30b6f7528ef8af39ac526f7eb00d9b1eab7: Bug 1344748 - Remove B2G offline management from Marionette; r=maja_zf, a=test-only
Andreas Tolfsen <ato@mozilla.com> - Mon, 06 Mar 2017 16:45:35 +0000 - rev 375586
Push 10979 by ryanvm@gmail.com at Thu, 30 Mar 2017 17:57:37 +0000
Bug 1344748 - Remove B2G offline management from Marionette; r=maja_zf, a=test-only MozReview-Commit-ID: 68iUhwT7xdv
90b35818bd830cca7dd1a3ef731e75beeafd4180: Bug 1342162 - Align pageLoad key with WebDriver. r=maja_zf, a=test-only
Andreas Tolfsen <ato@mozilla.com> - Thu, 23 Feb 2017 18:33:26 +0000 - rev 375481
Push 10960 by ryanvm@gmail.com at Mon, 27 Mar 2017 20:45:47 +0000
Bug 1342162 - Align pageLoad key with WebDriver. r=maja_zf, a=test-only The WebDriver specification recently decided to use "pageLoad" instead of "page load" to identify the page load duration timeout in the session timeouts configuration object: https://github.com/w3c/webdriver/pull/796 This change aligns Marionette with WebDriver, and as long as this patch is uplifted to Aurora (53) and Beta (52) in reasonable time, we should be able to avoid the backwards compatibility dance with the Python client (for upgrade tests) because the original change to the data format landed on the current Firefox version: https://bugzilla.mozilla.org/show_bug.cgi?id=1316622 MozReview-Commit-ID: BzQeJku4AFS
cf30efb78ec544326ccfc3465a7db632194d20b7: Bug 1333014 - Lint testing/marionette/element.js; r=maja_zf a=test-only
Andreas Tolfsen <ato@mozilla.com> - Tue, 07 Feb 2017 19:18:40 +0000 - rev 375406
Push 10941 by cbook@mozilla.com at Fri, 24 Mar 2017 08:21:41 +0000
Bug 1333014 - Lint testing/marionette/element.js; r=maja_zf a=test-only No functional changes. MozReview-Commit-ID: CK33FjpQMmO
dca88c00f35a558eabd2441234473db2883b5ec6: Bug 1333014 - Change element.isDisconnected to take container; r=maja_zf a=test-only
Andreas Tolfsen <ato@mozilla.com> - Tue, 07 Feb 2017 19:00:28 +0000 - rev 375405
Push 10941 by cbook@mozilla.com at Fri, 24 Mar 2017 08:21:41 +0000
Bug 1333014 - Change element.isDisconnected to take container; r=maja_zf a=test-only It makes sense for element.isDisconnected to accept a container object with frame and shadowRoot, instead of taking the shadowRoot as an optional third argument, since this is what most consumers start out with. MozReview-Commit-ID: 6kfEIEf8u96
c852580194208796bd82f20ff8301db4fe71dd36: Bug 1333014 - Remove unused element.isInteractable API; r=maja_zf a=test-only
Andreas Tolfsen <ato@mozilla.com> - Tue, 07 Feb 2017 17:05:06 +0000 - rev 375404
Push 10941 by cbook@mozilla.com at Fri, 24 Mar 2017 08:21:41 +0000
Bug 1333014 - Remove unused element.isInteractable API; r=maja_zf a=test-only MozReview-Commit-ID: 5iBcHUeNmSN
41092b5df8a6307a3c0d2eb20dc6aa4328889bae: Bug 1333014 - Pretty-print HTML elements; r=maja_zf a=test-only
Andreas Tolfsen <ato@mozilla.com> - Tue, 07 Feb 2017 16:59:59 +0000 - rev 375403
Push 10941 by cbook@mozilla.com at Fri, 24 Mar 2017 08:21:41 +0000
Bug 1333014 - Pretty-print HTML elements; r=maja_zf a=test-only When passing a DOM element that is an HTML element to error.pprint, it will get pretty-printed with its ID and class properties. This helps to identify elements when one is obscuring the other when clicking. For example, the error message Element <input id="foo"> is obscured by <input id="bar"> is nicer than the old error message Element [object HTMLElement] {} is obscured by [object HTMLElement] {} MozReview-Commit-ID: 8U2Lo8V4lmv
23c1e33165b480b4be20af0c97b7ea750dc71ff5: Bug 1322383 - Update Puppeteer and firefox-ui tests for valid window checks. r=maja_zf a=test-only
Henrik Skupin <mail@hskupin.info> - Tue, 07 Feb 2017 11:16:55 +0100 - rev 375399
Push 10941 by cbook@mozilla.com at Fri, 24 Mar 2017 08:21:41 +0000
Bug 1322383 - Update Puppeteer and firefox-ui tests for valid window checks. r=maja_zf a=test-only We have to ensure to switch to the current browser window after closing all the windows in tearDown. MozReview-Commit-ID: 3sYwmbew43d
041eba73027e38e1dbc32d9f03f299e5d431f09a: Bug 1322383 - getCurrentWindow() has to only return the currently selected window. r=ato,maja_zf a=test-only
Henrik Skupin <mail@hskupin.info> - Mon, 20 Mar 2017 22:43:32 +0100 - rev 375398
Push 10941 by cbook@mozilla.com at Fri, 24 Mar 2017 08:21:41 +0000
Bug 1322383 - getCurrentWindow() has to only return the currently selected window. r=ato,maja_zf a=test-only Given that this method will be used in each command for checks of a valid window, we have to return the currently active window. It means the window mediator should only be used during setting up the session to find the first browser window. At the same time the code in this method is getting split-up for chrome and content scopes. MozReview-Commit-ID: KyzxYk63RgA
445c4d9562b6f2b4cdb66dfb8f00ab063f50a23e: Bug 1347658: Allow negative integers for Marionette pointerMove. r=maja_zf a=testonly
David Burns <dburns@mozilla.com> - Wed, 15 Mar 2017 22:28:10 +0000 - rev 375248
Push 10908 by kwierso@gmail.com at Thu, 16 Mar 2017 23:42:57 +0000
Bug 1347658: Allow negative integers for Marionette pointerMove. r=maja_zf a=testonly W3C WebDriver spec had incorrectly described that we could only have positive integers when it should have been just Integers. MozReview-Commit-ID: CttUFKiav7q
e0563eeab4043e203614bd505773b2396e4a2e30: Bug 1340775 - Allow window position to be set to negative coordinates. r=maja_zf, a=test-only
Andreas Tolfsen <ato@mozilla.com> - Thu, 23 Feb 2017 14:12:29 +0000 - rev 375215
Push 10903 by ryanvm@gmail.com at Wed, 15 Mar 2017 23:12:31 +0000
Bug 1340775 - Allow window position to be set to negative coordinates. r=maja_zf, a=test-only It should be possible to set a window's position to a pair of negative coordinates, since the user may move the window off-screen. The window may also be situated off-screen by default: for example a maximised window on Windows will report window.screenX to be -8px. Relevant change to the specification: https://github.com/w3c/webdriver/pull/805 MozReview-Commit-ID: FdReDi8pLL0
42c74dd948b9fb34695555396daa4a6e09056198: Bug 1335873 - Convert marionette harness unittests to standard python unittests, r=maja_zf
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 15 Feb 2017 16:38:45 -0500 - rev 374494
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1335873 - Convert marionette harness unittests to standard python unittests, r=maja_zf This formats the marionette-harness python tests to be a regular |mach python-test| suite. Though we add subsuite=marionette, this is just for automation purposes. The new preferred way to run the marionette harness tests locally is: ./mach python-test testing/marionette They will also run if running the full suite. The mozbase packages.txt file modifies mozlog to use 'setup.py' instead of 'pth'. The reason for this is that the marionette-harness tests use the pytest_mozlog pytest plugin for formatting their results (converts pytest format into something resembling the standard tbpl logging format). In order for this plugin to get picked up however, mozlog's setup.py file needs to be processed. MozReview-Commit-ID: Ata99evHxbd
b7f4708903844cb5aa6dda8dd5c235e58c277f89: Bug 1335873 - Ignore MozconfigFindException when looking for a mozinfo.json, r=maja_zf
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 15 Feb 2017 16:37:58 -0500 - rev 374493
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1335873 - Ignore MozconfigFindException when looking for a mozinfo.json, r=maja_zf This gets raised when trying to run the marionette-harness python tests without an objdir. It's safe to ignore because mozinfo.json will still be found via the 'dirs' variable which gets passed in from the marionette harness. MozReview-Commit-ID: Ata99evHxbd
b557bdc314e76fdac31f53682b04f463abf2b992: Bug 1343129 - Update the base media test class to set self.return_code based on the job result parser. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 28 Feb 2017 15:46:16 +1300 - rev 374483
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1343129 - Update the base media test class to set self.return_code based on the job result parser. r=maja_zf Right now the base run_media_tests function doesn't set the self.return_code value based on the result of the job result parser. Overrides of the function appear to need to set this value if it's to be used. This changeset moves the logic to set this value from the buildbot script to the base. Overrides are free to alter the behaviour so that the value can be set as appropriate depending on the tests, but removes the ability to footgun by assuming that the base will set the value (as I did). MozReview-Commit-ID: FBT0N62ydR9
3c0a7527608aa6398f8177b08088da39592078d9: Bug 1335873 - Convert marionette harness unittests to standard python unittests, r=maja_zf
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 15 Feb 2017 16:38:45 -0500 - rev 374419
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1335873 - Convert marionette harness unittests to standard python unittests, r=maja_zf This formats the marionette-harness python tests to be a regular |mach python-test| suite. Though we add subsuite=marionette, this is just for automation purposes. The new preferred way to run the marionette harness tests locally is: ./mach python-test testing/marionette They will also run if running the full suite. The mozbase packages.txt file modifies mozlog to use 'setup.py' instead of 'pth'. The reason for this is that the marionette-harness tests use the pytest_mozlog pytest plugin for formatting their results (converts pytest format into something resembling the standard tbpl logging format). In order for this plugin to get picked up however, mozlog's setup.py file needs to be processed. MozReview-Commit-ID: Ata99evHxbd
caacf82afba18ddcbab61f3cc486f9b98f98e279: Bug 1335873 - Ignore MozconfigFindException when looking for a mozinfo.json, r=maja_zf
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 15 Feb 2017 16:37:58 -0500 - rev 374418
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1335873 - Ignore MozconfigFindException when looking for a mozinfo.json, r=maja_zf This gets raised when trying to run the marionette-harness python tests without an objdir. It's safe to ignore because mozinfo.json will still be found via the 'dirs' variable which gets passed in from the marionette harness. MozReview-Commit-ID: Ata99evHxbd
20f6edaec61ee22350354dbed3f684802fdcee3b: Bug 1322383 - Update Puppeteer and firefox-ui tests for valid window checks. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Tue, 07 Feb 2017 11:16:55 +0100 - rev 374389
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1322383 - Update Puppeteer and firefox-ui tests for valid window checks. r=maja_zf We have to ensure to switch to the current browser window after closing all the windows in tearDown. MozReview-Commit-ID: 3sYwmbew43d
c6a4bbb143946b614aa02da0a88bf1c80ea9918e: Bug 1343407 - Fix attribute name video_uri -> base_uri when logging stalls. r=maja_zf
Bryce Van Dyk <bvandyk@mozilla.com> - Wed, 01 Mar 2017 14:12:06 +1300 - rev 374233
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1343407 - Fix attribute name video_uri -> base_uri when logging stalls. r=maja_zf When logging a stall a non-existent attribute was attempting to be printed. This changeset fixes the name being used so that the logging will work correctly. Also contains a drive by change to make _video_var_script more consistent. There was a inconsistency with how objects were referenced which has been removed. MozReview-Commit-ID: hTHC9VIxBW
e35efb0da85ffbf8ad02f9bd1765e3557db302ed: Bug 1343361 - Auomatically replace `-u all` with a set of suites that do not include compiled tests when requesting an artifact build via |./mach try|. r=maja_zf
Chris Manchester <cmanchester@mozilla.com> - Tue, 28 Feb 2017 14:27:57 -0800 - rev 374213
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1343361 - Auomatically replace `-u all` with a set of suites that do not include compiled tests when requesting an artifact build via |./mach try|. r=maja_zf MozReview-Commit-ID: BYgzbYrbw7E
01bc4c9ad3b50d29b61e0bbfbba2862af8cf5b81: Bug 1342162 - Align pageLoad key with WebDriver; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Thu, 23 Feb 2017 18:33:26 +0000 - rev 374115
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1342162 - Align pageLoad key with WebDriver; r=maja_zf The WebDriver specification recently decided to use "pageLoad" instead of "page load" to identify the page load duration timeout in the session timeouts configuration object: https://github.com/w3c/webdriver/pull/796 This change aligns Marionette with WebDriver, and as long as this patch is uplifted to Aurora (53) and Beta (52) in reasonable time, we should be able to avoid the backwards compatibility dance with the Python client (for upgrade tests) because the original change to the data format landed on the current Firefox version: https://bugzilla.mozilla.org/show_bug.cgi?id=1316622 MozReview-Commit-ID: BzQeJku4AFS
8c97b432e7c5f846aaeda695b7296a954f40d8bd: Bug 1337827 - [one-click-loaner] Always set up mach environment when calling 'run-mozharness' (if possible) r=maja_zf
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 10 Feb 2017 12:07:44 -0500 - rev 371864
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1337827 - [one-click-loaner] Always set up mach environment when calling 'run-mozharness' (if possible) r=maja_zf This is a minor refactor that aims to always attempt to set up 'mach' after running the 'run-mozharness' script. We put it in a 'finally' block so we'll even do this if the user presses Ctrl-C or there was an exception in the test harness. Importantly, this will be set up regardless of whether the user chooses "Option 1" or "Option 2" at the wizard prompt. The reason for this change is mostly 'might as well'. If it can save some users confusion, then it is worthwhile. MozReview-Commit-ID: Dx3rV17FOoJ
b3c43c86a86bb951e708049a8542d606eaa1bfb8: Bug 1337827 - [one-click-loaner] Print error message if mach binary wasn't found r=maja_zf
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 10 Feb 2017 12:07:38 -0500 - rev 371863
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1337827 - [one-click-loaner] Print error message if mach binary wasn't found r=maja_zf MozReview-Commit-ID: Dx3rV17FOoJ
9ba825a65a34304bbcbeadbeb0eb573ad9a3be95: Bug 1337827 - [one-click-loaner] Refactor mach environment setup into a standalone function r=maja_zf
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 10 Feb 2017 11:39:03 -0500 - rev 371862
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1337827 - [one-click-loaner] Refactor mach environment setup into a standalone function r=maja_zf MozReview-Commit-ID: CuxSwkp0Uuk
b83537047757127f89aa5d6f397ab92460c0fad3: Bug 1337828 - Improve mochitest 'no tests' error message, r=maja_zf
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 09 Feb 2017 09:55:23 -0500 - rev 371781
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1337828 - Improve mochitest 'no tests' error message, r=maja_zf Include the current flavor in the "No tests found" error message. Also suggest what may have went wrong. MozReview-Commit-ID: 5LEQFVDoJrT
e725ba1475be5300919d3be04b7dedafa3e02f43: Bug 1337828 - Pass unexpected test paths as is from mach_test_package_bootstrap to the test harness, r=maja_zf
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 09 Feb 2017 09:55:18 -0500 - rev 371780
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1337828 - Pass unexpected test paths as is from mach_test_package_bootstrap to the test harness, r=maja_zf This was a bug in the mach test package bootstrap that could happen in one-click loaners. If a user neglected to pass in --flavor, this meant that instead of a nice error message out of mochitest, they'd get a cryptic traceback. With this fix, it will be obvious that the problem is "no tests were found". MozReview-Commit-ID: 5LEQFVDoJrT
f4c341352fad7b69368cdca672f3dc37572f06bd: Bug 1336214 - Preserve stacktraces in Marionette errors; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Fri, 10 Feb 2017 18:36:52 +0000 - rev 371765
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1336214 - Preserve stacktraces in Marionette errors; r=maja_zf Since bug 1326534 we have discarded the original stacktrace from errors originating inside Marionette. This was due to faulty logic when attempting to generate a new stacktrace when it was missing from a propagated error. This change simplifies WebDriver errors by making use of Error inheritance. The WebDriver error specific functions error.toJson and error.fromJson has additionally been moved to WebDriverError. MozReview-Commit-ID: C3Ns0H01LyG
eba41ae5c5bf483bc6ce2b7ac9d9b2b24dd9ab98: Bug 1336214 - Use static lookup of errors; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Fri, 10 Feb 2017 18:33:37 +0000 - rev 371764
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1336214 - Use static lookup of errors; r=maja_zf To avoid errors from being needlessly constructed on starting the Marionette server, this changes testing/marionette/error.js to use a static lookup table for error status codes. This also provides some added security since individual custom errors may have specific constructor logic that would cause an error to throw an error if the correct arguments were not provided, and we cannot guarantee that we provide the right ones generically when loading in the error module. MozReview-Commit-ID: 1sejpNzsjJp
af9a91862c82bc672bc4ad55a8e9deab5a5659ce: Bug 1336214 - Remove duplicate error.wrap; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Thu, 09 Feb 2017 19:28:30 +0000 - rev 371763
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1336214 - Remove duplicate error.wrap; r=maja_zf MozReview-Commit-ID: KC6ByTiyhre
5a01a4abbd7e0cc62854a61fbc899d9a00877984: Bug 1319237 - Fix calls to session.find; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Fri, 03 Feb 2017 16:32:16 +0000 - rev 371546
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1319237 - Fix calls to session.find; r=maja_zf MozReview-Commit-ID: 5afoA6aKgCV
5cfe97b8816376530ba3ce4c71f0b8b00941b638: Bug 1319237 - Disable WebDriver navigation to file: protocol test; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Fri, 03 Feb 2017 16:31:57 +0000 - rev 371545
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1319237 - Disable WebDriver navigation to file: protocol test; r=maja_zf MozReview-Commit-ID: 3SlvHmggRET
c9e7feb55b9af20f9a8ad96514e4964d7f5d5bad: Bug 1319237 - Enable WebDriver context test; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Fri, 03 Feb 2017 16:31:19 +0000 - rev 371544
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1319237 - Enable WebDriver context test; r=maja_zf MozReview-Commit-ID: EQZHO6npFtH
c460127ccb63136cb066e961cd70713f843c5c0f: Bug 1319237 - Avoid reposition waiting if position is unchanged; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Thu, 02 Feb 2017 14:58:36 +0000 - rev 371543
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1319237 - Avoid reposition waiting if position is unchanged; r=maja_zf When the requested window position is the same as the current position, we should avoid the wait condition. MozReview-Commit-ID: 3koG5BeOkFC
eb9c22a9b7076f39af3f3ef95bf65beaefe1daef: Bug 1319237 - Improve window position test assertions; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Thu, 02 Feb 2017 14:57:19 +0000 - rev 371542
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1319237 - Improve window position test assertions; r=maja_zf MozReview-Commit-ID: qmFS0JEqx3
b37ea97fa14d226fe05c6c4a813fc3bc9565e774: Bug 1319237 - Make GeckoDriver#setWindowSize synchronous; r=automatedtester,maja_zf
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:44:22 +0100 - rev 371540
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1319237 - Make GeckoDriver#setWindowSize synchronous; r=automatedtester,maja_zf Return from the Set Window Size command only after the window resize DOM event has occurred. MozReview-Commit-ID: 7ygZuNJZzq2
c3e0436c49edcd6c60da85b3ec3c3d4a33058faa: Bug 1319237 - Generalise wait condition utility; r=automatedtester,maja_zf
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:41:20 +0100 - rev 371538
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1319237 - Generalise wait condition utility; r=automatedtester,maja_zf This makes the `implicitWaitFor` utility from testing/marionette/element.js generally available in Marionette. It improves on the design of the old wait utility by providing promise-like resolve and reject options to the evaluated function. These can be used to indicate success or failure of waiting. If resolved, the provided value is returned immediately. When rejected, the function is evaluated over again until the timeout is reached or an error is thrown. It is useful to indicate success and failure state because it saves the calling code from guessing based on the return value. Guessing from the return value can be problematic since there are certain types and values in JavaScript that are ambigeous or misleading, such as the fact that empty arrays are evaluated as a truthy value. MozReview-Commit-ID: G8F99tdbiNb
be39185b68b08eb5037fc592ba99f769dfb67089: Bug 1322383 - Update Puppeteer and firefox-ui tests for valid window checks. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Tue, 07 Feb 2017 11:16:55 +0100 - rev 370675
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1322383 - Update Puppeteer and firefox-ui tests for valid window checks. r=maja_zf We have to ensure to switch to the current browser window after closing all the windows in tearDown. MozReview-Commit-ID: 3sYwmbew43d
f5e6da82e68df1d6b2d4912b7425de7c37717efb: Bug 1322383 - getCurrentWindow() has to only return the currently selected window. r=ato,maja_zf
Henrik Skupin <mail@hskupin.info> - Wed, 08 Feb 2017 12:58:45 +0100 - rev 370674
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1322383 - getCurrentWindow() has to only return the currently selected window. r=ato,maja_zf Given that this method will be used in each command for checks of a valid window, we have to return the currently active window. It means the window mediator should only be used during setting up the session to find the first browser window. At the same time the code in this method is getting split-up for chrome and content scopes. MozReview-Commit-ID: KyzxYk63RgA
93b5ddfa8698431ba6a229e66782150bc681d5ba: Bug 1322862 - Wait for forward- and back commands to complete; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Thu, 02 Feb 2017 14:08:52 +0000 - rev 369980
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1322862 - Wait for forward- and back commands to complete; r=maja_zf The Back and Forward commands are meant to be synchronous and this works around the problem of intermittents on slow try machines until bug 1330348 is fixed. For some reason, the preceding patches make script evaluation quicker and makes navigating back and forward less racy. MozReview-Commit-ID: GRcgMp1Rc6N
c4441c1492fd729592539121f7400e565e53b75e: Bug 1336124 - Only delete session if one exists when testing capabilities; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Fri, 03 Feb 2017 16:53:31 +0000 - rev 369977
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1336124 - Only delete session if one exists when testing capabilities; r=maja_zf MozReview-Commit-ID: IEqHzADUQow
6d17a85df7e32778362ba54466d1a4a224f645b8: Bug 1336124 - Return error when there is no session; r=maja_zf
Andreas Tolfsen <ato@mozilla.com> - Thu, 02 Feb 2017 16:15:31 +0000 - rev 369976
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1336124 - Return error when there is no session; r=maja_zf Returns an invalid session id error when there is no current session and the requested command is not newSession. MozReview-Commit-ID: Dnu2PXDmeaG