searching for reviewer(emilio)
bee2a7a54c04e45c5d96135fda975cd7908cf9b0: servo: Merge #15816 - Improve performance of layout queries and requestAnimationFrame (from servo:raf-timer); r=jdm,emilio
Patrick Walton <pcwalton@mimiga.net> - Sun, 05 Mar 2017 05:14:45 -0800 - rev 374970
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15816 - Improve performance of layout queries and requestAnimationFrame (from servo:raf-timer); r=jdm,emilio Part of #14442. Source-Repo: https://github.com/servo/servo Source-Revision: 72fd27bbccf9214cee11c78834ca1fbc96b3bf22
4a2a58be8c6c54dbf85b90aa85e4d4281e72088f: Bug 1338921 - Handle lazy frame construction in the regular post-servo pass. r=emilio
Bobby Holley <bobbyholley@gmail.com> - Mon, 27 Feb 2017 19:06:07 -0800 - rev 374939
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1338921 - Handle lazy frame construction in the regular post-servo pass. r=emilio MozReview-Commit-ID: FSXKAiyZDzt
a57ff8701dc2a1132e404cf4c56a571eb1713c6d: Bug 1338921 - Collect and coalesce adjacent siblings for lazy frame construction. r=emilio
Bobby Holley <bobbyholley@gmail.com> - Thu, 02 Mar 2017 22:51:39 -0800 - rev 374938
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1338921 - Collect and coalesce adjacent siblings for lazy frame construction. r=emilio
b866630a4183b38c2c234508b1ca3b80f51d8595: Bug 1340277. Fix stylo to properly update styles on the anonymous scrolled-content frame inside a scrollframe. r=emilio
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 03 Mar 2017 16:16:11 -0500 - rev 374935
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340277. Fix stylo to properly update styles on the anonymous scrolled-content frame inside a scrollframe. r=emilio MozReview-Commit-ID: DE4C6pIp8SC
a1a760aee967f10e29592efe0ce8de63a12a3c28: Bug 1343771. Fix stylo to properly update styles on the anonymous block inside a table cell. r=emilio
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 03 Mar 2017 16:14:39 -0500 - rev 374934
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1343771. Fix stylo to properly update styles on the anonymous block inside a table cell. r=emilio MozReview-Commit-ID: 8LnPTKVxxVc
53a53f671871e4d7a854bd2c9d04471dd307b533: Bug 1337696. Fix change hint computation for table-outer frames to be more correct. r=emilio
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 03 Mar 2017 15:54:47 -0500 - rev 374933
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1337696. Fix change hint computation for table-outer frames to be more correct. r=emilio MozReview-Commit-ID: LgRmTlWsM6o
8335b277da3fb5c8407d694d87203830e2475bc4: Bug 1340723 part 3. Fix stylo to properly update styles on the anonymous blocks we create in a block-inside-inline situation when the style of the inline changes. r=emilio
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 03 Mar 2017 15:45:40 -0500 - rev 374932
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340723 part 3. Fix stylo to properly update styles on the anonymous blocks we create in a block-inside-inline situation when the style of the inline changes. r=emilio MozReview-Commit-ID: JYz6g1ZJInT
f6370635b0906d84ac6880139ceb05dedc08bae1: Bug 1340723 part 2. Call the new UpdateStyleOnOwnedAnonBoxes function as needed from ServoRestyleManager. r=emilio
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 03 Mar 2017 15:44:48 -0500 - rev 374931
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340723 part 2. Call the new UpdateStyleOnOwnedAnonBoxes function as needed from ServoRestyleManager. r=emilio MozReview-Commit-ID: 5nrv8x7CEtN
130e62d8966352e4883af609347316e5d57d704a: Bug 1340723 part 1. Add an nsIFrame function that can be called from the stylo restyle manager to update style contexts on anonymous boxes associated with that frame, and a frame state bit that can be used to optimize out the virtual calls. r=emilio
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 03 Mar 2017 15:44:24 -0500 - rev 374930
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340723 part 1. Add an nsIFrame function that can be called from the stylo restyle manager to update style contexts on anonymous boxes associated with that frame, and a frame state bit that can be used to optimize out the virtual calls. r=emilio MozReview-Commit-ID: 2niUdJPSXKa
6fcffb34361d5f7e8a912d291f1d2893e2921cd5: servo: Merge #15809 - stylo: Backport rust-nsstring crash fixes to the vendored version (from emilio:nsstuff); r=emilio
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 03 Mar 2017 09:15:15 -0800 - rev 374898
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15809 - stylo: Backport rust-nsstring crash fixes to the vendored version (from emilio:nsstuff); r=emilio Source-Repo: https://github.com/servo/servo Source-Revision: c32181c6dbd611c351b1434118739040ec7307b9
6feb133d8c38e90a3a3e947acc86308fc53ab3a7: servo: Merge #15793 - Fix animation shorthand parsing (from upsuper:animation); r=emilio,bholley
Xidorn Quan <me@upsuper.org> - Fri, 03 Mar 2017 03:28:21 -0800 - rev 374875
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15793 - Fix animation shorthand parsing (from upsuper:animation); r=emilio,bholley which is somehow broken after #15779. But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec. I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested. Source-Repo: https://github.com/servo/servo Source-Revision: 7cd4c69c40f90b2db6371bff27cfbd70fb045f5d
bcf89da3a9c0b30fbcec4a3ac7c8e1ba7fa8c7cd: Bug 1343030 - Modify stylo reftest assert expectations for image-object-position-with-background-1.html; r=emilio
Geoff Brown <gbrown@mozilla.com> - Fri, 03 Mar 2017 09:18:56 -0700 - rev 374847
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1343030 - Modify stylo reftest assert expectations for image-object-position-with-background-1.html; r=emilio
9fbb6524544f306147501fb9e6f6379db3bd69df: servo: Merge #15768 - Trigger reflow on document.elementsFromPoint (from ferjm:issue-15592-document-elementsFromPoint); r=emilio
Fernando Jiménez Moreno <ferjmoreno@gmail.com> - Thu, 02 Mar 2017 11:43:17 -0800 - rev 374683
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15768 - Trigger reflow on document.elementsFromPoint (from ferjm:issue-15592-document-elementsFromPoint); r=emilio As [suggested](https://github.com/servo/servo/issues/15592#issuecomment-280379805) by @jdm `Document::nodes_from_point` now triggers a reflow. I added a new reftest that panics with `ERROR:servo: Tried to hit test without a DisplayList` if this patch is not applied. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15592. - [X] There are tests for these changes Source-Repo: https://github.com/servo/servo Source-Revision: fa32d50c7a2fc9cb29c7245dc45a46ed68551601
1029e1a5b03d2d1a81f11c1a8d2720be7ee4b3bd: Bug 1343362 - Allow restyle hints to be posted during change hint handling. r=emilio
Bobby Holley <bobbyholley@gmail.com> - Wed, 01 Mar 2017 18:07:14 -0800 - rev 374533
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1343362 - Allow restyle hints to be posted during change hint handling. r=emilio MozReview-Commit-ID: 6ZU24tLQCjV
1a3de0af9d95b3f3b8b0711c718fd175d8d7c83a: servo: Merge #15779 - Don't serialize shorthand if some but not all its longhands have CSS-wide keyword (from upsuper:shorthand); r=emilio
Xidorn Quan <me@upsuper.org> - Wed, 01 Mar 2017 16:12:36 -0800 - rev 374515
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15779 - Don't serialize shorthand if some but not all its longhands have CSS-wide keyword (from upsuper:shorthand); r=emilio This also changes `LonghandsToSerialize` to store references to specified value directly rather than declared value, which significantly simplify many serialization code. Source-Repo: https://github.com/servo/servo Source-Revision: c87524c8888d9c4a1f1eaedb5e3a29886f627697
01131dccb20c5228b2826356ae6ed1c7d479a40a: servo: Merge #15416 - Fix border shorthand serialization (from karlding:servo-15395_border_serialization); r=emilio
Karl <karlding@users.noreply.github.com> - Wed, 01 Mar 2017 09:50:49 -0800 - rev 374471
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15416 - Fix border shorthand serialization (from karlding:servo-15395_border_serialization); r=emilio Fix border shorthand serialization when sides are not identical. I think I managed to get the serialization to work as expected. I added a check to ensure that the **border-width**, **border-style** and **border-color** were the same, before performing the serialization. I'm still a Rust newbie, so if there's a more idiomatic way of doing things (or any critiques in general), please let me know! --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15395 <!-- Either: --> - [X] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: f0257364c26ef89e7652eabe73a3788388adf5ca
a79c630604eb88f8c98087cbead0d02008035be7: Bug 1343388 - Assert against the servo traversal when serializing gecko declarations. r=emilio
Bobby Holley <bobbyholley@gmail.com> - Tue, 28 Feb 2017 15:58:31 -0800 - rev 374231
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1343388 - Assert against the servo traversal when serializing gecko declarations. r=emilio MozReview-Commit-ID: LnYYbx742X1
042624a21b86862645c2bf4fc131c54cef43dd5c: Bug 1343388 - Assert against the servo traversal when analyzing visited-link style contexts. r=emilio
Bobby Holley <bobbyholley@gmail.com> - Tue, 28 Feb 2017 15:32:33 -0800 - rev 374230
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1343388 - Assert against the servo traversal when analyzing visited-link style contexts. r=emilio MozReview-Commit-ID: 1SJlS4PwBoy
2d3c0b4c3e4a91b549c71d87711449fae0133a5e: Bug 1343388 - Use threadsafe style struct accessor in assertion. r=emilio
Bobby Holley <bobbyholley@gmail.com> - Tue, 28 Feb 2017 15:25:13 -0800 - rev 374229
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1343388 - Use threadsafe style struct accessor in assertion. r=emilio MozReview-Commit-ID: 5DdcKgyADbE
5b8c22b505a48f78764e22ae720b9bda07853b33: Bug 1343388 - Don't write to undisplayed contents map cache during servo traversal. r=emilio
Bobby Holley <bobbyholley@gmail.com> - Tue, 28 Feb 2017 15:23:56 -0800 - rev 374228
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1343388 - Don't write to undisplayed contents map cache during servo traversal. r=emilio MozReview-Commit-ID: 732bV0X80Gk
086f36cc278fe6f6cd4fa023dcda4b31950f1d5b: Bug 1343128 - Don't leave stale change hints and other restyle data hanging around in reconstructed subtrees. r=emilio
Bobby Holley <bobbyholley@gmail.com> - Mon, 27 Feb 2017 18:29:28 -0800 - rev 374223
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1343128 - Don't leave stale change hints and other restyle data hanging around in reconstructed subtrees. r=emilio MozReview-Commit-ID: 4BIvC6lPUmF
4dffb174c94d3f999a7fd2be303ba5f6c0be5058: servo: Merge #15464 - Support lang pseudo class (from KiChjang:pseudo-lang); r=emilio
Keith Yeung <kungfukeith11@gmail.com> - Mon, 27 Feb 2017 17:21:50 -0800 - rev 374144
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15464 - Support lang pseudo class (from KiChjang:pseudo-lang); r=emilio Fixes #8219. Source-Repo: https://github.com/servo/servo Source-Revision: 4b394312153c56812113c149df77a313939de30f
0260913ef653610e3b5183c037512b99423cd898: servo: Merge #15747 - Fix wrong index for missing properties in keyframes (from hiikezoe:fix-wrong-index-in-keyframe); r=emilio
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 27 Feb 2017 02:28:55 -0800 - rev 374036
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15747 - Fix wrong index for missing properties in keyframes (from hiikezoe:fix-wrong-index-in-keyframe); r=emilio <!-- Please describe your changes on the following line: --> This is PR of https://bugzilla.mozilla.org/show_bug.cgi?id=1342323 , reviewed by @emilio. Thank you Emilio! --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because it's for stylo. I think we have test cases for this in gecko tree. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 29e3347242c6cc6e23babce15fe0aceae4259a04
4feeec9a52e9dba80e1f77bc27f43d5f0a6cd752: servo: Merge #15743 - Update ws to 0.6 (from nox:ws); r=emilio
Anthony Ramine <n.oxyde@gmail.com> - Sun, 26 Feb 2017 06:26:05 -0800 - rev 374001
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15743 - Update ws to 0.6 (from nox:ws); r=emilio This is exactly the same as 0.5.4, but without a semver violation. Source-Repo: https://github.com/servo/servo Source-Revision: 7ab1ef887c70a398db1f64486cb09c01e01f9e2c
6fec46f1729153a0e230f4dac07ba776eebe6102: servo: Merge #15735 - Update cssparser to 0.11 (from servo:cssparserup); r=emilio
Simon Sapin <simon.sapin@exyr.org> - Sun, 26 Feb 2017 02:19:32 -0800 - rev 373986
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15735 - Update cssparser to 0.11 (from servo:cssparserup); r=emilio <!-- Please describe your changes on the following line: --> <s>Depends on https://github.com/servo/rust-cssparser/pull/122.</s> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 94e563e4d9292d7b19ce061e070cda358e822172
b02bd54b83e26bb80755b67acb493c5567afa022: servo: Merge #15710 - Implement gecko glue for clip property (from canaltinova:clip); r=emilio
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 24 Feb 2017 07:44:48 -0800 - rev 373765
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15710 - Implement gecko glue for clip property (from canaltinova:clip); r=emilio <!-- Please describe your changes on the following line: --> Implemented gecko glue for clip property. Clip property looks slightly different in gecko. `auto` top and left values are preserved as auto in [gecko](http://searchfox.org/mozilla-central/rev/39e4b25a076c59d2e7820297d62319f167871449/layout/style/nsRuleNode.cpp#10294,10316) but converted to 0 in [servo](https://dxr.mozilla.org/servo/rev/65624dbfc28442b58145215f524eb13aeb2cadf6/components/style/values/specified/mod.rs#942). Gecko is setting `NS_STYLE_CLIP_TOP_AUTO` and `NS_STYLE_CLIP_LEFT_AUTO` flags with that information. But I tried this property in stylo build and it is working correctly like this. It looks like it doesn't change the outcome of the property. ~Do we really need to set these flags?~ Manishearth and bz said that auto and 0 values are same. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [Bug 1341728](https://bugzilla.mozilla.org/show_bug.cgi?id=1341728) <!-- Either: --> - [X] These changes do not require tests because this is stylo side change. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 050d9d909749f5d549b4dfdf69690bd1b5486836
6b8aba91bf73cfc89e21ef402b25dca5fa469ceb: servo: Merge #15696 - Do not pool HTTP connections (from jdm:no-http-pool); r=emilio
Josh Matthews <josh@joshmatthews.net> - Thu, 23 Feb 2017 03:55:45 -0800 - rev 373521
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15696 - Do not pool HTTP connections (from jdm:no-http-pool); r=emilio HTTP connection pooling triggers consistent failures in #14620. Let's disable it until there's more time to solve the underlying problem in #15694. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes Source-Repo: https://github.com/servo/servo Source-Revision: a780f6f28cf5d0f4faa7ad84822692d9bab1d031
d47255dae628cd97b6262f9b36b63abf6b8f8eeb: servo: Merge #14962 - Remove network requests from image cache thread (from jdm:image_script_load); r=Ms2ger,glennw,emilio
Josh Matthews <josh@joshmatthews.net> - Wed, 22 Feb 2017 17:50:48 -0800 - rev 373375
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #14962 - Remove network requests from image cache thread (from jdm:image_script_load); r=Ms2ger,glennw,emilio The design of initiating network requests from the image cache thread was simple, but it makes it difficult to implement image loading that conforms to the HTML specification. These changes make the implementation of HTMLImageElement responsible for network requests for `<img>` elements, and CSS-based images (background-image, bullets, etc.) are requested by the script thread to ensure that the layout thread does not attempt to retain unsafe pointers to DOM nodes during asynchronous operations. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #7708 - [X] There are tests for these changes Source-Repo: https://github.com/servo/servo Source-Revision: 854d720b21dda68034233a25385c4f2564a4a2d5
2e2093189f5549660f99d09e0d5519865a2ede4f: servo: Merge #15458 - Update heartbeats-simple dependencies for bug fixes (from connorimes:hbs-0.4); r=emilio
Connor Imes <connor.k.imes@gmail.com> - Wed, 22 Feb 2017 09:05:37 -0800 - rev 373343
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15458 - Update heartbeats-simple dependencies for bug fixes (from connorimes:hbs-0.4); r=emilio <!-- Please describe your changes on the following line: --> Updates heartbeats-simple dependencies for some bug fixes in native code (primarily for Windows). Now we create heartbeats as needed so we don't have to maintain a hardcoded list which keeps getting out of sync. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15471 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because it updates a dependency and performs some code maintenance. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 2bfea912dccd5e76e062143f3d48d2a66118fc59
887ae49f0e2fa2a26b2215348bc25932d0590851: servo: Merge #15683 - Fill missing property in keyframe (from hiikezoe:fill-missing-property-in-keyframe); r=emilio
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 22 Feb 2017 08:17:18 -0800 - rev 373294
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15683 - Fill missing property in keyframe (from hiikezoe:fill-missing-property-in-keyframe); r=emilio <!-- Please describe your changes on the following line: --> This is a PR of https://bugzilla.mozilla.org/show_bug.cgi?id=1340961 All patches has been reviewed by @emilio. Thanks! --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 4f7e422054237c8ba0a8e521a615a6012b90eab4
b6384caa73402e382f3fa9471a67c866b68c7b26: servo: Merge #15656 - Add more public crates to libservo (from servo:pub-crate); r=emilio
Ms2ger <Ms2ger@gmail.com> - Mon, 20 Feb 2017 03:20:26 -0800 - rev 372894
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15656 - Add more public crates to libservo (from servo:pub-crate); r=emilio Fixes #15640. Source-Repo: https://github.com/servo/servo Source-Revision: a1e4c547f042bf74c638fdff4b3faacf0b96558d
7b8628e541b608ae2395791fc8dcfec6f2a931fe: servo: Merge #15629 - stylo: Destroy static Variables struct on shutdown (from heycam:variables-leak); r=bholley,emilio
Cameron McCormack <cam@mcc.id.au> - Sun, 19 Feb 2017 21:12:57 -0800 - rev 372786
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15629 - stylo: Destroy static Variables struct on shutdown (from heycam:variables-leak); r=bholley,emilio Fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1340457. r? @emilio Source-Repo: https://github.com/servo/servo Source-Revision: 58aa6ce7aedfe93df7154e84676a52905f1709f5
4e75e0178a87a3f059193cc0a3abb5af92669fbb: Bug 1338936 - Part 4: stylo: Update reftest results; r=emilio
Manish Goregaokar <manishearth@gmail.com> - Sun, 12 Feb 2017 16:02:29 -0800 - rev 372770
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1338936 - Part 4: stylo: Update reftest results; r=emilio MozReview-Commit-ID: 6wg32flypt7
7f7bb42ecf53893497e0d098c55dcd0c6b564d1a: Bug 1338936 - Part 3: stylo: Support lang property; r=emilio
Nazım Can Altınova <canaltinova@gmail.com> - Sun, 12 Feb 2017 16:02:29 -0800 - rev 372769
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1338936 - Part 3: stylo: Support lang property; r=emilio MozReview-Commit-ID: 6wg32flypt7
28d72f228244590ced658878c5ac42a7a7ee6aea: Bug 1338936 - Part 2: stylo: Add necessary stubbed-out bindings for ServoSpecifiedValues; r=bz,emilio
Manish Goregaokar <manishearth@gmail.com> - Sun, 12 Feb 2017 16:02:29 -0800 - rev 372768
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1338936 - Part 2: stylo: Add necessary stubbed-out bindings for ServoSpecifiedValues; r=bz,emilio MozReview-Commit-ID: 6wg32flypt7
a0c56ecc911127591ea25904486bfa019836f0c2: Bug 1338936 - Part 1: stylo: Add stubbed-out ServoSpecifiedValues interface, use it for pres attr mapping; r=bz,emilio
Manish Goregaokar <manishearth@gmail.com> - Sun, 12 Feb 2017 16:02:29 -0800 - rev 372767
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1338936 - Part 1: stylo: Add stubbed-out ServoSpecifiedValues interface, use it for pres attr mapping; r=bz,emilio MozReview-Commit-ID: 6wg32flypt7
2d887234705f65d86a6f2b4e7780c14e7aca7dd4: Bug 1338936 - Part 4: stylo: Update reftest results; r=emilio
Manish Goregaokar <manishearth@gmail.com> - Sun, 12 Feb 2017 16:02:29 -0800 - rev 372748
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1338936 - Part 4: stylo: Update reftest results; r=emilio MozReview-Commit-ID: 6wg32flypt7
38de3820ca8102fa5fc2ae02d0605237e287cac2: Bug 1338936 - Part 3: stylo: Support lang property; r=emilio
Nazım Can Altınova <canaltinova@gmail.com> - Sun, 12 Feb 2017 16:02:29 -0800 - rev 372747
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1338936 - Part 3: stylo: Support lang property; r=emilio MozReview-Commit-ID: 6wg32flypt7
7d7457d5ca8a83e6279ffa278d98bb170f1ddbc4: Bug 1338936 - Part 2: stylo: Add necessary stubbed-out bindings for ServoSpecifiedValues; r=bz,emilio
Manish Goregaokar <manishearth@gmail.com> - Sun, 12 Feb 2017 16:02:29 -0800 - rev 372746
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1338936 - Part 2: stylo: Add necessary stubbed-out bindings for ServoSpecifiedValues; r=bz,emilio MozReview-Commit-ID: 6wg32flypt7
7943ca5e483ab2865df343e0529d5217c3aced1b: Bug 1338936 - Part 1: stylo: Add stubbed-out ServoSpecifiedValues interface, use it for pres attr mapping; r=bz,emilio
Manish Goregaokar <manishearth@gmail.com> - Sun, 12 Feb 2017 16:02:29 -0800 - rev 372745
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1338936 - Part 1: stylo: Add stubbed-out ServoSpecifiedValues interface, use it for pres attr mapping; r=bz,emilio MozReview-Commit-ID: 6wg32flypt7
fcccffa68c9df87a4c35cc8232cd01b2f2c2fb07: servo: Merge #15644 - stylo: Support all presentation attributes (from Manishearth:stylo-abstract); r=emilio,bz
Nazım Can Altınova <canaltinova@gmail.com> - Sat, 18 Feb 2017 20:43:33 -0800 - rev 372744
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15644 - stylo: Support all presentation attributes (from Manishearth:stylo-abstract); r=emilio,bz From https://bugzilla.mozilla.org/show_bug.cgi?id=1338936 r=emilio,bz Source-Repo: https://github.com/servo/servo Source-Revision: 4d82d4e68e1f1954f4fbdd823a92c8b533a49022
c69baa105d70a30dd408e4758a07c4bfc83e8284: Bug 1324661 part 2. Reenable various table reftests that were disabled before. They all seem to be passing, or at least failing for unrelated reasons, with the part 1 patch applied. r=bholley,emilio
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 17 Feb 2017 15:06:14 -0500 - rev 372678
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1324661 part 2. Reenable various table reftests that were disabled before. They all seem to be passing, or at least failing for unrelated reasons, with the part 1 patch applied. r=bholley,emilio MozReview-Commit-ID: 24VFWXJJE4E
a300522006bc5e93e841e0132fa940874180afcd: Bug 1324661 part 1. When recreating style contexts for elements in stylo, use the right frame (not the primary frame!) for tables. r=bholley,emilio
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 17 Feb 2017 14:52:39 -0500 - rev 372677
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1324661 part 1. When recreating style contexts for elements in stylo, use the right frame (not the primary frame!) for tables. r=bholley,emilio For a table, the primary frame is the table wrapper anonymous box. That anonymous box inherits style from its _child_ table frame, which is the frame that has the actual style for the element. So we want to use the stylo-computed style for the table frame, and then compute an updated style for the table wrapper too, because some things (like absolute positioning) are done for the table wrapper anonymous box, not the table frame.
fd6b2015612733fc57c92b7e6bcc8cbdf23fe81a: Bug 1340022 - Implement "handled for descendants" tracking for RestyleDamage. r=emilio
Bobby Holley <bobbyholley@gmail.com> - Wed, 15 Feb 2017 19:36:57 -0800 - rev 372671
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1340022 - Implement "handled for descendants" tracking for RestyleDamage. r=emilio MozReview-Commit-ID: Bbk99ogILXC
828693e934905658534c303275559339c678cf54: servo: Merge #15599 - Implement "handled for descendants" tracking for RestyleDamage (from bholley:damage_handled); r=emilio
Bobby Holley <bobbyholley@gmail.com> - Fri, 17 Feb 2017 10:20:44 -0800 - rev 372670
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15599 - Implement "handled for descendants" tracking for RestyleDamage (from bholley:damage_handled); r=emilio Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1340022 Source-Repo: https://github.com/servo/servo Source-Revision: eb916f290334f9f56c4c8680e25224a16e4c7d59
b9caaf6c527f403bccab14ddfc47710327f85e27: servo: Merge #15557 - stylo: various fixes to improve style logging in opt builds (from bholley:opt_logging); r=emilio
Bobby Holley <bobbyholley@gmail.com> - Wed, 15 Feb 2017 03:05:07 -0800 - rev 372390
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15557 - stylo: various fixes to improve style logging in opt builds (from bholley:opt_logging); r=emilio This adds a traversal time entry to the style statistics, and switches to warn! as discussed in [1]. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1339176 Source-Repo: https://github.com/servo/servo Source-Revision: 715a16423095e1bba2c192c0aebecb8f6aaffab3
6925f5382ca01f7759aee367456fbcde8ca39311: servo: Merge #15539 - Add rejection of out-of-range values for single-timing-functions (from AdmiralCoco:reject_outofrange_transition_values); r=emilio
Dawing Cho <dawingc@hotmail.com> - Tue, 14 Feb 2017 19:25:49 -0800 - rev 372388
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15539 - Add rejection of out-of-range values for single-timing-functions (from AdmiralCoco:reject_outofrange_transition_values); r=emilio <!-- Please describe your changes on the following line: --> This PR fixes #15344, checking for the `cubic-bezier p1x/p2x` and `steps` first value after parsing. There are unit tests that check for parsing of invalid values - I was not sure if there was a more suitable place, so I created a file (name subject to change). Q: I found this [test suite](https://github.com/servo/servo/blob/master/tests/unit/style/properties/serialization.rs#L592), and noticed that the `p2x` value is out of range, but the test does not fail - is this because there is no check when calling the function itself? Thanks! --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15344 <!-- Either: --> - [X] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: f3bacf84f47e12ef50cfd8ddd0aad613fe7e2a05
765539a9bec11822f7888d9de027d46b5fa49c3b: servo: Merge #15534 - style: add missing semicolons for bindgen on BSDs and Solaris (from jbeich:freebsd); r=emilio
Jan Beich <jbeich@FreeBSD.org> - Mon, 13 Feb 2017 10:08:24 -0800 - rev 372375
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15534 - style: add missing semicolons for bindgen on BSDs and Solaris (from jbeich:freebsd); r=emilio - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [x] These changes fix a typo in #15529 - [x] These changes do not require tests because Tier3 support is incomplete Source-Repo: https://github.com/servo/servo Source-Revision: 1b399cd27ff902d70c4ea0893c7dd31a5a32f0e5
33bd44c0e8db44ae90e2e38eac592a6e184566b9: servo: Merge #15529 - style: unbreak bindgen on BSDs and Solaris (from jbeich:freebsd); r=emilio
Jan Beich <jbeich@FreeBSD.org> - Mon, 13 Feb 2017 06:09:03 -0800 - rev 372374
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15529 - style: unbreak bindgen on BSDs and Solaris (from jbeich:freebsd); r=emilio <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [x] These changes fix Firefox [bug 1339033](https://bugzilla.mozilla.org/show_bug.cgi?id=1339033) <!-- Either: --> - [x] These changes do not require tests because Tier3 platforms support is incomplete <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 5d8870fda9702ed552f7b11f5f772647aa7a6ce1
2b147f3dcae89e547ce05bae480389eed1aa45f6: servo: Merge #15514 - fix #15492 (Negative ShapeRadius values should be invalid) (from alon:master); r=emilio
Alon Levy <alon@pobox.com> - Sun, 12 Feb 2017 03:15:36 -0800 - rev 372194
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #15514 - fix #15492 (Negative ShapeRadius values should be invalid) (from alon:master); r=emilio <!-- Please describe your changes on the following line: --> Address issue #15492 - Negative value in <shape-radius> should be invalid --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15492 (github issue number if applicable). - [X] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 45db39cc0406a90273a5a74738fe94943a57b142