Bug 1352380 - Make sure gradient stops have ordered mPosition variables. r=dbaron a=lizzard MozReview-Commit-ID: DsP5Q6qmvH2

Bug 1348596 - Back out incorrectly-landed (and unreviewed) change to ContinueTextRunAcrossFrames that was mistakenly pushed. r=dbaron a=gchang

Bug 1344628 - Remove RecalculateRowIndex() and combine its functionality with ResetRowIndices(). r=dbaron a=gchang MozReview-Commit-ID: BokshmpqH7N

Bug 1300355 - Part 2: Don't track use counts in the reftest harness when the cache is disabled. r=dbaron

Bug 1300355 - Part 1: Increase frequency of GC/CC during reftests. r=dbaron

Bug 1285874 - Maintain a map of removed table-rows and use it to lazily recalculate row indices. r=dbaron MozReview-Commit-ID: Jt6QJTp0YGe

Bug 1337940 - Part 3 - Restrict the amount of session history we keep around during test_parse_rule. r=dbaron During its run this test amasses a considerable collection of session history. Because the page title never changes, though, the Android session store previously never attempted to capture the state here. As of this bug this has changed and history change events now (correctly) trigger a session store data update on Android as well. On a debug build running on the Android emulator however, collecting the session history data can take up to 1 s when the session history count approaches the default "browser.sessionhistory.max_entries" limit of 50 entries, which increases the total running time of this test considerably and leads to timeouts (although only just). Bug 1341810 will track possibly improving the session store performance on Android by not doing a full history collect when not needed, but for the time being, restricting the amount of session history we keep around during this test is the simpler solution. MozReview-Commit-ID: JRREidiWnM3

Bug 1326407 Part 8 - Implement shape-outside: inset(). r=dbaron The reftests have passed layout/reftests/w3c-css/submitted/check-for-references.sh. MozReview-Commit-ID: JZk1fo8SxgV

Bug 1326407 Part 7 - Rename BoxShapeInfo to RoundedBoxShapeInfo. r=dbaron The radii has been cached in the BoxShapeInfo in the previous part. Hence the rename. This class will be used to implement inset() in the next part, so the rect stored isn't necessarily the rect of the <shape-box>. It could be the inset rectangle. Therefore I rename mShapeBoxRect to mRect to avoid any confusion. MozReview-Commit-ID: J0hpQDsbMyN

Bug 1326407 Part 6 - Cache the border radii in BoxShapeInfo. r=dbaron The radii can be computed when creating BoxShapeInfo. No need to compute them every time in the LineLeft() and LineRight(). MozReview-Commit-ID: GIDSLgickCT

Bug 1326407 Part 5 - Rename ConvertPhysicalToLogical(). r=dbaron Make the name and the order of arguments be consistent with the ConvertPhysicalToLogical() method added in the previous part. MozReview-Commit-ID: 1YARDzI3cyr

Bug 1326407 Part 4 - Extract a function to convert a rect to float manager's logical coordinate. r=dbaron MozReview-Commit-ID: Ag6V6XmlHIU

Bug 1326407 Part 3 - Extract a function to compute <shape-box> rect. r=dbaron MozReview-Commit-ID: HaiDqNgE25P

Bug 1326407 Part 2 - Extract a function to compute inset radii. r=dbaron MozReview-Commit-ID: 3XbfW40AJCI

Bug 1326407 Part 1 - Extract a function to compute inset rect. r=dbaron MozReview-Commit-ID: DmVOVArtzBZ

Bug 1313753 - Update overflow at the establisher of the 3D rendering context. r=dbaron

Bug 1292460 - Focus the reftest browser before starting tests, except when filtering out needs-focus tests. r=dbaron

Bug 1333685 - Eliminate CircleShapeInfo, and use EllipseShapeInfo for circle(). r=dbaron The difference between CircleShapeInfo's constructor and EllipseShapeInfo's is the computation of the radii. Therefore, this patch creates a factory function to distinguish that, so shape-outside: circle() could be implemented by using EllipseShapeInfo. MozReview-Commit-ID: 9ZBQu8zCSrM

Bug 1326406 Part 6 - Make CircleShapeInfo inherit from EllipseShapeInfo. r=dbaron MozReview-Commit-ID: H0UgT6P6c7K

Bug 1326406 Part 5 - Update document about float manager's coordinate space. r=dbaron MozReview-Commit-ID: LJVqs49CSqQ

Bug 1326406 Part 4 - Implement shape-outside: ellipse(). r=dbaron MozReview-Commit-ID: t1gaoKNbNp

Bug 1326406 Part 3 - Add ShapeInfo::Translate() for moving the origin of ShapeInfo. r=dbaron Instead of manually adding (aLineLeft, aBlockStart) when creating a shape, add Translate() to let the shapes implement their only way to move their origin. FloatInfo could then move the shapes after they're created. MozReview-Commit-ID: ApZBHnkng74

Bug 1326406 Part 2 - Extract the computation of ellipse radii as ComputeEllipseRadii(). r=dbaron MozReview-Commit-ID: LPdvg66adHQ

Bug 1326406 Part 1 - Fix indentation of </body> for the shapes1 reftests. r=dbaron MozReview-Commit-ID: 20vidQM09Jn

Bug 1313753 - Update overflow at the establisher of the 3D rendering context. r=dbaron a=jcristau

Bug 1292460 - Focus the reftest browser before starting tests, except when filtering out needs-focus tests. r=dbaron, a=test-only

Bug 1331846 - Exclude the lines which have "include" appeared in the middle. r=dbaron Change "include" match rule from "^include" to "include " since there might be "skip-if" or other <failure-type> conditions before the "include". The single space after is added so that tests like "include.html" won't be excluded. DONTBUILD because this patch modifies a script checking for the validity of reftests, which is NPOTB. MozReview-Commit-ID: 3tFFIo8RKFp

Bug 1281424 followup, remove spec link from reference file. r=dbaron DONTBUILD

Bug 1311244 Part 7 - Implement shape-outside: circle(). r=dbaron circle() allows the user to define an empty flow area, so IsEmpty() needs to be overridden. The flow area defined by a shape needs to be clipped to the margin-box per https://drafts.csswg.org/css-shapes/#relation-to-box-model-and-float-behavior In the reftests, both clip-path and shape-outside uses the same value so that it's easier to debug visually. Add LogicalPoint::LineRelative() because we need to convert a point's I() to the line-axis in nsFloatManager. LineRelative() differs from I() in all 'rtl' direction per https://drafts.csswg.org/css-writing-modes-3/#logical-to-physical MozReview-Commit-ID: FxQaFPrEQ73

Bug 1311244 Part 6 - Add ShapeInfo and move <shape-box> impl to BoxShapeInfo. r=dbaron Create ShapeInfo as a base class for implementing all the shapes. In this design, we only need to create the correct subclass in FloatInfo's constructor whenever shape-outside is used rather than manually branching on StyleShapeSourceType and StyleBasicShape in all the methods like LineRight(), LineLeft(), etc. The concrete subclass of ShapeInfo could focus on implementing how its shape influence the flow area by overriding the needed methods in ShapeInfo. Move ComputeEllipseLineInterceptDiff() and XInterceptAtY() under the scope of ShapeInfo so that they could be used by BoxShapeInfo and all the other ShpapeInfo subclasses yet to come. MozReview-Commit-ID: ETVc5FdGNha

Bug 1311244 Part 5 - Convert FloatInfo's copy constructor into a move constructor. r=dbaron Use move constructor for two reasons. 1) The copy constructor is needed only when appending FloatInfo to mFloats, so using move constructor will likely be more efficient if some of the member variables support move constructor. 2) Part 6 will added a UniquePtr member to FloatInfo, so using move constructor becomes necessary. Also change the return value of AddFloat() to void to simplify the code, since all the other callers do not check the return value, and BlockReflowInput::FloatAndPlaceFloat() only asserts in debug mode. I assume it's safe to omit the OOM check. MozReview-Commit-ID: GVbbsdBjr7b

Bug 1311244 Part 4 - Extract the computation of circle radius as ComputeCircleRadius(). r=dbaron MozReview-Commit-ID: LJNvNOoc7FI

Bug 1311244 Part 3 - Extract the computation of center as ComputeCircleOrEllipseCenter(). r=dbaron MozReview-Commit-ID: A6OTJ9PD43c

Bug 1311244 Part 2 - Create ShapeUtils, and move EnumerationToLength into it. r=dbaron More functions in nsCSSClipPathInstance will be refactored and moved into ShapeUtils in subsequent patches. MozReview-Commit-ID: LmJUevY8YGr

Bug 1311244 Part 1 - Use nsPoint type for center in nsCSSClipPathInstance. r=dbaron |center| should be of nsPoint type since all the arguments of ComputeObjectAnchorPoint() uses nsPoint and nsSize. We should only convert center to Point (which is an an UnknownUnits type) for APIs requiring Point type. MozReview-Commit-ID: EDrQGPUZp6m

Bug 1311244 Part 0 - Preemptively fix unified build bustage in nsLayoutUtils. r=dbaron The is a preemptively fix for unified bustage after Part 2 adds a new file under layout/base/. The error was: In static member function 'static bool nsLayoutUtils::SupportsServoStyleBackend(nsIDocument*)': invalid static_cast from type 'nsIDocument*' to type 'nsDocument*' MozReview-Commit-ID: A8xTSPgh8Ls

Bug 1311244 Part 7 - Implement shape-outside: circle(). r=dbaron circle() allows the user to define an empty flow area, so IsEmpty() needs to be overridden. The flow area defined by a shape needs to be clipped to the margin-box per https://drafts.csswg.org/css-shapes/#relation-to-box-model-and-float-behavior In the reftests, both clip-path and shape-outside uses the same value so that it's easier to debug visually. Add LogicalPoint::LineRelative() because we need to convert a point's I() to the line-axis in nsFloatManager. LineRelative() differs from I() in all 'rtl' direction per https://drafts.csswg.org/css-writing-modes-3/#logical-to-physical MozReview-Commit-ID: FxQaFPrEQ73

Bug 1311244 Part 6 - Add ShapeInfo and move <shape-box> impl to BoxShapeInfo. r=dbaron Create ShapeInfo as a base class for implementing all the shapes. In this design, we only need to create the correct subclass in FloatInfo's constructor whenever shape-outside is used rather than manually branching on StyleShapeSourceType and StyleBasicShape in all the methods like LineRight(), LineLeft(), etc. The concrete subclass of ShapeInfo could focus on implementing how its shape influence the flow area by overriding the needed methods in ShapeInfo. Move ComputeEllipseLineInterceptDiff() and XInterceptAtY() under the scope of ShapeInfo so that they could be used by BoxShapeInfo and all the other ShpapeInfo subclasses yet to come. MozReview-Commit-ID: ETVc5FdGNha

Bug 1311244 Part 5 - Convert FloatInfo's copy constructor into a move constructor. r=dbaron Use move constructor for two reasons. 1) The copy constructor is needed only when appending FloatInfo to mFloats, so using move constructor will likely be more efficient if some of the member variables support move constructor. 2) Part 6 will added a UniquePtr member to FloatInfo, so using move constructor becomes necessary. Also change the return value of AddFloat() to void to simplify the code, since all the other callers do not check the return value, and BlockReflowInput::FloatAndPlaceFloat() only asserts in debug mode. I assume it's safe to omit the OOM check. MozReview-Commit-ID: GVbbsdBjr7b

Bug 1311244 Part 4 - Extract the computation of circle radius as ComputeCircleRadius(). r=dbaron MozReview-Commit-ID: LJNvNOoc7FI

Bug 1311244 Part 3 - Extract the computation of center as ComputeCircleOrEllipseCenter(). r=dbaron MozReview-Commit-ID: A6OTJ9PD43c

Bug 1311244 Part 2 - Create ShapeUtils, and move EnumerationToLength into it. r=dbaron More functions in nsCSSClipPathInstance will be refactored and moved into ShapeUtils in subsequent patches. MozReview-Commit-ID: LmJUevY8YGr

Bug 1311244 Part 1 - Use nsPoint type for center in nsCSSClipPathInstance. r=dbaron |center| should be of nsPoint type since all the arguments of ComputeObjectAnchorPoint() uses nsPoint and nsSize. We should only convert center to Point (which is an an UnknownUnits type) for APIs requiring Point type. MozReview-Commit-ID: EDrQGPUZp6m

Bug 1311244 Part 0 - Preemptively fix unified build bustage in nsLayoutUtils. r=dbaron The is a preemptively fix for unified bustage after Part 2 adds a new file under layout/base/. The error was: In static member function 'static bool nsLayoutUtils::SupportsServoStyleBackend(nsIDocument*)': invalid static_cast from type 'nsIDocument*' to type 'nsDocument*' MozReview-Commit-ID: A8xTSPgh8Ls

Bug 1311244 Part 7 - Implement shape-outside: circle(). r=dbaron circle() allows the user to define an empty flow area, so IsEmpty() needs to be overridden. The flow area defined by a shape needs to be clipped to the margin-box per https://drafts.csswg.org/css-shapes/#relation-to-box-model-and-float-behavior In the reftests, both clip-path and shape-outside uses the same value so that it's easier to debug visually. Add LogicalPoint::LineRelative() because we need to convert a point's I() to the line-axis in nsFloatManager. LineRelative() differs from I() in all 'rtl' direction per https://drafts.csswg.org/css-writing-modes-3/#logical-to-physical MozReview-Commit-ID: FxQaFPrEQ73

Bug 1311244 Part 6 - Add ShapeInfo and move <shape-box> impl to BoxShapeInfo. r=dbaron Create ShapeInfo as a base class for implementing all the shapes. In this design, we only need to create the correct subclass in FloatInfo's constructor whenever shape-outside is used rather than manually branching on StyleShapeSourceType and StyleBasicShape in all the methods like LineRight(), LineLeft(), etc. The concrete subclass of ShapeInfo could focus on implementing how its shape influence the flow area by overriding the needed methods in ShapeInfo. Move ComputeEllipseLineInterceptDiff() and XInterceptAtY() under the scope nsFloatManager so that they could be used by BoxShapeInfo and all the other ShpapeInfo subclasses yet to come. MozReview-Commit-ID: ETVc5FdGNha

Bug 1311244 Part 5 - Convert FloatInfo's copy constructor into a move constructor. r=dbaron Use move constructor for two reasons. 1) The copy constructor is needed only when appending FloatInfo to mFloats, so using move constructor will likely be more efficient if some of the member variables support move constructor. 2) Part 6 will added a UniquePtr member to FloatInfo, so using move constructor becomes necessary. Also change the return value of AddFloat() to void to simplify the code, since all the other callers do not check the return value, and BlockReflowInput::FloatAndPlaceFloat() only asserts in debug mode. I assume it's safe to omit the OOM check. MozReview-Commit-ID: GVbbsdBjr7b

Bug 1311244 Part 4 - Extract the computation of circle radius as ComputeCircleRadius(). r=dbaron MozReview-Commit-ID: LJNvNOoc7FI

Bug 1311244 Part 3 - Extract the computation of center as ComputeCircleOrEllipseCenter(). r=dbaron MozReview-Commit-ID: A6OTJ9PD43c

Bug 1311244 Part 2 - Create ShapeUtils, and move EnumerationToLength into it. r=dbaron More functions in nsCSSClipPathInstance will be refactored and moved into ShapeUtils in subsequent patches. MozReview-Commit-ID: LmJUevY8YGr