searching for reviewer(chmanchester)
48c662cadc6faadde91fe1ea8bbfbdd2107cd4b1: Bug 1315032 - Make |mach try| set --artifact flag when --enable-artifact-builds is set. r=chmanchester
Nick Alexander <nalexander@mozilla.com> - Sun, 20 Nov 2016 14:31:52 -0800 - rev 374217
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1315032 - Make |mach try| set --artifact flag when --enable-artifact-builds is set. r=chmanchester Tri-state flags: I hate them. I don't want to default "--artifact" in the autotry parser, since not all consumers of that code have a mozconfig. However, we also can't overwrite the `artifact` value from a "--no-artifact" flag without knowing if we're changing anything. Therefore, we add a new "--no-artifact" flag and manage the tri-state ourselves. MozReview-Commit-ID: 19gl3mM4YO0
6c1627e917136d72f3b7d74da2d10d45315dd929: Bug 1342937 - Error out of |mach try| when using test paths and no build config is detected, r=chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Mon, 27 Feb 2017 09:42:25 -0500 - rev 374190
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1342937 - Error out of |mach try| when using test paths and no build config is detected, r=chmanchester MozReview-Commit-ID: 2RE3vc1Kxvc
f967d32a9efb6cc566985c6bdfde466c67ad8a17: Bug 1341215 - Remove the dependency on the python taskcluster client module for `mach artifact`. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 21 Feb 2017 15:32:28 +0900 - rev 374131
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1341215 - Remove the dependency on the python taskcluster client module for `mach artifact`. r=chmanchester This also removes the need for a virtualenv.
4f108fc57f7cb11c46bc30ba27ed3c70b088e32a: Bug 1341215 - Remove the dependency on the mozregression module for mach artifact. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 21 Feb 2017 16:10:54 +0900 - rev 374130
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1341215 - Remove the dependency on the mozregression module for mach artifact. r=chmanchester This imports two modules from mozregression in the tree to do so. They are imported from current trunk on github, rather than the version we were getting from pypi. Note we take six from testing/web-platform/tests/tools/six) instead of moving it to python/six because it's there by coming from a copy of https://github.com/w3c/wpt-tools, which contains it as a submodule, and moving it would make updates there harder.
7d817a123f53088c543ae09fafa386c4f4105fc4: Bug 1341215 - Vendor dlmanager. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 23 Feb 2017 15:30:46 +0900 - rev 374129
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1341215 - Vendor dlmanager. r=chmanchester from https://github.com/parkouss/dlmanager Note this technically should come before the first patch, but mozreview won't show useful interdiffs if I do that, so I'll reorder the patches before landing.
e71b6d1907a868c5aa67913755de36dc151a8cb3: Bug 1302704 - part 6 - enforce identical profiles for gkrust and gkrust-gtest; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Thu, 23 Feb 2017 10:35:06 -0500 - rev 373626
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1302704 - part 6 - enforce identical profiles for gkrust and gkrust-gtest; r=chmanchester Cargo hashes various compilation settings into the dependency graph for dependent libraries. So if the compilation settings for gkrust and gkrust-gtest are different, their dependencies will likewise be different. The setup we've created in the previous patches depends on the compilation settings being identical, so we should enforce that at the moz.build level.
7cbbf867604cadcc1f083848cd42222997aad251: Bug 1302704 - part 5 - harmonize gkrust_gtest's profile.release with gkrust's; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Thu, 23 Feb 2017 10:35:07 -0500 - rev 373625
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1302704 - part 5 - harmonize gkrust_gtest's profile.release with gkrust's; r=chmanchester The comment here is a relic from bygone days when we tried sticking gkrust and gkrust-gtest into the same library at link time. Making gkrust and gkrust-gtest's profile.release settings identical also means that Cargo considers build artifacts from one suitable for the other, which is extremely desirable with our new shared CARGO_TARGET_DIR setup.
95b0a622699271828ef3bcb644837be4a5bf0d7d: Bug 1302704 - part 4 - provide a target directory for gkrust and gkrust-gtest; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Thu, 23 Feb 2017 10:35:07 -0500 - rev 373624
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1302704 - part 4 - provide a target directory for gkrust and gkrust-gtest; r=chmanchester Doing this gets us all of the benefits that we want from Cargo workspaces (only compiling artifacts from gkrust-shared one time for both libraries) without all the hassles that using Cargo workspaces would require. We don't have to worry about multiple Cargo processes running simultaneously and racing to write files; Cargo is smart enough to lock the build directory to serialize access to it.
3c3ffbed3a4b22e613f0912c2ecb0378e7f8a35e: Bug 1302704 - part 3 - propagate information about CARGO_TARGET_DIR from the frontend into the backend; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Thu, 23 Feb 2017 10:35:07 -0500 - rev 373623
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1302704 - part 3 - propagate information about CARGO_TARGET_DIR from the frontend into the backend; r=chmanchester Rust libraries can set RUST_LIBRARY_TARGET_DIR so that they can share compilation artifacts with other libraries. This setting needs to be propagated to the backend so it can be communicated to Cargo.
17b7f6a479363762110c33625771be609be00990: Bug 1302704 - part 2 - rename cargo_target_directory; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Thu, 23 Feb 2017 10:35:07 -0500 - rev 373622
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1302704 - part 2 - rename cargo_target_directory; r=chmanchester We're going to be introducing a value for CARGO_TARGET_DIR in a later patch, we we should rename this function to not conflict with that concept.
7b63c26dd7c1776c35b6fb9afbe5a90f980e4147: Bug 1302704 - part 1 - define CARGO_TARGET_DIR in the backend; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Thu, 23 Feb 2017 10:35:07 -0500 - rev 373621
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1302704 - part 1 - define CARGO_TARGET_DIR in the backend; r=chmanchester CARGO_TARGET_DIR is currently hardcoded to the current directory, but we'd like the ability to choose a value for Rust libraries.
b819211e52a441b4edee1d32e448da80b20ee310: Bug 1341207 - Use MachCommandConditions.is_{git,hg} for `mach clobber python`. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 21 Feb 2017 16:04:08 +0900 - rev 373128
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1341207 - Use MachCommandConditions.is_{git,hg} for `mach clobber python`. r=chmanchester
b26e27c14e49f0c025dadc61b3ea6d9aa58ca67f: Bug 1339240 - Detect git worktrees in MachCommandConditions.is_git. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 21 Feb 2017 15:53:27 +0900 - rev 373127
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1339240 - Detect git worktrees in MachCommandConditions.is_git. r=chmanchester
002f04770d29a7b0aafe15f99231bf85ba7fba4d: Bug 1338608 - Use mozunit in check_mkdir.py; r=chmanchester
Mike Shal <mshal@mozilla.com> - Thu, 02 Feb 2017 18:04:23 -0500 - rev 372351
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1338608 - Use mozunit in check_mkdir.py; r=chmanchester This makes the check_mkdir.py match the TEST-PASS output of other tests in the suite. MozReview-Commit-ID: FR3m09wRXg0
007864924aeb7fad4442c56c8cd10276d58e9e06: Bug 1338608 - Move check_mkdir.tpy into a python unittest manifest; r=chmanchester
Mike Shal <mshal@mozilla.com> - Thu, 02 Feb 2017 17:49:11 -0500 - rev 372350
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1338608 - Move check_mkdir.tpy into a python unittest manifest; r=chmanchester We also rename it to check_mkdir.py for consistency with other python files. MozReview-Commit-ID: ALuX6NUMsD2
8857aa03d1a56be62d19d909ffc6da0a6d554461: Bug 1337391 - Don't skip all directories that aren't traversed with a DIRS in a moz.build file. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 09 Feb 2017 15:22:34 +0900 - rev 370748
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1337391 - Don't skip all directories that aren't traversed with a DIRS in a moz.build file. r=chmanchester The way directory traversal is computed relies on the RecursiveMakeTraversal class, which is used to reproduce the old traversal order from the old entirely-in-make traversal with DIRS, PARALLEL_DIRS, etc. because of the undeclared intra-directory dependencies that are looming here and there. It's fed through DirectoryTraversal objects emitted by the frontend. Normally, DirectoryTraversal objects are emitted for a directory, possibly giving the subdirectories defined in DIRS/TEST_DIRS its moz.build. But in the case of gyp processing, nothing places the gyp objdirs in some virtual DIRS of some parent moz.build since bug 1308982. As a consequence, the corresponding entries in the RecursiveMakeTraversal instance attached to the backend are not attached to any parent directory. When subsequently traversing the tree from the root, they are never found, and end up being skipped, irregarding of their actual _no_skip status. It would probably be possible to revert the changes from bug 1308992, but we might as well not rely on remains from the old ways. So instead, we make the RecursiveMakeTraversal consider directories without a declared parent attached directly to the root directory. They don't need to depend on any other directory anyways.
ddd06f373719a8fe0dc08370c019edc4f3285295: Bug 1317019 - Fix object iteration and check if scriptName exists. r=chmanchester,jmaher
Greg Mierzwinski <gmierz2@outlook.com> - Sat, 21 Jan 2017 16:04:28 -0700 - rev 369835
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1317019 - Fix object iteration and check if scriptName exists. r=chmanchester,jmaher This patch first implements an iterator so that we can properly iterate over the elements of the object returned by the _getMethodNames function. Next, the recordTestCoverage function now checks to see if the file actually has methods before recording them. And finally, some formatting was done. MozReview-Commit-ID: EPOeYlMBc0w
35967a21613ea7f0a6aca96a4042d7a2d8fdcccf: Bug 1335666 - Remove @depends_when. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 01 Feb 2017 16:25:29 +0900 - rev 361358
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1335666 - Remove @depends_when. r=chmanchester In bug 1296530, we made @depends take a when argument, it can now replace all uses of @depends_when.
c78a57144263224e409204ee3ab43fdc305a6b9f: Bug 1322025 - Provide variants of host and target that depend on --help. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 17:54:16 +0900 - rev 360318
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1322025 - Provide variants of host and target that depend on --help. r=chmanchester We want to avoid giving --help dependencies to host and target, so that they we don't spawn config.guess and config.sub when running configure --help, and don't need to reach out to the which module to find a suitable shell to execute them. So, when --help is given, we return a fake host/target namespace, and avoid the config.guess/config.sub-invoking code being executed. Then, by giving the --help option to the linter, it can properly find that the config.guess/config.sub-invoking code doesn't need the dependency on --help. This effectively unbreaks configure --help after bug 1313306.
9c02acca893d374375778cd49f9ff542c16b91c4: Bug 1322025 - Allow to combine two DependsFunctions with "|". r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 17:42:33 +0900 - rev 360317
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1322025 - Allow to combine two DependsFunctions with "|". r=chmanchester Ideally, it would have been better if it were "or", but it's not possible to override "or" in python ; __or__ is for "|". This does feel magic, but it's also shorter than adding something like @depends_any(), and while we're only adding "|" as of this change, we can add other operations such as "&" in the future, or __getattr__ for things like milestone.is_nightly. An alternative form in moz.configure could require the @depends function to be called, e.g. "a() | b()" instead of "a | b", but I'm not particularly convinced that one is less magic than the other. This feature is hooked up such that b is not resolved if a is true, although in practice, it will still be resolved in Sandbox.run... but not when --help is passed. In the long run, the forced resolution of @depends functions will be removed from Sandbox.run.
5e9a5b5829d161f9b50ed3b9165772425f3d5511: Bug 1322025 - Don't automatically add --help dependencies to CombinedDependsFunctions. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 17:10:03 +0900 - rev 360316
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1322025 - Don't automatically add --help dependencies to CombinedDependsFunctions. r=chmanchester Adding those dependencies, retrospectively, only worked around the poor handling of --help requirements by the linter, that we fixed a few commits ago. This is now not necessary anymore.
0b17ca34cb2e7988105ec52d90ea0f92ab996448: Bug 1322025 - Don't wrap the combination function in CombinedDependsFunction. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 16:50:29 +0900 - rev 360315
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1322025 - Don't wrap the combination function in CombinedDependsFunction. r=chmanchester Several things were wrong with the wrapping: - the equality test on functions was actually comparing the memoized functions, which have a type memoize, which inherits from dict. So they weren't comparing actual functions, but the dict used to store the cache of their invocation. - each CombinedDependsFunction created for the same combination function used a different wrapped function, so even if the dict problem wasn't there, the equality test still wouldn't work, except if the function wrapping itself was memoized. - the memoization was not particularly useful. Also, for upcoming changes, we'd actually like the combination function to take an iterable instead of a variable argument list, so that items of the iterable can be skipped.
175dabab373b0f584beedfa768612743e264aa9a: Bug 1322025 - Make DependsFunction.func less public. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 16:32:03 +0900 - rev 360314
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1322025 - Make DependsFunction.func less public. r=chmanchester We're going to change the function signature for CombinedDependsFunction, so make it visible in the API that the function member is not meant to be used directly. The linter still does, though, because it needs to look in their guts. At the same time, avoid setting DependsFunction names via the function name itself, because in upcoming changes, it will not be modifiable in some cases.
42f5b6502a6414392cce5098bfe3c6b6b7fc8032: Bug 1322025 - Enforce --help requirement on option's when argument. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 14:37:34 +0900 - rev 360313
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1322025 - Enforce --help requirement on option's when argument. r=chmanchester Options with a `when` argument (either directly, or inherited through only_when() or an include) require --help per _value_for_option, but that code path is not exercised during a lint pass. With this change, along the previous one, we now correctly detect that bug 1316957 was not supposed to work as is.
97c019e39b8f873f3884630f481251d20474360d: Bug 1322025 - Enforce --help requirement on indirect dependencies. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Jan 2017 14:25:58 +0900 - rev 360312
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1322025 - Enforce --help requirement on indirect dependencies. r=chmanchester Bug 1313306 relaxed the --help dependency requirement in some cases, but while doing so, the requirement was also removed in other, unexpected cases. Specifically, the --help dependency ended up not being required on indirect dependencies that should have had it, had the --help dependency been explicit on the direct dependency.
4b5b1d19453ade8b8510bedc80a6fd400d13efc4: Bug 1256730 - Fail configure when API key files do not exist or are empty. r=chmanchester,mikedeboer
Mike Hommey <mh+mozilla@glandium.org> - Tue, 09 Aug 2016 18:17:35 +0900 - rev 359950
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1256730 - Fail configure when API key files do not exist or are empty. r=chmanchester,mikedeboer
fc1190104ee086b3889e262a91be3a9eaf69aa71: Bug 1328888 - Report build stats for Android x86 (nightly) TC builds. r=chmanchester
Justin Wood <Callek@gmail.com> - Mon, 23 Jan 2017 12:08:05 -0500 - rev 359723
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
Bug 1328888 - Report build stats for Android x86 (nightly) TC builds. r=chmanchester MozReview-Commit-ID: Hm5YyEKXoNY
d68404317ac4634a36e3c931e616f86cc8293624: Bug 1256730 - Fail configure when API key files do not exist or are empty. r=chmanchester, r=mikedeboer, a=jcristau
Mike Hommey <mh+mozilla@glandium.org> - Tue, 09 Aug 2016 18:17:35 +0900 - rev 358679
Push 10628 by ryanvm@gmail.com at Wed, 25 Jan 2017 14:57:11 +0000
Bug 1256730 - Fail configure when API key files do not exist or are empty. r=chmanchester, r=mikedeboer, a=jcristau
210b8d21be0634b4f5b01b9413b2207311e763bb: Bug 1302028 - part 2 - add configury for stylo build-time bindgen needs; r=gps,chmanchester
nfroyd@mozilla.com <nfroyd@mozilla.com> - Fri, 20 Jan 2017 16:33:04 +0000 - rev 358392
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1302028 - part 2 - add configury for stylo build-time bindgen needs; r=gps,chmanchester
479b8c84babf0c5d5cd69dc75144eeffb7ab547c: Bug 1329726 - part 2 - ensure {,HOST_}RUST_PROGRAMS are hooked into root-deps.mk; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Tue, 10 Jan 2017 11:33:58 -0500 - rev 356798
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1329726 - part 2 - ensure {,HOST_}RUST_PROGRAMS are hooked into root-deps.mk; r=chmanchester If we don't do this, a directory with only RUST_PROGRAMS (resp. HOST_RUST_PROGRAMS) won't get traversed properly.
4cc34e640a6286525131089b8a907df417dd44e8: Bug 1329726 - part 1 - ensure _compile_graph is deterministically ordered; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Tue, 10 Jan 2017 11:33:58 -0500 - rev 356797
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1329726 - part 1 - ensure _compile_graph is deterministically ordered; r=chmanchester Future tests will depend on the ordering for this, and it seems like a good change to make in any event.
a9ba8e8f983a29761ff45eb431c25811810581e2: Bug 1322323 - Consolidate common artifact build mozconfig options. r=chmanchester
Ralph Giles <giles@mozilla.com> - Wed, 21 Dec 2016 15:44:48 -0800 - rev 354872
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1322323 - Consolidate common artifact build mozconfig options. r=chmanchester Collect common options used in artifact build tests in a single mozconfig so they can be set more consistently. Use this to make unsetting toolchain defines universal in these tasks, fixing fallout from bug 1283898 which defined CARGO and RUSTC everywhere, conflicting with --disable-compiler-environment just like CC and CXX were conflicts in some artifact tasks. MozReview-Commit-ID: 4SbxByjClQb
998a91a718108ec3d0248f8e52cefbdccc23e6f2: Bug 1321408 - Move ENABLE_MARIONETTE to python configure. r=chmanchester
Nick Alexander <nalexander@mozilla.com> - Fri, 16 Dec 2016 15:49:14 -0800 - rev 354253
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1321408 - Move ENABLE_MARIONETTE to python configure. r=chmanchester This patch tries to do three things: 1) Replace the ENABLE_MARIONETTE entrypoint with --enable-marionette. 2) Fold the default value -- forced on unless building for target OS Android or building with toolkit gonk -- into the flag, rather than embedding that condition in the tree. 3) Stop using AC_DEFINE and instead use only AC_SUBST, so that no compiled code needs to be rebuilt if the flag is flipped locally. n.b., each installer/Makefile.in knows that ENABLE_MARIONETTE is set (in order to set -DENABLE_MARIONETTE=1 for */installer/package-manifest.in) due to it being an AC_SUBST. MozReview-Commit-ID: AkkmybyP1uI
2c698b01dfe8a2639cb825fdb138baa7fe44c113: Bug 1319227 - Support ObjdirFiles in tup; r=chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 06 Dec 2016 19:39:01 -0500 - rev 353346
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1319227 - Support ObjdirFiles in tup; r=chmanchester MozReview-Commit-ID: 5AXDZUzlg4t
6b3b26d63719ceeb45c0219f6fb1eb58af3b49d3: Bug 1322301 - Add flags to GeneratedFiles in the tup backend; r=chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 06 Dec 2016 19:35:12 -0500 - rev 353345
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1322301 - Add flags to GeneratedFiles in the tup backend; r=chmanchester MozReview-Commit-ID: 5N6jm6RMitD
79b6b6ff9a1b07b2a1b76c933c38a4daebc40e42: Bug 1311224 - Talos jobs don't get scheduled for artifact builds on try; r=chmanchester
Maja Frydrychowicz <mjzffr@gmail.com> - Tue, 06 Dec 2016 23:40:25 -0500 - rev 353339
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1311224 - Talos jobs don't get scheduled for artifact builds on try; r=chmanchester Enabled talos sendchange on linux,linux64,win32,win64,macosx64. MozReview-Commit-ID: 8M0VSZ5fr8d
db686076ae29249df47ff792c996de293d23cd6f: Bug 1319156 - part 3 - tests for Rust library features, frontend and backend; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Dec 2016 11:39:15 -0500 - rev 353156
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1319156 - part 3 - tests for Rust library features, frontend and backend; r=chmanchester This commit also adds an overdue test for plain Rust libraries in the recursivemake backend, but said test also serves to ensure that we don't emit features for a library if none were defined in moz.build.
b5de6b777970f98b97e9f33db1e7e8b4a7deeeab: Bug 1319156 - part 2 - handle Rust library features in the recursivemake backend; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Dec 2016 11:39:15 -0500 - rev 353155
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1319156 - part 2 - handle Rust library features in the recursivemake backend; r=chmanchester
8276296cd50509ba109d115d7b1d3b28b761e97c: Bug 1319156 - part 1 - add features to RustLibrary objects and moz.build definitions; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Dec 2016 11:39:15 -0500 - rev 353154
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1319156 - part 1 - add features to RustLibrary objects and moz.build definitions; r=chmanchester Ideally, people will just use the extra argument to RustLibrary to define features for their library.
d9d80b5b44fc7b11a935e853844caa8b51cf16d7: Bug 1318981 - part 2 - pass MOZ_DIST as an environment variable to `cargo build`; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Dec 2016 11:38:45 -0500 - rev 353153
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1318981 - part 2 - pass MOZ_DIST as an environment variable to `cargo build`; r=chmanchester rust-bindgen, at least, will need to know where Gecko's headers are to parse them.
f49a4f2953f35a1161d79902ba71e26592371c3d: Bug 1318981 - part 1 - factor out a CARGO_BUILD makefile variable; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Dec 2016 11:38:45 -0500 - rev 353152
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1318981 - part 1 - factor out a CARGO_BUILD makefile variable; r=chmanchester This change makes the individual cargo rules easier to understand, and provides a single place to change e.g. environment variables passed to cargo.
02aa6ad54a6ecd18d1e9d5f219f12ac74a8db9e6: Bug 1321696 - Require rust 1.13 with --enable-rust. r=chmanchester
Ralph Giles <giles@mozilla.com> - Thu, 01 Dec 2016 17:35:52 -0800 - rev 353135
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1321696 - Require rust 1.13 with --enable-rust. r=chmanchester Bug 1320425 using the '?' operator stabilized in rust 1.13.0. Update the minimum supported version to reflect this. MozReview-Commit-ID: 3HKrhfNavEZ
0a1c6a0b270dc6b13b819731d1eac28a02b36a46: Bug 1321691 - Suggest boostrap if configure fails to find rust. r=chmanchester
Ralph Giles <giles@mozilla.com> - Thu, 01 Dec 2016 17:01:55 -0800 - rev 353134
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1321691 - Suggest boostrap if configure fails to find rust. r=chmanchester Now that `./mach boostrap` installs rustup, suggest this if configure fails to find the toolchain when building with --enable-rust. Also point out https://rustup.rs/ for those who want more control. MozReview-Commit-ID: 8JIbERfz12f
cd6aa4390d359320b0eeed1e1a6823a01516f115: Bug 1320741 - Recommend `rustup target add`. r=chmanchester
Ralph Giles <giles@mozilla.com> - Mon, 28 Nov 2016 10:51:59 -0800 - rev 353020
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1320741 - Recommend `rustup target add`. r=chmanchester Provide some guidance on how to resolve the common error: can't find crate for `std` when cross-compiling rust code. This most commonly comes up with the Android build. MozReview-Commit-ID: 8PKKt7tf1KS
f72e2fa55bf5c2e87b1e5f6f1c7657ff7a635dfb: Bug 1285608 - Part 2: Make --artifact handle Android builds. r=chmanchester,maja_zf
Nick Alexander <nalexander@mozilla.com> - Tue, 29 Nov 2016 19:52:01 -0800 - rev 352834
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1285608 - Part 2: Make --artifact handle Android builds. r=chmanchester,maja_zf I'm not a fan of introducing a new configuration flags (and not knowing where or how to document it!), but there's a clear need for configuration in the absence of a documented way to add a coherent "artifact build dimension" akin to "opt/debug". I like adding a subtle tri-state flag even less, but I tried this with two flags (ignore and build-variant) and it was worse, so I'm rolling with a tri-state flag. MozReview-Commit-ID: KTNvacTBUXB
4b304f6f7c92f39b19981f7df1f47e1da1a60c3f: Bug 1314679 - Remove inherited mh config to support tc win artifact builds. r=chmanchester
Rob Thijssen <rthijssen@mozilla.com> - Fri, 25 Nov 2016 12:30:09 +0000 - rev 352811
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1314679 - Remove inherited mh config to support tc win artifact builds. r=chmanchester MozReview-Commit-ID: u5zCj9Sg4r
d63d083ab7672423620d6d83366d3e1cbae86bad: Bug 1316957 - Include windows.configure conditionally instead of using @depends_win. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Sat, 12 Nov 2016 06:05:07 +0900 - rev 352770
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1316957 - Include windows.configure conditionally instead of using @depends_win. r=chmanchester
8c1409a443ee41860f8caaf59a149ab83c467736: Bug 1317504 - Don't try to set LD from old-configure. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 24 Nov 2016 15:47:10 +0900 - rev 352769
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1317504 - Don't try to set LD from old-configure. r=chmanchester Now, it's completely unused.
6353e704bf2c4d47610f0e3555d2fd47c002ebda: Bug 1317504 - Make MSVC builds use the LINK variable instead of LD. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 24 Nov 2016 15:45:16 +0900 - rev 352768
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1317504 - Make MSVC builds use the LINK variable instead of LD. r=chmanchester At the same time, remove HOST_LD. It was only used for MSVC builds, which don't support cross-compile anyways, so we can, at least for now, use LINK for both host and target.
fd007caf51dfebb5224316c5d0978d15a2cfcc4b: Bug 1317504 - Remove the GNU_LD variable, nothing uses it. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 24 Nov 2016 15:25:42 +0900 - rev 352767
Push 10621 by jlund@mozilla.com at Mon, 23 Jan 2017 16:02:43 +0000
Bug 1317504 - Remove the GNU_LD variable, nothing uses it. r=chmanchester