searching for reviewer(caillon)
908c5a39cdd369e26dc14ab2d85ee50420c0f1d9: Bug 101294 - make sure that nsPref is never unhappy at construction time, r=caillon, sr=dveditz
timeless@mozdev.org - Thu, 15 Jan 2009 20:02:22 -0800 - rev 23784
Bug 101294 - make sure that nsPref is never unhappy at construction time, r=caillon, sr=dveditz
9ffef99c9aa719688384909986fd1f9f8ecaa67d: Bug 427164 - jsdIScript.isLineExecutable should return NS_ERROR_OUT_OF_MEMORY for oom, r=caillon
timeless@mozdev.org - Sun, 04 Jan 2009 10:59:17 -0800 - rev 23295
Bug 427164 - jsdIScript.isLineExecutable should return NS_ERROR_OUT_OF_MEMORY for oom, r=caillon
9e9f0cabbc376442bc2d27eab24c208ef19f7f25: Bug 399500 - "support XDG user dirs in the directory service" [p=chpe@gnome.org (Christian Persch) r=caillon sr=bsmedberg a1.9=damons]
reed@reedloden.com - Wed, 12 Mar 2008 15:35:56 -0700 - rev 12974
Bug 399500 - "support XDG user dirs in the directory service" [p=chpe@gnome.org (Christian Persch) r=caillon sr=bsmedberg a1.9=damons]
efc6c7ab3f328668914c0c669ee5e83e1ecf621d: Bug 421303 Crash [@ jsds_ScriptHookProc] r=caillon a=dsicore If we reach ~jsdService, that means our client doesn't care about us, so we can (and should) drop all references to any callbacks (if they cared, they'd have kept us alive!*). I think jsdService::Off should clear all the hooks, the strange magic of not clearing it isn't really a great idea. So for Off, we'll now clear the ScriptHook too (consumers who use off should really drop any references they have to our objects...). I'm still on the fence on this point, I suspect we can actually move it from ::Off to ~jsdService (it must be cleared at some point, otherwise if jsd_xpc's library manages to get unloaded, the function pointer would be invalid, which would be *BAD*). jsds_NotifyPendingDeadScripts needs to clear gDeadScripts whether or not there's a service or hooks, so it does. Because it's a static callback and because of the scary way GC works, I'd rather ensure (deathgrip) that jsds is available (and consistent!) for the duration of the function call. The code already handles the lack of a hook, so there's no reason to do magical returns.... The real problem which mayhemer found was that jsdService::Off was returning early (failure) because gGCStatus wasn't JSGC_END when called from ~jsdService from JS_GC from the cyclecollector, so we make sure that ~jsdService forces ::Off to act as if it is JSGC_END (after ensuring that there are no callbacks available). * a pure javascript (xpcom component, not DOM hosted!) version of a jsdService consumer means that jsdService will need to talk to the CycleCollector eventually (this is another bug for the future).
timeless@mozdev.org - Mon, 10 Mar 2008 17:13:48 -0700 - rev 12860
Bug 421303 Crash [@ jsds_ScriptHookProc] r=caillon a=dsicore If we reach ~jsdService, that means our client doesn't care about us, so we can (and should) drop all references to any callbacks (if they cared, they'd have kept us alive!*). I think jsdService::Off should clear all the hooks, the strange magic of not clearing it isn't really a great idea. So for Off, we'll now clear the ScriptHook too (consumers who use off should really drop any references they have to our objects...). I'm still on the fence on this point, I suspect we can actually move it from ::Off to ~jsdService (it must be cleared at some point, otherwise if jsd_xpc's library manages to get unloaded, the function pointer would be invalid, which would be *BAD*). jsds_NotifyPendingDeadScripts needs to clear gDeadScripts whether or not there's a service or hooks, so it does. Because it's a static callback and because of the scary way GC works, I'd rather ensure (deathgrip) that jsds is available (and consistent!) for the duration of the function call. The code already handles the lack of a hook, so there's no reason to do magical returns.... The real problem which mayhemer found was that jsdService::Off was returning early (failure) because gGCStatus wasn't JSGC_END when called from ~jsdService from JS_GC from the cyclecollector, so we make sure that ~jsdService forces ::Off to act as if it is JSGC_END (after ensuring that there are no callbacks available). * a pure javascript (xpcom component, not DOM hosted!) version of a jsdService consumer means that jsdService will need to talk to the CycleCollector eventually (this is another bug for the future).
a3e47ad6fa3ccb9e2e1b60f6e8c414bfb97ebe6e: Bug 419350 Fix compilation on ia64 against gcc4.3 Patch by dchapman@redhat.com (with improvement by dbaron) r=caillon a=beltzner
caillon@redhat.com - Tue, 26 Feb 2008 22:54:30 -0800 - rev 12342
Bug 419350 Fix compilation on ia64 against gcc4.3 Patch by dchapman@redhat.com (with improvement by dbaron) r=caillon a=beltzner
6810ca1a16e73b25349a6ab5ca3e9a566ba35fa3: Bug 394114 Interfaces missing from various QI implementations. jsdContext r=caillon sr=jag a=dsicore
timeless@mozdev.org - Tue, 26 Feb 2008 07:10:19 -0800 - rev 12262
Bug 394114 Interfaces missing from various QI implementations. jsdContext r=caillon sr=jag a=dsicore
271678cd7e3be708e848ef45677d1a3b3a11ba1d: Bug 388192 - Remove gopher OS integration support. r=caillon, a=mconnor:blocking-firefox3
rob_strong@exchangecode.com - Mon, 01 Oct 2007 11:25:26 -0700 - rev 6485
Bug 388192 - Remove gopher OS integration support. r=caillon, a=mconnor:blocking-firefox3
03ce1e36717feba4436e558c5704d88c988677db: Lots of fixes for native themed checkbox and radio buttons on gtk2. Bug 247631, r=caillon, sr=blizzard.
bryner@brianryner.com - Tue, 21 Aug 2007 22:02:37 -0700 - rev 5099
Lots of fixes for native themed checkbox and radio buttons on gtk2. Bug 247631, r=caillon, sr=blizzard.
7b831e6be7532fb7ea9eb30a021755bdd1c06d40: Bug 368016. Don't XFlush() in SetCursor(), it's slow and can be called often. r=caillon
roc+@cs.cmu.edu - Mon, 02 Apr 2007 20:21:39 -0700 - rev 278
Bug 368016. Don't XFlush() in SetCursor(), it's slow and can be called often. r=caillon