ee67814f9015f33e893caefe9c8bad0b4daa46f4: Bug 1312477 - Post: remove arbitrary peek and max heights from BottomSheet menu r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Wed, 02 Nov 2016 21:13:19 +0100 - rev 348241
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1312477 - Post: remove arbitrary peek and max heights from BottomSheet menu r=sebastian Setting the max height is completely arbitrary, and largely unnecessary - I think it's better to let the bottom automatically handle this until we know more about how the bottom sheet is perceived by real users. The peek height is similarly arbitrary - we'll probably want to discuss a good default height algorithm with UX, but setting an arbitrary hardcoded value seems wrong, especially since it doesn't behave well in landscape mode. BottomSheetDialog already does an acceptable job of finding a default peek height. MozReview-Commit-ID: LyAYzcytR6H
ffdf65db6dba6bbc5eb3e62cdc869746371fdca6: Bug 1312477 - Add popupmenu mode to AS context menu for use on tablet r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Wed, 02 Nov 2016 21:01:43 +0100 - rev 348240
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1312477 - Add popupmenu mode to AS context menu for use on tablet r=sebastian MozReview-Commit-ID: HCym4G8RtcU
522f6a80deadca7229e77a39babe6224e6bc8b07: Bug 1312477 - Pre: refactor AS context menu to allow multiple view implementations r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Wed, 02 Nov 2016 20:57:05 +0100 - rev 348239
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1312477 - Pre: refactor AS context menu to allow multiple view implementations r=sebastian This is in preparation for having a popup menu on tablets. MozReview-Commit-ID: 14thIuhRkgB
594d5fc4d75c0550defed9d336f8e20a4e6e0302: Bug 1312477 - Pre: increase touch-target size to Android UI guidelines r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Wed, 02 Nov 2016 20:58:26 +0100 - rev 348238
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1312477 - Pre: increase touch-target size to Android UI guidelines r=sebastian 48dp is the minimum touch target size as suggested in the Android UI guidelines: https://developer.android.com/design/patterns/accessibility.html A similar recommendation is made in: https://material.google.com/layout/metrics-keylines.html#metrics-keylines-touch-target-size MozReview-Commit-ID: 9ybgjSOfD2J
e32d64d47c5212727f0201c2911477045512f6e1: Bug 1173823 - Always use document.baseURI as the uri parameter of _readerParse method, r=Gijs
Evan Tseng <evan@tseng.io> - Mon, 07 Nov 2016 17:31:23 +0800 - rev 348237
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1173823 - Always use document.baseURI as the uri parameter of _readerParse method, r=Gijs MozReview-Commit-ID: RnICyZALNb
c1a71be7ea59dbd92f3b16a98c3e3185dc26ee37: Bug 1315688 - Fix browser_toolbox_remoteness_change.js assertion on Aurora. r=jryans
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 07 Nov 2016 10:21:16 -0800 - rev 348236
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1315688 - Fix browser_toolbox_remoteness_change.js assertion on Aurora. r=jryans MozReview-Commit-ID: 2qEUm1vzZPO
0c810988abdcd3dea1c826bff47b47ecb9c6548b: Bug 985517 - Remove pseudo class locks of children to prevent ending up with broken pseudo class state. r=pbro
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 02 Nov 2016 06:44:48 -0700 - rev 348235
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 985517 - Remove pseudo class locks of children to prevent ending up with broken pseudo class state. r=pbro MozReview-Commit-ID: LAh6HdKKJsk
3fdf9f2b81f2e41172e58d39dbb9ffc6f572cc6e: Bug 985517 - Only allow one node to be pseudo class locked per pseudo. r=pbro
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 02 Nov 2016 04:49:06 -0700 - rev 348234
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 985517 - Only allow one node to be pseudo class locked per pseudo. r=pbro MozReview-Commit-ID: HF7Thklh0bZ
9b708de08fba114dfa749e421afea4a5d5a162ab: Bug 985517 - Keep pseudo class locked when selecting another node in the markup view. r=pbro
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 02 Nov 2016 04:48:05 -0700 - rev 348233
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 985517 - Keep pseudo class locked when selecting another node in the markup view. r=pbro MozReview-Commit-ID: 4davyHgBtUh
6f1c0c2af6b0639f4f60ccef3babf9085f86caf8: Bug 1123334 - Use SQLITE_ENABLE_API_ARMOR in debug mode. r=asuth
Marco Bonardo <mbonardo@mozilla.com> - Mon, 07 Nov 2016 14:51:25 +0100 - rev 348232
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1123334 - Use SQLITE_ENABLE_API_ARMOR in debug mode. r=asuth MozReview-Commit-ID: IOa2167571s
05f8aed1d9c5d35cfac1dda1410542fa337617a1: Bug 1312649 part.2 IMEInputHandler::GetVaildAttributesForMarkedText() should return non-empty array r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 07 Nov 2016 16:19:41 +0900 - rev 348231
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1312649 part.2 IMEInputHandler::GetVaildAttributesForMarkedText() should return non-empty array r=m_kato Vietnamese Telex perhaps referes this result and change its behavior. When typying something, Telex starts composition on Chrome but may not behave so on Gecko. Fortunately, Chromium just returns some attributes when validAttributesForMarkedText: of NSTextInputClient [1] but it doesn't return these styles when attributedSubstringForProposedRange: of NSTextInputClient is called (always returns non-styled plain text) [2]. Therefore, this patch does not touch IMEInputHandler::GetAttributedSubstringFromRange(). *1 <https://chromium.googlesource.com/chromium/src/+/7d85f23cb0235db06b0b6c2de1dc29ae5eaeb8f5/content/browser/renderer_host/render_widget_host_view_mac.mm#2936> *2 <https://chromium.googlesource.com/chromium/src/+/7d85f23cb0235db06b0b6c2de1dc29ae5eaeb8f5/content/browser/renderer_host/render_widget_host_view_mac.mm#3036> MozReview-Commit-ID: 1gPIiu4Qbud
6bfd79a3ab98c93f7a6bff0ff27b24a9164ea59d: Bug 1312649 part.1 TextInputHandler::InsertText() should dispatch composition events instead of keypress events when it replaces a range which is different from current selection r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 07 Nov 2016 10:30:05 +0900 - rev 348230
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1312649 part.1 TextInputHandler::InsertText() should dispatch composition events instead of keypress events when it replaces a range which is different from current selection r=m_kato Vietnamese Telex IME handles Backspace key immediately after inputting a word even when there is no marked text. At this time, it tries to replace the word with specific string. In such case, our editor shouldn't remove anything at handling the Backspace keypress event. For avoiding this issue, InserText() should dispatch a set of composition for inserting the specified text into the range. Then, editor won't perform any action of the key. Additionally, when a Backspace keydown tries to remove the last character of the word, Telex removes it with a composition. At this time, it creates dummy marked text "a" and make it empty later. So, in this case, InsertText() won't be called, therefore, we need to consume the Backspace keypress when SetMarkedText() is called for preventing removing the previous character of the word. MozReview-Commit-ID: LfeEHDWn0cZ
00f8bca94661bc5be13c1635b63e086ba7f03ce6: Bug 1315672 - Only check for IdleDeadline on nightly. r=bkelly
Andreas Farre <farre@mozilla.com> - Mon, 07 Nov 2016 19:28:52 +0100 - rev 348229
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1315672 - Only check for IdleDeadline on nightly. r=bkelly MozReview-Commit-ID: HgR5FIhM0R6
dd2c93bc1da35cbd72f15896222f5744b6ae04cc: Bug 1315551 - part2 : check we have initialized agent when we want to call the agent's function. r=jwwang
Alastor Wu <alwu@mozilla.com> - Tue, 08 Nov 2016 11:08:02 +0800 - rev 348228
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1315551 - part2 : check we have initialized agent when we want to call the agent's function. r=jwwang Because the agent's initialization might fail if we don't get the valid inner window, we need to check whether the agent exists before calling the agent's method. MozReview-Commit-ID: IUuvyGh7CMd
967dd79df01ce7a8702c87bf568a0b4807bf1561: Bug 1315551 - part1 : should pass valid window for agent's initialization. r=baku
Alastor Wu <alwu@mozilla.com> - Tue, 08 Nov 2016 11:06:04 +0800 - rev 348227
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1315551 - part1 : should pass valid window for agent's initialization. r=baku MozReview-Commit-ID: 4uh4nU8YVsS
5bc308f6ac4c5f428399d975cfadf4039d44827f: Bug 1315617 - Fix remaining no-unused-vars for local scope in browser/ and enable the rule for all of browser/ r=mossop
Mark Banner <standard8@mozilla.com> - Thu, 03 Nov 2016 11:56:28 +0000 - rev 348226
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1315617 - Fix remaining no-unused-vars for local scope in browser/ and enable the rule for all of browser/ r=mossop MozReview-Commit-ID: FO1p5G5K3zg
6fb5f161f09c4a75984b053c022fe36a101a7bcc: Bug 1315575: Part 3 - Convert ImageData objects at the binding layer, and remove unnecessary content bindings. r=aswan
Kris Maglione <maglione.k@gmail.com> - Sun, 06 Nov 2016 17:35:07 -0800 - rev 348225
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1315575: Part 3 - Convert ImageData objects at the binding layer, and remove unnecessary content bindings. r=aswan MozReview-Commit-ID: CjqXRiFcMWp
f29c03c0682adebf120110a654d22eb5130d7bca: Bug 1315575: Part 2 - Stop generating multiple sets of schema bindings for proxy contexts. r=aswan
Kris Maglione <maglione.k@gmail.com> - Mon, 07 Nov 2016 22:21:01 -0800 - rev 348224
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1315575: Part 2 - Stop generating multiple sets of schema bindings for proxy contexts. r=aswan MozReview-Commit-ID: 2VqYscQAAF6
2e0180c345940fa1893ef4e26ac68effa024ef48: Bug 1315575: Part 1 - More cleanup. r=aswan
Kris Maglione <maglione.k@gmail.com> - Sun, 06 Nov 2016 17:28:16 -0800 - rev 348223
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1315575: Part 1 - More cleanup. r=aswan MozReview-Commit-ID: KdAplJGH9Hy
deb2dcbb0ec045561f1fa042957221466439240c: Bug 1314552. Part 2 - remove unused canonical. r=jya
JW Wang <jwwang@mozilla.com> - Wed, 02 Nov 2016 17:23:37 +0800 - rev 348222
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1314552. Part 2 - remove unused canonical. r=jya MozReview-Commit-ID: FW6Wj1iiadS
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip