864ab5efde71487c27619d175978818b37c1ac74: Bug 1313632: P1. Remove unused OggReader. r=kaku
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 09 Nov 2016 11:54:41 +1100 - rev 348546
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1313632: P1. Remove unused OggReader. r=kaku Also remove related preference. MozReview-Commit-ID: D5pkyPXAoG9
8ffd0e45ac580a8d0a85d603e5395297b5f2d9d3: Bug 1316096 - Change eslint configuration to use string values for rules instead of integers, making it easier for others who are reading the rules to know if a rule is set to off, warn, or error. r=mossop
Jared Wein <jwein@mozilla.com> - Tue, 08 Nov 2016 15:14:19 -0500 - rev 348545
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1316096 - Change eslint configuration to use string values for rules instead of integers, making it easier for others who are reading the rules to know if a rule is set to off, warn, or error. r=mossop MozReview-Commit-ID: 2Xuj5nxuQdO
b737f14975c2a83bf6c3753528641e0f51745778: Bug 1316040 - Change target to non-target in test_caret_not_appear_when_typing_in_scrollable_content. r=mtseng
Ting-Yu Lin <tlin@mozilla.com> - Wed, 09 Nov 2016 14:14:53 +0800 - rev 348544
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1316040 - Change target to non-target in test_caret_not_appear_when_typing_in_scrollable_content. r=mtseng In this test, we assume the caret does not appear at the end of the input. However in this case, self.actions.flick() will select all text within the input, and then send_keys() will replace it with '!'. As a result, the final content might varies on different platforms. Test the final content match tho target_content might not be reliable. To fix this, we instead assert that final content does *not* match the non_target_content as the bug occurs. MozReview-Commit-ID: 2YRN8W3PUXG
fb579bc49c2f153e61cf06b34bcd6a03a409e6c4: Bug 1316250 - Allow functions using the fake os module to not depend on --help. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 09 Nov 2016 15:32:28 +0900 - rev 348543
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1316250 - Allow functions using the fake os module to not depend on --help. r=chmanchester
53f988e1c1fd34ca2ff5f42a59fa05b4a768a1e5: Bug 1316250 - Don't pretend imported modules in templates are inherited by functions they contain. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 09 Nov 2016 15:22:17 +0900 - rev 348542
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1316250 - Don't pretend imported modules in templates are inherited by functions they contain. r=chmanchester The current state of python configure sandbox execution is that if a template imports a module, and a function defined in the template tries to use the module, it doesn't work. Ideally, it would, but rather than try to fix this corner case, we remove the unit tests that assume it works (and consequently pass for half bad reasons), and add a unit test so that the behavior doesn't change unwillingly.
30d3890fca9847a283859a53043277713b7eadab: Bug 1316206 - Make RefPtr(decltype(nullptr)) MOZ_IMPLICIT - r=froydnj
Gerald Squelart <gsquelart@mozilla.com> - Tue, 08 Nov 2016 15:12:33 +1100 - rev 348541
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1316206 - Make RefPtr(decltype(nullptr)) MOZ_IMPLICIT - r=froydnj Making this constructor non-explicit will permit automatic conversions from 'nullptr' into RefPtr types, which I think are not dangerous. The one spot that this affects is in 'UserDataType nsBaseHashtable::Get(KeyType)', which does a 'return 0;' into the UserDataType, which could be a bool, an int, a RefPtr or other. I'm changing that into a C++11 "value initialization", which falls back to "zero initialization" for PODs: 'return UserDataType{};'. Also fixed the comment to clarify not-found return values, as Get(KeyType) was not only used for pointers anyway. MozReview-Commit-ID: F41VlvTNOZU
9380a01deaf545a1ef339caaf15ffb951c158681: Bug 1316206 - Fix RefPtr assignments from 0 - r=froydnj
Gerald Squelart <gsquelart@mozilla.com> - Tue, 08 Nov 2016 14:34:06 +1100 - rev 348540
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1316206 - Fix RefPtr assignments from 0 - r=froydnj Giving '0' (literal zero) to RefPtr is now ambiguous, as both RefPtr(decltype(nullptr)) and RefPtr(T*) could be used. In any case, our coding standards mandate the use of 'nullptr' for pointers. So I'm changing all zeroes into nullptr's where necessary. MozReview-Commit-ID: A458A4e9for
d78a1d9f6a4a82a3f134c095ead3d6ecf95ec204: Bug 1316206 - RefPtr construction/assignment from nullptr - r=froydnj
Gerald Squelart <gsquelart@mozilla.com> - Thu, 10 Nov 2016 07:58:10 +1100 - rev 348539
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1316206 - RefPtr construction/assignment from nullptr - r=froydnj Added constructor and operator= from a nullptr, bypassing the incoming pointer check. Note that the constructor is 'explicit', because one particular use in nsBaseHashtable is doing a 'return 0' into a templated type that is a RefPtr in many cases. Making this new constructor explicit removes it from consideration in this case. As it's not strictly necessary to have it MOZ_IMPLICIT (but could still be nice), I will tackle that in the patch after next. Also changed all zeroes into nullptr when relevant in RefPtr.h (other system- wide affected files will be updated in following patch.) MozReview-Commit-ID: Ds4CEv9hZWI
2635cff0413bd1d4c6b0be57b579aa41393ad1ab: bug 1316165 ensure xcb_get_input_focus_reply is called to avoid leaking the reply r=lsalzman
Karl Tomlinson <karlt+@karlt.net> - Wed, 09 Nov 2016 08:56:27 +1300 - rev 348538
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
bug 1316165 ensure xcb_get_input_focus_reply is called to avoid leaking the reply r=lsalzman MozReview-Commit-ID: JPi0TeKVCB5
2ab7ed6880d3e0f973d1209ba4f1639f6f89d00f: Bug 1315675 - Fix tests to not fail if browser.urlbar.oneOffSearches gets turned off in other branches. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 08 Nov 2016 14:08:52 +0000 - rev 348537
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1315675 - Fix tests to not fail if browser.urlbar.oneOffSearches gets turned off in other branches. r=mak MozReview-Commit-ID: HgLy6Dis0jU
a9d136b32432b84504635fc93a52e22b9f61c377: Bug 1316287 - Remove test_history_redirects.js as it doesn't actually test anything. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 09 Nov 2016 11:42:37 +0000 - rev 348536
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1316287 - Remove test_history_redirects.js as it doesn't actually test anything. r=mak MozReview-Commit-ID: GkX9yjsXk9G
a87aea7bdeda45126ad8306f2df47a694b052780: Bug 1316430 - Add fuzzy annotation for reftests/details-summary/mouse-click-twice-float-details.html r=dholbert
Neerja Pancholi <npancholi@mozilla.com> - Wed, 09 Nov 2016 13:15:27 -0800 - rev 348535
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1316430 - Add fuzzy annotation for reftests/details-summary/mouse-click-twice-float-details.html r=dholbert MozReview-Commit-ID: 47XhcgMrOu6
f6377025e793a60af4a30aa913ff896e26a5cd6d: Bug 1311782 - Make the sync bookmark validator ignore the title for bookmark roots r=markh
Thom Chiovoloni <tchiovoloni@mozilla.com> - Tue, 08 Nov 2016 12:13:37 -0500 - rev 348534
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1311782 - Make the sync bookmark validator ignore the title for bookmark roots r=markh MozReview-Commit-ID: Ji1Sar0ld7j
5c62fafdf68285f5696a9210bfab362ded36ff1d: Bug 1316114 - reset sjs file at the end of the test case. r=jmaher
Joel Maher <jmaher@mozilla.com> - Wed, 09 Nov 2016 16:18:08 -0500 - rev 348533
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1316114 - reset sjs file at the end of the test case. r=jmaher MozReview-Commit-ID: FKm93zKuFe1
9bf5be90848a3819636fcc65986c02ec65e66fd7: Bug 1316118: Remove need for ia2_api_all.idl; r=surkov
Aaron Klotz <aklotz@mozilla.com> - Wed, 09 Nov 2016 12:56:23 -0700 - rev 348532
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1316118: Remove need for ia2_api_all.idl; r=surkov MozReview-Commit-ID: EBAz0MQXmJq
05db990f8787e761f12418ec2da0f7d4a7cc04fe: Bug 1316374 - Fixed typo in uninstaller r=mhowell
Anthony Miyaguchi <amiyaguchi@mozilla.com> - Wed, 09 Nov 2016 10:19:35 -0800 - rev 348531
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1316374 - Fixed typo in uninstaller r=mhowell MozReview-Commit-ID: 8Le7gaRNOyF
358036b9cda869e57f9f1cd30e4a587cd9086244: Bug 1295466 - Use MozReftestInvalidate event in box-sizing-replaced-001.xht to avoid test failure when paint delay is reduced r=mstange
Neerja Pancholi <npancholi@mozilla.com> - Mon, 07 Nov 2016 16:32:48 -0800 - rev 348530
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1295466 - Use MozReftestInvalidate event in box-sizing-replaced-001.xht to avoid test failure when paint delay is reduced r=mstange MozReview-Commit-ID: IXK2WwM3mrH
69fd9d1c09c53dd20dfd3db56b5508c6a68b4646: Bug 1315911 - Disable time picker UI by making it pref-off by default; r=mconley
Scott Wu <scottcwwu@gmail.com> - Tue, 08 Nov 2016 19:07:50 +0800 - rev 348529
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1315911 - Disable time picker UI by making it pref-off by default; r=mconley MozReview-Commit-ID: 2kpzN27KzaB
151c40efcb3c7afad7eda5d315b497630eec81e5: Bug 1315846 - Fix reftests with minor AA and layerization issues by replacing text with tall divs as placeholders r=dholbert
Neerja Pancholi <npancholi@mozilla.com> - Tue, 08 Nov 2016 13:34:09 -0800 - rev 348528
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1315846 - Fix reftests with minor AA and layerization issues by replacing text with tall divs as placeholders r=dholbert MozReview-Commit-ID: 4FB1MrQjGhE
7ceca5ed99e16090da6eb52866f35bf7c7b2e919: Bug 1312951 - Add fuzzy annotation for editor/reftests/824080-3.html r=mstange
Neerja Pancholi <npancholi@mozilla.com> - Mon, 07 Nov 2016 17:18:08 -0800 - rev 348527
Push 10298 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:33:03 +0000
Bug 1312951 - Add fuzzy annotation for editor/reftests/824080-3.html r=mstange MozReview-Commit-ID: 7ZMQPXFHrWq
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip