716fab262b56c21a04cfb915189a2fff23e81f8c: Bug 1115812 patch 7 - Always call DoProcessRestyles if mInRebuildAllStyleData. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:12 -0800 - rev 241181
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1115812 patch 7 - Always call DoProcessRestyles if mInRebuildAllStyleData. r=heycam
This is needed for patch 9 (once patch 9 is used via the
ProcessPendingRestyles() codepath in patch 13); it ensures that when we
use the new way of rebuilding, we don't bail out early because we think
we have nothing to do.
ce19dc161a0b5a65eaa0c2c9a0659f3079900146: Bug 1115812 patch 6 - Move ProcessRestyles from RestyleTracker to RestyleManager. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:12 -0800 - rev 241180
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1115812 patch 6 - Move ProcessRestyles from RestyleTracker to RestyleManager. r=heycam
This is needed for the following patch, so that it can access a member
variable of RestyleManager.
722bcd3bcbbc3b3ede754045441ac4d3d4f64789: Bug 1115812 patch 5 - Store the state of whether we're currently rebuilding all style data in a member variable, to prepare for future merging of the rebuild into other code. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:12 -0800 - rev 241179
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1115812 patch 5 - Store the state of whether we're currently rebuilding all style data in a member variable, to prepare for future merging of the rebuild into other code. r=heycam
This adds a member variable that is currently only used within a single
function, but that function will be split apart so that different parts
of it can be called from different places within ProcessPendingRestyles.
5f64ba26810f9b63dcfcb5a815dd157384159393: Bug 1115812 patch 4 - Rename mRebuildAllStyleData to mDoRebuildAllStyleData. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:11 -0800 - rev 241178
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1115812 patch 4 - Rename mRebuildAllStyleData to mDoRebuildAllStyleData. r=heycam
This is the variable that says we *need to* rebuild style data. Since
the next patch will introduce a variable that says we're *currently*
rebuilding all style data, renaming this one makes things clearer.
4d145190cf56bfd03ec2e801557852b7f91efe1c: Bug 1115812 patch 3 - Pass the hints to DoRebuildAllStyleData via the member variables, in preparation for future refactoring. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:11 -0800 - rev 241177
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1115812 patch 3 - Pass the hints to DoRebuildAllStyleData via the member variables, in preparation for future refactoring. r=heycam
Part of this refactoring involves the ability to start the rebuild-all
process within the processing of restyles. This means we can't pass
parameters directly from RebuildAllStyleData into DoRebuildAllStyleData.
So this continues storing the hints as member variables a little bit
deeper into the process.
(I tried to move in a different direction in this patch queue, and store
these hints in mPendingRestyles, for the root element. But that broke
layout/style/test/test_counter_style.html and
layout/style/test/test_font_loading_api.html, and I didn't want to
figure out why. It would be somewhat better in the long run, since
currently these hints will get processed if we do a rebuild-all on a
RestyleTracker other than mPendingRestyles, which can happen if we have
'rem' units and have a root element font size change in the
animation-only update or in mPendingAnimationRestyles.)
8927072cd0fb0216ce2205c8652c217c0af91eef: Bug 1115812 patch 2 - Move the eRestyle_ChangeAnimationPhaseDescendants hint in DoRebuildAllStyleData so that the new rebuild-all codepaths will keep it. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:11 -0800 - rev 241176
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1115812 patch 2 - Move the eRestyle_ChangeAnimationPhaseDescendants hint in DoRebuildAllStyleData so that the new rebuild-all codepaths will keep it. r=heycam
The patches in this series refactor the process of rebuilding all style
data (RestyleManager::RebuildAllStyleData and
RestyleManager::DoRebuildAllStyleData) so that the process of rebuilding
all style data uses the existing restyle processing loops in
ProcessPendingRestyles. (Rebuilding all style data is what we do when
we need to throw away the rule tree because something has invalidated
the cached data in it.) This removes (increasing, especially with
bug
960465 coming) code duplicated between the two codepaths, fixes some
omissions from the separate rebuild-all codepath, and (more immediately)
allows fixing lifetime issues of ReframingStyleContexts objects in
bug
1110277 so that we can have a single ReframingStyleContexts for all of
the restyle processing in each restyle processing operation. In other
words, the goal is to change the rebuild-all process from a separate
codepath to a few variables that modify the way ProcessPendingRestyles
works (and make it do the extra work).
This is just a small first step in that process, which moves one piece
of code from a chunk of duplicated and to-be-removed code into a chunk
of code that will be preserved.
8b5e114c159c7d148603bd790883f3dce106e65c: Bug 1115812 patch 1 - Remove obsolete comment that was fixed by bug 1047928. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:11 -0800 - rev 241175
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1115812 patch 1 - Remove obsolete comment that was fixed by
bug 1047928. r=heycam
7d3ef4f3fa8fc5509203c0290fa7941bdbaad07b: Bug 908987 - Honor mIsActive more aggressively to avoid calling IsVisibleConsideringAncestors. r=roc
L. David Baron <dbaron@dbaron.org> - Tue, 13 Jan 2015 21:03:11 -0800 - rev 241174
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 908987 - Honor mIsActive more aggressively to avoid calling IsVisibleConsideringAncestors. r=roc
This means that we avoid an O(N^2) calling pattern of IsVisible when we
call IsVisible for all tabs of a tabbrowser, since in a tabbrowser
(which uses an nsDeckFrame), IsVisibleConsideringAncestors is O(N) in
number of earlier tabs.
2896167fae141cf518577a9d9e1d18161cd2bf72: Bug 1116056 - Change MOZ_ASSERT() to NS_WARNING() in Box::Read(); r=jya
Anthony Jones <ajones@mozilla.com> - Wed, 14 Jan 2015 16:57:14 +1300 - rev 241173
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1116056 - Change MOZ_ASSERT() to NS_WARNING() in Box::Read(); r=jya
0c9c9c240b070bfbbc953d2d5584b3f04f0ae052: Bug 1121065 - Ensure Software Vsync TimeStamp is never in the future. r=kats
Mason Chang <mchang@mozilla.com> - Tue, 13 Jan 2015 19:30:29 -0800 - rev 241172
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1121065 - Ensure Software Vsync TimeStamp is never in the future. r=kats
f867a45b806867e036c57c4054464a54fb6a6a62: Bug 1120257 (part 2) - Remove some duplicated inline string methods. r=jandem.
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 13 Jan 2015 14:25:37 -0800 - rev 241171
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1120257 (part 2) - Remove some duplicated inline string methods. r=jandem.
Some of the inline string methods have a templated and a non-templated version,
e.g. lengthFits() and init(). Others don't, e.g. NewInlineString(). Having both
seems unnecessary, so this patch removes the non-templated versions.
270cd86a7e4cdad49099407bd24f276221bfb0df: Bug 1120257 (part 1) - Clarify inline string naming by adding JSThinInline. r=jandem.
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 13 Jan 2015 14:25:36 -0800 - rev 241170
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1120257 (part 1) - Clarify inline string naming by adding JSThinInline. r=jandem.
This patch introduces a new sub-class of JSInlineString called
JSThinInlineString, and moves the operations specific to thin inline strings
into it. JSInlineString now clearly subsumes both of JS{Thin,Fat}InlineString,
and "inling string" now clearly subsumes both of "thin inline string" and "fat
inline string". Despite adding yet another JSString subclass, I think it makes
things clearer :)
The patch also renames a bunch of things accordingly, and removes the dead
resetLength() declaration.
e3b9dcef0c711050db12338fa848fea859e5221a: Bug 1120630 - Skip tests failing with e10s enabled.;r=jgriffin
Chris Manchester <cmanchester@mozilla.com> - Tue, 13 Jan 2015 21:27:26 -0500 - rev 241169
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1120630 - Skip tests failing with e10s enabled.;r=jgriffin
340b2907b368f195d5bbfc3a081e4cfe9eb9959a: Bug 1120630 - Add --e10s to turn on electrolysis for marionette tests.;r=jgriffin
Chris Manchester <cmanchester@mozilla.com> - Tue, 13 Jan 2015 21:27:25 -0500 - rev 241168
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1120630 - Add --e10s to turn on electrolysis for marionette tests.;r=jgriffin
906a97d224d6ec663c39e8e7192647f5dd80e732: Merge m-c to inbound a=merge
Wes Kocher <wkocher@mozilla.com> - Tue, 13 Jan 2015 17:45:46 -0800 - rev 241167
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Merge m-c to inbound a=merge
111218ebc70b2ff3170d16ff40ce6153c6c64115: Bug 1116187 - Add in-tree config for B2G mochitest-chrome, r=gbrown
Jonathan Griffin <jgriffin@mozilla.com> - Tue, 13 Jan 2015 16:31:41 -0800 - rev 241166
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1116187 - Add in-tree config for B2G mochitest-chrome, r=gbrown
07029b5f00e9ff990c4237051071fbb254032825: Bug 1121256: Remove commented-out debugging printfs from 1998, in nsSubDocumentFrame::Reflow. (comment-only, no review, DONTBUILD)
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 13 Jan 2015 16:30:32 -0800 - rev 241165
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1121256: Remove commented-out debugging printfs from 1998, in nsSubDocumentFrame::Reflow. (comment-only, no review, DONTBUILD)
33394bd63ec09fac63b991aab063e06c87f87d34: Bug 1117768 - unified bustage followup on a CLOSED TREE
Steve Fink <sfink@mozilla.com> - Tue, 13 Jan 2015 15:44:14 -0800 - rev 241164
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1117768 - unified bustage followup on a CLOSED TREE
4f64a711181dc0add9338067691a8ed3a33601e0: Bug 1117768 - Fix assertion in AutoStopVerifyingBarriers and add tests, r=terrence
Steve Fink <sfink@mozilla.com> - Tue, 13 Jan 2015 14:01:42 -0800 - rev 241163
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1117768 - Fix assertion in AutoStopVerifyingBarriers and add tests, r=terrence
15d5847d41f86ad9eac41179209f117c7365a5b1: Bug 1105388 - Avoid robocop shutdown crashes with longer wait; r=mfinkle
Geoff Brown <gbrown@mozilla.com> - Tue, 13 Jan 2015 15:42:06 -0700 - rev 241162
Push
7677 by raliiev@mozilla.com at Mon, 23 Feb 2015 18:11:24 +0000
Bug 1105388 - Avoid robocop shutdown crashes with longer wait; r=mfinkle