created 2008-03-10 17:13 -0700
pushed unknown
timeless timeless - Bug 421303 Crash [@ jsds_ScriptHookProc] r=caillon a=dsicore If we reach ~jsdService, that means our client doesn't care about us, so we can (and should) drop all references to any callbacks (if they cared, they'd have kept us alive!*). I think jsdService::Off should clear all the hooks, the strange magic of not clearing it isn't really a great idea. So for Off, we'll now clear the ScriptHook too (consumers who use off should really drop any references they have to our objects...). I'm still on the fence on this point, I suspect we can actually move it from ::Off to ~jsdService (it must be cleared at some point, otherwise if jsd_xpc's library manages to get unloaded, the function pointer would be invalid, which would be *BAD*). jsds_NotifyPendingDeadScripts needs to clear gDeadScripts whether or not there's a service or hooks, so it does. Because it's a static callback and because of the scary way GC works, I'd rather ensure (deathgrip) that jsds is available (and consistent!) for the duration of the function call. The code already handles the lack of a hook, so there's no reason to do magical returns.... The real problem which mayhemer found was that jsdService::Off was returning early (failure) because gGCStatus wasn't JSGC_END when called from ~jsdService from JS_GC from the cyclecollector, so we make sure that ~jsdService forces ::Off to act as if it is JSGC_END (after ensuring that there are no callbacks available). * a pure javascript (xpcom component, not DOM hosted!) version of a jsdService consumer means that jsdService will need to talk to the CycleCollector eventually (this is another bug for the future).
created 2008-03-05 13:10 -0800
pushed unknown
timeless timeless - Bug 282660 Crash [@ jsds_NotifyPendingDeadScripts] ds->script is null r=jst a=beltzner
created 2008-02-26 07:10 -0800
pushed unknown
timeless timeless - Bug 394114 Interfaces missing from various QI implementations. jsdContext r=caillon sr=jag a=dsicore
created 2008-01-31 11:12 -0800
pushed unknown
timeless timeless - Bug 411249 Top crash [@ jsds_ScriptHookProc][@jsds_ScriptHookProc(JSDContext*, JSDScript*, int, void*)] on shutdown with Firebug 1.1.0b10 installed r=gijs a=beltzner
created 2008-01-15 07:50 -0800
pushed unknown
benjamin benjamin - Bug 411327 - nsIXPCNativeCallContext should not inherit from nsISupports, r=mrbkap, a=schrep
created 2007-07-08 00:08 -0700
pushed unknown
jwalden jwalden - Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
created 2007-07-01 12:25 -0700
pushed unknown
timeless timeless - Bug 385765 [@ jsdASObserver::Observe] You can't dereference a NULL nsCOMPtr with operator->()
created 2007-06-19 22:56 -0700
pushed unknown
timeless timeless - Bug 365363 Return value for GetJSDValue ignored leading to death
created 2007-04-29 14:49 -0700
pushed unknown
igor igor - Bug 379165: Simplifing JS_DimpHeap while fixing BeOS build problems. r=brendan
created 2007-04-25 06:43 -0700
pushed unknown
igor igor - Bug 378261: Replacing GC_MARK_DEBUG by DumpHeap. r=brendan
created 2007-03-22 10:30 -0700
pushed unknown
hg hg - Free the (distributed) Lizard! Automatic merge from CVS: Module mozilla: tag HG_REPO_INITIAL_IMPORT at 22 Mar 2007 10:30 PDT,
less more (0) tip