0df3d53f6451769da7830ffd30046f99e67f9c2e: servo: Merge #12537 - Partial fix for #12415: expose interfaces only where necessary (from ice9js:fix/expose-interfaces-only-where-necessary); r=Ms2ger
Kuba Birecki <kuba.birecki@crystalplanet.io> - Sat, 23 Jul 2016 05:16:44 -0500 - rev 368381
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12537 - Partial fix for #12415: expose interfaces only where necessary (from ice9js:fix/expose-interfaces-only-where-necessary); r=Ms2ger Partial fix for #12415. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] These changes do not require tests because they don't affect any features. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7ea73ba2eec54e626db964eb3c943c2ba9b61466
4fff433d8304cd9094767565dcb4044e6674bcfe: servo: Merge #12530 - partial-fix #12415: incorrect exposure of Window,Worker in webidl (from woshilapin:fix-12415/htmltable); r=jdm
Jean SIMARD <woshilapin@tuziwo.info> - Sat, 23 Jul 2016 00:10:27 -0500 - rev 368380
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12530 - partial-fix #12415: incorrect exposure of Window,Worker in webidl (from woshilapin:fix-12415/htmltable); r=jdm <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix (partially) #12415 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because they don't add any feature <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> * HTMLTableCaptionElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmltablecaptionelement)] * HTMLTableCellElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmltablecellelement)] * HTMLTableColElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmltablecolelement)] * HTMLTableElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmltableelement)] * HTMLTableRowElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmltablerowelement)] * HTMLTableSectionElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmltablesectionelement)] Source-Repo: https://github.com/servo/servo Source-Revision: 7c8bd58c4a53077af564f8024179732dffa15b39
f5ba391915d5955a1d5e5c06a8f0bc480dd3a1ba: servo: Merge #12526 - partial-fix #12415: incorrect exposure of Window,Worker in webidl (from woshilapin:fix-12415/htmlp-htmls); r=jdm
Jean SIMARD <woshilapin@tuziwo.info> - Fri, 22 Jul 2016 20:14:55 -0500 - rev 368379
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12526 - partial-fix #12415: incorrect exposure of Window,Worker in webidl (from woshilapin:fix-12415/htmlp-htmls); r=jdm <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix (partially) #12415 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because they don't add any feature <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> * HTMLParagraphElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmlparagraphelement )] * HTMLParamElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmlparamelement)] * HTMLPreElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmlpreelement)] * HTMLProgressElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmlprogresselement)] * HTMLQuoteElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmlquoteelement)] * HTMLScriptElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmlscriptelement)] * HTMLSelectElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmlselectelement)] * HTMLSourceElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmlsourceelement)] * HTMLSpanElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmlspanelement)] * HTMLStyleElement.webidl [[spec](https://html.spec.whatwg.org/multipage/#htmlstyleelement)] Source-Repo: https://github.com/servo/servo Source-Revision: 07fcaf48f6eb6eff09b9f764827e5ef37ba49ebc
c5b2df42cc2597371a2a113f0e9023511c542500: servo: Merge #12533 - partial-fix #12415: incorrect exposure of Window,Worker in webidl (from woshilapin:fix-12415/htmlt-htmlv); r=jdm
Jean SIMARD <woshilapin@tuziwo.info> - Fri, 22 Jul 2016 19:17:34 -0500 - rev 368378
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12533 - partial-fix #12415: incorrect exposure of Window,Worker in webidl (from woshilapin:fix-12415/htmlt-htmlv); r=jdm <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix (partially) #12415 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because they don't add any feature <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> * HTMLTemplateElement.webidl [[spec](https://html.spec.whatwg.org/multipage/scripting.html#htmltemplateelement)] * HTMLTextAreaElement.webidl [[spec](https://html.spec.whatwg.org/multipage/forms.html#htmltextareaelement)] * HTMLTimeElement.webidl [[spec](https://html.spec.whatwg.org/multipage/semantics.html#htmltimeelement)] * HTMLTitleElement.webidl [[spec](https://html.spec.whatwg.org/multipage/semantics.html#htmltitleelement)] * HTMLTrackElement.webidl [[spec](https://html.spec.whatwg.org/multipage/embedded-content.html#htmltrackelement)] * HTMLUnknownElement.webidl [[spec](https://html.spec.whatwg.org/multipage/semantics.html#htmlunknownelement)] * HTMLUListElement.webidl [[spec](https://html.spec.whatwg.org/multipage/semantics.html#htmlulistelement)] * HTMLVideoElement.webidl [[spec](https://html.spec.whatwg.org/multipage/embedded-content.html#htmlvideoelement)] Source-Repo: https://github.com/servo/servo Source-Revision: ccc4b41d3610f0d38b279c8f1ff04807fe0cf587
dcfc8c3cbd73cec1b952c90f296a729483e1b942: servo: Merge #12552 - History interface Go, Back, and Forward (from cbrewster:history_interface); r=asajeffrey
Connor Brewster <connor.brewster@eagles.oc.edu> - Fri, 22 Jul 2016 15:34:14 -0500 - rev 368377
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12552 - History interface Go, Back, and Forward (from cbrewster:history_interface); r=asajeffrey <!-- Please describe your changes on the following line: --> r? @asajeffrey --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #5670 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> implement go, forward, back Source-Repo: https://github.com/servo/servo Source-Revision: 0e887ca8d3327b63db43cc329dd83bf4c02e2a1c
a2215c75c4c5c781961ea3be033afb7f70bb5ca2: servo: Merge #12559 - Generate multiple DOM bindings in parallel (from jdm:parallel-codegen); r=Ms2ger
Josh Matthews <josh@joshmatthews.net> - Fri, 22 Jul 2016 12:07:40 -0500 - rev 368376
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12559 - Generate multiple DOM bindings in parallel (from jdm:parallel-codegen); r=Ms2ger Reduces the time for a build after touching `CodegenRust.py` by 58s for me. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12529 (github issue number if applicable). - [X] These changes do not require tests because it's a build performance optimization Source-Repo: https://github.com/servo/servo Source-Revision: cdf225c26e04ac8a2f3294ab32999ec482db8cd4
ffd969183f3a02766db9f77ee27d49758ec5d96c: servo: Merge #12544 - Patches of File API (from izgzhen:patch-file-api); r=Manishearth
Zhen Zhang <izgzhen@gmail.com> - Fri, 22 Jul 2016 01:09:58 -0500 - rev 368375
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12544 - Patches of File API (from izgzhen:patch-file-api); r=Manishearth r? @Manishearth <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] There are tests for these changes OR <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 9c0e7b1cf2696ac214fcb0ce20f95ae9f16f2ea1
ac567e491db5f61b0e4c61c2430f603b26a93a6b: servo: Merge #11866 - Implement joint session history (from cbrewster:joint_session_history); r=asajeffrey
Connor Brewster <brewsterc@my.caspercollege.edu> - Thu, 21 Jul 2016 22:40:56 -0500 - rev 368374
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #11866 - Implement joint session history (from cbrewster:joint_session_history); r=asajeffrey <!-- Please describe your changes on the following line: --> This is cleaned up and should align with the patches on https://github.com/ConnorGBrewster/ServoNavigation/blob/master/notes/notes.pdf r? @asajeffrey --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11669 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because this is not testable until the History API is added. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 05cc76370f4f8dd5c715e42549a2027dc4c8ca71
658ef2031b62490c4665a4b19bb624272460cf03: servo: Merge #12546 - Union types now allow ByteString (from malisas:malisa-bytestring-unions); r=KiChjang
Malisa Smith <malisa.tsmith@gmail.com> - Thu, 21 Jul 2016 21:25:42 -0500 - rev 368373
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12546 - Union types now allow ByteString (from malisas:malisa-bytestring-unions); r=KiChjang <!-- Please describe your changes on the following line: --> This PR addresses issue #12527 to allow ByteStrings in union types. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12527 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 6064f31f1959fa877e96029eedf8723962a10311
6bbba3a67511db235ec2509ba9ffe13f2ee0fcb1: servo: Merge #12469 - style: Rewrite the restyle hints code to allow different kinds of element snapshots (from emilio:stylo); r=bholley
Emilio Cobos Álvarez <ecoal95@gmail.com> - Thu, 21 Jul 2016 16:54:34 -0500 - rev 368372
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12469 - style: Rewrite the restyle hints code to allow different kinds of element snapshots (from emilio:stylo); r=bholley <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] These changes do not require tests because refactoring. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> This is a rewrite for how style interfaces with its consumers in order to allow different representations for an element snapshot. This also changes the requirements of an element snapshot, requiring them to only implement MatchAttr, instead of MatchAttrGeneric. This is important for stylo since implementing MatchAttrGeneric is way more difficult for us given the atom limitations. This also allows for more performant implementations in the Gecko side of things. I don't want to get this merged just yet, mainly because the stylo part is not implemented, but I'd like early feedback from @bholley and/or @heycam: How do you see this approach? I don't think we'll have much problem to implement MatchAttr for our element snapshots, but... worth checking. r? @heycam Source-Repo: https://github.com/servo/servo Source-Revision: 1e0321f7dde5f33f7d26bbd4f088622fa3660477
a3a43f2ec02cad0f8381d772a6891a0f43d39f8a: servo: Merge #12545 - Update ipc-channel (from jdm:ipcchannelbump); r=metajack
Josh Matthews <josh@joshmatthews.net> - Thu, 21 Jul 2016 15:28:04 -0500 - rev 368371
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12545 - Update ipc-channel (from jdm:ipcchannelbump); r=metajack - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12303 - [X] These changes do not require tests because we don't run automated tests on the platforms this affects Source-Repo: https://github.com/servo/servo Source-Revision: f8eab2b1658e687de03d58beb5b87fd0719509ef
c52144012094fa6c89c3b594b819d3ba02e7cbeb: servo: Merge #12541 - Support sequences of sequences in generated bindings (from jdm:seqseq); r=nox
Josh Matthews <josh@joshmatthews.net> - Thu, 21 Jul 2016 14:24:52 -0500 - rev 368370
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12541 - Support sequences of sequences in generated bindings (from jdm:seqseq); r=nox This fixes a blocker for #11897. `unroll` recursively gets the inner type of any sequence type encountered, so it's inappropriate for codegen that only wants the immediate inner type. However, if a type identifies as a sequence and is nullable, we need to reach through the nullable wrapper first. Gecko does very similar things. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12528 (github issue number if applicable). - [X] There are tests for these changes Source-Repo: https://github.com/servo/servo Source-Revision: 4ae0897175143351439ff5b903d05a79c17e3725
423ec8d6f2176635425691d883c81308a59633eb: servo: Merge #12539 - Improve page load error information (from johannhof:error-page); r=jdm
Johann Hofmann <mail@johann-hofmann.com> - Thu, 21 Jul 2016 13:27:06 -0500 - rev 368369
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12539 - Improve page load error information (from johannhof:error-page); r=jdm Fixes #8640. This commit adds a neterror page that displays really really basic information about what went wrong with your request, which is an improvement over the current state of blank page. It also fixes the problem of certificate validation errors not triggering the cert error page, since for some reason the function string seems to have turned lowercase. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #8640. - [x] These changes do not require tests because I'm not sure how to test this, suggestions welcome! r?@jdm Source-Repo: https://github.com/servo/servo Source-Revision: 1e835e330df49da068928231a5b55b165c360a42
9eae875626b805c8a5e4389cedb7aab5a66ebd6f: servo: Merge #12511 - Added test-tidy for dependent licenses (from asajeffrey:test-tidy-dep-licenses); r=larsbergstrom
Alan Jeffrey <ajeffrey@mozilla.com> - Thu, 21 Jul 2016 12:23:24 -0500 - rev 368368
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12511 - Added test-tidy for dependent licenses (from asajeffrey:test-tidy-dep-licenses); r=larsbergstrom <!-- Please describe your changes on the following line: --> Add a test-tidy lint for dependency licenses. Note that #12507 should land first. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because we don't test our lints <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: de4eaa4f21c53a1d1da7d58ef2cda8ef28989fb6
21660f6e86ad6301eb1f5927b329b8e548c3a5f8: servo: Merge #12468 - Removed panic channel, replaced by integrated logging and issue reporting (from asajeffrey:constellation-remove-panic-channel); r=emilio
Alan Jeffrey <ajeffrey@mozilla.com> - Thu, 21 Jul 2016 11:20:37 -0500 - rev 368367
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12468 - Removed panic channel, replaced by integrated logging and issue reporting (from asajeffrey:constellation-remove-panic-channel); r=emilio <!-- Please describe your changes on the following line: --> Remove the previous ad hoc panic channel, replace it by an integrated logging and panicking mechanism, including crash reporting. All thread panics are now reported, not just content threads. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11838 - [X] These changes do not require tests because we don't test error reporting <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: df1b00d43db615244e8e4bcf8296ed51b64249ea
5c19793bc963013b5b3d7346957d9e800edf20cb: servo: Merge #12518 - Remove expect calls in service worker manager thread (from creativcoder:swm-fix); r=nox
Rahul Sharma <rsconceptx@gmail.com> - Thu, 21 Jul 2016 10:17:47 -0500 - rev 368366
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12518 - Remove expect calls in service worker manager thread (from creativcoder:swm-fix); r=nox <!-- Please describe your changes on the following line: --> An intermittent timeout was seen in #12516 , caused by panic of ServiceWorkerManager thread on reception of messages from resource thread. This PR amends things to not have the ServiceWorkerManager thread panic in such situation. cc @jdm --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix ##12516 (github issue number if applicable). <!-- Either: --> - [X] These changes do not require tests because its an "intermittent fix" <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 07a0c2f1dc87fc21a4ed96d251390a4bff165bda
68c3eb970558c77a6e521864644d57dabc2d297d: servo: Merge #12535 - Use Result instead of panicking when the resource dir can't be found (from Manishearth:try-resource); r=KiChjang
Manish Goregaokar <manishsmail@gmail.com> - Thu, 21 Jul 2016 04:08:49 -0500 - rev 368365
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12535 - Use Result instead of panicking when the resource dir can't be found (from Manishearth:try-resource); r=KiChjang <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12520 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it's a refactoring <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: a39bd7db5ba26fa3c95e4bbbb5f1a358bc01965f
75547de353adcc064e99149a1190d382e9d9482f: servo: Merge #12521 - Introduce safer layer of sugar for nsStyleUnion (from Manishearth:safer-coord); r=bholley
Manish Goregaokar <manishsmail@gmail.com> - Thu, 21 Jul 2016 03:05:56 -0500 - rev 368364
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12521 - Introduce safer layer of sugar for nsStyleUnion (from Manishearth:safer-coord); r=bholley This routes (almost) all access to nsStyleUnion through a largely safe interface, CoordData. It also introduces a corresponding Rust enum, CoordDataValue, which can be used when interacting with CoordData LLVM should optimize the costs away in release mode. eddyb tested this a bit, and LLVM has no trouble threading matches together with inlining -- so all of the matches using enums here will have the same generated code as the old matches on the units. Some unresolved questions: Should I provide convenience methods like `set_coord`, `set_auto`, etc on CoordData? `.set_enum(CoordDataValue::Something)` should optimize down to the same thing, but the convenience methods look cleaner and won't load the optimizer as much. Also, we're converting immutable references to mutable ones, which can be used to cause unsafety using some acrobatics. Perhaps a trait-based approach is better? The issue is that in some places we only have a `&CoordData` (eg copy_from), but CoordData internally is `*mut`. It would be nice if CoordData could parametrize over its mutability, but Rust doesn't let us do that. The alternate approach is to make CoordData a trait (also CoordDataMut). The trait requires you to implement `get_union()` and `get_unit()`, and gives you the rest of the functions for free. `nsStyleCoord` would directly implement both traits. `nsStyleSides` would have `data_at(idx)` and `data_at_mut(idx)` methods which return a struct `SidesData` containing a reference to the Sides and the index, which itself implements the `CoordData` and `CoordDataMut` trait (we need two traits here because there will have to be two `SidesData` structs). I decided not to implement the traits approach first since it's pretty trivial to change this code to use traits, and the current design is more straightforward. Thoughts? r? @bholley cc @emilio @heycam Source-Repo: https://github.com/servo/servo Source-Revision: 4a77cbdbb2fc1a4f163171356a7f5340e1237317
5f5140999b0daecd716ddfee29b4d5cf80916d32: servo: Merge #12514 - Issue 12396 to add developer documentation to readme (from changm:issue12396); r=SimonSapin
Mason Chang <mchang@mozilla.com> - Wed, 20 Jul 2016 21:23:18 -0500 - rev 368363
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12514 - Issue 12396 to add developer documentation to readme (from changm:issue12396); r=SimonSapin <!-- Please describe your changes on the following line: --> Just some added developer documentation that was useful for me while starting to develop servo. This adds the documentation about running ./mach clean with a partially built servo but before linking openssl. It also adds the -Z flag under command line flags for debugging help. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X ] `./mach build -d` does not report any errors - [ X] `./mach test-tidy` does not report any errors - [ X] These changes fix #12396 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because it is a documentation update only. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 20b1764d71a967ee4a355cd1b55e4250fe5f59a9
5e6e58e3b087266c5a856446f2a87cb2d44d6d64: servo: Merge #12522 - Update cargo (from servo:update-cargo); r=metajack
Ms2ger <Ms2ger@gmail.com> - Wed, 20 Jul 2016 18:26:16 -0500 - rev 368362
Push 10863 by jlorenzo@mozilla.com at Mon, 06 Mar 2017 23:02:23 +0000
servo: Merge #12522 - Update cargo (from servo:update-cargo); r=metajack Source-Repo: https://github.com/servo/servo Source-Revision: b34b30fd96e29f9c3773c9146c78e3d47fdc156d
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 tip