06982056b5a5cb566eb836d53283b545a927de29: Bug 1245649: Turn on linebreak-style. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 03 Feb 2016 17:04:56 -0800 - rev 306139
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1245649: Turn on linebreak-style. r=Gijs
6c56f5dad3b24506c41d5a38115d19456fe2a802: Bug 1245649: Turn on no-trailing-spaces. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 03 Feb 2016 14:22:33 -0800 - rev 306138
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1245649: Turn on no-trailing-spaces. r=Gijs
345ff6c8b0a24a357c9f0b4d8d4f9c6e5c71eb16: Bug 1245649: Merge browser and toolkit eslint rule settings. r=felipe
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 03 Feb 2016 13:12:18 -0800 - rev 306137
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1245649: Merge browser and toolkit eslint rule settings. r=felipe
9aa32d9a25df32ef740835d14836ff20db0a0cc4: Bug 1234629 - Follow-up: clear distributions from /data/data during test. r=bustage
Nick Alexander <nalexander@mozilla.com> - Thu, 04 Feb 2016 17:41:54 -0800 - rev 306136
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1234629 - Follow-up: clear distributions from /data/data during test. r=bustage On a CLOSED TREE I don't understand why I didn't see this in local testing or try builds, but I didn't. Simple enough: we now load a distribution from /data/data as a matter of course, which means that tests that install such a distribution need to remove it when they are done. This patch does that.
80b86fb2bd9d33773c476e23532427dff75ae4e1: Bug 1168175 - Follow-up: Guard against null contexts. r=bustage
Nick Alexander <nalexander@mozilla.com> - Thu, 04 Feb 2016 17:17:07 -0800 - rev 306135
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1168175 - Follow-up: Guard against null contexts. r=bustage On a CLOSED TREE. So, apparently we race to have a non-null application context from the target context. No matter, we can use the target context directly.
ceb8dff2037ed60e13bc09f7b01b10e88f5c40e8: Bug 1246010 - Force a default width for sidebars even if no pref is set;r=pbrosset
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 04 Feb 2016 16:59:35 -0800 - rev 306134
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1246010 - Force a default width for sidebars even if no pref is set;r=pbrosset
d73d36c9619bed640e6a756746b81ece5ef492cb: Bug 1234629 - Follow-up: Add forgotten documentation file. r=me
Nick Alexander <nalexander@mozilla.com> - Thu, 04 Feb 2016 15:54:12 -0800 - rev 306133
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1234629 - Follow-up: Add forgotten documentation file. r=me Documentation only: DONTBUILD NPOTB
a7f63b3721cd3ba105990bbb37a87044383d26d9: Bug 1233882 - Fold base Gradle project into app Gradle project. r=sebastian,mcomella
Nick Alexander <nalexander@mozilla.com> - Sun, 17 Jan 2016 21:52:46 -0800 - rev 306132
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1233882 - Fold base Gradle project into app Gradle project. r=sebastian,mcomella DONTBUILD NPOTB Using the real Android manifest tripped up Robolectric, so I've taken the easy way out and added a dummy TestGeckoApplication; see comment in the code.
47242d5db87afa496ec1c597dc31d8b91b78f99d: Bug 1227662 - Fix code and add tests for fetching video mimetypes r=margaret
Mark Finkle <mfinkle@mozilla.com> - Thu, 04 Feb 2016 18:19:59 -0500 - rev 306131
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1227662 - Fix code and add tests for fetching video mimetypes r=margaret
10dfe5e3ded1621a7ef777ddbc54e5f80696c3d6: Bug 1242213 - Part 3: Use android:packageName="org.mozilla.gecko" and --rename-manifest-package. r=mfinkle
Nick Alexander <nalexander@mozilla.com> - Sun, 24 Jan 2016 22:00:30 -0800 - rev 306130
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1242213 - Part 3: Use android:packageName="org.mozilla.gecko" and --rename-manifest-package. r=mfinkle ON A CLOSED TREE I have manually verified that this results in a byte-identical gecko.ap_. This is because after the earlier patches there are no definitions (or aliases) that are package-local (like .App or .Webapp), which are the only things (other than the Android package name) that get rewritten by --rename-manifest-package.
92227c8d185ba25e540d7f3ecd82c6d9203e6e54: Bug 1242213 - Part 2: Fold App <activity-alias> into BrowserApp <activity>. r=mfinkle
Nick Alexander <nalexander@mozilla.com> - Sun, 24 Jan 2016 22:00:29 -0800 - rev 306129
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1242213 - Part 2: Fold App <activity-alias> into BrowserApp <activity>. r=mfinkle Way back in Fennec 33 (Bug 929865, see https://hg.mozilla.org/mozilla-central/rev/a4f39c9db1d9) we replaced org.mozilla.gecko.App with org.mozilla.gecko.BrowserApp and introduced the .App <activity-alias>. Per the entry for android:name of http://developer.android.com/guide/topics/manifest/activity-element.html, .App translates to $ANDROID_PACKAGE_NAME.App. We haven't referenced an Activity qualified with a non-org.mozilla.gecko *class* name (for example, from bookmark shortcuts) since well before Fennec 33, so this probably never did what it was intended to do: we wanted to redirect org.mozilla.gecko.App to org.mozilla.gecko.BrowserApp, but it instead has been redirecting org.mozilla.fennec.App to org.mozilla.gecko.BrowserApp. I don't think we've been referring to $ANDROID_PACKAGE_NAME.App since well before Fennec 29, if ever. The <activity-alias> has been servicing essentially all <intent-filter> invocations of Fennec by passing them directly to org.mozilla.gecko.BrowserApp. This pushes a long programme of simplification forward. Fallout might look like very old homescreen shortcuts failing to launch, but I'm quite confident that won't actually happen.
b517a7f4296a430ac91f704eaa8f728f639e6e40: Bug 1242213 - Part 1: Remove old-style Webapp entry-point. r=mfinkle f=myk
Nick Alexander <nalexander@mozilla.com> - Sun, 24 Jan 2016 22:00:29 -0800 - rev 306128
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1242213 - Part 1: Remove old-style Webapp entry-point. r=mfinkle f=myk This <activity> and <activity-alias> support old-style homescreen shortcuts to old-style Webapps. Such shortcuts must have been produced at least 18 months ago, and pre-date the new-style synthetic APK Webapps entirely. New-style APK Webapps are slated to be removed from the product entirely, and there's no reason to keep their even less viable predecessor around. Telemetry from http://mzl.la/23kXGV5 shows that there were no launches of webapps (old-style or new-style) for Fennec 43 release. Telemetry from http://mzl.la/23kXFAs shows that there were 40.7k launches of webapps (again, old-style or new-style) for Fennec 44 beta (of 39.0M total -- for 0.1% total). We cannot distinguish old-style from new-style, but it is safe to assume it's a tiny proportion. Users with such homescreen shortcuts will see a bogus "App isn't installed" message and need to delete and re-create their shortcut in some way. The org.mozilla.gecko.Webapp class cannot be removed until new-style APK Webapps are removed.
2b77aa9048009d076e4dd54a6890657815432b03: Bug 1242213 - Part 0: Use org.mozilla.gecko.BrowserApp instead of .App. r=me,gbrown,bc
Nick Alexander <nalexander@mozilla.com> - Wed, 27 Jan 2016 12:15:19 -0800 - rev 306127
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1242213 - Part 0: Use org.mozilla.gecko.BrowserApp instead of .App. r=me,gbrown,bc This approach lets us get rid of the .App <activity-alias> definitions, at least. In Bug 1237755, I tried pretty hard to use real intent filters, rather than a different hard-code path name, but ran into significant issues, and finally into the hard reality that Android 2.3 doesn't support bare package names. (It only supports package/class component names.) Android 2.3 can't die fast enough. Sadly, this approach doesn't address the issues I see loading URLs that prompted Bug 1237755. This is the path of least resistance. Onwards! Tested via: nalexander@chocho ~/M/gecko> ./mach run Starting: Intent { act=android.activity.MAIN cmp=org.mozilla.fennec_nalexander/org.mozilla.gecko.BrowserApp } Warning: Activity not started, its current task has been brought to the front nalexander@chocho ~/M/gecko> ./mach run https://mozilla.org Starting: Intent { act=android.activity.MAIN dat=https://mozilla.org cmp=org.mozilla.fennec_nalexander/org.mozilla.gecko.BrowserApp } nalexander@chocho ~/M/gecko> ./mach run file:///mnt/sdcard/test.html Starting: Intent { act=android.activity.MAIN dat=file:///mnt/sdcard/test.html cmp=org.mozilla.fennec_nalexander/org.mozilla.gecko.BrowserApp }
21ff9b18942e1ef3572de8eed08efd2ee92202b2: Bug 1245516 - Don't shadow originHost, so we can process appOrigin correctly r=margaret
Andrzej Hunt <ahunt@mozilla.com> - Wed, 03 Feb 2016 15:27:35 -0800 - rev 306126
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1245516 - Don't shadow originHost, so we can process appOrigin correctly r=margaret
c79f4a8c3e86aa0c1c693f637b9d5ac053a6fd2f: Bug 1234629 - Post: Add simple bouncer APK docs. r=me
Nick Alexander <nalexander@mozilla.com> - Thu, 04 Feb 2016 11:23:27 -0800 - rev 306125
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1234629 - Post: Add simple bouncer APK docs. r=me
400c030d3c01d8818fe07d4547e0c145e19f099e: Bug 1234629 - Post: Make bouncer APK Java package org.mozilla.gecko, like the main APK. r=me
Nick Alexander <nalexander@mozilla.com> - Wed, 27 Jan 2016 15:28:12 -0800 - rev 306124
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1234629 - Post: Make bouncer APK Java package org.mozilla.gecko, like the main APK. r=me This small change is a follow-up to Bug 1242213, which did the same for the main package. This is a nod to the future and Gradle, which cleanly splits the internal Java package (org.mozilla.gecko) from the external Android package (org.mozilla.fennec and friends).
54a3d0851bc60d26fb4744c605787031070052c8: Bug 1234629 - Post: Add Gradle support for bouncer. r=me
Nick Alexander <nalexander@mozilla.com> - Tue, 26 Jan 2016 11:54:00 -0800 - rev 306123
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1234629 - Post: Add Gradle support for bouncer. r=me
f80912ecfa87584394d22e28ed09e68c182d1b35: Bug 1234629 - Part 3: Make bouncer's <intent-filter> set a larger subset of Fennec's <intent-filter> set. r=margaret
Nick Alexander <nalexander@mozilla.com> - Wed, 27 Jan 2016 15:44:29 -0800 - rev 306122
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1234629 - Part 3: Make bouncer's <intent-filter> set a larger subset of Fennec's <intent-filter> set. r=margaret
50bcadca213183aaa64e39632892b8f00957dcfc: Bug 1234629 - Part 2: Fail packaging if bouncer APK and main APK have different permissions. r=gps
Nick Alexander <nalexander@mozilla.com> - Wed, 27 Jan 2016 14:34:46 -0800 - rev 306121
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1234629 - Part 2: Fail packaging if bouncer APK and main APK have different permissions. r=gps This isn't sensible for b2gdroid, but that project should never enable the bouncer APK anyway.
aaa420ed66d754ecc17b19f5a12297d24371f1ca: Bug 1234629 - Part 1: Create bouncer APK for OTA distribution installs. r=margaret,gps
Nick Alexander <nalexander@mozilla.com> - Wed, 27 Jan 2016 15:28:31 -0800 - rev 306120
Push 9214 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:25:21 +0000
Bug 1234629 - Part 1: Create bouncer APK for OTA distribution installs. r=margaret,gps This commit produces an "install bouncer" APK which is a "hollow shell" that looks like the main Fennec APK. In particular, both APKs have: * the same Android package name (application id); and * the same set of <permission>, <uses-permission>, and <uses-feature> blocks in their manifests. The bouncer APK must always have an android:versionCode smaller than the main Fennec APK; for now, we will just bump that manually mobile/android/bouncer/moz.build.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip