author Nicholas Nethercote <>
Fri, 03 Mar 2017 15:32:11 +1100
changeset 374836 4e196d802c7be7f3a3c147cc6c5b6406656584b1
parent 373871 0a0883e44430cb50bf837048f55fef176eb90654
child 375112 715af4db0ac4dfb8d4a46ca9e8752ccbba32d54a
permissions -rw-r--r--
Bug 1344118 - Fix the profiler's sleeping threads optimization. r=jseward. When ProfilerBuffer::reset() is called, DuplicateLastSample() will start failing for all sleeping threads because there will be no prior thread data in the buffer to duplicate. But the sampling loop doesn't detect such failure. This causes two problems: - Missing samples. - CPU usage goes through the roof, because each time around the sampling loop the length of the failing search increases. The fix is simple: detect failure in the sampling loop and do a normal sample in that case. The patch also removes ThreadInfo::DuplicateLastSample(), because it just calls onto ProfileBuffer::DuplicateLastSample().

load 68912-1.html
load 257818-1.html
load 285166-1.html
load 294235-1.html
load 307616-1.html
load 324918-1.xhtml
load 338649-1.xhtml
load 339501-1.xhtml
load 339501-2.xhtml
load 378993-1.xhtml
load 382568-1.html
asserts-if(stylo,1) load 383137.xhtml # bug 1324704
load 388183-1.html
load 395340-1.html # bug 1323652
load 399694-1.html
load 407053.html
load 423371-1.html
load 448564.html
load 451123-1.html
load 453406-1.html
load 464197-1.html
load 465466-1.xhtml
load 468562-1.html
load 468562-2.html
load 494225.html
load 495543.svg
load 495546-1.html
load 504183-1.html
load 515829-1.html
load 515829-2.html
load 564461.xhtml
load 570566-1.html
load 571428-1.html
load 580507-1.xhtml
load 590387.html
load 596785-1.html
load 596785-2.html
load 601422.html
load 602117.html
load 604807.html
load 605264.html
load 606430-1.html
load 613027.html
load 614279.html
load 614988-1.html
load 620078-1.html
load 620078-2.html
load 631421.html
load 673853.html
load 680922-1.xul
load 682058.xhtml
load 682460.html
load 738744.xhtml
load 741218.json
load 741250.xhtml
load 795221-1.html
load 795221-2.html
skip-if(stylo) load 795221-3.html # bug 1342289
load 795221-4.html
load 795221-5.xml
load 811226.html
load 819745.html
load 828180.html
pref(dom.experimental_forms,true) load 828472.html
load 837033.html
load 838256-1.html
load 862084.html
load 865147.html
load 877910.html
load 903106.html
load 916322-1.html
load 916322-2.html
load 1032654.html
load 1141260.html
load 1228876.html
load 1230110.html
load 1237633.html
load 1281972-1.html
load 1282894.html
load 1290904.html