70458df3531bcd64226f26c4541d983e58b609f4: Bug 418406 - "Make network error constants accessible via Components.results" [p=trev.moz@adblockplus.org (Wladimir Palant) r=biesi sr=sicking a1.9=damons]
reed@reedloden.com - Tue, 11 Mar 2008 01:14:04 -0700 - rev 12879
Bug 418406 - "Make network error constants accessible via Components.results" [p=trev.moz@adblockplus.org (Wladimir Palant) r=biesi sr=sicking a1.9=damons]
b5dc9683ffc1e0f9d6302545984641c09cbccc5e: Bug 421635 - "[EM] post restart notification should specify foreground color" [p=taken.spc@gmail.com (KUROSAWA, Takeshi) r=rob_strong a1.9=damons]
reed@reedloden.com - Tue, 11 Mar 2008 01:13:07 -0700 - rev 12878
Bug 421635 - "[EM] post restart notification should specify foreground color" [p=taken.spc@gmail.com (KUROSAWA, Takeshi) r=rob_strong a1.9=damons]
f4598b400b650fcd7802640fdff54391b9b15f46: Bug 414342 - "Fix spacing and margins in Preferences, Addons, Pageinfo" [p=ispence@gmail.com (Ian Spence) / michael.monreal@gmx.net (Michael Monreal) r=Mano a1.9=damons]
reed@reedloden.com - Tue, 11 Mar 2008 01:12:06 -0700 - rev 12877
Bug 414342 - "Fix spacing and margins in Preferences, Addons, Pageinfo" [p=ispence@gmail.com (Ian Spence) / michael.monreal@gmx.net (Michael Monreal) r=Mano a1.9=damons]
72786d38a38d8ef274691d56dcbf743bf0866433: Bug 420595 - ""you have chosen to open" dialog uses wrong icon" (Change the accept button icon to a save one when the only choice is "save") [p=frnchfrgg-mozbugs@altern.org (RIVAUD Julien [_FrnchFrgg_]) r=sdwilsh a1.9=damons]
reed@reedloden.com - Tue, 11 Mar 2008 01:11:08 -0700 - rev 12876
Bug 420595 - ""you have chosen to open" dialog uses wrong icon" (Change the accept button icon to a save one when the only choice is "save") [p=frnchfrgg-mozbugs@altern.org (RIVAUD Julien [_FrnchFrgg_]) r=sdwilsh a1.9=damons]
dbda195e8b3bdd0d7f22932afe96c503e251d4c7: Bug 421947 - "More C++ casts required for Windows only, especially overloaded pow() and log10()" [p=benjamin@smedbergs.us (Benjamin Smedberg [bsmedberg]) r=crowder a1.9=damons]
reed@reedloden.com - Tue, 11 Mar 2008 01:09:41 -0700 - rev 12875
Bug 421947 - "More C++ casts required for Windows only, especially overloaded pow() and log10()" [p=benjamin@smedbergs.us (Benjamin Smedberg [bsmedberg]) r=crowder a1.9=damons]
d26489ee6abcc8a5444093b96b9486849f5a92eb: Bug 419036 - "Simplify nsCacheEntryHashTable::VisitEntries and break 'friendship'" [p=alfredkayser@gmail.com (Alfred Kayser) r=dcamp sr=biesi a1.9=damons]
reed@reedloden.com - Tue, 11 Mar 2008 01:08:05 -0700 - rev 12874
Bug 419036 - "Simplify nsCacheEntryHashTable::VisitEntries and break 'friendship'" [p=alfredkayser@gmail.com (Alfred Kayser) r=dcamp sr=biesi a1.9=damons]
f5011715e3cacbd723de62dc259cf376d24d12e0: Bug 413027 reftest
roc+@cs.cmu.edu - Tue, 11 Mar 2008 00:46:40 -0700 - rev 12873
Bug 413027 reftest
5fc74a4bc646d6bccbbb63058043a227b07fd3a7: Bug 413027. The XUL min-size and pref-size for a CSS block should just be its height when reflowed at its preferred width --- NOT the height of the tallest line, that is insane. r+sr=dbaron
roc+@cs.cmu.edu - Tue, 11 Mar 2008 00:38:26 -0700 - rev 12872
Bug 413027. The XUL min-size and pref-size for a CSS block should just be its height when reflowed at its preferred width --- NOT the height of the tallest line, that is insane. r+sr=dbaron
9d02e549668172cf00f37c769efa246cce91f1d0: Bug 420351. Empty bullets cannot make a line non-empty. r+sr=dbaron
roc+@cs.cmu.edu - Tue, 11 Mar 2008 00:36:03 -0700 - rev 12871
Bug 420351. Empty bullets cannot make a line non-empty. r+sr=dbaron
b5ca0beecdab0a49d146cda76bff57ab5dc6b898: Bug 419990 - "Firefox hides the urlbar dropmarker too late when chromehidden contains toolbar" (Correct the chrome size accounting when chromehidden contains toolbar) [p=frnchfrgg-mozbugs@altern.org (RIVAUD Julien [_FrnchFrgg_]) r=Mano a1.9=shaver]
reed@reedloden.com - Tue, 11 Mar 2008 00:08:16 -0700 - rev 12870
Bug 419990 - "Firefox hides the urlbar dropmarker too late when chromehidden contains toolbar" (Correct the chrome size accounting when chromehidden contains toolbar) [p=frnchfrgg-mozbugs@altern.org (RIVAUD Julien [_FrnchFrgg_]) r=Mano a1.9=shaver]
b2edd1210882e3a81a1c5abf17659ebb74f2cad0: Bug 421955. combining mark at start of text run rendered as NUL hex box or garbage. r=roc, a1.9=damons
karlt+@karlt.net - Tue, 11 Mar 2008 00:04:31 -0700 - rev 12869
Bug 421955. combining mark at start of text run rendered as NUL hex box or garbage. r=roc, a1.9=damons
dd5b12de4cd6e2114d7cb895e99f662f6ed95680: Bug 420541: test failures because onfocus never fires for iframe load, r=Enn
ajschult@verizon.net - Mon, 10 Mar 2008 21:35:46 -0700 - rev 12868
Bug 420541: test failures because onfocus never fires for iframe load, r=Enn
a48e789069865be15f087d87525820b654d70ca2: Bug 408938 - Include bookmarks toolbar folder in bookmarks menu. r=dietrich.
mozilla.mano@sent.com - Mon, 10 Mar 2008 20:18:44 -0700 - rev 12867
Bug 408938 - Include bookmarks toolbar folder in bookmarks menu. r=dietrich.
58d4debe70a9b40c0bd6c80a1f926e4a9bccc916: Disable one check that seems to be mysteriously failing.
dolske@mozilla.com - Mon, 10 Mar 2008 19:24:08 -0700 - rev 12866
Disable one check that seems to be mysteriously failing.
d025ab2f8a83dd4538412c38b0d98a0d8c35b732: Back out due to failed mochitest
jonas@sicking.cc - Mon, 10 Mar 2008 19:18:15 -0700 - rev 12865
Back out due to failed mochitest
c96f59e71f675641c0b02baa0f1775500d391136: Bug 419510 PAC dateRange function doesn't handle months after JUN r=biesi a=dsicore Also adds support for getDay("SAT")...
timeless@mozdev.org - Mon, 10 Mar 2008 18:40:08 -0700 - rev 12864
Bug 419510 PAC dateRange function doesn't handle months after JUN r=biesi a=dsicore Also adds support for getDay("SAT")...
d94399ec917e156d8107206268ff2fe889a73cf8: Bug 401155: Make sure plugins and XBL constructors not execute when creating a script wrapper if it's not safe to execute scripts. r=bz sr=jst.
jonas@sicking.cc - Mon, 10 Mar 2008 17:49:19 -0700 - rev 12863
Bug 401155: Make sure plugins and XBL constructors not execute when creating a script wrapper if it's not safe to execute scripts. r=bz sr=jst.
57aa933e94e309d31a27e47da7d45d1daaae2c97: Bug 402637 - Make uri-element class work on any element, r=mano, r=mconnor, a1.9=dsicore
philringnalda@gmail.com - Mon, 10 Mar 2008 17:19:04 -0700 - rev 12862
Bug 402637 - Make uri-element class work on any element, r=mano, r=mconnor, a1.9=dsicore
7f7cbe3bb5105e0170c54a30c90871ffe3126459: Bug 419081 - Password prompting code doesn't check new passwords against all possible existing passwords. r=gavin, a=blocking-ff3+
dolske@mozilla.com - Mon, 10 Mar 2008 17:14:10 -0700 - rev 12861
Bug 419081 - Password prompting code doesn't check new passwords against all possible existing passwords. r=gavin, a=blocking-ff3+
efc6c7ab3f328668914c0c669ee5e83e1ecf621d: Bug 421303 Crash [@ jsds_ScriptHookProc] r=caillon a=dsicore If we reach ~jsdService, that means our client doesn't care about us, so we can (and should) drop all references to any callbacks (if they cared, they'd have kept us alive!*). I think jsdService::Off should clear all the hooks, the strange magic of not clearing it isn't really a great idea. So for Off, we'll now clear the ScriptHook too (consumers who use off should really drop any references they have to our objects...). I'm still on the fence on this point, I suspect we can actually move it from ::Off to ~jsdService (it must be cleared at some point, otherwise if jsd_xpc's library manages to get unloaded, the function pointer would be invalid, which would be *BAD*). jsds_NotifyPendingDeadScripts needs to clear gDeadScripts whether or not there's a service or hooks, so it does. Because it's a static callback and because of the scary way GC works, I'd rather ensure (deathgrip) that jsds is available (and consistent!) for the duration of the function call. The code already handles the lack of a hook, so there's no reason to do magical returns.... The real problem which mayhemer found was that jsdService::Off was returning early (failure) because gGCStatus wasn't JSGC_END when called from ~jsdService from JS_GC from the cyclecollector, so we make sure that ~jsdService forces ::Off to act as if it is JSGC_END (after ensuring that there are no callbacks available). * a pure javascript (xpcom component, not DOM hosted!) version of a jsdService consumer means that jsdService will need to talk to the CycleCollector eventually (this is another bug for the future).
timeless@mozdev.org - Mon, 10 Mar 2008 17:13:48 -0700 - rev 12860
Bug 421303 Crash [@ jsds_ScriptHookProc] r=caillon a=dsicore If we reach ~jsdService, that means our client doesn't care about us, so we can (and should) drop all references to any callbacks (if they cared, they'd have kept us alive!*). I think jsdService::Off should clear all the hooks, the strange magic of not clearing it isn't really a great idea. So for Off, we'll now clear the ScriptHook too (consumers who use off should really drop any references they have to our objects...). I'm still on the fence on this point, I suspect we can actually move it from ::Off to ~jsdService (it must be cleared at some point, otherwise if jsd_xpc's library manages to get unloaded, the function pointer would be invalid, which would be *BAD*). jsds_NotifyPendingDeadScripts needs to clear gDeadScripts whether or not there's a service or hooks, so it does. Because it's a static callback and because of the scary way GC works, I'd rather ensure (deathgrip) that jsds is available (and consistent!) for the duration of the function call. The code already handles the lack of a hook, so there's no reason to do magical returns.... The real problem which mayhemer found was that jsdService::Off was returning early (failure) because gGCStatus wasn't JSGC_END when called from ~jsdService from JS_GC from the cyclecollector, so we make sure that ~jsdService forces ::Off to act as if it is JSGC_END (after ensuring that there are no callbacks available). * a pure javascript (xpcom component, not DOM hosted!) version of a jsdService consumer means that jsdService will need to talk to the CycleCollector eventually (this is another bug for the future).
(0) -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip