searching for reviewer(jst)
ed32cbc749af541110036a40294fccaab3079464: Followup bustage fix for bug 653926. r=jst a=akeybl for checkin into a CLOSED TREE CAMINO_2_1_MINIBRANCH
Blake Kaplan <mrbkap@gmail.com> - Mon, 31 Oct 2011 14:37:04 -0700 - rev 35225
Push 1998 by alqahira@ardisson.org at Thu, 03 Nov 2011 02:27:52 +0000
Followup bustage fix for bug 653926. r=jst a=akeybl for checkin into a CLOSED TREE
eb499b0c7d8cd70aacfb81384b013e6afa836805: Fix bug 653926. r=jst a=LegNeato CAMINO_2_1_MINIBRANCH
Blake Kaplan <mrbkap@gmail.com> - Fri, 28 Oct 2011 13:47:46 -0700 - rev 35224
Push 1998 by alqahira@ardisson.org at Thu, 03 Nov 2011 02:27:52 +0000
Fix bug 653926. r=jst a=LegNeato
b5d60f395ce5de1e5b8832025bb8722ac8ff5b24: Followup bustage fix for bug 653926. r=jst a=akeybl for checkin into a CLOSED TREE
Blake Kaplan <mrbkap@gmail.com> - Mon, 31 Oct 2011 14:37:04 -0700 - rev 35209
Push 1991 by mrbkap@mozilla.com at Mon, 31 Oct 2011 21:55:29 +0000
Followup bustage fix for bug 653926. r=jst a=akeybl for checkin into a CLOSED TREE
2d3d72d5868dc3ea390daa178cb9b82a3ce631e6: Fix bug 653926. r=jst a=LegNeato
Blake Kaplan <mrbkap@gmail.com> - Fri, 28 Oct 2011 13:47:46 -0700 - rev 35208
Push 1990 by mrbkap@mozilla.com at Fri, 28 Oct 2011 23:49:45 +0000
Fix bug 653926. r=jst a=LegNeato
535985445918e32d99c80aa036ae0d2c41bd85cb: Bug 665548 - bail early on failure r=jst, a=dveditz
Mounir Lamouri <mounir.lamouri@gmail.com> - Tue, 09 Aug 2011 01:40:51 +0200 - rev 35133
Push 1949 by dveditz@mozilla.com at Tue, 09 Aug 2011 01:27:58 +0000
Bug 665548 - bail early on failure r=jst, a=dveditz
5d9164417ba7495a3573474f4a077e586678af70: Bug 552663 - Crash [@ nsContentUtils::ComparePosition], r=jst, a=dveditz
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 29 Jul 2011 19:26:14 +0300 - rev 35118
Push 1940 by opettay@mozilla.com at Fri, 29 Jul 2011 16:28:59 +0000
Bug 552663 - Crash [@ nsContentUtils::ComparePosition], r=jst, a=dveditz
6991b08bcf4890c6bed76e09fe2fe6c960271e1e: Fix bug 614151. r=jst@mozilla.com, a=dveditz
Blake Kaplan <mrbkap@gmail.com> - Tue, 28 Dec 2010 11:21:30 -0800 - rev 35116
Push 1939 by mrbkap@mozilla.com at Thu, 28 Jul 2011 23:19:55 +0000
Fix bug 614151. r=jst@mozilla.com, a=dveditz
e828fec9dc313a4391f59b3dfc0ef4e1089a00e5: Bug 648065: Followup to make implicit adoption of doctypes work. r=jst a=dveditz
Jonas Sicking <jonas@sicking.cc> - Tue, 26 Jul 2011 14:04:03 -0700 - rev 35115
Push 1938 by sicking@mozilla.com at Tue, 26 Jul 2011 21:04:22 +0000
Bug 648065: Followup to make implicit adoption of doctypes work. r=jst a=dveditz
97b5edc11e01b9f0e075312353dabe447873ca21: Bug 648065: Don't attempt to insert nodes that live in the wrong document as a child if userdata or mutation handlers have moved the node after we originally adopted it. r=jst a=dveditz
Jonas Sicking <jonas@sicking.cc> - Thu, 21 Jul 2011 17:07:19 -0700 - rev 35109
Push 1932 by sicking@mozilla.com at Fri, 22 Jul 2011 00:13:57 +0000
Bug 648065: Don't attempt to insert nodes that live in the wrong document as a child if userdata or mutation handlers have moved the node after we originally adopted it. r=jst a=dveditz
9ce9a35604f24a0b5cb52e7f0a1f017a5162f8d1: Fixing more bustage from bug 604262. r=jst a=dveditz
Blake Kaplan <mrbkap@gmail.com> - Tue, 12 Apr 2011 14:09:05 -0700 - rev 35025
Push 1877 by mrbkap@mozilla.com at Tue, 12 Apr 2011 21:11:27 +0000
Fixing more bustage from bug 604262. r=jst a=dveditz
a7a241b581ad67daf7d32fccc028723759f2b68d: Bug 631421: Teach nsImageDocument to say the magic password to nsImageLoadingContent::RemoveObserver. r=jst a=dveditz
Kyle Huey <khuey@kylehuey.com> - Sun, 20 Feb 2011 09:40:45 -0500 - rev 35022
Push 1874 by mrbkap@mozilla.com at Tue, 12 Apr 2011 05:27:57 +0000
Bug 631421: Teach nsImageDocument to say the magic password to nsImageLoadingContent::RemoveObserver. r=jst a=dveditz
c24f21581d77bda498317670abc9779fa5bbfa17: Bug 634986. Don't act like we're redirecting if we don't have a channel. r=jst, a=blocker
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 02 Mar 2011 14:21:13 -0500 - rev 34956
Push 1838 by bzbarsky@mozilla.com at Wed, 02 Mar 2011 19:22:45 +0000
Bug 634986. Don't act like we're redirecting if we don't have a channel. r=jst, a=blocker
c85da142aaf0f76fab3f0dc1ef241f0cd8a38559: Bug 630919, add collect and invalidate phases for tree ranges, r=enn+neil, a=jst
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 01 Mar 2011 15:26:00 +0200 - rev 34952
Push 1834 by opettay@mozilla.com at Tue, 01 Mar 2011 13:55:10 +0000
Bug 630919, add collect and invalidate phases for tree ranges, r=enn+neil, a=jst
1abc3d4ba037c64e9253b0e7470945520ce6575a: Bug 631607 - Crash while spell checking with French modern dictionary 4.0.3 [@ mozalloc_abort(char const* const) ][@ mozalloc_abort(char const* const) | mozalloc_handle_oom() ]; r=jst a=LegNeato
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 08 Feb 2011 18:01:06 -0500 - rev 34945
Push 1829 by eakhgari@mozilla.com at Thu, 24 Feb 2011 19:47:01 +0000
Bug 631607 - Crash while spell checking with French modern dictionary 4.0.3 [@ mozalloc_abort(char const* const) ][@ mozalloc_abort(char const* const) | mozalloc_handle_oom() ]; r=jst a=LegNeato
d7c24aa07c300a3eeb1610e627ad71ce294663ca: Fix for bug 605672 (Fix reason for invalid scope assertion). r=jst, a=clegnitto.
Peter Van der Beken <peterv@propagandism.org> - Wed, 19 Jan 2011 15:27:57 -0800 - rev 34882
Push 1781 by jst@mozilla.com at Wed, 19 Jan 2011 23:29:12 +0000
Fix for bug 605672 (Fix reason for invalid scope assertion). r=jst, a=clegnitto.
095ed971f2a45eccbdcf47304df43ff76804b394: Bug 478823: Fix memory leak that can result from reloading the plugin list. r=josh r=jst a1.9.2.14=bsterne
Scott Greenlay - Wed, 12 Jan 2011 00:32:42 -0800 - rev 34862
Push 1766 by dveditz@mozilla.com at Wed, 12 Jan 2011 08:33:58 +0000
Bug 478823: Fix memory leak that can result from reloading the plugin list. r=josh r=jst a1.9.2.14=bsterne
6697a04d3f8727ae8974b52b5f6e3b7a3d7f85d7: Fix plugin stream test to not assume bogus things about the exception error messages it will get. r=jst@mozilla.org
Ben Turner <bent.mozilla@gmail.com> - Sun, 10 Oct 2010 15:39:14 -0700 - rev 34848
Push 1752 by bzbarsky@mozilla.com at Thu, 30 Dec 2010 22:52:44 +0000
Fix plugin stream test to not assume bogus things about the exception error messages it will get. r=jst@mozilla.org
fd40740804fe525ec91e288b8fcd91ede57406b1: Bug 406375 - In modal dialog (window.open with modal=yes) child windows and dialogs do not populate with expected content, r=jst, a=clegnitto
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 27 Dec 2010 11:27:44 +0200 - rev 34835
Push 1745 by opettay@mozilla.com at Mon, 27 Dec 2010 09:31:36 +0000
Bug 406375 - In modal dialog (window.open with modal=yes) child windows and dialogs do not populate with expected content, r=jst, a=clegnitto
a86d079b0514c7a057b3518c68255171e7d080cc: Bug 541396 - Intermittent failure in test_fallback.html | Fallback page displayed for top level document, r=jst, a=test-only-change
Honza Bambas <honzab.moz@firemni.cz> - Wed, 15 Dec 2010 19:30:01 +0100 - rev 34829
Push 1739 by sgautherie.bz@free.fr at Sat, 18 Dec 2010 03:36:26 +0000
Bug 541396 - Intermittent failure in test_fallback.html | Fallback page displayed for top level document, r=jst, a=test-only-change
1e85c1a49573738117354adde8deb2a430f37789: Properly check attribute URLs -- Bug 562547, r=jst, blocking2.0
Robert Sayre <sayrer@gmail.com> - Tue, 14 Dec 2010 21:26:27 +0100 - rev 34821
Push 1737 by mozilla.BenB@bucksch.org at Tue, 14 Dec 2010 20:26:53 +0000
Properly check attribute URLs -- Bug 562547, r=jst, blocking2.0 Do not inherit principal from embedding doc (often chrome) when checking URIs, but use NullPrincipal for untrusted content.
6bc072d1c54548f686ca51b12688e7aed9fc6059: Bug 573873: Fix bug in HTTP handling for plugins. r=jst a=dveditz
Josh Aas <joshmoz@gmail.com> - Wed, 08 Dec 2010 15:34:29 -0500 - rev 34808
Push 1730 by josh@mozilla.com at Wed, 08 Dec 2010 20:36:10 +0000
Bug 573873: Fix bug in HTTP handling for plugins. r=jst a=dveditz
10fd22d179025df9c0f5cb4555b2da11562b5c4e: Bug 608662 - fix X-Frame-Options crash when using external view-source editor, r=jst, a=dveditz
Brandon Sterne <bsterne@mozilla.com> - Fri, 19 Nov 2010 10:41:00 -0800 - rev 34775
Push 1707 by reed@reedloden.com at Sun, 21 Nov 2010 01:07:54 +0000
Bug 608662 - fix X-Frame-Options crash when using external view-source editor, r=jst, a=dveditz
5cb659ed04a07349b8d9da4b159b0350e9ec1847: Bug 605077 - "Gmail Inbox not loading in standard view" [r=jst a=dveditz]
Brandon Sterne <bsterne@mozilla.com> - Wed, 20 Oct 2010 08:37:00 -0700 - rev 34774
Push 1706 by reed@reedloden.com at Sun, 21 Nov 2010 01:04:26 +0000
Bug 605077 - "Gmail Inbox not loading in standard view" [r=jst a=dveditz]
5b97fd4f11d49e6ca22440cc98f6c9875f27aac3: Bug 581226 - "Assertion failure: ASSERTION: DoContent returned no listener?: 'abort || m_targetStreamListener'" [r=jst a=clegnitto]
Brandon Sterne <bsterne@mozilla.com> - Wed, 29 Sep 2010 15:04:00 -0700 - rev 34761
Push 1694 by reed@reedloden.com at Fri, 19 Nov 2010 08:39:57 +0000
Bug 581226 - "Assertion failure: ASSERTION: DoContent returned no listener?: 'abort || m_targetStreamListener'" [r=jst a=clegnitto]
81f0ff4d3cbb4e90e20ae98931c0141b5fe140c5: Fix bug 554449. r=jst sr=peterv a=LegNeato
Blake Kaplan <mrbkap@gmail.com> - Tue, 27 Apr 2010 16:24:35 -0700 - rev 34759
Push 1692 by mrbkap@mozilla.com at Fri, 19 Nov 2010 07:57:19 +0000
Fix bug 554449. r=jst sr=peterv a=LegNeato
85be45fb4a3416aec3c28da194ee975dd262c191: Bug 611897 - r=jst,bzbarsky a=blocking1.9.2.13+
Steven Michaud <smichaud@pobox.com> - Thu, 18 Nov 2010 20:20:38 -0600 - rev 34757
Push 1690 by smichaud@pobox.com at Fri, 19 Nov 2010 02:21:10 +0000
Bug 611897 - r=jst,bzbarsky a=blocking1.9.2.13+
37a0416ff3ffa7c1eba4258965bd4b61d461edcd: Bug 573873: Fix bug in HTTP handling for plugins. r=jst a=LegNeato
Josh Aas <joshmoz@gmail.com> - Thu, 18 Nov 2010 18:18:06 -0500 - rev 34756
Push 1689 by josh@mozilla.com at Thu, 18 Nov 2010 23:18:46 +0000
Bug 573873: Fix bug in HTTP handling for plugins. r=jst a=LegNeato
ba187e04e20ef6a4bc4fbbb0305fd47c6a84365d: Bug 599479 - Accessing window.localStorage with dom.storage.enabled=false causes NS_ERROR_DOM_SECURITY_ERR, r=jst, a1.9.2.13=LegNeato
Honza Bambas <honzab.moz@firemni.cz> - Thu, 18 Nov 2010 21:23:18 +0100 - rev 34752
Push 1685 by honzab.moz@firemni.cz at Thu, 18 Nov 2010 20:24:34 +0000
Bug 599479 - Accessing window.localStorage with dom.storage.enabled=false causes NS_ERROR_DOM_SECURITY_ERR, r=jst, a1.9.2.13=LegNeato
f1ae505ad72dfa2cf16b6b5e98f20d0403ba0b3d: Bug 610525 - r=jst a=blocking1.9.2.13
Steven Michaud <smichaud@pobox.com> - Mon, 15 Nov 2010 10:22:34 -0600 - rev 34734
Push 1673 by smichaud@pobox.com at Mon, 15 Nov 2010 16:23:15 +0000
Bug 610525 - r=jst a=blocking1.9.2.13
236dc97577177127ca482180f72f4ac9d74c9dd7: Bug 608662 - Fix X-Frame-Options crash when external view-source editor is set, r=jst, a=LegNeato
Brandon Sterne <bsterne@mozilla.com> - Fri, 05 Nov 2010 13:00:16 -0700 - rev 34726
Push 1666 by bsterne@mozilla.com at Fri, 05 Nov 2010 20:00:52 +0000
Bug 608662 - Fix X-Frame-Options crash when external view-source editor is set, r=jst, a=LegNeato
8b515f27f430495c06832503d91bdee9b957d778: Bug 602780. Fix handling of hosts in NS_SecurityCompareURIs. r=jst, a=dveditz
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 15 Oct 2010 17:55:53 -0400 - rev 34701
Push 1650 by bzbarsky@mozilla.com at Tue, 26 Oct 2010 02:05:10 +0000
Bug 602780. Fix handling of hosts in NS_SecurityCompareURIs. r=jst, a=dveditz
74e4421e0a30c6e21b594675e32a8d9d663c309c: Bug 605307 - nsGeolocation::ClearWatch crash. r=jst a=LegNeato
Doug Turner <dougt@dougt.org> - Tue, 19 Oct 2010 12:31:15 -0700 - rev 34694
Push 1644 by dougt@mozilla.com at Thu, 21 Oct 2010 00:47:59 +0000
Bug 605307 - nsGeolocation::ClearWatch crash. r=jst a=LegNeato
fb800ed2a4b1a9f57c374f74d606611b31eb724d: Fix bug 576616. r=jst
Blake Kaplan <mrbkap@gmail.com> - Thu, 22 Jul 2010 16:35:58 -0700 - rev 34649
Push 1612 by dveditz@mozilla.com at Wed, 29 Sep 2010 22:28:25 +0000
Fix bug 576616. r=jst
5f928f65382d6dba33488ac8208a421902681e93: bug 588929, don't throw when getting/setting visibility of *bars, r=jst, sr=mrbkap, a=dveditz
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 28 Sep 2010 15:33:21 +0300 - rev 34631
Push 1599 by opettay@mozilla.com at Tue, 28 Sep 2010 13:59:32 +0000
bug 588929, don't throw when getting/setting visibility of *bars, r=jst, sr=mrbkap, a=dveditz
bf0d8cb609598d9f69875293ddc14cd9cf0f20e4: Bug 588874 - Replace Minefield with Firefox in UA string. r=khuey, sr=jst, a=dveditz
Dan Witte <dwitte@mozilla.com> - Mon, 27 Sep 2010 16:56:14 -0700 - rev 34617
Push 1591 by dwitte@mozilla.com at Mon, 27 Sep 2010 23:56:20 +0000
Bug 588874 - Replace Minefield with Firefox in UA string. r=khuey, sr=jst, a=dveditz
92c5cc22340203f81771b112d773b52e41bc32ab: Bug 594699 - Null check this to return to pre-bug 532730 behavior in pathological cases. r=jst a=Standard8 for checkin to Thunderbird-only COMM1929_20100825_RELBRANCH COMM1929_20100825_RELBRANCH
Blake Kaplan <mrbkap@gmail.com> - Tue, 14 Sep 2010 10:52:50 -0700 - rev 34575
Push 1563 by bugzilla@standard8.plus.com at Wed, 15 Sep 2010 10:16:17 +0000
Bug 594699 - Null check this to return to pre-bug 532730 behavior in pathological cases. r=jst a=Standard8 for checkin to Thunderbird-only COMM1929_20100825_RELBRANCH
8e370c690d2e82b9b8dda47a97fd39ce4f7ab1e4: Bug 594699 - Null check this to return to pre-bug 532730 behavior in pathological cases. r=jst a=LegNeato
Blake Kaplan <mrbkap@gmail.com> - Tue, 14 Sep 2010 10:52:50 -0700 - rev 34569
Push 1560 by mrbkap@mozilla.com at Tue, 14 Sep 2010 17:53:37 +0000
Bug 594699 - Null check this to return to pre-bug 532730 behavior in pathological cases. r=jst a=LegNeato
097d5f0a0e1c7839591380f2580c836af27fb2fe: Bug 594699 - Null check this to return to pre-bug 532730 behavior in pathological cases. r=jst a=LegNeato GECKO1929_20100824_RELBRANCH
Blake Kaplan <mrbkap@gmail.com> - Tue, 14 Sep 2010 10:52:50 -0700 - rev 34568
Push 1559 by mrbkap@mozilla.com at Tue, 14 Sep 2010 17:53:05 +0000
Bug 594699 - Null check this to return to pre-bug 532730 behavior in pathological cases. r=jst a=LegNeato
a962fcafdd3ebc6f840baa84e1c49c6c02ad04b6: Fix bug 584512. r=jst a=dveditz
Blake Kaplan <mrbkap@gmail.com> - Thu, 12 Aug 2010 21:05:05 -0700 - rev 34533
Push 1533 by mrbkap@mozilla.com at Mon, 16 Aug 2010 19:41:14 +0000
Fix bug 584512. r=jst a=dveditz
b80930b974b07dcb0c8007059d897bdba52a3663: Fix bug 552090. r=sicking sr=jst
Blake Kaplan <mrbkap@gmail.com> - Tue, 16 Mar 2010 16:23:45 -0700 - rev 34529
Push 1530 by mrbkap@mozilla.com at Fri, 13 Aug 2010 18:38:21 +0000
Fix bug 552090. r=sicking sr=jst
56ad2e0034a379b756f02bbe0fad349ca11bde66: Fix bug 532730. r=jst sr=sicking
Blake Kaplan <mrbkap@gmail.com> - Tue, 27 Apr 2010 15:39:52 -0700 - rev 34528
Push 1530 by mrbkap@mozilla.com at Fri, 13 Aug 2010 18:38:21 +0000
Fix bug 532730. r=jst sr=sicking
10046599e0cacf46383268617bdd5bf985ea7389: Fix bug 576447. r=jst/dbaron a=dveditz
Jonas Sicking <jonas@sicking.cc> - Tue, 20 Jul 2010 17:37:08 -0700 - rev 34524
Push 1527 by sicking@mozilla.com at Fri, 13 Aug 2010 03:01:20 +0000
Fix bug 576447. r=jst/dbaron a=dveditz
f5ebe00ac30b7c21f95422c457547878fe2467d6: Bug 570417 - All content iterators need to take part in cycle collection; r=jst a1.9.2.9=LegNeato
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 08 Jun 2010 00:31:44 -0400 - rev 34499
Push 1507 by eakhgari@mozilla.com at Fri, 06 Aug 2010 18:31:40 +0000
Bug 570417 - All content iterators need to take part in cycle collection; r=jst a1.9.2.9=LegNeato
164d166a913f0fc0b79e21c75c237eed2cdf1698: Fix for bug 583225 (Use the right DOMCI for DocumentFragment). r=jst, a=LegNeato.
Peter Van der Beken <peterv@propagandism.org> - Fri, 30 Jul 2010 15:04:30 +0200 - rev 34480
Push 1495 by pvanderbeken@mozilla.com at Tue, 03 Aug 2010 09:25:10 +0000
Fix for bug 583225 (Use the right DOMCI for DocumentFragment). r=jst, a=LegNeato.
177e3561f58cd2d71087f64b8f3655c96f82e2a1: Bug 336104 - bustage fix; r=jst a1.9.2.9=beltzner
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Jul 2010 15:28:50 -0400 - rev 34465
Push 1484 by eakhgari@mozilla.com at Tue, 27 Jul 2010 19:29:07 +0000
Bug 336104 - bustage fix; r=jst a1.9.2.9=beltzner
ac83b3496c63d32adb96a5500c5feffb6e5673e6: Bug 564461 - Change content editable count from a script runner; r=jst a1.9.2.9=dveditz
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 12 May 2010 18:21:24 -0400 - rev 34450
Push 1476 by eakhgari@mozilla.com at Fri, 23 Jul 2010 20:29:41 +0000
Bug 564461 - Change content editable count from a script runner; r=jst a1.9.2.9=dveditz
a2e1894b6ecf22225bf29258cf1f4fafa22b762c: Bug 475530 - X-Frame-Options w/ redirect to about:blank, r=jst
Brandon Sterne <bsterne@mozilla.com> - Fri, 23 Jul 2010 12:08:01 -0700 - rev 34449
Push 1475 by bsterne@mozilla.com at Fri, 23 Jul 2010 19:14:44 +0000
Bug 475530 - X-Frame-Options w/ redirect to about:blank, r=jst
ad35ca56728931eb312d6fe10d06d9f0e6279af3: Bug 579744. Extract the actual content type from the attribute value before using it as a type hint for the channel. r=jst
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 22 Jul 2010 17:34:21 -0400 - rev 34447
Push 1473 by bzbarsky@mozilla.com at Thu, 22 Jul 2010 22:43:49 +0000
Bug 579744. Extract the actual content type from the attribute value before using it as a type hint for the channel. r=jst
fd971f28dfd1381f8eb54c4d32830b48b86d1804: Fix logic here. r=jst r=josh a=clegnitto GECKO1927_20100701_RELBRANCH
Chris Jones <jones.chris.g@gmail.com> - Thu, 22 Jul 2010 17:07:12 -0400 - rev 34443
Push 1471 by josh@mozilla.com at Thu, 22 Jul 2010 21:07:55 +0000
Fix logic here. r=jst r=josh a=clegnitto
96ae337c41fbff7c1c96ddca599ee5997ffed406: Bug 575836: Fix logic here. r=jst r=josh
Chris Jones <jones.chris.g@gmail.com> - Thu, 22 Jul 2010 16:44:11 -0400 - rev 34442
Push 1470 by josh@mozilla.com at Thu, 22 Jul 2010 20:46:13 +0000
Bug 575836: Fix logic here. r=jst r=josh