Bug 1576397 - Fix updating the checked state of "Message Pane" in appmenu. r+a=jorgk
authorPaul Morris <paul@thunderbird.net>
Mon, 26 Aug 2019 14:35:11 -0400
changeset 36186 c5cd0eb02cd0b582b19e0ef68532a6ab8ec19dcd
parent 36185 32788fdbc17c3891a91ce749388175fa35f7347f
child 36187 3f2d30df82df3291b31d74ab1f2b790e194c2e69
push id392
push userclokep@gmail.com
push dateMon, 02 Sep 2019 20:17:19 +0000
bugs1576397
Bug 1576397 - Fix updating the checked state of "Message Pane" in appmenu. r+a=jorgk Here: Appmenu > Preferences > Layout > Message Pane.
mail/base/content/mailWindowOverlay.js
--- a/mail/base/content/mailWindowOverlay.js
+++ b/mail/base/content/mailWindowOverlay.js
@@ -197,17 +197,17 @@ function view_init() {
   let messagePaneMenuItem = document.getElementById("menu_showMessage");
   if (!messagePaneMenuItem.hidden) { // Hidden in the standalone msg window.
     messagePaneMenuItem.setAttribute("checked",
       accountCentralDisplayed ? false : gMessageDisplay.visible);
     messagePaneMenuItem.disabled = accountCentralDisplayed;
   }
 
   let messagePaneAppMenuItem = document.getElementById("appmenu_showMessage");
-  if (messagePaneAppMenuItem && messagePaneAppMenuItem.hidden) { // Hidden in the standalone msg window.
+  if (messagePaneAppMenuItem && !messagePaneAppMenuItem.hidden) { // Hidden in the standalone msg window.
     messagePaneAppMenuItem.setAttribute("checked",
       accountCentralDisplayed ? false : gMessageDisplay.visible);
     messagePaneAppMenuItem.disabled = accountCentralDisplayed;
   }
 
   let folderPaneMenuItem = document.getElementById("menu_showFolderPane");
   if (!folderPaneMenuItem.hidden) { // Hidden in the standalone msg window.
     folderPaneMenuItem.setAttribute("checked", gFolderDisplay.folderPaneVisible);