Bug 1563089 - replace <textbox> in EdHLineProps.xul. r=mkmelin
authorKhushil Mistry <khushil324@gmail.com>
Mon, 30 Sep 2019 23:40:00 +0200
changeset 37033 b55b050060f57778da498794870408a11a390da8
parent 37032 387fad8b2d9c5a3d353f45aa54da471c8103b8bd
child 37034 d09c38b4a740dc580c3d6c5b8fb8af399e372d9d
push id395
push userclokep@gmail.com
push dateMon, 02 Dec 2019 19:38:57 +0000
reviewersmkmelin
bugs1563089
Bug 1563089 - replace <textbox> in EdHLineProps.xul. r=mkmelin
mail/components/compose/content/dialogs/EdHLineProps.xul
mail/themes/linux/editor/EditorDialog.css
mail/themes/osx/editor/EditorDialog.css
mail/themes/windows/editor/EditorDialog.css
--- a/mail/components/compose/content/dialogs/EdHLineProps.xul
+++ b/mail/components/compose/content/dialogs/EdHLineProps.xul
@@ -1,64 +1,75 @@
 <?xml version="1.0"?>
 
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <?xml-stylesheet href="chrome://editor/skin/editor.css" type="text/css"?>
 <?xml-stylesheet href="chrome://editor/skin/EditorDialog.css" type="text/css"?>
+<?xml-stylesheet href="chrome://messenger/skin/input-fields.css" type="text/css"?>
 
 <!DOCTYPE dialog [
 <!ENTITY % edHLineProperties SYSTEM "chrome://messenger/locale/messengercompose/EditorHLineProperties.dtd">
 %edHLineProperties;
 <!ENTITY % edDialogOverlay SYSTEM "chrome://messenger/locale/messengercompose/EdDialogOverlay.dtd">
 %edDialogOverlay;
 ]>
 
 <dialog title="&windowTitle.label;"
     xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" xmlns:html="http://www.w3.org/1999/xhtml"
     onload="Startup()">
 
+  <script src="chrome://global/content/globalOverlay.js"/>
+  <script src="chrome://global/content/editMenuOverlay.js"/>
   <!-- Methods common to all editor dialogs -->
   <script src="chrome://messenger/content/messengercompose/editorUtilities.js"/>
   <script src="chrome://messenger/content/messengercompose/EdDialogCommon.js"/>
   <!--- Element-specific methods -->
   <script src="chrome://messenger/content/messengercompose/EdHLineProps.js"/>
 
   <spacer id="location" offsetY="50" persist="offsetX offsetY"/>
 
   <groupbox>
     <hbox class="groupbox-title">
       <label class="header">&dimensionsBox.label;</label>
     </hbox>
-    <hbox>
-      <vbox>
-        <hbox align="center" flex="1">
-          <label control="width"
+    <html:table>
+      <html:tr>
+        <html:th>
+          <label id="widthLabel"
+                 control="width"
                  value="&widthEditField.label;"
                  accesskey="&widthEditField.accessKey;"/>
-        </hbox>
-        <hbox align="center" flex="1">
-          <label control="height"
+        </html:th>
+        <html:td>
+          <html:input id="width" type="number" class="narrow input-inline"
+                      aria-labelledby="widthLabel"/>
+        </html:td>
+        <html:td>
+          <menulist id="pixelOrPercentMenulist"/>
+        </html:td>
+      </html:tr>
+      <html:tr>
+        <html:th>
+          <label id="heightLabel"
+                 control="height"
                  value="&heightEditField.label;"
                  accesskey="&heightEditField.accessKey;"/>
-        </hbox>
-      </vbox>
-      <vbox>
-        <textbox class="narrow" id="width" flex="1" oninput="forceInteger('width')"/>
-        <textbox class="narrow" id="height" flex="1" oninput="forceInteger('height')"/>
-      </vbox>
-      <vbox>
-        <menulist id="pixelOrPercentMenulist"/>
-        <hbox align="center" flex="1">
+        </html:th>
+        <html:td>
+          <html:input id="height" type="number" class="narrow input-inline"
+                      aria-labelledby="heightLabel"/>
+        </html:td>
+        <html:td>
           <label value="&pixelsPopup.value;"/>
-        </hbox>
-      </vbox>
-    </hbox>
+        </html:td>
+      </html:tr>
+    </html:table>
     <checkbox id="3dShading" label="&threeDShading.label;" accesskey="&threeDShading.accessKey;"/>
   </groupbox>
   <groupbox>
     <hbox class="groupbox-title">
       <label class="header">&alignmentBox.label;</label>
     </hbox>
     <radiogroup id="alignmentGroup" orient="horizontal">
       <spacer class="spacer"/>
--- a/mail/themes/linux/editor/EditorDialog.css
+++ b/mail/themes/linux/editor/EditorDialog.css
@@ -36,17 +36,17 @@ groupbox {
   font-style: italic;
 }
 
 .larger {
   font-size: 120%;
 }
 
 *|*.narrow {
-  width: 3em;
+  width: 4em;
 }
 
 .menulist-narrow {
   width: 10em;
 }
 
 .wrap {
  width: 1em;
--- a/mail/themes/osx/editor/EditorDialog.css
+++ b/mail/themes/osx/editor/EditorDialog.css
@@ -36,17 +36,17 @@ groupbox {
   font-style: italic;
 }
 
 .larger {
   font-size: 120%;
 }
 
 *|*.narrow {
-  width: 3em;
+  width: 4em;
 }
 
 .menulist-narrow {
   width: 10em;
 }
 
 .wrap {
  width: 1em;
--- a/mail/themes/windows/editor/EditorDialog.css
+++ b/mail/themes/windows/editor/EditorDialog.css
@@ -43,17 +43,17 @@ groupbox > hbox > .header {
   font-style: italic;
 }
 
 .larger {
   font-size: 120%;
 }
 
 *|*.narrow {
-  width: 3em;
+  width: 4em;
 }
 
 .menulist-narrow {
   width: 10em;
 }
 
 .wrap {
  width: 1em;