Bug 1624429 - Fix lintpref failures by removing duplicates. r=mkmelin
authorRob Lemley <rob@thunderbird.net>
Thu, 02 Apr 2020 16:23:51 -0400
changeset 38813 b1ac2173d7c89f15582e1a80fba1a5886e3bcf51
parent 38812 aa50c4d9d57a311bdb01d0f0ce3db310f9c96a76
child 38814 809ba28e36f4e6f0c823950f0370bac913fcfc7c
push id401
push userclokep@gmail.com
push dateMon, 01 Jun 2020 20:41:59 +0000
reviewersmkmelin
bugs1624429
Bug 1624429 - Fix lintpref failures by removing duplicates. r=mkmelin This check compares the js files to modules/libpref/init/StaticPrefList.yaml which states that prefs listed in it should not be included in js data files unless the value is overridden. These duplicated prefs do not have different values in all-thunderbird.js.
mail/app/profile/all-thunderbird.js
--- a/mail/app/profile/all-thunderbird.js
+++ b/mail/app/profile/all-thunderbird.js
@@ -183,17 +183,16 @@ pref("extensions.dss.switchPending", fal
 // Don't show recommendations on the extension and theme list views.
 pref("extensions.htmlaboutaddons.recommendations.enabled", false);
 
 pref("lightweightThemes.update.enabled", true);
 
 // Built-in default permissions.
 pref("permissions.manager.defaultsUrl", "resource://app/defaults/permissions");
 
-pref("general.smoothScroll", true);
 #ifdef UNIX_BUT_NOT_MAC
 pref("general.autoScroll", false);
 #else
 pref("general.autoScroll", true);
 #endif
 
 pref("mail.shell.checkDefaultClient", true);
 pref("mail.spellcheck.inline", true);
@@ -271,20 +270,16 @@ pref("mail.warn_on_shift_delete", true);
 // at least this percentage of the thread pane visible above / below the
 // selected message.
 pref("mail.threadpane.padding.top_percent", 10);
 pref("mail.threadpane.padding.bottom_percent", 10);
 
 // Use correspondents column instead of from/recipient columns.
 pref("mail.threadpane.use_correspondents", true);
 
-// only affects cookies from RSS articles
-// 0-Accept, 1-dontAcceptForeign, 2-dontUse
-pref("network.cookie.cookieBehavior", 0);
-
 // To allow images to be inserted into a composition with an auth prompt, we
 // need the following two.
 pref("network.auth.subresource-img-cross-origin-http-auth-allow", true);
 pref("network.auth.non-web-content-triggered-resources-http-auth-allow", true);
 
 // clear the SeaMonkey pref, so we don't hear about how we don't have a chrome
 // package registered for editor-region while opening about:config
 pref("editor.throbber.url", "");
@@ -381,17 +376,16 @@ pref("view_source.syntax_highlight", fal
 // End core all.js pref overrides
 /////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////
 // Generic browser related prefs.
 /////////////////////////////////////////////////////////////////
 pref("browser.send_pings", false);
 pref("browser.chrome.toolbar_tips",         true);
-pref("browser.xul.error_pages.enabled", true);
 pref("browser.xul.error_pages.expert_bad_cert", false);
 
 // Attachment download manager settings
 pref("browser.download.useDownloadDir", false);
 pref("browser.download.folderList", 0);
 pref("browser.download.manager.showAlertOnComplete", false);
 pref("browser.download.manager.showAlertInterval", 2000);
 pref("browser.download.manager.retention", 1);
@@ -751,25 +745,16 @@ pref("privacy.userContext.enabled", fals
 // If set to true, Thunderbird will collapse the main menu for new profiles
 // (or, more precisely, profiles that start with no accounts created).
 pref("mail.main_menu.collapse_by_default", true);
 
 // If set to true, when saving a message to a file, use underscore
 // instead of space in the file name.
 pref("mail.save_msg_filename_underscores_for_space", false);
 
-#ifdef MOZ_SANDBOX
-// This controls the strength of the Windows content process sandbox for testing
-// purposes. This will require a restart.
-// On windows these levels are:
-// See - security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp
-// SetSecurityLevelForContentProcess() for what the different settings mean.
-pref("security.sandbox.content.level", 0);
-#endif
-
 #ifdef NIGHTLY_BUILD
 // See bug 1572568 for details. Disallow eval() with system principal.
 pref("security.allow_eval_with_system_principal", false);
 #endif
 
 // Enable FIDO U2F
 pref("security.webauth.u2f", true);