Bug 1482334 - fix add-on options menu by replacing .value with .getAttribute('value') when opening add-on prefs. r=jorgk
authoraceman <acelists@atlas.sk>
Thu, 11 Oct 2018 23:36:25 +0200
changeset 33354 9b05b741a18853060319a212eb08025a2ec1546f
parent 33353 056b4d7d3d6b1e2689c028805757b637bf8f0bb3
child 33355 1bffb3f6d7a9634e803aa28dd85c57dc36f00cef
push id387
push userclokep@gmail.com
push dateMon, 10 Dec 2018 21:30:47 +0000
reviewersjorgk
bugs1482334
Bug 1482334 - fix add-on options menu by replacing .value with .getAttribute('value') when opening add-on prefs. r=jorgk
mail/base/content/mainNavigationToolbox.inc
mail/base/content/mainPopupSet.inc
--- a/mail/base/content/mainNavigationToolbox.inc
+++ b/mail/base/content/mainNavigationToolbox.inc
@@ -827,17 +827,17 @@
               label="&addonPrefsUnix.label;"
               accesskey="&addonPrefsUnix.accesskey;">
 #else
               label="&addonPrefs.label;"
               accesskey="&addonPrefs.accesskey;">
 #endif
           <menupopup id="addonPrefs"
                      onpopupshowing="initAddonPrefsMenu(this);"
-                     oncommand="openAddonPrefs(event.target.value, event.target.getAttribute('optionsType'));">
+                     oncommand="openAddonPrefs(event.target.getAttribute('value'), event.target.getAttribute('optionsType'));">
             <menuitem label="&addonNoPrefs.label;" disabled="true"/>
           </menupopup>
         </menu>
         <menuitem id="activityManager" label="&activitymanager.label;"
                   accesskey="&activitymanager.accesskey;"
                   oncommand="openActivityMgr();"/>
         <menu id="imAccountsStatus" label="&imAccountsStatus.label;"
               accesskey="&imAccountsStatus.accesskey;"
--- a/mail/base/content/mainPopupSet.inc
+++ b/mail/base/content/mainPopupSet.inc
@@ -263,17 +263,17 @@
         </splitmenu>
         <spacer class="appmenuPane-spacer"/>
         <splitmenu id="appmenu_addons"
                    class="menuitem-iconic"
                    label="&addons.label;"
                    oncommand="openAddonsMgr();">
           <menupopup id="appmenu_addonPrefs"
                      onpopupshowing="initAddonPrefsMenu(this);"
-                     oncommand="openAddonPrefs(event.target.value, event.target.getAttribute('optionsType'));">
+                     oncommand="openAddonPrefs(event.target.getAttribute('value'), event.target.getAttribute('optionsType'));">
             <menuitem label="&addons.label;" oncommand="openAddonsMgr(); event.stopPropagation();"/>
             <menuseparator class="appmenu-menuseparator"/>
             <menuitem label="&addonNoPrefs.label;" disabled="true"/>
           </menupopup>
         </splitmenu>
         <splitmenu id="appmenu_customize"
 #ifdef XP_WIN
                    label="&preferencesCmd2.label;"