Bug 1546338 - Fix two instances of createElement that should be createXULElement; rs=bustage-fix
authorGeoff Lankow <geoff@darktrojan.net>
Fri, 24 May 2019 16:12:20 +1200
changeset 35678 886769faf4ff2832b25274633c6e1e5a29ad7fcc
parent 35677 5a137395d1dbba0faf39fdb2b8e6ef4d83014fa9
child 35679 eebe1c3a65ec5d5538e9e2be887e676df4e973d6
push id392
push userclokep@gmail.com
push dateMon, 02 Sep 2019 20:17:19 +0000
reviewersbustage-fix
bugs1546338
Bug 1546338 - Fix two instances of createElement that should be createXULElement; rs=bustage-fix
calendar/lightning/content/lightning-item-panel.js
mail/components/preferences/applications.js
--- a/calendar/lightning/content/lightning-item-panel.js
+++ b/calendar/lightning/content/lightning-item-panel.js
@@ -222,17 +222,17 @@ function onLoadLightningItemPanel(aIfram
         let iframeId = aIframeId || gTabmail.currentTabInfo.iframe.id;
         iframe = document.getElementById(iframeId);
         iframeSrc = aUrl;
 
         // Add a listener to detect close events, prompt user about saving changes.
         window.addEventListener("close", windowCloseListener);
     } else {
         // window dialog case
-        iframe = document.createElement("iframe");
+        iframe = document.createXULElement("iframe");
         iframeSrc = window.arguments[0].useNewItemUI
             ? "chrome://lightning/content/html-item-editing/lightning-item-iframe.html"
             : "chrome://lightning/content/lightning-item-iframe.xul";
 
         iframe.setAttribute("id", "lightning-item-panel-iframe");
         iframe.setAttribute("flex", "1");
 
         let statusbar = document.getElementById("status-bar");
--- a/mail/components/preferences/applications.js
+++ b/mail/components/preferences/applications.js
@@ -737,17 +737,17 @@ var gCloudFileTab = {
   },
 
   _showAccountInfo(aAccountKey) {
     let account = cloudFileAccounts.getAccount(aAccountKey);
     this._settingsDeck.selectedPanel = this._settingsPanelWrap;
 
     let url = account.managementURL + `?accountId=${account.accountKey}`;
 
-    let iframe = document.createElement("iframe");
+    let iframe = document.createXULElement("iframe");
     iframe.setAttribute("flex", "1");
     // allows keeping dialog background color without hoops
     iframe.setAttribute("transparent", "true");
 
     let type = url.startsWith("chrome:") ? "chrome" : "content";
     iframe.setAttribute("type", type);
     iframe.setAttribute("src", url);