Bug 1509377 - Port bug 1508142: Remove remains of tree cell-based selection code. r=jorgk
authorRichard Marti <richard.marti@gmail.com>
Thu, 22 Nov 2018 20:33:34 +0100
changeset 33764 854e46a4c5f226a20fb42f14a2c50af188038289
parent 33763 5af3c13ff2eeaa2889348519ff7e40353c84deb1
child 33765 202a0c6da02dfed38143bbe9488ccc01faae6b92
push id388
push userclokep@gmail.com
push dateMon, 28 Jan 2019 20:54:56 +0000
reviewersjorgk
bugs1509377, 1508142
Bug 1509377 - Port bug 1508142: Remove remains of tree cell-based selection code. r=jorgk
editor/ui/dialogs/content/EdSelectProps.js
editor/ui/dialogs/content/EditorSaveAsCharset.js
mail/components/preferences/cookies.js
mailnews/addrbook/src/nsAbView.cpp
mailnews/base/src/nsMsgDBView.cpp
mailnews/base/src/nsSubscribableServer.cpp
mailnews/extensions/newsblog/content/feed-subscriptions.js
mailnews/news/src/nsNntpIncomingServer.cpp
--- a/editor/ui/dialogs/content/EdSelectProps.js
+++ b/editor/ui/dialogs/content/EdSelectProps.js
@@ -543,17 +543,16 @@ function Startup()
       gDialog.previousButton.disabled = currentIndex < 2;
       gDialog.nextButton.disabled = !currentItem.canMoveDown();
       // For Advanced Edit
       globalElement = currentItem.element;
       currentItem.onFocus();
     },
     cycleCell: function cycleCell(index, column) { itemArray[index].cycleCell(index); },
     isEditable: function isEditable(index, column) { return false; },
-    isSelectable: function isSelectable(index, column) { return false; },
     performAction: function performAction(action) { },
     performActionOnCell: function performActionOnCell(action, index, column) { }
   };
   treeSelection.select(0);
   currentItem = gDialog;
   //onNameInput();
 
   SetTextboxFocus(gDialog.selectName);
--- a/editor/ui/dialogs/content/EditorSaveAsCharset.js
+++ b/editor/ui/dialogs/content/EditorSaveAsCharset.js
@@ -34,17 +34,16 @@ var gCharsetView = {
   getProgressMode: function(index) { return 0; },
   getCellValue: function(index) { return ""; },
   getCellText: function(index) { return gCharsetInfo[index].label; },
   toggleOpenState: function(index) {},
   cycleHeader: function(column) {},
   selectionChanged: function() {},
   cycleCell: function(index, column) {},
   isEditable: function isEditable(index, column) { return false; },
-  isSelectable: function isSelectable(index, column) { return true; },
   performAction: function performAction(action) {},
   performActionOnCell: function performActionOnCell(action, index, column) {}
 };
 
 function Startup()
 {
   var editor = GetCurrentEditor();
   if (!editor)
--- a/mail/components/preferences/cookies.js
+++ b/mail/components/preferences/cookies.js
@@ -408,19 +408,16 @@ var gCookiesWindow = {
       }
     },
     cycleHeader(aColumn) {},
     selectionChanged() {},
     cycleCell(aIndex, aColumn) {},
     isEditable(aIndex, aColumn) {
       return false;
     },
-    isSelectable(aIndex, aColumn) {
-      return false;
-    },
     setCellValue(aIndex, aColumn, aValue) {},
     setCellText(aIndex, aColumn, aValue) {},
     performAction(aAction) {},
     performActionOnRow(aAction, aIndex) {},
     performActionOnCell(aAction, aindex, aColumn) {},
   },
 
   _makeStrippedHost(aHost) {
--- a/mailnews/addrbook/src/nsAbView.cpp
+++ b/mailnews/addrbook/src/nsAbView.cpp
@@ -564,21 +564,16 @@ NS_IMETHODIMP nsAbView::CycleCell(int32_
     return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP nsAbView::IsEditable(int32_t row, nsTreeColumn* col, bool* _retval)
 {
     return NS_ERROR_NOT_IMPLEMENTED;
 }
 
-NS_IMETHODIMP nsAbView::IsSelectable(int32_t row, nsTreeColumn* col, bool* _retval)
-{
-    return NS_ERROR_NOT_IMPLEMENTED;
-}
-
 NS_IMETHODIMP nsAbView::SetCellValue(int32_t row, nsTreeColumn* col, const nsAString& value)
 {
     return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP nsAbView::SetCellText(int32_t row, nsTreeColumn* col, const nsAString& value)
 {
     return NS_ERROR_NOT_IMPLEMENTED;
--- a/mailnews/base/src/nsMsgDBView.cpp
+++ b/mailnews/base/src/nsMsgDBView.cpp
@@ -1060,25 +1060,16 @@ nsMsgDBView::IsEditable(int32_t row,
     return NS_OK;
   }
 
   *_retval = false;
   return NS_OK;
 }
 
 NS_IMETHODIMP
-nsMsgDBView::IsSelectable(int32_t row,
-                          nsTreeColumn* col,
-                          bool* _retval)
-{
-  *_retval = false;
-  return NS_OK;
-}
-
-NS_IMETHODIMP
 nsMsgDBView::SetCellValue(int32_t row,
                           nsTreeColumn* col,
                           const nsAString& value)
 {
   return NS_OK;
 }
 
 NS_IMETHODIMP
--- a/mailnews/base/src/nsSubscribableServer.cpp
+++ b/mailnews/base/src/nsSubscribableServer.cpp
@@ -941,24 +941,16 @@ NS_IMETHODIMP
 nsSubscribableServer::IsEditable(int32_t aRow, nsTreeColumn *aCol,
                                  bool *retval)
 {
   *retval = false;
   return NS_OK;
 }
 
 NS_IMETHODIMP
-nsSubscribableServer::IsSelectable(int32_t aRow, nsTreeColumn *aCol,
-                                   bool *retval)
-{
-  *retval = false;
-  return NS_OK;
-}
-
-NS_IMETHODIMP
 nsSubscribableServer::IsSeparator(int32_t aRowIndex, bool *retval)
 {
   *retval = false;
   return NS_OK;
 }
 
 NS_IMETHODIMP
 nsSubscribableServer::IsSorted(bool *retval)
--- a/mailnews/extensions/newsblog/content/feed-subscriptions.js
+++ b/mailnews/extensions/newsblog/content/feed-subscriptions.js
@@ -137,17 +137,16 @@ var FeedSubscriptions = {
 
     _selection:                  null,
     get selection()              { return this._selection; },
     set selection(val)           { return this._selection = val; },
 
     setTree(aTreebox)            { this.treeBox = aTreebox; },
     isSeparator(aRow)            { return false; },
     isSorted()                   { return false; },
-    isSelectable(aRow, aColumn)  { return false; },
     isEditable(aRow, aColumn)    { return false; },
 
     getProgressMode(aRow, aCol)  {},
     cycleHeader(aCol)            {},
     cycleCell(aRow, aCol)        {},
     selectionChanged()           {},
     performAction(aAction)       {},
     performActionOnRow(aAction, aRow)        {},
--- a/mailnews/news/src/nsNntpIncomingServer.cpp
+++ b/mailnews/news/src/nsNntpIncomingServer.cpp
@@ -1936,23 +1936,16 @@ nsNntpIncomingServer::CycleCell(int32_t 
 NS_IMETHODIMP
 nsNntpIncomingServer::IsEditable(int32_t row, nsTreeColumn* col, bool *_retval)
 {
   *_retval = false;
   return NS_OK;
 }
 
 NS_IMETHODIMP
-nsNntpIncomingServer::IsSelectable(int32_t row, nsTreeColumn* col, bool *_retval)
-{
-  *_retval = false;
-  return NS_OK;
-}
-
-NS_IMETHODIMP
 nsNntpIncomingServer::SetCellValue(int32_t row, nsTreeColumn* col, const nsAString& value)
 {
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 nsNntpIncomingServer::SetCellText(int32_t row, nsTreeColumn* col, const nsAString& value)
 {