Bug 1594331 - Port bug 1592369: rewrite consumers of the deprecated "left" and "right" align values to "start" and "end". r=khushil
authorMagnus Melin <mkmelin+mozilla@iki.fi>
Wed, 06 Nov 2019 11:44:14 +0200
changeset 37458 724dcab508f5c645e8a28899b5735d2ec3f92871
parent 37457 9220866c582eae6e2c5e2cf4e633c96a33217402
child 37459 e912d62faefa058a5feea95af0533364ce4c9966
push id396
push userclokep@gmail.com
push dateMon, 06 Jan 2020 23:11:57 +0000
reviewerskhushil
bugs1594331, 1592369
Bug 1594331 - Port bug 1592369: rewrite consumers of the deprecated "left" and "right" align values to "start" and "end". r=khushil * align="left" -> align="start" * align="right" -> align="end" * setAttribute("align", "left") -> setAttribute("align", "start") * setAttribute("align", "right") -> setAttribute("align", "end") ``` grep -rl 'align="left"' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/align="left"/align="start"/g' grep -rl 'align="right"' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/align="right"/align="end"/g' grep -rl 'setAttribute("align", "left")' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/setAttribute("align", "left")/setAttribute("align", "start")/g' grep -rl 'setAttribute("align", "right")' --exclude-dir=.hg --exclude-dir=suite --exclude-dir=editor . | xargs sed -i 's/setAttribute("align", "right")/setAttribute("align", "end")/g' hg revert calendar/import-export/calMonthGridPrinter.html calendar/import-export/calWeekPrinter.html ```
calendar/base/content/calendar-editable-item.js
calendar/base/content/calendar-month-view.js
calendar/resources/content/mouseoverPreviews.js
mail/components/compose/content/dialogs/EdTableProps.xul
mail/components/im/content/chat-conversation-info.js
mail/components/migration/content/migration.xul
mail/components/preferences/permissions.xul
mail/extensions/mailviews/content/mailViewSetup.xul
mailnews/base/content/msgSynchronize.xul
mailnews/base/prefs/content/am-offline.xul
mailnews/base/prefs/content/am-server.xul
mailnews/extensions/newsblog/content/feed-subscriptions.xul
--- a/calendar/base/content/calendar-editable-item.js
+++ b/calendar/base/content/calendar-editable-item.js
@@ -135,17 +135,17 @@
               <box class="calendar-color-box"
                    flex="1">
                 <box class="calendar-event-selection"
                      orient="horizontal"
                      flex="1">
                   <stack class="calendar-event-box-container"
                          flex="1">
                     <hbox class="calendar-event-details">
-                      <vbox align="left"
+                      <vbox align="start"
                             flex="1">
                         <label class="event-name-label"
                                crop="end"
                                style="margin: 0;">
                         </label>
                         <html:input class="calendar-event-details-core title-desc"
                                     hidden="hidden"
                                     style="background: transparent !important;"/>
--- a/calendar/base/content/calendar-month-view.js
+++ b/calendar/base/content/calendar-month-view.js
@@ -295,17 +295,17 @@
                   <stack class="calendar-event-box-container"
                          flex="1">
                     <hbox class="calendar-event-details">
                       <vbox pack="center">
                           <image class="calendar-item-image"></image>
                       </vbox>
                       <label class="calendar-month-day-box-item-label"></label>
                       <vbox class="event-name-label-container"
-                            align="left" flex="1">
+                            align="start" flex="1">
                         <label class="event-name-label"
                                crop="end"
                                flex="1"
                                style="margin: 0;">
                         </label>
                         <html:input class="plain calendar-event-name-textbox title-desc"
                                     hidden="hidden"/>
                         <spacer flex="1"></spacer>
--- a/calendar/resources/content/mouseoverPreviews.js
+++ b/calendar/resources/content/mouseoverPreviews.js
@@ -381,17 +381,17 @@ function boxAppendLabeledText(box, label
  *
  * @param   {String} text  The text to display in the node
  * @returns {Node}         The node
  */
 function createTooltipHeaderLabel(text) {
   let labelCell = document.createElementNS("http://www.w3.org/1999/xhtml", "th");
   labelCell.setAttribute("class", "tooltipHeaderLabel");
   labelCell.textContent = text;
-  labelCell.setAttribute("align", "right");
+  labelCell.setAttribute("align", "end");
   return labelCell;
 }
 
 /**
  * PRIVATE: Creates an element for field value (for header table)
  *
  * @param   {String} text  The text to display in the node
  * @returns {Node}         The node
--- a/mail/components/compose/content/dialogs/EdTableProps.xul
+++ b/mail/components/compose/content/dialogs/EdTableProps.xul
@@ -126,17 +126,17 @@
                           aria-labelledby="BorderWidthLabel"/>
               <html:input id="SpacingInput" type="number" class="narrow input-inline"
                           aria-labelledby="SpacingLabel"/>
               <html:input id="PaddingInput" type="number" class="narrow input-inline"
                           aria-labelledby="PaddingLabel"/>
             </vbox>
             <vbox>
               <hbox flex="1" align="center">
-                <label align="left" value="&pixels.label;"/>
+                <label align="start" value="&pixels.label;"/>
               </hbox>
               <hbox flex="1" align="center">
                 <label value="&tablePxBetwCells.label;"/>
               </hbox>
               <hbox flex="1" align="center">
                 <label value="&tablePxBetwBrdrCellContent.label;"/>
               </hbox>
             </vbox>
--- a/mail/components/im/content/chat-conversation-info.js
+++ b/mail/components/im/content/chat-conversation-info.js
@@ -81,17 +81,17 @@
                            mousethrough="never"
                            crop="end"
                            flex="100000"/>
               <html:input class="statusMessageInput input-inline"
                           hidden="hidden"/>
             </stack>
           </hbox>
           <hbox class="otr-container"
-                align="left"
+                align="start"
                 valign="middle"
                 hidden="true">
             <label class="otr-label"
                    crop="end"
                    data-l10n-id="state-label"
                    flex="1"/>
             <toolbarbutton id="otrButton"
                            mode="dialog"
--- a/mail/components/migration/content/migration.xul
+++ b/mail/components/migration/content/migration.xul
@@ -45,41 +45,41 @@
     </vbox>
     <label>&importSourceNotFound.label;</label>
     </deck>
   </wizardpage>
 
   <wizardpage id="selectProfile" pageid="selectProfile" label="&selectProfile.title;"
               next="importItems">
     <label control="profiles">&selectProfile.label;</label>
-    <radiogroup id="profiles" align="left"/>
+    <radiogroup id="profiles" align="start"/>
   </wizardpage>
 
   <wizardpage id="importItems" pageid="importItems" label="&importItems.title;"
               next="migrating"
               oncommand="MigrationWizard.onImportItemCommand();">
     <description>&importItems.label;</description>
 
-    <vbox id="dataSources" style="overflow: auto; -moz-appearance: listbox" align="left" flex="1"/>
+    <vbox id="dataSources" style="overflow: auto; -moz-appearance: listbox" align="start" flex="1"/>
   </wizardpage>
 
   <wizardpage id="migrating" pageid="migrating" label="&migrating.title;"
               next="done">
 
     <description>&migrating.label;</description>
     <separator class="thin"/>
-    <vbox id="migratingItems" class="indent" style="overflow: auto;" flex="1" align="left"/>
+    <vbox id="migratingItems" class="indent" style="overflow: auto;" flex="1" align="start"/>
     <separator class="thin"/>
 
     <hbox>
       <html:progress class="progressmeter-statusbar" id="progressBar" flex="1" value="0" max="100"/>
     </hbox>
 
   </wizardpage>
 
   <wizardpage id="done" pageid="done" label="&done.title;">
     <description>&done.label;</description>
 
     <separator class="thin"/>
-    <vbox id="doneItems" class="indent" style="overflow: auto;" align="left"/>
+    <vbox id="doneItems" class="indent" style="overflow: auto;" align="start"/>
   </wizardpage>
 </wizard>
 
--- a/mail/components/preferences/permissions.xul
+++ b/mail/components/preferences/permissions.xul
@@ -62,27 +62,27 @@
         <splitter class="tree-splitter"/>
         <treecol id="statusCol" label="&treehead.status.label;" flex="1"
                  data-field-name="capability" persist="width"/>
       </treecols>
       <treechildren/>
     </tree>
   </vbox>
   <vbox>
-    <hbox class="actionButtons" align="left" flex="1">
+    <hbox class="actionButtons" align="start" flex="1">
       <button id="removePermission" disabled="true"
               accesskey="&removepermission.accesskey;"
               icon="remove" label="&removepermission.label;"
               oncommand="gPermissionManager.onPermissionDeleted();"/>
       <button id="removeAllPermissions"
               icon="clear" label="&removeallpermissions.label;"
               accesskey="&removeallpermissions.accesskey;"
               oncommand="gPermissionManager.onAllPermissionsDeleted();"/>
     </hbox>
     <spacer flex="1"/>
-    <hbox class="actionButtons" align="right" flex="1">
+    <hbox class="actionButtons" align="end" flex="1">
       <button oncommand="window.close();" icon="close"
               label="&button.cancel.label;" accesskey="&button.cancel.accesskey;" />
       <button id="btnApplyChanges" oncommand="gPermissionManager.onApplyChanges();" icon="save"
               label="&button.ok.label;" accesskey="&button.ok.accesskey;"/>
     </hbox>
   </vbox>
 </window>
--- a/mail/extensions/mailviews/content/mailViewSetup.xul
+++ b/mail/extensions/mailviews/content/mailViewSetup.xul
@@ -14,17 +14,17 @@
 ]>
 
 <dialog id="mailViewSetupDialog"
         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
         xmlns:html="http://www.w3.org/1999/xhtml"
         onload="mailViewOnLoad();"
         onunload="mailViewOnUnLoad();"
         buttons="accept,cancel"
-        buttonalign="right"
+        buttonalign="end"
         windowtype="mailnews:mailview"
         title="&mailViewSetupTitle.label;"
         style="width: 52em; height: 22em;"
         persist="screenX screenY width height">
 
   <stringbundleset id="stringbundleset">
     <stringbundle id="bundle_search" src="chrome://messenger/locale/search.properties"/>
   </stringbundleset>
--- a/mailnews/base/content/msgSynchronize.xul
+++ b/mailnews/base/content/msgSynchronize.xul
@@ -30,13 +30,13 @@
                   accesskey="&syncTypeMail.accesskey;"/>
         <checkbox id="syncNews" label="&syncTypeNews.label;" accesskey="&syncTypeNews.accesskey;"/>
     </vbox>
     <vbox align="start">
         <checkbox id="sendMessage" label="&sendMessage.label;" accesskey="&sendMessage.accesskey;"/>
         <checkbox id="workOffline" label="&workOffline.label;" accesskey="&workOffline.accesskey;"/>
     </vbox>
     <separator class="thin"/>
-    <hbox align="right">
+    <hbox align="end">
         <button id="select" label="&selectButton.label;" accesskey="&selectButton.accesskey;"
                 oncommand="OnSelect();"/>
     </hbox>
 </dialog>
--- a/mailnews/base/prefs/content/am-offline.xul
+++ b/mailnews/base/prefs/content/am-offline.xul
@@ -34,22 +34,22 @@
               id="offline.folders" label="&allFoldersOffline2.label;"
               oncommand="toggleOffline()"
               accesskey="&allFoldersOffline2.accesskey;"/>
 
     <description hidefor="pop3,nntp,movemail,none,rss">&allFoldersOfflineNote.label;</description>
 
     <separator class="thin" hidefor="movemail,pop3,nntp,none"/>
 
-    <hbox hidefor="movemail,pop3,nntp,none" align="right">
+    <hbox hidefor="movemail,pop3,nntp,none" align="end">
         <button label="&offlineImapAdvancedOffline.label;" accesskey="&offlineImapAdvancedOffline.accesskey;"
                 oncommand="onClickSelect()" id="selectImapFoldersButton" class="selectForOfflineUseButton"/>
     </hbox>
 
-    <hbox hidefor="movemail,pop3,imap,none" align="right">
+    <hbox hidefor="movemail,pop3,imap,none" align="end">
         <button label="&offlineSelectNntp.label;" accesskey="&offlineSelectNntp.accesskey;"
                 oncommand="onClickSelect()" id="selectNewsgroupsButton" class="selectForOfflineUseButton"/>
     </hbox>
 
     </groupbox>
 
     <groupbox id="diskspace.titlebox">
       <label class="header" hidefor="movemail,pop3,none,rss">&diskspaceGroupTitle.label;</label>
--- a/mailnews/base/prefs/content/am-server.xul
+++ b/mailnews/base/prefs/content/am-server.xul
@@ -242,17 +242,17 @@
     </hbox>
     </vbox>
     <!-- IMAP -->
     <label hidden="true" wsm_persist="true" id="imap.trashFolderName"
                   prefattribute="value"
                   prefstring="mail.server.%serverkey%.trash_folder_name"/>
 
     <hbox align="center" hidefor="pop3,nntp,movemail">
-      <label value="&deleteMessagePrefix.label;" align="left"
+      <label value="&deleteMessagePrefix.label;" align="start"
              control="imap.deleteModel"/>
     </hbox>
     <vbox>
       <hbox align="center"
             id="imap.deleteModel.box"
             hidefor="pop3,nntp,movemail"
             flex="1">
         <radiogroup id="imap.deleteModel"
--- a/mailnews/extensions/newsblog/content/feed-subscriptions.xul
+++ b/mailnews/extensions/newsblog/content/feed-subscriptions.xul
@@ -50,17 +50,17 @@
   </keyset>
 
   <stringbundle id="bundle_newsblog"
                 src="chrome://messenger-newsblog/locale/newsblog.properties"/>
   <stringbundle id="bundle_brand"
                 src="chrome://branding/locale/brand.properties"/>
 
   <vbox flex="1" id="contentPane">
-    <hbox align="right">
+    <hbox align="end">
       <label is="text-link" id="learnMore"
              crop="end"
              value="&learnMore.label;"
              href="https://support.mozilla.org/kb/how-subscribe-news-feeds-and-blogs"/>
     </hbox>
 
     <tree id="rssSubscriptionsList"
           treelines="true"