Bug 1620861 - Fix prompt for extension permission updates. r=mkmelin DONTBUILD
authorGeoff Lankow <geoff@darktrojan.net>
Thu, 12 Mar 2020 12:20:10 +1300
changeset 38474 6e05e171547189be7183d9ea611587848ad5c49d
parent 38473 9aa142882f1850579cd4262bdbb7263306b2f00a
child 38475 4af2fc631df9d4eb1709b8d72872f3702737048a
push id400
push userclokep@gmail.com
push dateMon, 04 May 2020 18:56:09 +0000
reviewersmkmelin
bugs1620861
Bug 1620861 - Fix prompt for extension permission updates. r=mkmelin DONTBUILD
mail/base/modules/ExtensionsUI.jsm
--- a/mail/base/modules/ExtensionsUI.jsm
+++ b/mail/base/modules/ExtensionsUI.jsm
@@ -680,23 +680,24 @@ var gXPInstallObserver = {
             info.resolve();
           } else {
             info.reject();
           }
         });
         break;
       }
       case "webextension-update-permissions": {
-        let { info } = subject.wrappedJSObject;
+        let info = subject.wrappedJSObject;
         info.type = "update";
         let strings = this._buildStrings(info);
 
         // If we don't prompt for any new permissions, just apply it.
         if (strings.msgs.length == 0) {
           info.resolve();
+          return;
         }
 
         this.showPermissionsPrompt(browser, strings, info.addon.iconURL).then(
           answer => {
             if (answer) {
               info.resolve();
             } else {
               info.reject();