Bug 1560021 - Remove hack to set persisted values on <radiogroup> elements in overlays; r=Fallen
authorGeoff Lankow <geoff@darktrojan.net>
Thu, 04 Jul 2019 21:04:38 +1200
changeset 36028 56961a825e639c25fcb980603cf4fef0c3c79461
parent 36027 20be9dc63498172a68daea91dba46083a97abaec
child 36029 b48185ee97e6bf8494e60f10f69df0f49affa083
push id392
push userclokep@gmail.com
push dateMon, 02 Sep 2019 20:17:19 +0000
reviewersFallen
bugs1560021
Bug 1560021 - Remove hack to set persisted values on <radiogroup> elements in overlays; r=Fallen
common/src/Overlays.jsm
--- a/common/src/Overlays.jsm
+++ b/common/src/Overlays.jsm
@@ -322,17 +322,17 @@ class Overlays {
    * Insert the node in the given parent, observing the insertbefore/insertafter/position attributes
    *
    * @param {Element} parent        The parent element to insert the node into.
    * @param {Element} node          The node to insert.
    */
   _insertElement(parent, node) {
     // These elements need their values set before they are added to
     // the document, or bad things happen.
-    for (let element of node.querySelectorAll("menulist, radiogroup")) {
+    for (let element of node.querySelectorAll("menulist")) {
       if (element.id && this.persistedIDs.has(element.id)) {
         element.setAttribute("value", Services.xulStore.getValue(this.location, element.id, "value"));
       }
     }
 
     let wasInserted = false;
     let pos = node.getAttribute("insertafter");
     let after = true;