Bug 1546309 - Remove extra unused arguments from refresh functions. r=mkmelin
authorPaul Morris <paul@paulwmorris.com>
Thu, 13 Jun 2019 10:16:13 +0200
changeset 35848 534295374182843b26aece5515c042d8cf1a6dd0
parent 35847 9e0328fce2fcff72173ddb31c0393f9827833762
child 35849 fe4c6acd6880bdd9360662e2742dc96c24035c95
push id392
push userclokep@gmail.com
push dateMon, 02 Sep 2019 20:17:19 +0000
reviewersmkmelin
bugs1546309
Bug 1546309 - Remove extra unused arguments from refresh functions. r=mkmelin The functions RefreshViewPopup, RefreshTagsPopup, and RefreshCustomViewsPopup each take one argument, so only pass one argument to them.
mail/base/content/mainMailToolbox.inc.xul
mail/base/content/mainNavigationToolbox.inc.xul
mail/base/content/mainPopupSet.inc.xul
--- a/mail/base/content/mainMailToolbox.inc.xul
+++ b/mail/base/content/mainMailToolbox.inc.xul
@@ -383,22 +383,22 @@
                     type="radio"/>
           <menuitem id="viewPickerNotDeleted" value="3"
                     label="&viewNotDeleted.label;"
                     type="radio"/>
           <menuseparator id="afterViewPickerUnreadSeparator"/>
           <menu id="viewPickerTags" label="&viewTags.label;">
             <menupopup id="viewPickerTagsPopup"
                        class="menulist-menupopup"
-                       onpopupshowing="RefreshTagsPopup(this, true);"/>
+                       onpopupshowing="RefreshTagsPopup(this);"/>
           </menu>
           <menu id="viewPickerCustomViews" label="&viewCustomViews.label;">
             <menupopup id="viewPickerCustomViewsPopup"
                        class="menulist-menupopup"
-                       onpopupshowing="RefreshCustomViewsPopup(this, true);"/>
+                       onpopupshowing="RefreshCustomViewsPopup(this);"/>
           </menu>
           <menuseparator id="afterViewPickerCustomViewsSeparator"/>
           <menuitem id="viewPickerVirtualFolder"
                     value="7"
                     label="&viewVirtualFolder.label;"/>
           <menuitem id="viewPickerCustomize"
                     value="8"
                     label="&viewCustomizeView.label;"/>
--- a/mail/base/content/mainNavigationToolbox.inc.xul
+++ b/mail/base/content/mainNavigationToolbox.inc.xul
@@ -430,26 +430,26 @@
             <menuseparator id="sortAfterDescendingSeparator"/>
             <menuitem id="sortThreaded" type="radio" name="threaded" label="&sortThreaded.label;" accesskey="&sortThreaded.accesskey;" oncommand="MsgSortThreaded();"/>
             <menuitem id="sortUnthreaded" type="radio" name="threaded" label="&sortUnthreaded.label;" accesskey="&sortUnthreaded.accesskey;" oncommand="MsgSortUnthreaded();"/>
             <menuitem id="groupBySort" type="radio" name="group" label="&groupBySort.label;" accesskey="&groupBySort.accesskey;" oncommand="MsgGroupBySort();"/>
           </menupopup>
         </menu>
         <menu id="viewMessageViewMenu" label="&msgsMenu.label;" accesskey="&msgsMenu.accesskey;"
               command="mailHideMenus" oncommand="ViewChangeByMenuitem(event.target);">
-            <menupopup id="viewMessagePopup" onpopupshowing="RefreshViewPopup(this, false);">
+            <menupopup id="viewMessagePopup" onpopupshowing="RefreshViewPopup(this);">
               <menuitem id="viewMessageAll"    value="0" type="radio" label="&viewAll.label;" accesskey="&viewAll.accesskey;"/>
               <menuitem id="viewMessageUnread" value="1" type="radio" label="&viewUnread.label;" accesskey="&viewUnread.accesskey;"/>
               <menuitem id="viewMessageNotDeleted" value="3" type="radio" label="&viewNotDeleted.label;" accesskey="&viewNotDeleted.accesskey;"/>
               <menuseparator id="messageViewAfterUnreadSeparator"/>
               <menu id="viewMessageTags" label="&viewTags.label;" accesskey="&viewTags.accesskey;">
-                <menupopup id="viewMessageTagsPopup" onpopupshowing="RefreshTagsPopup(this, false);"/>
+                <menupopup id="viewMessageTagsPopup" onpopupshowing="RefreshTagsPopup(this);"/>
               </menu>
               <menu id="viewMessageCustomViews" label="&viewCustomViews.label;" accesskey="&viewCustomViews.accesskey;">
-                <menupopup id="viewMessageCustomViewsPopup" onpopupshowing="RefreshCustomViewsPopup(this, false);"/>
+                <menupopup id="viewMessageCustomViewsPopup" onpopupshowing="RefreshCustomViewsPopup(this);"/>
               </menu>
               <menuseparator id="messageViewAfterCustomSeparator"/>
               <menuitem id="viewMessageVirtualFolder" value="7" label="&viewVirtualFolder.label;" accesskey="&viewVirtualFolder.accesskey;"/>
               <menuitem id="viewMessageCustomize"     value="8" label="&viewCustomizeView.label;" accesskey="&viewCustomizeView.accesskey;"/>
             </menupopup>
           </menu>
 
           <menu label="&threads.label;" id="viewMessagesMenu" accesskey="&threads.accesskey;">
--- a/mail/base/content/mainPopupSet.inc.xul
+++ b/mail/base/content/mainPopupSet.inc.xul
@@ -552,39 +552,39 @@
                           oncommand="MsgGroupBySort();"/>
               </menupopup>
             </menu>
             <menu id="appmenu_viewMessageViewMenu"
                   label="&msgsMenu.label;"
                   command="mailHideMenus"
                   oncommand="ViewChangeByMenuitem(event.target);">
               <menupopup id="appmenu_viewMessagePopup"
-                         onpopupshowing="RefreshViewPopup(this, false);">
+                         onpopupshowing="RefreshViewPopup(this);">
                 <menuitem id="appmenu_viewMessageAll"
                           value="0"
                           type="radio"
                           label="&viewAll.label;"/>
                 <menuitem id="appmenu_viewMessageUnread"
                           value="1"
                           type="radio"
                           label="&viewUnread.label;"/>
                 <menuitem id="appmenu_viewMessageNotDeleted"
                           value="3"
                           type="radio"
                           label="&viewNotDeleted.label;"/>
                 <menuseparator id="appmenu_messageViewAfterUnreadSeparator"/>
                 <menu id="viewMessageTags"
                       label="&viewTags.label;">
                   <menupopup id="appmenu_viewMessageTagsPopup"
-                             onpopupshowing="RefreshTagsPopup(this, false);"/>
+                             onpopupshowing="RefreshTagsPopup(this);"/>
                 </menu>
                 <menu id="appmenu_viewMessageCustomViews"
                       label="&viewCustomViews.label;">
                   <menupopup id="appmenu_viewMessageCustomViewsPopup"
-                             onpopupshowing="RefreshCustomViewsPopup(this, false);"/>
+                             onpopupshowing="RefreshCustomViewsPopup(this);"/>
                 </menu>
                 <menuseparator id="appmenu_messageViewAfterCustomSeparator"/>
                 <menuitem id="appmenu_viewMessageVirtualFolder"
                           value="7"
                           label="&viewVirtualFolder.label;"/>
                 <menuitem id="appmenu_viewMessageCustomize"
                           value="8"
                           label="&viewCustomizeView.label;"/>