Bug 1533578 - on macOS do not show chevron in thread column header. r=Paenglab
authorAlessandro Castellani <alessandro@thunderbird.net>
Fri, 31 May 2019 23:45:39 +0200
changeset 35736 48a77222e0c6f0aa85e59f4d05752e3f746ee6dc
parent 35735 f22dd6d49717e8484fe1cc5994e0c3f844193a3e
child 35737 dd45283763df5ccdc4c69a63fe0860aece16a8c8
push id392
push userclokep@gmail.com
push dateMon, 02 Sep 2019 20:17:19 +0000
reviewersPaenglab
bugs1533578
Bug 1533578 - on macOS do not show chevron in thread column header. r=Paenglab
mail/base/content/threadPane.js
--- a/mail/base/content/threadPane.js
+++ b/mail/base/content/threadPane.js
@@ -303,25 +303,24 @@ function UpdateSortIndicators(sortType, 
   document.getElementById("threadCol").collapsed = viewWrapper.showGroupedBySort;
 
   // show twisties only when grouping or threading
   if (viewWrapper.showGroupedBySort || viewWrapper.showThreaded)
     subjectCol.setAttribute("primary", "true");
   else
     subjectCol.removeAttribute("primary");
 
-  // If threading, set the sort direction on the thread column which causes it
-  //  to be able to 'light up' or otherwise indicate threading is active.
-  if (viewWrapper.showThreaded)
-    threadCol.setAttribute("sortDirection", "ascending");
-
   if (sortedColumn)
     sortedColumn.setAttribute("sortDirection",
                               sortOrder == Ci.nsMsgViewSortOrder.ascending ?
                                 "ascending" : "descending");
+
+  // Prevent threadCol from showing the sort direction chevron.
+  if (viewWrapper.showThreaded)
+    threadCol.removeAttribute("sortDirection");
 }
 
 function IsSpecialFolderSelected(flags, checkAncestors) {
   let folder = GetThreadPaneFolder();
   return folder && folder.isSpecialFolder(flags, checkAncestors);
 }
 
 function GetThreadTree() {