Bug 1515176 - Restrict access to APIs where a manifest key is required; r=mkmelin
authorGeoff Lankow <geoff@darktrojan.net>
Thu, 20 Dec 2018 20:18:05 +1300
changeset 34032 3df0e93306f9092a25631f9c7558cceb577fa9d8
parent 34031 40783ac10e72f52d2febe0c8aa52db77403a4f41
child 34033 66eedcaff9fac89a318dd866d42b3777e32e58c4
push id389
push userclokep@gmail.com
push dateMon, 18 Mar 2019 19:01:53 +0000
reviewersmkmelin
bugs1515176
Bug 1515176 - Restrict access to APIs where a manifest key is required; r=mkmelin
mail/components/extensions/schemas/browserAction.json
mail/components/extensions/schemas/cloudFile.json
mail/components/extensions/schemas/composeAction.json
--- a/mail/components/extensions/schemas/browserAction.json
+++ b/mail/components/extensions/schemas/browserAction.json
@@ -46,16 +46,17 @@
           }
         }
       }
     ]
   },
   {
     "namespace": "browserAction",
     "description": "Use toolbar actions to put icons in the mail window toolbar. In addition to its icon, a toolbar action can also have a tooltip, a badge, and a popup. This namespace is called browserAction for compatibility with browser WebExtensions.",
+    "permissions": ["manifest:browser_action"],
     "types": [
       {
         "id": "Details",
         "type": "object",
         "description": "Specifies to which tab or window the value should be set, or from which one it should be retrieved. If no tab nor window is specified, the global value is set or retrieved.",
         "properties": {
           "tabId": {
             "type": "integer",
--- a/mail/components/extensions/schemas/cloudFile.json
+++ b/mail/components/extensions/schemas/cloudFile.json
@@ -37,16 +37,17 @@
             "optional": true
           }
         }
       }
     ]
   },
   {
     "namespace": "cloudFile",
+    "permissions": ["manifest:cloud_file"],
     "allowedContexts": ["content"],
     "events": [
       {
         "name": "onFileUpload",
         "type": "function",
         "description": "Fired when a file should be uploaded to the cloud file provider",
         "parameters": [
           {
--- a/mail/components/extensions/schemas/composeAction.json
+++ b/mail/components/extensions/schemas/composeAction.json
@@ -47,16 +47,17 @@
           }
         }
       }
     ]
   },
   {
     "namespace": "composeAction",
     "description": "Use toolbar actions to put icons in the message composition toolbars. In addition to its icon, a toolbar action can also have a tooltip, a badge, and a popup.",
+    "permissions": ["manifest:compose_action"],
     "types": [
       {
         "id": "Details",
         "type": "object",
         "description": "Specifies to which tab or window the value should be set, or from which one it should be retrieved. If no tab nor window is specified, the global value is set or retrieved.",
         "properties": {
           "tabId": {
             "type": "integer",