Bug 1543725 - Use skip-unless-changed scheduling for all included test yml files. r=darktrojan
authorRob Lemley <rob@thunderbird.net>
Tue, 25 Jun 2019 18:15:40 -0400
changeset 35986 3d07be225714b6ec9ed4ac7704f66cd4a4d026d9
parent 35985 7302ce3d1e789d0493735a41662a44a8adc4e274
child 35987 1afa90fe67103f9b81f65ae94304489e8f74a595
push id392
push userclokep@gmail.com
push dateMon, 02 Sep 2019 20:17:19 +0000
reviewersdarktrojan
bugs1543725, 1414043
Bug 1543725 - Use skip-unless-changed scheduling for all included test yml files. r=darktrojan To avoid bug 1414043, test suites need to use the 'skip-unless-changed' task optimizer rather than 'schedules' that it defaults to. Moving the 'job-defaults.when' configuration out of tests.yml into kind.yml so it applies to all of the included files listed in 'jobs-from'. This will also allow us to further break the test configurations into multiple files before tests.yml gets any more unweildy.
taskcluster/ci/test/kind.yml
taskcluster/ci/test/tests.yml
--- a/taskcluster/ci/test/kind.yml
+++ b/taskcluster/ci/test/kind.yml
@@ -13,8 +13,33 @@ kind-dependencies:
 transforms:
     - taskgraph.transforms.tests:transforms
     - comm_taskgraph:tests_drop_1proc
     - taskgraph.transforms.job:transforms
     - taskgraph.transforms.task:transforms
 
 jobs-from:
     - tests.yml
+
+# These apply to all included test yml files listed in jobs-from
+job-defaults:
+    when:
+        files-changed:
+            # Include everything in comm-central except suite/
+            # https://bugzilla.mozilla.org/show_bug.cgi?id=1422060
+            - comm/build
+            - comm/calendar
+            - comm/chat
+            - comm/common
+            - comm/db
+            - comm/editor
+            - comm/ldap
+            - comm/mail
+            - comm/mailnews
+            - comm/mozharness
+            - comm/other-licenses
+            - comm/rdf
+            - comm/taskcluster
+            - comm/testing
+            - comm/.gecko_rev.yml
+            - comm/.taskcluster.yml
+            - comm/moz.build
+
--- a/taskcluster/ci/test/tests.yml
+++ b/taskcluster/ci/test/tests.yml
@@ -6,38 +6,16 @@
 # processed through the transformations described in kind.yml to produce a
 # bunch of tasks.  See the schema in `taskcluster/taskgraph/transforms/tests.py`
 # for a description of the fields used here.
 
 # Note that these are in lexical order, as enforced by the task loader.
 
 # Adding a new test type or running tests on a new platform? Be sure to review
 # https://wiki.mozilla.org/Sheriffing/Job_Visibility_Policy
-job-defaults:
-    when:
-        files-changed:
-            # Include everything in comm-central except suite/
-            # https://bugzilla.mozilla.org/show_bug.cgi?id=1422060
-            - comm/build
-            - comm/calendar
-            - comm/chat
-            - comm/common
-            - comm/db
-            - comm/editor
-            - comm/ldap
-            - comm/mail
-            - comm/mailnews
-            - comm/mozharness
-            - comm/other-licenses
-            - comm/rdf
-            - comm/taskcluster
-            - comm/testing
-            - comm/.gecko_rev.yml
-            - comm/.taskcluster.yml
-            - comm/moz.build
 
 xpcshell:
     description: "xpcshell test run"
     suite: xpcshell
     treeherder-symbol: X(X)
     run-on-projects: built-projects
     docker-image:
         in-tree: "desktop1604-test"