Bug 1499286 - Fix failing testLocalICS.js by listening for input event instead of command event. r=philipp
authorGeoff Lankow <geoff@darktrojan.net>
Tue, 16 Oct 2018 23:20:44 +1300
changeset 33393 379f94cf13ee6dcf5c4b5c4575b3729baee7f702
parent 33392 2be6397d3b059904c0a8ccf7dae963bf0b93798a
child 33394 9348dfd44e19fa573eab407d3ddce174c03e2a7f
push id387
push userclokep@gmail.com
push dateMon, 10 Dec 2018 21:30:47 +0000
reviewersphilipp
bugs1499286
Bug 1499286 - Fix failing testLocalICS.js by listening for input event instead of command event. r=philipp
calendar/resources/content/calendarCreation.xul
calendar/test/mozmill/testLocalICS.js
--- a/calendar/resources/content/calendarCreation.xul
+++ b/calendar/resources/content/calendarCreation.xul
@@ -52,25 +52,20 @@
                     <radiogroup id="calendar-format" onselect="onSelectProvider(this.value)">
                         <radio value="ics" label="&calendarproperties.webdav.label;" selected="true" />
                         <radio value="caldav" label="&calendarproperties.caldav.label;"/>
                         <radio id="wcap-radio" value="wcap" label="&calendarproperties.wcap.label;"/>
                     </radiogroup>
                 </row>
                 <row align="center">
                     <label value="&calendarproperties.location.label;" control="calendar-uri"/>
-                    <!--  Due to bug 128066, dropping urls here doesn't trigger
-                          events. To work around, we use the dragexit handler,
-                          which is triggered. Unfortunately, the more logical
-                          choice of drag'n'drop doesn't work here either.-->
                     <textbox id="calendar-uri"
                              required="true"
                              type="search"
-                             oncommand="checkRequired();"
-                             ondragexit="checkRequired();"/>
+                             oninput="checkRequired();"/>
                 </row>
                 <row>
                      <label/>
                      <checkbox id="cache"
                                checked="true"
                                label="&calendarproperties.cache3.label;"/>
                 </row>
                 <notificationbox id="location-notifications" flex="1"/>
--- a/calendar/test/mozmill/testLocalICS.js
+++ b/calendar/test/mozmill/testLocalICS.js
@@ -81,13 +81,12 @@ function testLocalICS() {
     cstream.init(fstream, "UTF-8", 0, 0);
 
     let str = {};
     cstream.readString(-1, str);
     cstream.close();
 
     controller.assertJS(str.value.includes("SUMMARY:" + calendarTitle));
 }
-testLocalICS.EXCLUDED_PLATFORMS = ["linux"];
 
 function teardownTest(module) {
     deleteCalendars(controller, calendarName);
 }