Bug 1556228 - Port bug 1503341: Use UX provided text for displaying errors when writing the update settings json file. r=jorgk DONTBUILD
authorRichard Marti <richard.marti@gmail.com>
Sun, 02 Jun 2019 11:49:47 +0200
changeset 35774 0e71e7bac1888f0d0871fc6542dec4b32fb5b532
parent 35773 5116ce5bc260ce3aa7cc7c975eca2149bc14c8c6
child 35775 2be4f664709ce345bf9a06561b6462e509aef9a1
push id392
push userclokep@gmail.com
push dateMon, 02 Sep 2019 20:17:19 +0000
reviewersjorgk
bugs1556228, 1503341
Bug 1556228 - Port bug 1503341: Use UX provided text for displaying errors when writing the update settings json file. r=jorgk DONTBUILD
mail/components/preferences/advanced.js
mail/locales/en-US/messenger/preferences/preferences.ftl
--- a/mail/components/preferences/advanced.js
+++ b/mail/components/preferences/advanced.js
@@ -402,18 +402,18 @@ var gAdvancedPane = {
       if (!updateAutoValue) {
         await this.checkUpdateInProgress();
       }
     }
   },
 
   async reportUpdatePrefWriteError(error) {
     let [title, message] = await document.l10n.formatValues([
-      {id: "update-pref-write-failure-title"},
-      {id: "update-pref-write-failure-message", args: {path: error.path}},
+      {id: "update-setting-write-failure-title"},
+      {id: "update-setting-write-failure-message", args: {path: error.path}},
     ]);
 
     // Set up the Ok Button
     let buttonFlags = (Services.prompt.BUTTON_POS_0 *
                        Services.prompt.BUTTON_TITLE_OK);
     Services.prompt.confirmEx(window, title, message, buttonFlags,
                               null, null, null, null, {});
   },
--- a/mail/locales/en-US/messenger/preferences/preferences.ftl
+++ b/mail/locales/en-US/messenger/preferences/preferences.ftl
@@ -4,21 +4,26 @@
 
 choose-messenger-language-description = Choose the languages used to display menus, messages, and notifications from { -brand-short-name }.
 manage-messenger-languages-button =
   .label = Set Alternatives…
   .accesskey = l
 confirm-messenger-language-change-description = Restart { -brand-short-name } to apply these changes
 confirm-messenger-language-change-button = Apply and Restart
 
-update-pref-write-failure-title = Write Failure
+update-setting-write-failure-title = Error saving Update preferences
 
 # Variables:
 #   $path (String) - Path to the configuration file
-update-pref-write-failure-message = Unable to save preference. Could not write to file: { $path }
+# The newlines between the main text and the line containing the path is
+# intentional so the path is easier to identify.
+update-setting-write-failure-message =
+    { -brand-short-name } encountered an error and didnít save this change. Note that setting this update preference requires permission to write to the file below. You or a system administrator may be able resolve the error by granting the Users group full control to this file.
+
+    Could not write to file: { $path }
 
 update-in-progress-title = Update In Progress
 
 update-in-progress-message = Do you want { -brand-short-name } to continue with this update?
 
 update-in-progress-ok-button = &Discard
 # Continue is the cancel button so pressing escape or using a platform standard
 # method of closing the UI will not discard the update.