Bug 1498863 - Fix broken remembering of selected preference pane after bug 1481949. r=jorgk DONTBUILD
authorGeoff Lankow <geoff@darktrojan.net>
Mon, 15 Oct 2018 14:47:59 +1300
changeset 33373 08a107c8c517158fbb1c32f09a1d224505bcda20
parent 33372 ab7eef3d430ed61fb8ee43ebdeb831e63dc49576
child 33374 883d9d1734ad1c0a7321f1101190160ba45dc1a4
push id387
push userclokep@gmail.com
push dateMon, 10 Dec 2018 21:30:47 +0000
reviewersjorgk
bugs1498863, 1481949
Bug 1498863 - Fix broken remembering of selected preference pane after bug 1481949. r=jorgk DONTBUILD
common/bindings/preferences.xml
--- a/common/bindings/preferences.xml
+++ b/common/bindings/preferences.xml
@@ -739,16 +739,17 @@
 
 
       <method name="_makePaneButton">
         <parameter name="aPaneElement"/>
         <body>
         <![CDATA[
           var radio = document.createElement("radio");
           radio.setAttribute("pane", aPaneElement.id);
+          radio.setAttribute("value", aPaneElement.id);
           radio.setAttribute("label", aPaneElement.label);
           // Expose preference group choice to accessibility APIs as an unchecked list item
           // The parent group is exposed to accessibility APIs as a list
           if (aPaneElement.image)
             radio.setAttribute("src", aPaneElement.image);
           radio.style.listStyleImage = aPaneElement.style.listStyleImage;
           this._selector.appendChild(radio);
           return radio;