searching for reviewer(Neil)
ed4c04ff19d9650216f19d88348a6a6af0ec6d0f: Bug 1527173 - [autoconfig] Fix race condition in addOneFinishedObserver. r=Neil
Ben Bucksch <ben.bucksch@beonex.com> - Wed, 13 Feb 2019 12:43:54 +0100 - rev 34527
Push 390 by clokep@gmail.com at Mon, 20 May 2019 17:04:42 +0000
Bug 1527173 - [autoconfig] Fix race condition in addOneFinishedObserver. r=Neil
bf09891616a48952acec87cef9d37861bc5fbacc: Bug 1527173 - [autoconfig] Fix race condition in addOneFinishedObserver. r=Neil a=jorgk
Ben Bucksch <ben.bucksch@beonex.com> - Wed, 13 Feb 2019 12:43:54 +0100 - rev 34349
Push 389 by clokep@gmail.com at Mon, 18 Mar 2019 19:01:53 +0000
Bug 1527173 - [autoconfig] Fix race condition in addOneFinishedObserver. r=Neil a=jorgk
1ff4cbc59aae01ffd7fbb94852cbf07223e7806b: Bug 1518890 - [autoconfig] Pass Exchange URL from account creation dialog to addon. r=Neil
Ben Bucksch <ben.bucksch> - Thu, 10 Jan 2019 08:18:00 +0100 - rev 34157
Push 389 by clokep@gmail.com at Mon, 18 Mar 2019 19:01:53 +0000
Bug 1518890 - [autoconfig] Pass Exchange URL from account creation dialog to addon. r=Neil
130e9b3087d79100c46fa00b54150d36267bf788: Bug 1518155 - [autoconfig] Exchange AutoDiscover: Ask for username only if necessary. r=Neil
Ben Bucksch <ben.bucksch> - Thu, 10 Jan 2019 08:01:00 +0100 - rev 34156
Push 389 by clokep@gmail.com at Mon, 18 Mar 2019 19:01:53 +0000
Bug 1518155 - [autoconfig] Exchange AutoDiscover: Ask for username only if necessary. r=Neil
1cb168d17d1b89b99e2549d633e3db084362e56c: Bug 1516229 - [autoconfig] Beautify the account config debug output and avoid logging the password. r=Neil
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 04 Jan 2019 06:58:00 +0100 - rev 34116
Push 389 by clokep@gmail.com at Mon, 18 Mar 2019 19:01:53 +0000
Bug 1516229 - [autoconfig] Beautify the account config debug output and avoid logging the password. r=Neil
1f255495f7a15d5b8094512f76cf8078b2a61e76: Bug 1515903 - [autoconfig] Allow PNG and JPEG image data: URLs. r=Neil
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 21 Dec 2018 15:44:48 +0100 - rev 34044
Push 389 by clokep@gmail.com at Mon, 18 Mar 2019 19:01:53 +0000
Bug 1515903 - [autoconfig] Allow PNG and JPEG image data: URLs. r=Neil Bug 1514628 changed the icon URL from http: to data:image/png;. However, data: URLs are forbidden, so the addon doesn't show up at all. data: URLs are highly dangerous in chrome code. They can contain anything, including javascript, e.g. data:text/javascript; and data:text/html; and similar. If these come from the network, and they are run from chrome code, they allow the attacker to run arbitrary code with system privileges, i.e. a remote code execution bug, a critical security bug. These are one of the most dangerous URLs in chrome. These should be avoided at all costs. However, I guess that data:image/png; and data:image/jpeg; are fine, because they cannot contain code. Then again, SVG can contain JS and must be forbidden. This change opens this up a little bit, allowing specifically PNG and JPEG image data: URLs, and only those. That allows icons to be inline.
1403c0fa3d1ac8b10ec74adb92b245575059298f: Bug 1500105 - Support Exchange AutoDiscover and parallelize network calls. r=aceman,mkmelin,Neil
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 14 Dec 2018 12:05:14 +0100 - rev 33996
Push 389 by clokep@gmail.com at Mon, 18 Mar 2019 19:01:53 +0000
Bug 1500105 - Support Exchange AutoDiscover and parallelize network calls. r=aceman,mkmelin,Neil Summary: * Parallelize network calls * Exchange AutoDiscover protocol implementation * Try to find IMAP servers in the server response * Offer to install an extension which supports the Exchange protocol to get mails Runs all the ISP config lookup network calls in parallel. Class PriorityOrderAbortable (subclass of ParallelAbortable) implements a policy that waits until one of the calls returns successfully, then takes that result and cancels all pending less desirable calls. Implements the Exchange AutoDiscover protocol to detect Exchange servers. If the server gives an IMAP configuration, we offer that to the user. Alternatively, we offer a compatible verified extension that implements the specific Exchange protocol that the Exchange server returned. Exchange has at least 7 protocols, and we show extensions that support the protocols that the server listed and that are known to work well and actively maintained. The setup process then continues without interruption. Test plan: Exchange autoconfig: 1. To test Exchange AutoDiscover with an hotmail/outlook.com account (which has an IMAP config in our ISPDB), set these prefs: mailnews.auto_config.guess.enabled = false mailnews.auto_config_url = "" mailnews.mx_service_url = "" 2. Enter you@outlook.com and a valid password (it will not work without valid password, due to the Exchange AutoDiscover protocol design) 3. [Continue] 4. -> TB should find an Exchange server with hostname 5. -> TB will offer you to install an extension that supports this protocol type, with explanatory text and a link 6. Click [Install] 7. -> The password is checked, the dialog closes, and the account appears, and your emails are downloaded. Parallel network calls: 1. Open account creation dialog 2. Enter "foo@gmail.com", "foo@yahoo.com", "foo@sys4.de", "foo@example.com", or any other domain 3. -> It works functionally as before, see https://developer.mozilla.org/en-US/docs/Mozilla/Thunderbird/Autoconfiguration 4. -> It's faster than before Differential Revision: https://phabricator.services.mozilla.com/D9215
492bea4ded8961c2171ba05a185555c5e6deb7af: Bug 1518890 - [autoconfig] Pass Exchange URL from account creation dialog to addon. r=Neil a=jorgk
Ben Bucksch <ben.bucksch> - Thu, 10 Jan 2019 08:18:00 +0100 - rev 33947
Push 388 by clokep@gmail.com at Mon, 28 Jan 2019 20:54:56 +0000
Bug 1518890 - [autoconfig] Pass Exchange URL from account creation dialog to addon. r=Neil a=jorgk
d90827241325c5d38974e01ea61bdac3c7cd1fbb: Bug 1518155 - [autoconfig] Exchange AutoDiscover: Ask for username only if necessary. r=Neil a=jorgk
Ben Bucksch <ben.bucksch@beonex.com> - Wed, 16 Jan 2019 14:32:33 +0100 - rev 33946
Push 388 by clokep@gmail.com at Mon, 28 Jan 2019 20:54:56 +0000
Bug 1518155 - [autoconfig] Exchange AutoDiscover: Ask for username only if necessary. r=Neil a=jorgk
a68ee343e490c89dcf226229ad99247e8dfdfe01: Bug 1516229 - [autoconfig] Beautify the account config debug output and avoid logging the password. r=Neil a=jorgk
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 04 Jan 2019 06:58:00 +0100 - rev 33919
Push 388 by clokep@gmail.com at Mon, 28 Jan 2019 20:54:56 +0000
Bug 1516229 - [autoconfig] Beautify the account config debug output and avoid logging the password. r=Neil a=jorgk * * * Bug 1516229 - Follow-up: Fix linting errors. r=me DONTBUILD
7f685897fe309ac256c3e591e4b14332c536a9e6: Bug 1515903 - [autoconfig] Allow PNG and JPEG image data: URLs. r=Neil a=jorgk
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 21 Dec 2018 15:44:48 +0100 - rev 33918
Push 388 by clokep@gmail.com at Mon, 28 Jan 2019 20:54:56 +0000
Bug 1515903 - [autoconfig] Allow PNG and JPEG image data: URLs. r=Neil a=jorgk Bug 1514628 changed the icon URL from http: to data:image/png;. However, data: URLs are forbidden, so the addon doesn't show up at all. data: URLs are highly dangerous in chrome code. They can contain anything, including javascript, e.g. data:text/javascript; and data:text/html; and similar. If these come from the network, and they are run from chrome code, they allow the attacker to run arbitrary code with system privileges, i.e. a remote code execution bug, a critical security bug. These are one of the most dangerous URLs in chrome. These should be avoided at all costs. However, I guess that data:image/png; and data:image/jpeg; are fine, because they cannot contain code. Then again, SVG can contain JS and must be forbidden. This change opens this up a little bit, allowing specifically PNG and JPEG image data: URLs, and only those. That allows icons to be inline.
42dfab681c409905c0d84cd86d100452cd603e1a: Bug 1500105 - Support Exchange AutoDiscover and parallelize network calls. r=aceman,mkmelin,Neil a=jorgk
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 14 Dec 2018 12:05:14 +0100 - rev 33915
Push 388 by clokep@gmail.com at Mon, 28 Jan 2019 20:54:56 +0000
Bug 1500105 - Support Exchange AutoDiscover and parallelize network calls. r=aceman,mkmelin,Neil a=jorgk Summary: * Parallelize network calls * Exchange AutoDiscover protocol implementation * Try to find IMAP servers in the server response * Offer to install an extension which supports the Exchange protocol to get mails Runs all the ISP config lookup network calls in parallel. Class PriorityOrderAbortable (subclass of ParallelAbortable) implements a policy that waits until one of the calls returns successfully, then takes that result and cancels all pending less desirable calls. Implements the Exchange AutoDiscover protocol to detect Exchange servers. If the server gives an IMAP configuration, we offer that to the user. Alternatively, we offer a compatible verified extension that implements the specific Exchange protocol that the Exchange server returned. Exchange has at least 7 protocols, and we show extensions that support the protocols that the server listed and that are known to work well and actively maintained. The setup process then continues without interruption. Test plan: Exchange autoconfig: 1. To test Exchange AutoDiscover with an hotmail/outlook.com account (which has an IMAP config in our ISPDB), set these prefs: mailnews.auto_config.guess.enabled = false mailnews.auto_config_url = "" mailnews.mx_service_url = "" 2. Enter you@outlook.com and a valid password (it will not work without valid password, due to the Exchange AutoDiscover protocol design) 3. [Continue] 4. -> TB should find an Exchange server with hostname 5. -> TB will offer you to install an extension that supports this protocol type, with explanatory text and a link 6. Click [Install] 7. -> The password is checked, the dialog closes, and the account appears, and your emails are downloaded. Parallel network calls: 1. Open account creation dialog 2. Enter "foo@gmail.com", "foo@yahoo.com", "foo@sys4.de", "foo@example.com", or any other domain 3. -> It works functionally as before, see https://developer.mozilla.org/en-US/docs/Mozilla/Thunderbird/Autoconfiguration 4. -> It's faster than before Differential Revision: https://phabricator.services.mozilla.com/D9215
886ee22a3f85d1a7f55c7fa1e5813470be99d88a: Bug 1515903 - [autoconfig] Allow PNG and JPEG image data: URLs. r=Neil a=jorgk
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 21 Dec 2018 15:44:48 +0100 - rev 33896
Push 388 by clokep@gmail.com at Mon, 28 Jan 2019 20:54:56 +0000
Bug 1515903 - [autoconfig] Allow PNG and JPEG image data: URLs. r=Neil a=jorgk Bug 1514628 changed the icon URL from http: to data:image/png;. However, data: URLs are forbidden, so the addon doesn't show up at all. data: URLs are highly dangerous in chrome code. They can contain anything, including javascript, e.g. data:text/javascript; and data:text/html; and similar. If these come from the network, and they are run from chrome code, they allow the attacker to run arbitrary code with system privileges, i.e. a remote code execution bug, a critical security bug. These are one of the most dangerous URLs in chrome. These should be avoided at all costs. However, I guess that data:image/png; and data:image/jpeg; are fine, because they cannot contain code. Then again, SVG can contain JS and must be forbidden. This change opens this up a little bit, allowing specifically PNG and JPEG image data: URLs, and only those. That allows icons to be inline.
60a1cefdf2afe240abc3558542a8237276e7f000: Bug 1500105 - Support Exchange AutoDiscover and parallelize network calls. r=aceman,mkmelin,Neil a=jorgk
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 14 Dec 2018 12:05:14 +0100 - rev 33894
Push 388 by clokep@gmail.com at Mon, 28 Jan 2019 20:54:56 +0000
Bug 1500105 - Support Exchange AutoDiscover and parallelize network calls. r=aceman,mkmelin,Neil a=jorgk Summary: * Parallelize network calls * Exchange AutoDiscover protocol implementation * Try to find IMAP servers in the server response * Offer to install an extension which supports the Exchange protocol to get mails Runs all the ISP config lookup network calls in parallel. Class PriorityOrderAbortable (subclass of ParallelAbortable) implements a policy that waits until one of the calls returns successfully, then takes that result and cancels all pending less desirable calls. Implements the Exchange AutoDiscover protocol to detect Exchange servers. If the server gives an IMAP configuration, we offer that to the user. Alternatively, we offer a compatible verified extension that implements the specific Exchange protocol that the Exchange server returned. Exchange has at least 7 protocols, and we show extensions that support the protocols that the server listed and that are known to work well and actively maintained. The setup process then continues without interruption. Test plan: Exchange autoconfig: 1. To test Exchange AutoDiscover with an hotmail/outlook.com account (which has an IMAP config in our ISPDB), set these prefs: mailnews.auto_config.guess.enabled = false mailnews.auto_config_url = "" mailnews.mx_service_url = "" 2. Enter you@outlook.com and a valid password (it will not work without valid password, due to the Exchange AutoDiscover protocol design) 3. [Continue] 4. -> TB should find an Exchange server with hostname 5. -> TB will offer you to install an extension that supports this protocol type, with explanatory text and a link 6. Click [Install] 7. -> The password is checked, the dialog closes, and the account appears, and your emails are downloaded. Parallel network calls: 1. Open account creation dialog 2. Enter "foo@gmail.com", "foo@yahoo.com", "foo@sys4.de", "foo@example.com", or any other domain 3. -> It works functionally as before, see https://developer.mozilla.org/en-US/docs/Mozilla/Thunderbird/Autoconfiguration 4. -> It's faster than before Differential Revision: https://phabricator.services.mozilla.com/D9215
2cfa24cfd1ac6984457e9bd952fb2e347670faba: Bug 409458 - nsIMsgFolder.AddFolderListener should hold a reference to the listener. r=standard8,neil,darktrojan,jorgk
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Thu, 30 Aug 2018 15:42:58 +1200 - rev 33111
Push 387 by clokep@gmail.com at Mon, 10 Dec 2018 21:30:47 +0000
Bug 409458 - nsIMsgFolder.AddFolderListener should hold a reference to the listener. r=standard8,neil,darktrojan,jorgk
58e10a57231466920dda9c66396ca54ef12e6ed3: Bug 1160770 - Unnecessary return in tabScrolling property in XPFE autocomplete.xml NPOTB r=Neil DONTBUILD
Philip Chee <philip.chee@gmail.com> - Sun, 03 May 2015 00:15:40 +0800 - rev 30506
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 1160770 - Unnecessary return in tabScrolling property in XPFE autocomplete.xml NPOTB r=Neil DONTBUILD
3e9828cc49e70b0a248b07af82d24d83e912f304: Bug 1053166 Part 2 Remove trailing whitespace in blank lines and comments r=Neil DONTBUILD NPOTDB
Philip Chee <philip.chee@gmail.com> - Fri, 12 Sep 2014 00:30:37 +0800 - rev 30501
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 1053166 Part 2 Remove trailing whitespace in blank lines and comments r=Neil DONTBUILD NPOTDB
78bb1e757a3346bc9f77e844b87a315177ff0cfa: Bug 135019 - Inline autocomplete: single backspace deletes the last character typed along with the suggestion. r=Neil
Suyash Agarwal <syshagarwal@gmail.com> - Thu, 15 Aug 2013 08:30:49 -0400 - rev 30491
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 135019 - Inline autocomplete: single backspace deletes the last character typed along with the suggestion. r=Neil
6ed938b4d3f0a945b9d1a2469246f6c2e67125f0: bug 407956 - make nsITreeView not take a nsISupportsArray* r=neil, bz sr=neil
Trevor Saunders <trev.saunders@gmail.com> - Sun, 06 Jan 2013 19:54:42 -0500 - rev 30473
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
bug 407956 - make nsITreeView not take a nsISupportsArray* r=neil, bz sr=neil
8288831a9dd7f526660d87561186fd612e2f6b9a: Bug 747668. (Iv2a) XPFE autocomplete.xml: Implement (nsIAutoCompleteInput) searchCount and getSearchAt(), Nits. r=Neil.
Serge Gautherie <sgautherie.bz@free.fr> - Sat, 05 Jan 2013 20:27:12 +0800 - rev 30469
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 747668. (Iv2a) XPFE autocomplete.xml: Implement (nsIAutoCompleteInput) searchCount and getSearchAt(), Nits. r=Neil. DONTBUILD (npotb).
a44c609f7f027bfa905b8e7a6d2cd8cbb2fc2031: Bug 707039. (Dv4) XPFE autocomplete.xml: Adjust the direction of the (content) autocomplete popup list based on the textbox direction. r=neil.
Serge Gautherie <sgautherie.bz@free.fr> - Sun, 05 Feb 2012 00:07:40 +0100 - rev 30458
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 707039. (Dv4) XPFE autocomplete.xml: Adjust the direction of the (content) autocomplete popup list based on the textbox direction. r=neil. DONTBUILD (NPODB).
3134f4c81f2c40ab982a791f4e832c1450dd86f0: Bug 772963: remove empty parameter name. r=Neil
Benjamin Peterson <benjamin@python.org> - Wed, 11 Jul 2012 11:32:00 -0400 - rev 30452
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 772963: remove empty parameter name. r=Neil
bcbe43f604634e827c79a97635d658e18736a339: Bug 772963: remove empty parameter name. r=Neil DONTBUILD for m-c land
Benjamin Peterson <benjamin@python.org> - Wed, 11 Jul 2012 11:32:00 -0400 - rev 30451
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 772963: remove empty parameter name. r=Neil DONTBUILD for m-c land (since not used by Firefox/B2G/Fennec)
3f5c7f2c7b701bf42f8a60b14c47a5dbac83ef1c: Bug 747668. (Hv1a) XPFE autocomplete.xml: Implement nsIAutoCompleteInput.textValue. r=neil.
Serge Gautherie <sgautherie.bz@free.fr> - Wed, 30 May 2012 20:06:17 +0200 - rev 30450
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 747668. (Hv1a) XPFE autocomplete.xml: Implement nsIAutoCompleteInput.textValue. r=neil. DONTBUILD (npotb).
0aa7d37049496dff2ceba8f8a485475b36dd6df2: Bug 747668. (Gv1a) XPFE autocomplete.xml: Implement nsIAutoCompleteInput.popupOpen(). r=neil.
Serge Gautherie <sgautherie.bz@free.fr> - Sat, 26 May 2012 23:40:28 +0200 - rev 30449
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 747668. (Gv1a) XPFE autocomplete.xml: Implement nsIAutoCompleteInput.popupOpen(). r=neil. DONTBUILD (npotb).
a7e6e3d7bcfb3fb55f4c4e5fc71f04bcfec51874: Bug 747668. (Fv1) XPFE autocomplete.xml: Move selectBy() into nsIAutoCompletePopup section. r=neil.
Serge Gautherie <sgautherie.bz@free.fr> - Sat, 26 May 2012 16:30:31 +0200 - rev 30448
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 747668. (Fv1) XPFE autocomplete.xml: Move selectBy() into nsIAutoCompletePopup section. r=neil. DONTBUILD (npotb, trivial).
9a9b4f7a44f5203c8014b020e00748b1371dd7b1: Bug 747668. (Ev1) XPFE autocomplete.xml: Move code into searchParam. r=neil.
Serge Gautherie <sgautherie.bz@free.fr> - Wed, 02 May 2012 15:39:24 +0200 - rev 30446
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 747668. (Ev1) XPFE autocomplete.xml: Move code into searchParam. r=neil. DONTBUILD (a=npotb).
775954d54d208704e368203a0284b77d219e18dd: Bug 747668. (Dv1) XPFE autocomplete.xml: Move code into onTextReverted(). r=neil.
Serge Gautherie <sgautherie.bz@free.fr> - Fri, 27 Apr 2012 11:51:15 +0200 - rev 30445
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 747668. (Dv1) XPFE autocomplete.xml: Move code into onTextReverted(). r=neil. DONTBUILD (npotb).
86b125b9cad96f8f57da6d54432fbf313d9de7f0: Bug 747668. (Cv1) XPFE autocomplete.xml: Regroup code into onSearchComplete(). r=neil.
Serge Gautherie <sgautherie.bz@free.fr> - Fri, 27 Apr 2012 00:52:25 +0200 - rev 30444
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 747668. (Cv1) XPFE autocomplete.xml: Regroup code into onSearchComplete(). r=neil. DONTBUILD (npotb).
13ae00e9b517b08643bbaadc711715996f4d5e91: Bug 747668. (Bv1) Port |Bug 418712 - nsIAutoCompleteInput should fire an event when a search begins| to SeaMonkey. r=neil.
Serge Gautherie <sgautherie.bz@free.fr> - Mon, 23 Apr 2012 01:28:55 +0200 - rev 30443
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 747668. (Bv1) Port |Bug 418712 - nsIAutoCompleteInput should fire an event when a search begins| to SeaMonkey. r=neil. DONTBUILD (a=npotb).
cb26ffb49e69c8893987181317321b37005f7a0d: Bug 747668. (Av1a) XPFE autocomplete.xml: Regroup nsIAutoCompleteInput properties, Fix some nits. r=neil.
Serge Gautherie <sgautherie.bz@free.fr> - Sun, 22 Apr 2012 10:11:11 +0200 - rev 30442
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 747668. (Av1a) XPFE autocomplete.xml: Regroup nsIAutoCompleteInput properties, Fix some nits. r=neil. DONTBUILD (a=npotb).
0dc60e044f07050a1dca42dee9d3840b2be539f3: Bug 707039. (Dv4) XPFE autocomplete.xml: Adjust the direction of the (content) autocomplete popup list based on the textbox direction. r=neil.
Serge Gautherie <sgautherie.bz@free.fr> - Sun, 05 Feb 2012 00:07:40 +0100 - rev 30439
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 707039. (Dv4) XPFE autocomplete.xml: Adjust the direction of the (content) autocomplete popup list based on the textbox direction. r=neil. DONTBUILD (NPODB).
d062329d9868ccd87738c66ab7682f93a255f247: Bug 707039. (Bv1) XPFE autocomplete.xml: Rename resultsPopup to popup. r=neil.
Serge Gautherie <sgautherie.bz@free.fr> - Thu, 05 Jan 2012 04:07:19 +0100 - rev 30438
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 707039. (Bv1) XPFE autocomplete.xml: Rename resultsPopup to popup. r=neil. DONTBUILD (NPOMCB).
bc127aa3994f9a98480a7c7813464ab81d8961d4: Bug 707039. (Av1) XPFE autocomplete.xml: Rename openResultPopup()/closeResultPopup() to openPopup()/closePopup(). r=neil.
Serge Gautherie <sgautherie.bz@free.fr> - Thu, 05 Jan 2012 04:06:19 +0100 - rev 30437
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 707039. (Av1) XPFE autocomplete.xml: Rename openResultPopup()/closeResultPopup() to openPopup()/closePopup(). r=neil. DONTBUILD (NPOMCB).
6098be142a9fbf5216b84b732b32f86b9670c026: Fix comm-central app bustage from bug 696498 - change the depth of the makefiles to account for being generated from the comm-central build system now that the old xpfe autocomplete files are no longer generated within the mozilla-central part of the build system. rs=Neil over irc. NPOTFFB DONTBUILD
Mark Banner <bugzilla@standard8.plus.com> - Thu, 01 Dec 2011 15:26:29 +0000 - rev 30436
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Fix comm-central app bustage from bug 696498 - change the depth of the makefiles to account for being generated from the comm-central build system now that the old xpfe autocomplete files are no longer generated within the mozilla-central part of the build system. rs=Neil over irc. NPOTFFB DONTBUILD
9a2a2cf30642cd19fe0c731375f71fec5d9f6c11: Bug 635404 - Let a few more attributes inherit to the html input field in xpfe's autocomplete.xml. r=Neil, a=shaver over IRC (NPOTB).
stefanh@inbox.com - Sat, 19 Feb 2011 18:00:27 +0100 - rev 30425
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 635404 - Let a few more attributes inherit to the html input field in xpfe's autocomplete.xml. r=Neil, a=shaver over IRC (NPOTB).
e7770564b9382fff008de8380120f2921ca98c77: Bug 406396 xpfe "history-dropmarker" binding makes invalid assumption about menupop children. r=Neil a=NPOTB DONTBUILD
Philip Chee <philip.chee@gmail.com> - Mon, 17 Jan 2011 12:43:15 +0800 - rev 30424
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 406396 xpfe "history-dropmarker" binding makes invalid assumption about menupop children. r=Neil a=NPOTB DONTBUILD
480ff1057204795fb9ef05e9517ed7be12cc1ba7: Bug 500977 - xpfe's autocomplete.xml should not depend on bug 232598. r=neil
Dão Gottwald <dao@mozilla.com> - Sun, 28 Jun 2009 21:21:35 +0200 - rev 30415
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 500977 - xpfe's autocomplete.xml should not depend on bug 232598. r=neil
96e297d08b3fcc01ba93c929de23d6436846c615: Bug 468363 - Clicking on URL in autocomplete drop-down while search is running does not autocomplete URL, r=Neil, SeaMonkey/Thunderbird only
Frank Wein <mcsmurf@mcsmurf.de> - Tue, 14 Apr 2009 15:38:40 +0200 - rev 30413
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 468363 - Clicking on URL in autocomplete drop-down while search is running does not autocomplete URL, r=Neil, SeaMonkey/Thunderbird only
18a3ad252c7bcd850193b86410ed81ecfee5d95d: Bug 451015 <panel> element should not be topmost window r=deakin+gavin, sr=neil
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 08 Sep 2008 21:58:07 +0900 - rev 30405
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 451015 <panel> element should not be topmost window r=deakin+gavin, sr=neil
8c10c22a3f96dcb9087c17c852add08623d82a45: followup kinda-typo fix to bug 443370, use correct index to fix error when doing async autocomplete updates, r=Neil over IRC, NPOTB for FF
Robert Kaiser <kairo@kairo.at> - Sat, 16 Aug 2008 01:49:14 +0200 - rev 30401
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
followup kinda-typo fix to bug 443370, use correct index to fix error when doing async autocomplete updates, r=Neil over IRC, NPOTB for FF
f4811ba7c78092d9bed7ef22274e1587c660165b: Bug 309081 Sync xpfe autocomplete attributes with toolkit ones (sync case). r=mkmelin,sr=Neil
bugzilla@standard8.plus.com - Thu, 15 May 2008 05:45:31 -0700 - rev 30390
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 309081 Sync xpfe autocomplete attributes with toolkit ones (sync case). r=mkmelin,sr=Neil
971e6fa6771ff36088cf1a5381dbacc6eaf1867b: Bug 411226 - Migrate SeaMonkey's smart browsing preferences to new pref window (also rename panel to 'Location Bar'). r=IanN, sr=Neil.
stefanh@inbox.com - Tue, 06 May 2008 10:10:03 -0700 - rev 30389
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 411226 - Migrate SeaMonkey's smart browsing preferences to new pref window (also rename panel to 'Location Bar'). r=IanN, sr=Neil.
9d0dcc06751f8b0298e91b44c6501a34f2f028d6: Bug 257722 - No visual feedback when clicking on scrollbarbutton in autocomplete popups (no depressed state), r=neil, SeaMonkey-only
martijn.martijn@gmail.com - Mon, 26 Nov 2007 12:01:40 -0800 - rev 30386
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 257722 - No visual feedback when clicking on scrollbarbutton in autocomplete popups (no depressed state), r=neil, SeaMonkey-only
dd1c6d51c3c93780623b5d1b88e3e02bbc39e7e0: Bug 399316 - Bug introduced with patch for bug 216434 (autocomplete dropdown covers textbox when textbox is near bottom of screen), r=neil, a=mconnor
martijn.martijn@gmail.com - Fri, 12 Oct 2007 03:24:00 -0700 - rev 30384
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 399316 - Bug introduced with patch for bug 216434 (autocomplete dropdown covers textbox when textbox is near bottom of screen), r=neil, a=mconnor
55c7f52e0e4ff6cc61b7c989f26fcb50454df898: Bug 216434 - autocomplete dropdown covers textbox when textbox is near bottom of screen, r=neil, a=mconnor
martijn.martijn@gmail.com - Sun, 30 Sep 2007 12:00:10 -0700 - rev 30382
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 216434 - autocomplete dropdown covers textbox when textbox is near bottom of screen, r=neil, a=mconnor
8e44615e3bd23b389e62589a6f8e4f1c1ed9738e: Bug 279703, rework XUL popups to use asynchronous opening, plus many other fixes, attempt 2 with creating widgets later, r=bz,neil,roc,sr=bz
enndeakin@sympatico.ca - Wed, 04 Jul 2007 08:49:38 -0700 - rev 30373
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 279703, rework XUL popups to use asynchronous opening, plus many other fixes, attempt 2 with creating widgets later, r=bz,neil,roc,sr=bz
9a8ca53c8fe044962a9b2e7e6a6fb834adf6bd68: Bug 279703, rework XUL popups to use asynchronous opening, plus many other fixes, r=bz,neil,sr=bz
enndeakin@sympatico.ca - Fri, 29 Jun 2007 12:04:45 -0700 - rev 30371
Push 382 by clokep@gmail.com at Mon, 12 Mar 2018 19:05:34 +0000
Bug 279703, rework XUL popups to use asynchronous opening, plus many other fixes, r=bz,neil,sr=bz
23725f858c42de69a528dc63ecd089b23fc5dd12: Bug 312593 - Allow unicode in passwords. r=neil,standard8,jorgk
David Bienvenu <mozilla@davidbienvenu.org> - Thu, 12 Jul 2012 16:52:00 +0200 - rev 29865
Push 380 by clokep@gmail.com at Mon, 22 Jan 2018 17:40:24 +0000
Bug 312593 - Allow unicode in passwords. r=neil,standard8,jorgk
3ba5ab1a84a582c9a4b674eb7c54460d46e15990: Bug 312593 - Allow unicode in passwords. r=neil,standard8,jorgk a=jorgk
David Bienvenu <mozilla@davidbienvenu.org> - Thu, 12 Jul 2012 16:52:00 +0200 - rev 29817
Push 378 by clokep@gmail.com at Mon, 13 Nov 2017 18:45:35 +0000
Bug 312593 - Allow unicode in passwords. r=neil,standard8,jorgk a=jorgk