Bug 1593711 - Remove extraneous QueryInterface calls that broke task filtering. r+a=pmorris THUNDERBIRD_68_10_0_BUILD1 THUNDERBIRD_68_10_0_RELEASE
authorGeoff Lankow <geoff@darktrojan.net>
Tue, 30 Jun 2020 10:55:25 +1200
changeset 36205 6a7c26eb22bfe18295497c720a73e24b29b0604e
parent 36204 0579ee0b9174add62f2bd6f607cd35a4c27cdc82
child 36206 bc4af1e8c693a8cb4eb2faf57e0ef5621698b25d
push id112
push userthunderbird@calypsoblue.org
push dateMon, 29 Jun 2020 23:55:13 +0000
treeherdercomm-esr68@6a7c26eb22bf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1593711
Bug 1593711 - Remove extraneous QueryInterface calls that broke task filtering. r+a=pmorris
calendar/base/src/calFilter.js
--- a/calendar/base/src/calFilter.js
+++ b/calendar/base/src/calFilter.js
@@ -793,30 +793,28 @@ calFilter.prototype = {
         if (!next) {
           // there are no more occurrences
           return null;
         }
 
         if (this.isItemInFilters(next)) {
           return next;
         }
-        next.QueryInterface(Ci.calIEvent);
         start = next.startDate || next.entryDate;
       }
 
       // we've hit the maximum number of iterations without finding a match
       cal.WARN("[calFilter] getNextOccurrence: reached maximum iterations for " + aItem.title);
       return null;
     } else {
       // the parent item doesn't match the filter, we can return the first future exception
       // that matches the filter
       let exMatch = null;
       aItem.recurrenceInfo.getExceptionIds({}).forEach(function(rID) {
         let ex = aItem.recurrenceInfo.getExceptionFor(rID);
-        ex.QueryInterface(Ci.calIEvent);
         if (
           ex &&
           cal.dtz.now().compare(ex.startDate || ex.entryDate) < 0 &&
           this.isItemInFilters(ex)
         ) {
           exMatch = ex;
         }
       }, this);