fix saving a local message as .txt or .html on windows, r=neil,a=Standard8, bug 763319
authorDavid Bienvenu <bienvenu@nventure.com>
Mon, 11 Jun 2012 07:49:43 -0700
changeset 30810 9f64f487a9576064b7377f04698c89190e1668b9
parent 30809 0c203b72f169476543598e29b74348fa3e166e1d
child 30811 fd59f0076d0c92aea17a6b20b7ef446c64deb83b
push id1
push userclokep@gmail.com
push dateMon, 07 May 2018 22:45:56 +0000
treeherdercomm-esr60@57eacde5ef40 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersneil, Standard8, bug
bugs763319
fix saving a local message as .txt or .html on windows, r=neil,a=Standard8, bug 763319
mailnews/base/util/nsMsgUtils.cpp
--- a/mailnews/base/util/nsMsgUtils.cpp
+++ b/mailnews/base/util/nsMsgUtils.cpp
@@ -186,18 +186,18 @@ nsresult CreateStartupUrl(const char *ur
   }
   else if (PL_strncasecmp(uri, "news", 4) == 0)
   {
     nsCOMPtr<nsINntpUrl> nntpUrl = do_CreateInstance(kCNntpUrlCID, &rv);
     if (NS_SUCCEEDED(rv) && nntpUrl)
       rv = nntpUrl->QueryInterface(NS_GET_IID(nsIURI),
       (void**) aUrl);
   }
-  if (*aUrl)
-    rv = (*aUrl)->SetSpec(nsDependentCString(uri));
+  if (*aUrl) // SetSpec can fail, for mailbox urls, but we still have a url.
+    (void) (*aUrl)->SetSpec(nsDependentCString(uri));
   return rv;
 }
 
 
 // Where should this live? It's a utility used to convert a string priority,
 //  e.g., "High, Low, Normal" to an enum.
 // Perhaps we should have an interface that groups together all these
 //  utilities...