Bug 1287642 - Open as dialog for Add-ons and Data Managers should no longer be associated with browser.link.open_external; r=Ratty, a=IanN
authorrsx11m <rsx11m.pub@gmail.com>
Tue, 09 Aug 2016 15:34:35 -0500
changeset 31311 8d830bcece418eb7c6f8353a0bc9d691de6e280c
parent 31310 75e7d671fe05439396057a9b81af9ccceaac7c65
child 31312 8c1e5a12bdf90ccb9339e2698e1c20b3bf07ea8d
push id1
push userclokep@gmail.com
push dateMon, 07 May 2018 22:45:56 +0000
treeherdercomm-esr60@57eacde5ef40 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersRatty, IanN
bugs1287642
Bug 1287642 - Open as dialog for Add-ons and Data Managers should no longer be associated with browser.link.open_external; r=Ratty, a=IanN
suite/common/utilityOverlay.js
--- a/suite/common/utilityOverlay.js
+++ b/suite/common/utilityOverlay.js
@@ -1665,19 +1665,17 @@ function switchToTabHavingURI(aURI, aOpe
     if (browserWin.closed || browserWin == window)
       continue;
     if (switchIfURIInWindow(browserWin))
       return true;
   }
 
   // No opened tab has that url.
   if (aOpenNew) {
-    let newWindowPref = Services.prefs.getIntPref("browser.link.open_external");
-    let where = newWindowPref == kNewTab ? "tabfocused" : "window";
-    let browserWin = openUILinkIn(aURI.spec, where);
+    let browserWin = openUILinkIn(aURI.spec, "tabfocused");
     if (aCallback) {
       browserWin.addEventListener("pageshow", function browserWinPageShow(event) {
         if (event.target.location.href != aURI.spec)
           return;
         browserWin.removeEventListener("pageshow", browserWinPageShow, true);
         aCallback(browserWin.getBrowser().selectedBrowser);
       }, true);
     }