Bug 1265170 - Set also class="noIconPopup" to some menupopups in compose window. r=aceman a=rkent
authorRichard Marti <richard.marti@gmail.com>
Sat, 16 Apr 2016 20:50:28 +0200
changeset 31282 640bd220edb2ff51ea97c1a48c765240c07b9b4f
parent 31281 2b0e37b3a6cf649490501027e7f96df3ecffd1f5
child 31283 4f1b213a9b21e2ff566e633e86624dbf235ec334
push id1
push userclokep@gmail.com
push dateMon, 07 May 2018 22:45:56 +0000
treeherdercomm-esr60@57eacde5ef40 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaceman, rkent
bugs1265170
Bug 1265170 - Set also class="noIconPopup" to some menupopups in compose window. r=aceman a=rkent
mail/components/compose/content/editorOverlay.xul
mail/components/compose/content/messengercompose.xul
mail/themes/windows/mail/mailWindow1.css
mail/themes/windows/mail/messenger.css
--- a/mail/components/compose/content/editorOverlay.xul
+++ b/mail/components/compose/content/editorOverlay.xul
@@ -870,17 +870,18 @@
              tooltiptext="&FontFaceSelect.tooltip;"
              observes="cmd_renderedHTMLEnabler">
   <menulist id="FontFaceSelect"
             class="toolbar-focustarget"
             oncommand="doStatefulCommand('cmd_fontFace', event.target.value)"
             crop="right">
     <observes element="font-face-select-container" attribute="disabled"/>
     <observes element="cmd_fontFace" attribute="state" onbroadcast="onFontFaceChange(this.parentNode, 'cmd_fontFace')"/>
-    <menupopup id="FontFacePopup">
+    <menupopup id="FontFacePopup"
+               class="noIconPopup">
       <menuitem id="toolbarmenu_fontVarWidth" label="&fontVarWidth.label;" value=""/>
       <menuitem id="toolbarmenu_fontFixedWidth" label="&fontFixedWidth.label;" value="tt"/>
       <menuseparator id="toolbarmenuAfterGenericFontsSeparator"/>
       <menuitem id="toolbarmenu_fontHelvetica" label="&fontHelvetica.label;"
                 value="Helvetica, Arial, sans-serif"/>
       <menuitem id="toolbarmenu_fontTimes" label="&fontTimes.label;"
                 value="Times New Roman, Times, serif"/>
       <menuitem id="toolbarmenu_fontCourier" label="&fontCourier.label;"
--- a/mail/components/compose/content/messengercompose.xul
+++ b/mail/components/compose/content/messengercompose.xul
@@ -917,17 +917,18 @@
           <hbox id="top-gradient-box">
             <hbox align="center" pack="end" style="&headersSpace.style;">
               <label id="identityLabel" value="&fromAddr.label;"
                      accesskey="&fromAddr.accesskey;" control="msgIdentity"/>
             </hbox>
             <menulist id="msgIdentity" type="description" flex="1"
                       disableautoselect="true" onkeypress="fromKeyPress(event);"
                       oncommand="LoadIdentity(false);" disableonsend="true">
-              <menupopup id="msgIdentityPopup"/>
+              <menupopup id="msgIdentityPopup"
+                         class="noIconPopup"/>
             </menulist>
           </hbox>
           <listbox id="addressingWidget" flex="1" seltype="multiple" rows="1"
                    onkeydown="awKeyDown(event, this)"
                    onclick="awClickEmptySpace(event.originalTarget, true)"
                    disableonsend="true">
             <listcols>
               <listcol id="typecol-addressingWidget" style="&headersSpace.style;"/>
--- a/mail/themes/windows/mail/mailWindow1.css
+++ b/mail/themes/windows/mail/mailWindow1.css
@@ -874,25 +874,16 @@ treechildren::-moz-tree-image(subjectCol
     -moz-appearance: none;
   }
 
   #folderLocationPopup menu,
   #folderLocationPopup menuitem {
     -moz-padding-start: 2px;
   }
 
-  .noIconPopup > menuseparator {
-    -moz-appearance: none;
-    margin-top: 3px;
-    margin-bottom: 3px;
-    padding-top: 0;
-    padding-bottom: 0;
-    border-top-color: #d7d7d7;
-  }
-
   @media (-moz-windows-default-theme) {
     menulist {
       -moz-appearance: none;
       min-height: 24px;
       color: inherit;
       margin: 1px 4px;
       padding: 0 5px 1px !important;
       border: 1px solid;
--- a/mail/themes/windows/mail/messenger.css
+++ b/mail/themes/windows/mail/messenger.css
@@ -429,16 +429,25 @@ button[type="menu-button"] > button {
       transition-duration: 10ms;
     }
 
     .toolbarbutton-1[checked=true]:not(:active):hover {
       background-color: var(--toolbarbutton-checkedhover-backgroundcolor);
       transition: background-color .4s;
     }
   }
+
+  .noIconPopup > menuseparator {
+    -moz-appearance: none;
+    margin-top: 3px;
+    margin-bottom: 3px;
+    padding-top: 0;
+    padding-bottom: 0;
+    border-top-color: #d7d7d7;
+  }
 }
 
 @media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
        (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
   :root {
     --toolbarbutton-hover-background: linear-gradient(hsla(0, 0%, 100%, .6), hsla(0, 0%, 100%, .1));
     --toolbarbutton-hover-bordercolor: hsla(210, 54%, 20%, .15) hsla(210, 54%, 20%, .2) hsla(210, 54%, 20%, .25);
     --toolbarbutton-hover-boxshadow: 0 1px hsla(0, 0%, 100%, .3) inset,