Bug 1315924 - Fix usage of wrong variable and invalid declaration for map button checking. r=IanN a=IanN RELEASE_55_END
authorFrank-Rainer Grahl <frgrahl@gmx.net>
Mon, 11 Sep 2017 22:01:07 +0200
changeset 31424 41a888d5ecdb91e1f56c9f16f13f5ae9c346f6af
parent 31423 baf0d9dd53b6e928949e4d81c2f41bf7f4acd337
child 31425 de9dab6cf37effd4ffc7925c3faf646bbea52087
push id1
push userclokep@gmail.com
push dateMon, 07 May 2018 22:45:56 +0000
treeherdercomm-esr60@57eacde5ef40 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersIanN, IanN
bugs1315924
Bug 1315924 - Fix usage of wrong variable and invalid declaration for map button checking. r=IanN a=IanN
suite/mailnews/addrbook/abCardViewOverlay.js
--- a/suite/mailnews/addrbook/abCardViewOverlay.js
+++ b/suite/mailnews/addrbook/abCardViewOverlay.js
@@ -203,24 +203,24 @@ function DisplayCardViewPane(realCard)
   }
 
   var goimURL = "aim:goim?screenname=" + card.getProperty("_AimScreenName");
   var hasScreenName = HandleLink(data.cvScreenname, zScreenName, card.getProperty("_AimScreenName"), data.cvScreennameBox, goimURL);
 
   visible = hasScreenName || visible;
   visible = HandleLink(data.cvEmail2, zSecondaryEmail, card.getProperty("SecondEmail"), data.cvEmail2Box, "mailto:" + card.getProperty("SecondEmail")) || visible;
 
-	// Home section
-	visible = cvSetNode(data.cvHomeAddress, card.getProperty("HomeAddress"));
-	visible = cvSetNode(data.cvHomeAddress2, card.getProperty("HomeAddress2")) || visible;
-	visible = cvSetCityStateZip(data.cvHomeCityStZip, card.getProperty("HomeCity"), card.getProperty("HomeState"), card.getProperty("HomeZipCode")) || visible;
-	visible = cvSetNode(data.cvHomeCountry, card.getProperty("HomeCountry")) || visible;
+  // Home section
+  visible = cvSetNode(data.cvHomeAddress, card.getProperty("HomeAddress"));
+  visible = cvSetNode(data.cvHomeAddress2, card.getProperty("HomeAddress2")) || visible;
+  visible = cvSetCityStateZip(data.cvHomeCityStZip, card.getProperty("HomeCity"), card.getProperty("HomeState"), card.getProperty("HomeZipCode")) || visible;
+  visible = cvSetNode(data.cvHomeCountry, card.getProperty("HomeCountry")) || visible;
 
-  mapURLList = data.cvHomeMapIt.firstChild;
-  if (addressVisible)
+  let mapURLList = data.cvHomeMapIt.firstChild;
+  if (visible)
     mapURLList.initMapAddressFromCard(card, "Home");
 
   cvSetVisible(data.cvbHomeMapItBox, !!mapURLList.mapURL);
 
   visible = HandleLink(data.cvHomeWebPage, "", card.getProperty("WebPage2"), data.cvHomeWebPageBox, card.getProperty("WebPage2")) || visible;
 
 	cvSetVisible(data.cvhHome, visible);
 	cvSetVisible(data.cvbHome, visible);