Bug 1051862 Fix fallout from bug 983920 r=IanN a=Callek
authorNeil Rashbrook <neil@parkwaycc.co.uk>
Wed, 03 Sep 2014 21:29:08 +0100
changeset 31092 30d8cfc7d3b26557560e550d24986a48e7f8d301
parent 31091 0f9f574a0bd60ee652991b7c065384478fae96cd
child 31093 5ff7693d1c1bdbdc11fd3d80e718be292f26a105
child 31096 c9ebeab8ccf6722d4cd9f988d81045c5e4c8765f
push id1
push userclokep@gmail.com
push dateMon, 07 May 2018 22:45:56 +0000
treeherdercomm-esr60@57eacde5ef40 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersIanN, Callek
bugs1051862, 983920
Bug 1051862 Fix fallout from bug 983920 r=IanN a=Callek ba=Neil a=Callek for checkin to a CLOSED TREE
suite/common/public/moz.build
suite/common/public/nsISidebar.idl
suite/common/public/nsISidebarPanel.idl
suite/common/src/nsSidebar.js
--- a/suite/common/public/moz.build
+++ b/suite/common/public/moz.build
@@ -1,15 +1,15 @@
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 XPIDL_SOURCES += [
     'nsISessionStartup.idl',
     'nsISessionStore.idl',
-    'nsISidebarPanel.idl',
+    'nsISidebar.idl',
     'nsISuiteDownloadManagerUI.idl',
     'nsISuiteGlue.idl',
 ]
 
 XPIDL_MODULE = 'suitecommon'
 
rename from suite/common/public/nsISidebarPanel.idl
rename to suite/common/public/nsISidebar.idl
--- a/suite/common/public/nsISidebarPanel.idl
+++ b/suite/common/public/nsISidebar.idl
@@ -7,16 +7,20 @@
 /*
 
   The Sidebar API for 3rd parties
 
 */
 
 #include "nsISupports.idl"
 
-[scriptable, uuid(e0f4c5ee-2b35-4e99-81d2-ab956c4de0d1)]
-interface nsISidebarPanel : nsISupports
+[scriptable, uuid(97bfa970-8222-4c3f-bbe8-42141e4c7982)]
+interface nsISidebar : nsISupports
 {
     void addPanel(in DOMString aTitle, in DOMString aContentURL,
                   in DOMString aCustomizeURL);
     void addPersistentPanel(in DOMString aTitle, in DOMString aContentURL,
                             in DOMString aCustomizeURL);
+    void addSearchEngine(in DOMString engineURL, in DOMString iconURL,
+                         in DOMString suggestedTitle, in DOMString suggestedCategory);
+    void AddSearchProvider(in DOMString aDescriptionURL);
+    unsigned long IsSearchProviderInstalled(in DOMString aSearchURL);
 };
--- a/suite/common/src/nsSidebar.js
+++ b/suite/common/src/nsSidebar.js
@@ -21,18 +21,16 @@ const DEBUG = false; /* set to false to 
 const PANELS_RDF_FILE  = "UPnls"; /* directory services property to find panels.rdf */
 
 const SIDEBAR_CONTRACTID   = "@mozilla.org/sidebar;1";
 const SIDEBAR_CID      = Components.ID("{22117140-9c6e-11d3-aaf1-00805f8a4905}");
 const CONTAINER_CONTRACTID = "@mozilla.org/rdf/container;1";
 const NETSEARCH_CONTRACTID = "@mozilla.org/rdf/datasource;1?name=internetsearch"
 const nsISupports      = Components.interfaces.nsISupports;
 const nsISidebar       = Components.interfaces.nsISidebar;
-const nsISidebarPanel  = Components.interfaces.nsISidebarPanel;
-const nsISidebarExternal = Components.interfaces.nsISidebarExternal;
 const nsIRDFContainer  = Components.interfaces.nsIRDFContainer;
 const nsIProperties    = Components.interfaces.nsIProperties;
 const nsIFileURL       = Components.interfaces.nsIFileURL;
 const nsIRDFRemoteDataSource = Components.interfaces.nsIRDFRemoteDataSource;
 const nsIClassInfo     = Components.interfaces.nsIClassInfo;
 
 // File extension for Sherlock search plugin description files
 const SHERLOCK_FILE_EXT_REGEXP = /\.src$/i;
@@ -299,21 +297,21 @@ function (aSearchURL)
 {
   return 0;
 }
 
 nsSidebar.prototype.classInfo = XPCOMUtils.generateCI({
     classID: SIDEBAR_CID,
     contractID: SIDEBAR_CONTRACTID,
     classDescription: "Sidebar",
-    interfaces: [nsISidebar, nsISidebarPanel, nsISidebarExternal],
+    interfaces: [nsISidebar],
     flags: nsIClassInfo.DOM_OBJECT});
 
 nsSidebar.prototype.QueryInterface =
-    XPCOMUtils.generateQI([nsISidebar, nsISidebarPanel, nsISidebarExternal]);
+    XPCOMUtils.generateQI([nsISidebar]);
 
 nsSidebar.prototype.classID = SIDEBAR_CID;
 
 var NSGetFactory = XPCOMUtils.generateNSGetFactory([nsSidebar]);
 
 /* static functions */
 if (DEBUG)
     debug = function (s) { dump("-*- sidebar component: " + s + "\n"); }