Bug 1005687 - Scam/Phishing alert no longer showing when links in identified scam messages are clicked/followed. r=mkmelin,a=Standard8
authorThomas Düllmann <bugzilla2007@duellmann24.net>
Sun, 04 May 2014 12:00:00 +0300
changeset 19707 29dd057e374aa0ae707542ef3cefd1bb684b7779
parent 19706 fc7ad64bab9d136c2fec809911ff4da4bad9a9c1
child 19708 71b8ce28a0e3288c2e8c5ec5fce6297fab34fe1f
child 19710 636c7b1ef24a691ca3874b923bc556478d0d0539
push idunknown
push userunknown
push dateunknown
reviewersmkmelin, Standard8
bugs1005687
Bug 1005687 - Scam/Phishing alert no longer showing when links in identified scam messages are clicked/followed. r=mkmelin,a=Standard8
mail/base/content/phishingDetector.js
--- a/mail/base/content/phishingDetector.js
+++ b/mail/base/content/phishingDetector.js
@@ -246,19 +246,19 @@ var gPhishingDetector = {
    * before allowing the link click to be processed. The warning prompt includes the unobscured host name
    * of the http(s) url the user clicked on.
    *
    * @param aUrl the url
    * @return true if the link should be allowed to load
    */
   warnOnSuspiciousLinkClick: function(aUrl)
   {
-    // if the loaded message has been flagged as a phishing scam,
-    if (!gMessageNotificationBar.isShowingJunkNotification())
-      return true;
+    // If the loaded message has *not* been flagged as a scam...
+    if (!gMessageNotificationBar.isShowingPhishingNotification())
+      return true; // ...allow the link to load.
 
     var hrefURL;
     // make sure relative link urls don't make us bail out
     try {
       hrefURL = Services.io.newURI(aUrl, null, null);
     } catch(ex) { return false; }
 
     // only prompt for http and https urls